Index: Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Forms.Test/Views/WaveImpactAsphaltCoverFailureMechanismViewTest.cs =================================================================== diff -u -r6b2660c8a0d2fa638554f54825ea2e7ff34e1398 -r40ef20e4c3f012ed464240f3d5d43f5d22a505a2 --- Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Forms.Test/Views/WaveImpactAsphaltCoverFailureMechanismViewTest.cs (.../WaveImpactAsphaltCoverFailureMechanismViewTest.cs) (revision 6b2660c8a0d2fa638554f54825ea2e7ff34e1398) +++ Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Forms.Test/Views/WaveImpactAsphaltCoverFailureMechanismViewTest.cs (.../WaveImpactAsphaltCoverFailureMechanismViewTest.cs) (revision 40ef20e4c3f012ed464240f3d5d43f5d22a505a2) @@ -53,30 +53,20 @@ private const int calculationsIndex = 6; [Test] - public void DefaultConstructor_DefaultValues() + public void Constructor_ExpectedValues() { // Call using (var view = new WaveImpactAsphaltCoverFailureMechanismView()) { // Assert Assert.IsInstanceOf(view); Assert.IsInstanceOf(view); - Assert.IsNotNull(view.Map); Assert.IsNull(view.Data); - } - } - [Test] - public void DefaultConstructor_Always_AddEmptyMapControl() - { - // Call - using (var view = new WaveImpactAsphaltCoverFailureMechanismView()) - { - // Assert Assert.AreEqual(1, view.Controls.Count); Assert.IsInstanceOf(view.Controls[0]); - Assert.AreSame(view.Map, ((RingtoetsMapControl) view.Controls[0]).MapControl); - Assert.AreEqual(DockStyle.Fill, ((Control) view.Map).Dock); + Assert.AreSame(view.Map, ((RingtoetsMapControl)view.Controls[0]).MapControl); + Assert.AreEqual(DockStyle.Fill, ((Control)view.Map).Dock); Assert.IsNull(view.Map.Data); } } Index: Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Plugin.Test/ViewInfos/WaveImpactAsphaltCoverFailureMechanismViewInfoTest.cs =================================================================== diff -u -rf07d6418a5280c74ea8a35de183dbaed51dda066 -r40ef20e4c3f012ed464240f3d5d43f5d22a505a2 --- Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Plugin.Test/ViewInfos/WaveImpactAsphaltCoverFailureMechanismViewInfoTest.cs (.../WaveImpactAsphaltCoverFailureMechanismViewInfoTest.cs) (revision f07d6418a5280c74ea8a35de183dbaed51dda066) +++ Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Plugin.Test/ViewInfos/WaveImpactAsphaltCoverFailureMechanismViewInfoTest.cs (.../WaveImpactAsphaltCoverFailureMechanismViewInfoTest.cs) (revision 40ef20e4c3f012ed464240f3d5d43f5d22a505a2) @@ -19,6 +19,7 @@ // Stichting Deltares and remain full property of Stichting Deltares at all times. // All rights reserved. +using System.Drawing; using System.Linq; using Core.Common.Gui.Plugin; using Core.Common.TestUtil; @@ -60,7 +61,6 @@ // Assert Assert.AreEqual(typeof(WaveImpactAsphaltCoverFailureMechanismContext), info.DataType); Assert.AreEqual(typeof(WaveImpactAsphaltCoverFailureMechanismContext), info.ViewDataType); - TestHelper.AssertImagesAreEqual(RingtoetsCommonFormsResources.CalculationIcon, info.Image); } [Test] @@ -70,29 +70,36 @@ var assessmentSection = mocks.Stub(); mocks.ReplayAll(); - var waveImpactAsphaltCoverFailureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); - var waveImpactAsphaltCoverFailureMechanismContext = new WaveImpactAsphaltCoverFailureMechanismContext(waveImpactAsphaltCoverFailureMechanism, assessmentSection); + var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); + var waveImpactAsphaltCoverFailureMechanismContext = new WaveImpactAsphaltCoverFailureMechanismContext(failureMechanism, assessmentSection); - using (var view = new WaveImpactAsphaltCoverFailureMechanismView()) - { - // Call - string viewName = info.GetViewName(view, waveImpactAsphaltCoverFailureMechanismContext); + // Call + string viewName = info.GetViewName(null, waveImpactAsphaltCoverFailureMechanismContext); - // Assert - Assert.AreEqual(waveImpactAsphaltCoverFailureMechanism.Name, viewName); - } + // Assert + Assert.AreEqual(failureMechanism.Name, viewName); } [Test] + public void Image_Always_ReturnsGenericInputOutputIcon() + { + // Call + Image image = info.Image; + + // Assert + TestHelper.AssertImagesAreEqual(RingtoetsCommonFormsResources.CalculationIcon, image); + } + + [Test] public void CloseForData_ViewNotCorrespondingToRemovedAssessmentSection_ReturnsFalse() { // Setup var assessmentSection = new ObservableTestAssessmentSectionStub(); var otherAssessmentSection = mocks.Stub(); mocks.ReplayAll(); - var waveImpactAsphaltCoverFailureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); - var waveImpactAsphaltCoverFailureMechanismContext = new WaveImpactAsphaltCoverFailureMechanismContext(waveImpactAsphaltCoverFailureMechanism, assessmentSection); + var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); + var waveImpactAsphaltCoverFailureMechanismContext = new WaveImpactAsphaltCoverFailureMechanismContext(failureMechanism, assessmentSection); using (var view = new WaveImpactAsphaltCoverFailureMechanismView { @@ -105,6 +112,7 @@ // Assert Assert.IsFalse(closeForData); } + mocks.VerifyAll(); } @@ -113,10 +121,9 @@ { // Setup var assessmentSection = new ObservableTestAssessmentSectionStub(); + var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); + var waveImpactAsphaltCoverFailureMechanismContext = new WaveImpactAsphaltCoverFailureMechanismContext(failureMechanism, assessmentSection); - var waveImpactAsphaltCoverFailureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); - var waveImpactAsphaltCoverFailureMechanismContext = new WaveImpactAsphaltCoverFailureMechanismContext(waveImpactAsphaltCoverFailureMechanism, assessmentSection); - using (var view = new WaveImpactAsphaltCoverFailureMechanismView { Data = waveImpactAsphaltCoverFailureMechanismContext @@ -128,6 +135,7 @@ // Assert Assert.IsTrue(closeForData); } + mocks.VerifyAll(); } @@ -136,11 +144,10 @@ { // Setup var assessmentSection = new ObservableTestAssessmentSectionStub(); - - var waveImpactAsphaltCoverFailureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); + var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); var otherWaveImpactAsphaltCoverFailureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); - var waveImpactAsphaltCoverFailureMechanismContext = new WaveImpactAsphaltCoverFailureMechanismContext(waveImpactAsphaltCoverFailureMechanism, assessmentSection); + var waveImpactAsphaltCoverFailureMechanismContext = new WaveImpactAsphaltCoverFailureMechanismContext(failureMechanism, assessmentSection); using (var view = new WaveImpactAsphaltCoverFailureMechanismView { @@ -160,17 +167,16 @@ { // Setup var assessmentSection = new ObservableTestAssessmentSectionStub(); + var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); + var waveImpactAsphaltCoverFailureMechanismContext = new WaveImpactAsphaltCoverFailureMechanismContext(failureMechanism, assessmentSection); - var waveImpactAsphaltCoverFailureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); - var waveImpactAsphaltCoverFailureMechanismContext = new WaveImpactAsphaltCoverFailureMechanismContext(waveImpactAsphaltCoverFailureMechanism, assessmentSection); - using (var view = new WaveImpactAsphaltCoverFailureMechanismView { Data = waveImpactAsphaltCoverFailureMechanismContext }) { // Call - bool closeForData = info.CloseForData(view, waveImpactAsphaltCoverFailureMechanism); + bool closeForData = info.CloseForData(view, failureMechanism); // Assert Assert.IsTrue(closeForData);