Index: Riskeer/ClosingStructures/test/Riskeer.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs =================================================================== diff -u -r07256b6a9cc4abaff600e7c9a266cef54295b3c3 -r4c457767a06f837ce3f9fa60eb50f1cf7dbbd0e1 --- Riskeer/ClosingStructures/test/Riskeer.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs (.../ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs) (revision 07256b6a9cc4abaff600e7c9a266cef54295b3c3) +++ Riskeer/ClosingStructures/test/Riskeer.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs (.../ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs) (revision 4c457767a06f837ce3f9fa60eb50f1cf7dbbd0e1) @@ -487,7 +487,7 @@ } }; - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); failureMechanism.CalculationsGroup.Children.Add(new StructuresCalculationScenario()); IAssessmentSection assessmentSection = AssessmentSectionTestHelper.CreateAssessmentSectionStub(mocks); @@ -537,7 +537,7 @@ } }; - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); failureMechanism.CalculationsGroup.Children.Add(new StructuresCalculationScenario()); IAssessmentSection assessmentSection = AssessmentSectionTestHelper.CreateAssessmentSectionStub(null, mocks, "invalidFilePath"); @@ -560,12 +560,12 @@ using (ContextMenuStrip contextMenu = info.ContextMenuStrip(nodeData, null, treeViewControl)) { // Assert - ToolStripItem calculatAllContextMenuItem = contextMenu.Items[contextMenuCalculateAllIndexRootGroup]; + ToolStripItem calculateAllContextMenuItem = contextMenu.Items[contextMenuCalculateAllIndexRootGroup]; - Assert.AreEqual("Alles be&rekenen", calculatAllContextMenuItem.Text); - StringAssert.Contains("Herstellen van de verbinding met de hydraulische belastingendatabase is mislukt.", calculatAllContextMenuItem.ToolTipText); - TestHelper.AssertImagesAreEqual(RiskeerCommonFormsResources.CalculateAllIcon, calculatAllContextMenuItem.Image); - Assert.IsFalse(calculatAllContextMenuItem.Enabled); + Assert.AreEqual("Alles be&rekenen", calculateAllContextMenuItem.Text); + StringAssert.Contains("Herstellen van de verbinding met de hydraulische belastingendatabase is mislukt.", calculateAllContextMenuItem.ToolTipText); + TestHelper.AssertImagesAreEqual(RiskeerCommonFormsResources.CalculateAllIcon, calculateAllContextMenuItem.Image); + Assert.IsFalse(calculateAllContextMenuItem.Enabled); ToolStripItem validateAllContextMenuItem = contextMenu.Items[contextMenuValidateAllIndexRootGroup]; @@ -591,7 +591,7 @@ string validFilePath = Path.Combine(testDataPath, "complete.sqlite"); - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); failureMechanism.CalculationsGroup.Children.Add(new StructuresCalculationScenario()); var hydraulicBoundaryDatabase = new HydraulicBoundaryDatabase @@ -640,7 +640,7 @@ { // Setup IAssessmentSection assessmentSection = AssessmentSectionTestHelper.CreateAssessmentSectionStub(mocks); - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); var calculation = new StructuresCalculationScenario { InputParameters = @@ -693,7 +693,7 @@ calculationInputObserver.Expect(o => o.UpdateObserver()); IAssessmentSection assessmentSection = AssessmentSectionTestHelper.CreateAssessmentSectionStub(mocks); - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); var calculation = new StructuresCalculationScenario { @@ -968,7 +968,7 @@ IMainWindow mainWindow = MainWindowTestHelper.CreateMainWindowStub(mocks); var menuBuilder = new CustomItemsOnlyContextMenuBuilder(); - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); failureMechanism.CalculationsGroup.Children.Add(new TestClosingStructuresCalculationScenario { Name = "A", @@ -1065,7 +1065,7 @@ // Setup var menuBuilder = new CustomItemsOnlyContextMenuBuilder(); - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); failureMechanism.CalculationsGroup.Children.Add(new TestClosingStructuresCalculationScenario { Name = "A", Index: Riskeer/ClosingStructures/test/Riskeer.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationScenarioContextTreeNodeInfoTest.cs =================================================================== diff -u -r1bc5f2299c66132f869d09d017327d80f4a9522c -r4c457767a06f837ce3f9fa60eb50f1cf7dbbd0e1 --- Riskeer/ClosingStructures/test/Riskeer.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationScenarioContextTreeNodeInfoTest.cs (.../ClosingStructuresCalculationScenarioContextTreeNodeInfoTest.cs) (revision 1bc5f2299c66132f869d09d017327d80f4a9522c) +++ Riskeer/ClosingStructures/test/Riskeer.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationScenarioContextTreeNodeInfoTest.cs (.../ClosingStructuresCalculationScenarioContextTreeNodeInfoTest.cs) (revision 4c457767a06f837ce3f9fa60eb50f1cf7dbbd0e1) @@ -212,7 +212,7 @@ var assessmentSection = mocks.Stub(); assessmentSection.Stub(a => a.HydraulicBoundaryDatabase).Return(hydraulicBoundaryDatabase); - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); var parent = new CalculationGroup(); var calculation = new StructuresCalculationScenario(); var nodeData = new ClosingStructuresCalculationScenarioContext(calculation, parent, failureMechanism, assessmentSection); @@ -280,7 +280,7 @@ var parent = new CalculationGroup(); var calculation = new StructuresCalculationScenario(); - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); var nodeData = new ClosingStructuresCalculationScenarioContext(calculation, parent, failureMechanism, assessmentSection); var menuBuilder = new CustomItemsOnlyContextMenuBuilder(); @@ -318,7 +318,7 @@ Structure = new TestClosingStructure() } }; - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); var nodeData = new ClosingStructuresCalculationScenarioContext(calculation, parent, failureMechanism, assessmentSection); var menuBuilder = new CustomItemsOnlyContextMenuBuilder(); @@ -356,7 +356,7 @@ Structure = new TestClosingStructure() } }; - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); var nodeData = new ClosingStructuresCalculationScenarioContext(calculation, parent, failureMechanism, assessmentSection); var menuBuilder = new CustomItemsOnlyContextMenuBuilder(); @@ -556,7 +556,7 @@ IAssessmentSection assessmentSection = AssessmentSectionTestHelper.CreateAssessmentSectionStub(mocks); var parent = new CalculationGroup(); var calculation = new StructuresCalculationScenario(); - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); var nodeData = new ClosingStructuresCalculationScenarioContext(calculation, parent, failureMechanism, assessmentSection); using (var treeViewControl = new TreeViewControl()) @@ -591,7 +591,7 @@ IAssessmentSection assessmentSection = AssessmentSectionTestHelper.CreateAssessmentSectionStub(null, mocks, "invalidFilePath"); var parent = new CalculationGroup(); var calculation = new StructuresCalculationScenario(); - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); var nodeData = new ClosingStructuresCalculationScenarioContext(calculation, parent, failureMechanism, assessmentSection); using (var treeViewControl = new TreeViewControl()) @@ -639,7 +639,7 @@ var parent = new CalculationGroup(); var calculation = new StructuresCalculationScenario(); - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); var nodeData = new ClosingStructuresCalculationScenarioContext(calculation, parent, failureMechanism, assessmentSection); using (var treeViewControl = new TreeViewControl()) @@ -670,7 +670,7 @@ { // Setup IAssessmentSection assessmentSection = AssessmentSectionTestHelper.CreateAssessmentSectionStub(mocks); - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); var parent = new CalculationGroup(); var calculation = new StructuresCalculationScenario(); @@ -707,7 +707,7 @@ { // Setup IAssessmentSection assessmentSection = AssessmentSectionTestHelper.CreateAssessmentSectionStub(mocks); - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); var parent = new CalculationGroup(); var calculation = new StructuresCalculationScenario { @@ -750,7 +750,7 @@ { // Setup IAssessmentSection assessmentSection = AssessmentSectionTestHelper.CreateAssessmentSectionStub(mocks); - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); var foreshoreProfileInput = new TestForeshoreProfile(); var parent = new CalculationGroup(); @@ -799,7 +799,7 @@ calculationInputObserver.Expect(o => o.UpdateObserver()); IAssessmentSection assessmentSection = AssessmentSectionTestHelper.CreateAssessmentSectionStub(mocks); - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); var foreshoreProfileInput = new TestForeshoreProfile(true); var parent = new CalculationGroup(); @@ -851,7 +851,7 @@ var calculationObserver = mocks.StrictMock(); var calculationInputObserver = mocks.StrictMock(); IAssessmentSection assessmentSection = AssessmentSectionTestHelper.CreateAssessmentSectionStub(mocks); - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); var foreshoreProfileInput = new TestForeshoreProfile(true); var parent = new CalculationGroup(); @@ -933,7 +933,7 @@ var observer = mocks.StrictMock(); observer.Expect(o => o.UpdateObserver()); - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); var hydraulicBoundaryLocation = new TestHydraulicBoundaryLocation(); var hydraulicBoundaryDatabase = new HydraulicBoundaryDatabase @@ -991,10 +991,10 @@ using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { // When - Action action = () => contextMenuStrip.Items[contextMenuCalculateIndex].PerformClick(); + void Action() => contextMenuStrip.Items[contextMenuCalculateIndex].PerformClick(); // Then - TestHelper.AssertLogMessages(action, messages => + TestHelper.AssertLogMessages(Action, messages => { string[] msgs = messages.ToArray(); Assert.AreEqual(7, msgs.Length); @@ -1045,7 +1045,7 @@ var observer = mocks.StrictMock(); calculation.Attach(observer); - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); var calculationContext = new ClosingStructuresCalculationScenarioContext(calculation, parent, failureMechanism, assessmentSection); using (var treeViewControl = new TreeViewControl()) @@ -1057,10 +1057,10 @@ using (ContextMenuStrip contextMenuStrip = info.ContextMenuStrip(calculationContext, null, treeViewControl)) { // When - Action action = () => contextMenuStrip.Items[contextMenuValidateIndex].PerformClick(); + void Action() => contextMenuStrip.Items[contextMenuValidateIndex].PerformClick(); // Then - TestHelper.AssertLogMessages(action, messages => + TestHelper.AssertLogMessages(Action, messages => { string[] msgs = messages.ToArray(); Assert.AreEqual(2, msgs.Length); Index: Riskeer/ClosingStructures/test/Riskeer.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationsContextTreeNodeInfoTest.cs =================================================================== diff -u -r62b8135dcc02e56da0616c5d6f4e345198994393 -r4c457767a06f837ce3f9fa60eb50f1cf7dbbd0e1 --- Riskeer/ClosingStructures/test/Riskeer.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationsContextTreeNodeInfoTest.cs (.../ClosingStructuresCalculationsContextTreeNodeInfoTest.cs) (revision 62b8135dcc02e56da0616c5d6f4e345198994393) +++ Riskeer/ClosingStructures/test/Riskeer.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationsContextTreeNodeInfoTest.cs (.../ClosingStructuresCalculationsContextTreeNodeInfoTest.cs) (revision 4c457767a06f837ce3f9fa60eb50f1cf7dbbd0e1) @@ -19,7 +19,6 @@ // Stichting Deltares and remain full property of Stichting Deltares at all times. // All rights reserved. -using System; using System.Collections.Generic; using System.Drawing; using System.IO; @@ -262,7 +261,7 @@ public void ContextMenuStrip_HydraulicBoundaryDatabaseNotLinked_ContextMenuItemCalculateAllAndValidateAllDisabledAndTooltipSet() { // Setup - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); failureMechanism.CalculationsGroup.Children.Add(new StructuresCalculation()); IAssessmentSection assessmentSection = AssessmentSectionTestHelper.CreateAssessmentSectionStub(mocksRepository); @@ -302,7 +301,7 @@ public void ContextMenuStrip_HydraulicBoundaryDatabaseLinkedToInvalidFile_ContextMenuItemCalculateAllAndValidateAllDisabledAndTooltipSet() { // Setup - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); failureMechanism.CalculationsGroup.Children.Add(new StructuresCalculation()); IAssessmentSection assessmentSection = AssessmentSectionTestHelper.CreateAssessmentSectionStub(null, mocksRepository, "invalidFilePath"); @@ -344,7 +343,7 @@ public void ContextMenuStrip_AllRequiredInputSet_ContextMenuItemCalculateAllAndValidateAllEnabled() { // Setup - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); failureMechanism.CalculationsGroup.Children.Add(new StructuresCalculation()); string validFilePath = Path.Combine(testDataPath, "complete.sqlite"); @@ -395,7 +394,7 @@ IMainWindow mainWindow = MainWindowTestHelper.CreateMainWindowStub(mocksRepository); var menuBuilder = new CustomItemsOnlyContextMenuBuilder(); - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); failureMechanism.CalculationsGroup.Children.Add(new TestClosingStructuresCalculationScenario { Name = "A", @@ -488,7 +487,7 @@ public void ContextMenuStrip_ClickOnValidateAllItem_ValidateAllChildCalculations() { // Setup - var failureMechanism = new TestClosingStructuresFailureMechanism(); + var failureMechanism = new ClosingStructuresFailureMechanism(); failureMechanism.CalculationsGroup.Children.Add(new TestClosingStructuresCalculationScenario { Name = "A", @@ -532,10 +531,10 @@ using (ContextMenuStrip contextMenu = info.ContextMenuStrip(context, null, treeViewControl)) { // Call - Action call = () => contextMenu.Items[contextMenuValidateAllIndex].PerformClick(); + void Call() => contextMenu.Items[contextMenuValidateAllIndex].PerformClick(); // Assert - TestHelper.AssertLogMessages(call, messages => + TestHelper.AssertLogMessages(Call, messages => { string[] messageList = messages.ToArray(); @@ -563,7 +562,7 @@ Output = new TestStructuresOutput() }; - var failureMechanism = new TestClosingStructuresFailureMechanism + var failureMechanism = new ClosingStructuresFailureMechanism { CalculationsGroup = { @@ -610,7 +609,7 @@ Output = new TestStructuresOutput() }; - var failureMechanism = new TestClosingStructuresFailureMechanism + var failureMechanism = new ClosingStructuresFailureMechanism { CalculationsGroup = { @@ -661,7 +660,7 @@ Output = new TestStructuresOutput() }; - var failureMechanism = new TestClosingStructuresFailureMechanism + var failureMechanism = new ClosingStructuresFailureMechanism { CalculationsGroup = { @@ -728,7 +727,7 @@ Output = new TestStructuresOutput() }; - var failureMechanism = new TestClosingStructuresFailureMechanism + var failureMechanism = new ClosingStructuresFailureMechanism { CalculationsGroup = {