Index: Riskeer/GrassCoverErosionOutwards/test/Riskeer.GrassCoverErosionOutwards.Plugin.Test/TreeNodeInfos/GrassCoverErosionOutwardsWaveConditionsCalculationContextTreeNodeInfoTest.cs =================================================================== diff -u -r8339953df3276b6c7b4a3d9f5a278e4c19e85be3 -r4cc13f872e0ef1b826d0d23437d98bc9f7a16c2a --- Riskeer/GrassCoverErosionOutwards/test/Riskeer.GrassCoverErosionOutwards.Plugin.Test/TreeNodeInfos/GrassCoverErosionOutwardsWaveConditionsCalculationContextTreeNodeInfoTest.cs (.../GrassCoverErosionOutwardsWaveConditionsCalculationContextTreeNodeInfoTest.cs) (revision 8339953df3276b6c7b4a3d9f5a278e4c19e85be3) +++ Riskeer/GrassCoverErosionOutwards/test/Riskeer.GrassCoverErosionOutwards.Plugin.Test/TreeNodeInfos/GrassCoverErosionOutwardsWaveConditionsCalculationContextTreeNodeInfoTest.cs (.../GrassCoverErosionOutwardsWaveConditionsCalculationContextTreeNodeInfoTest.cs) (revision 4cc13f872e0ef1b826d0d23437d98bc9f7a16c2a) @@ -1040,10 +1040,10 @@ } [Test] - public void GivenHydraulicBoundaryDatabaseWithCanUsePreprocessorFalse_WhenValidatingCalculation_ThenNoValidationErrorsLogged() + public void GivenHydraulicBoundaryDataWithMissingPreprocessorClosureDatabase_WhenValidatingCalculation_ThenValidationErrorsLogged() { // Given - AssessmentSectionStub assessmentSection = CreateAssessmentSection(); + AssessmentSectionStub assessmentSection = CreateAssessmentSection(true); assessmentSection.SetHydraulicBoundaryLocationCalculations(new[] { new TestHydraulicBoundaryLocation() @@ -1054,70 +1054,7 @@ var parent = new CalculationGroup(); GrassCoverErosionOutwardsWaveConditionsCalculation calculation = GetValidCalculation(assessmentSection.HydraulicBoundaryData.Locations.First()); - var context = new GrassCoverErosionOutwardsWaveConditionsCalculationContext(calculation, - parent, - failureMechanism, - assessmentSection); - using (var treeViewControl = new TreeViewControl()) - { - var appFeatureCommandHandler = mocks.Stub(); - var importHandler = mocks.Stub(); - var exportHandler = mocks.Stub(); - var updateHandler = mocks.Stub(); - var viewCommands = mocks.Stub(); - var menuBuilder = new ContextMenuBuilder(appFeatureCommandHandler, - importHandler, - exportHandler, - updateHandler, - viewCommands, - context, - treeViewControl); - - var gui = mocks.Stub(); - gui.Stub(g => g.Get(context, treeViewControl)).Return(menuBuilder); - gui.Stub(cmp => cmp.MainWindow).Return(mocks.Stub()); - mocks.ReplayAll(); - - plugin.Gui = gui; - - using (ContextMenuStrip contextMenu = info.ContextMenuStrip(context, null, treeViewControl)) - { - // When - ToolStripItem validateMenuItem = contextMenu.Items[validateMenuItemIndex]; - void Call() => validateMenuItem.PerformClick(); - - // Then - TestHelper.AssertLogMessages(Call, logMessages => - { - string[] messages = logMessages.ToArray(); - Assert.AreEqual(2, messages.Length); - CalculationServiceTestHelper.AssertValidationStartMessage(messages[0]); - CalculationServiceTestHelper.AssertValidationEndMessage(messages[1]); - }); - } - } - } - - [Test] - public void GivenHydraulicBoundaryDatabaseWithUsePreprocessorFalse_WhenValidatingCalculation_ThenNoValidationErrorsLogged() - { - // Given - AssessmentSectionStub assessmentSection = CreateAssessmentSection(); - assessmentSection.SetHydraulicBoundaryLocationCalculations(new[] - { - new TestHydraulicBoundaryLocation() - }); - ConfigureAssessmentSectionWithHydraulicBoundaryOutput(assessmentSection); - - assessmentSection.HydraulicBoundaryData.HydraulicLocationConfigurationSettings.CanUsePreprocessor = true; - assessmentSection.HydraulicBoundaryData.HydraulicLocationConfigurationSettings.UsePreprocessor = false; - assessmentSection.HydraulicBoundaryData.HydraulicLocationConfigurationSettings.PreprocessorDirectory = "InvalidPreprocessorDirectory"; - - var failureMechanism = new GrassCoverErosionOutwardsFailureMechanism(); - - var parent = new CalculationGroup(); - GrassCoverErosionOutwardsWaveConditionsCalculation calculation = GetValidCalculation(assessmentSection.HydraulicBoundaryData.Locations.First()); var context = new GrassCoverErosionOutwardsWaveConditionsCalculationContext(calculation, parent, failureMechanism, @@ -1155,138 +1092,9 @@ TestHelper.AssertLogMessages(Call, logMessages => { string[] messages = logMessages.ToArray(); - Assert.AreEqual(2, messages.Length); - CalculationServiceTestHelper.AssertValidationStartMessage(messages[0]); - CalculationServiceTestHelper.AssertValidationEndMessage(messages[1]); - }); - } - } - } - - [Test] - public void GivenHydraulicBoundaryDatabaseWithUsePreprocessorTrue_WhenValidatingCalculation_ThenNoValidationErrorsLogged() - { - // Given - AssessmentSectionStub assessmentSection = CreateAssessmentSection(); - assessmentSection.SetHydraulicBoundaryLocationCalculations(new[] - { - new TestHydraulicBoundaryLocation() - }); - ConfigureAssessmentSectionWithHydraulicBoundaryOutput(assessmentSection); - - assessmentSection.HydraulicBoundaryData.HydraulicLocationConfigurationSettings.CanUsePreprocessor = true; - assessmentSection.HydraulicBoundaryData.HydraulicLocationConfigurationSettings.UsePreprocessor = true; - assessmentSection.HydraulicBoundaryData.HydraulicLocationConfigurationSettings.PreprocessorDirectory = TestHelper.GetScratchPadPath(); - - var failureMechanism = new GrassCoverErosionOutwardsFailureMechanism(); - - var parent = new CalculationGroup(); - GrassCoverErosionOutwardsWaveConditionsCalculation calculation = GetValidCalculation(assessmentSection.HydraulicBoundaryData.Locations.First()); - var context = new GrassCoverErosionOutwardsWaveConditionsCalculationContext(calculation, - parent, - failureMechanism, - assessmentSection); - - using (var treeViewControl = new TreeViewControl()) - { - var appFeatureCommandHandler = mocks.Stub(); - var importHandler = mocks.Stub(); - var exportHandler = mocks.Stub(); - var updateHandler = mocks.Stub(); - var viewCommands = mocks.Stub(); - var menuBuilder = new ContextMenuBuilder(appFeatureCommandHandler, - importHandler, - exportHandler, - updateHandler, - viewCommands, - context, - treeViewControl); - - var gui = mocks.Stub(); - gui.Stub(g => g.Get(context, treeViewControl)).Return(menuBuilder); - gui.Stub(cmp => cmp.MainWindow).Return(mocks.Stub()); - mocks.ReplayAll(); - - plugin.Gui = gui; - - using (ContextMenuStrip contextMenu = info.ContextMenuStrip(context, null, treeViewControl)) - { - // When - ToolStripItem validateMenuItem = contextMenu.Items[validateMenuItemIndex]; - void Call() => validateMenuItem.PerformClick(); - - // Then - TestHelper.AssertLogMessages(Call, logMessages => - { - string[] messages = logMessages.ToArray(); - Assert.AreEqual(2, messages.Length); - CalculationServiceTestHelper.AssertValidationStartMessage(messages[0]); - CalculationServiceTestHelper.AssertValidationEndMessage(messages[1]); - }); - } - } - } - - [Test] - public void GivenHydraulicBoundaryDatabaseWithUsePreprocessorTrue_WhenValidatingCalculation_ThenValidationErrorsLogged() - { - // Given - AssessmentSectionStub assessmentSection = CreateAssessmentSection(); - assessmentSection.SetHydraulicBoundaryLocationCalculations(new[] - { - new TestHydraulicBoundaryLocation() - }); - ConfigureAssessmentSectionWithHydraulicBoundaryOutput(assessmentSection); - - assessmentSection.HydraulicBoundaryData.HydraulicLocationConfigurationSettings.CanUsePreprocessor = true; - assessmentSection.HydraulicBoundaryData.HydraulicLocationConfigurationSettings.UsePreprocessor = true; - assessmentSection.HydraulicBoundaryData.HydraulicLocationConfigurationSettings.PreprocessorDirectory = "InvalidPreprocessorDirectory"; - - var failureMechanism = new GrassCoverErosionOutwardsFailureMechanism(); - - var parent = new CalculationGroup(); - GrassCoverErosionOutwardsWaveConditionsCalculation calculation = GetValidCalculation(assessmentSection.HydraulicBoundaryData.Locations.First()); - - var context = new GrassCoverErosionOutwardsWaveConditionsCalculationContext(calculation, - parent, - failureMechanism, - assessmentSection); - - using (var treeViewControl = new TreeViewControl()) - { - var appFeatureCommandHandler = mocks.Stub(); - var importHandler = mocks.Stub(); - var exportHandler = mocks.Stub(); - var updateHandler = mocks.Stub(); - var viewCommands = mocks.Stub(); - var menuBuilder = new ContextMenuBuilder(appFeatureCommandHandler, - importHandler, - exportHandler, - updateHandler, - viewCommands, - context, - treeViewControl); - - var gui = mocks.Stub(); - gui.Stub(g => g.Get(context, treeViewControl)).Return(menuBuilder); - gui.Stub(cmp => cmp.MainWindow).Return(mocks.Stub()); - mocks.ReplayAll(); - - plugin.Gui = gui; - - using (ContextMenuStrip contextMenu = info.ContextMenuStrip(context, null, treeViewControl)) - { - // When - ToolStripItem validateMenuItem = contextMenu.Items[validateMenuItemIndex]; - void Call() => validateMenuItem.PerformClick(); - - // Then - TestHelper.AssertLogMessages(Call, logMessages => - { - string[] messages = logMessages.ToArray(); Assert.AreEqual(3, messages.Length); CalculationServiceTestHelper.AssertValidationStartMessage(messages[0]); - Assert.AreEqual("De bestandsmap waar de preprocessor bestanden opslaat is ongeldig. De bestandsmap bestaat niet.", messages[1]); + Assert.AreEqual("Fixme", messages[1]); CalculationServiceTestHelper.AssertValidationEndMessage(messages[2]); }); } @@ -1708,7 +1516,7 @@ mocks.VerifyAll(); } - private static AssessmentSectionStub CreateAssessmentSection() + private static AssessmentSectionStub CreateAssessmentSection(bool usePreprocessorClosure = false) { var assessmentSection = new AssessmentSectionStub { @@ -1717,8 +1525,9 @@ FilePath = validFilePath } }; - HydraulicBoundaryDataTestHelper.SetHydraulicLocationConfigurationSettings(assessmentSection.HydraulicBoundaryData); + HydraulicBoundaryDataTestHelper.SetHydraulicLocationConfigurationSettings(assessmentSection.HydraulicBoundaryData, usePreprocessorClosure); + return assessmentSection; }