Index: Riskeer/StabilityStoneCover/src/Riskeer.StabilityStoneCover.Forms/PropertyClasses/RegistrationState/StabilityStoneCoverFailureMechanismProperties.cs =================================================================== diff -u -rf940fb0318486114473985b8a28a9d62546bffb5 -r578b74cc0c820182ee2be9f0e821dabb2e6be46b --- Riskeer/StabilityStoneCover/src/Riskeer.StabilityStoneCover.Forms/PropertyClasses/RegistrationState/StabilityStoneCoverFailureMechanismProperties.cs (.../StabilityStoneCoverFailureMechanismProperties.cs) (revision f940fb0318486114473985b8a28a9d62546bffb5) +++ Riskeer/StabilityStoneCover/src/Riskeer.StabilityStoneCover.Forms/PropertyClasses/RegistrationState/StabilityStoneCoverFailureMechanismProperties.cs (.../StabilityStoneCoverFailureMechanismProperties.cs) (revision 578b74cc0c820182ee2be9f0e821dabb2e6be46b) @@ -20,7 +20,6 @@ // All rights reserved. using System; -using Core.Common.Base.Data; using Core.Common.Util.Attributes; using Core.Gui.Attributes; using Riskeer.StabilityStoneCover.Data; @@ -36,8 +35,6 @@ private const int namePropertyIndex = 1; private const int codePropertyIndex = 2; private const int inAssemblyPropertyIndex = 3; - private const int nPropertyIndex = 4; - private const int applyLengthEffectInSectionPropertyIndex = 5; /// /// Creates a new instance of . @@ -66,57 +63,5 @@ } #endregion - - [DynamicVisibleValidationMethod] - public bool DynamicVisibleValidationMethod(string propertyName) - { - return data.InAssembly || !ShouldHidePropertyWhenFailureMechanismNotPartOfAssembly(propertyName); - } - - private static bool ShouldHidePropertyWhenFailureMechanismNotPartOfAssembly(string propertyName) - { - return nameof(N).Equals(propertyName) - || nameof(ApplyLengthEffectInSection).Equals(propertyName); - } - - #region Length effect parameters - - [DynamicVisible] - [PropertyOrder(nPropertyIndex)] - [ResourcesCategory(typeof(RiskeerCommonFormsResources), nameof(RiskeerCommonFormsResources.Categories_LengthEffect))] - [ResourcesDisplayName(typeof(RiskeerCommonFormsResources), nameof(RiskeerCommonFormsResources.FailureMechanism_N_DisplayName))] - [ResourcesDescription(typeof(RiskeerCommonFormsResources), nameof(RiskeerCommonFormsResources.FailureMechanism_N_Description))] - public RoundedDouble N - { - get - { - return data.GeneralInput.N; - } - set - { - data.GeneralInput.N = value; - data.NotifyObservers(); - } - } - - [DynamicVisible] - [PropertyOrder(applyLengthEffectInSectionPropertyIndex)] - [ResourcesCategory(typeof(RiskeerCommonFormsResources), nameof(RiskeerCommonFormsResources.Categories_LengthEffect))] - [ResourcesDisplayName(typeof(RiskeerCommonFormsResources), nameof(RiskeerCommonFormsResources.FailureMechanism_ApplyLengthEffectInSection_DisplayName))] - [ResourcesDescription(typeof(RiskeerCommonFormsResources), nameof(RiskeerCommonFormsResources.FailureMechanism_ApplyLengthEffectInSection_Description))] - public bool ApplyLengthEffectInSection - { - get - { - return data.GeneralInput.ApplyLengthEffectInSection; - } - set - { - data.GeneralInput.ApplyLengthEffectInSection = value; - data.NotifyObservers(); - } - } - - #endregion } } \ No newline at end of file Index: Riskeer/StabilityStoneCover/test/Riskeer.StabilityStoneCover.Forms.Test/PropertyClasses/RegistrationState/StabilityStoneCoverFailureMechanismPropertiesTest.cs =================================================================== diff -u -rf940fb0318486114473985b8a28a9d62546bffb5 -r578b74cc0c820182ee2be9f0e821dabb2e6be46b --- Riskeer/StabilityStoneCover/test/Riskeer.StabilityStoneCover.Forms.Test/PropertyClasses/RegistrationState/StabilityStoneCoverFailureMechanismPropertiesTest.cs (.../StabilityStoneCoverFailureMechanismPropertiesTest.cs) (revision f940fb0318486114473985b8a28a9d62546bffb5) +++ Riskeer/StabilityStoneCover/test/Riskeer.StabilityStoneCover.Forms.Test/PropertyClasses/RegistrationState/StabilityStoneCoverFailureMechanismPropertiesTest.cs (.../StabilityStoneCoverFailureMechanismPropertiesTest.cs) (revision 578b74cc0c820182ee2be9f0e821dabb2e6be46b) @@ -21,13 +21,9 @@ using System; using System.ComponentModel; -using Core.Common.Base; -using Core.Common.Base.Data; using Core.Common.TestUtil; using Core.Gui.TestUtil; using NUnit.Framework; -using Rhino.Mocks; -using Riskeer.Common.Data.TestUtil; using Riskeer.StabilityStoneCover.Data; using Riskeer.StabilityStoneCover.Forms.PropertyClasses; using Riskeer.StabilityStoneCover.Forms.PropertyClasses.RegistrationState; @@ -39,8 +35,6 @@ private const int namePropertyIndex = 0; private const int codePropertyIndex = 1; private const int inAssemblyPropertyIndex = 2; - private const int nPropertyIndex = 3; - private const int applyLengthEffectInSectionPropertyIndex = 4; [Test] public void Constructor_ExpectedValues() @@ -60,17 +54,10 @@ Assert.AreEqual(failureMechanism.Name, properties.Name); Assert.AreEqual(failureMechanism.Code, properties.Code); Assert.AreEqual(failureMechanism.InAssembly, properties.InAssembly); - - GeneralStabilityStoneCoverWaveConditionsInput generalInput = failureMechanism.GeneralInput; - Assert.AreEqual(2, properties.N.NumberOfDecimalPlaces); - Assert.AreEqual(generalInput.N, - properties.N, - properties.N.GetAccuracy()); - Assert.AreEqual(generalInput.ApplyLengthEffectInSection, properties.ApplyLengthEffectInSection); } [Test] - public void Constructor_InAssemblyTrue_PropertiesHaveExpectedAttributesValues() + public void Constructor_PropertiesHaveExpectedAttributesValues() { // Setup var failureMechanism = new StabilityStoneCoverFailureMechanism(); @@ -80,59 +67,6 @@ // Assert PropertyDescriptorCollection dynamicProperties = PropertiesTestHelper.GetAllVisiblePropertyDescriptors(properties); - Assert.AreEqual(5, dynamicProperties.Count); - - const string generalCategory = "Algemeen"; - const string lengthEffectCategory = "Lengte-effect"; - - PropertyDescriptor nameProperty = dynamicProperties[namePropertyIndex]; - PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(nameProperty, - generalCategory, - "Naam", - "De naam van het faalmechanisme.", - true); - - PropertyDescriptor labelProperty = dynamicProperties[codePropertyIndex]; - PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(labelProperty, - generalCategory, - "Label", - "Het label van het faalmechanisme.", - true); - - PropertyDescriptor inAssemblyProperty = dynamicProperties[inAssemblyPropertyIndex]; - PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(inAssemblyProperty, - generalCategory, - "In assemblage", - "Geeft aan of dit faalmechanisme wordt meegenomen in de assemblage.", - true); - - PropertyDescriptor nProperty = dynamicProperties[nPropertyIndex]; - PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(nProperty, - lengthEffectCategory, - "N [-]", - "De parameter 'N' die gebruikt wordt om het lengte-effect mee te nemen in de beoordeling."); - - PropertyDescriptor applySectionLengthInSectionProperty = dynamicProperties[applyLengthEffectInSectionPropertyIndex]; - PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(applySectionLengthInSectionProperty, - lengthEffectCategory, - "Toepassen lengte-effect binnen vak", - "Geeft aan of het lengte-effect binnen een vak toegepast wordt."); - } - - [Test] - public void Constructor_InAssemblyFalse_PropertiesHaveExpectedAttributesValues() - { - // Setup - var failureMechanism = new StabilityStoneCoverFailureMechanism - { - InAssembly = false - }; - - // Call - var properties = new StabilityStoneCoverFailureMechanismProperties(failureMechanism); - - // Assert - PropertyDescriptorCollection dynamicProperties = PropertiesTestHelper.GetAllVisiblePropertyDescriptors(properties); Assert.AreEqual(3, dynamicProperties.Count); const string generalCategory = "Algemeen"; @@ -158,104 +92,5 @@ "Geeft aan of dit faalmechanisme wordt meegenomen in de assemblage.", true); } - - [Test] - [SetCulture("nl-NL")] - [TestCase(0.0)] - [TestCase(-1.0)] - [TestCase(-20.0)] - public void N_SetInvalidValue_ThrowsArgumentOutOfRangeExceptionNoNotifications(double newN) - { - // Setup - var mocks = new MockRepository(); - var observer = mocks.StrictMock(); - mocks.ReplayAll(); - - var failureMechanism = new StabilityStoneCoverFailureMechanism(); - failureMechanism.Attach(observer); - - var properties = new StabilityStoneCoverFailureMechanismProperties(failureMechanism); - - // Call - void Call() => properties.N = (RoundedDouble) newN; - - // Assert - const string expectedMessage = "De waarde voor 'N' moet in het bereik [1,00, 20,00] liggen."; - TestHelper.AssertThrowsArgumentExceptionAndTestMessage(Call, expectedMessage); - - mocks.VerifyAll(); - } - - [Test] - [TestCase(1.0)] - [TestCase(10.0)] - [TestCase(20.0)] - public void N_SetValidValue_UpdateDataAndNotifyObservers(double newN) - { - // Setup - var mocks = new MockRepository(); - var observer = mocks.StrictMock(); - observer.Expect(o => o.UpdateObserver()); - mocks.ReplayAll(); - - var failureMechanism = new StabilityStoneCoverFailureMechanism(); - failureMechanism.Attach(observer); - - var properties = new StabilityStoneCoverFailureMechanismProperties(failureMechanism); - - // Call - properties.N = (RoundedDouble) newN; - - // Assert - Assert.AreEqual(newN, failureMechanism.GeneralInput.N, failureMechanism.GeneralInput.N.GetAccuracy()); - - mocks.VerifyAll(); - } - - [Test] - public void ApplyLengthEffectInSection_SetNewValue_NotifyObservers() - { - // Setup - var mocks = new MockRepository(); - var observer = mocks.StrictMock(); - observer.Expect(o => o.UpdateObserver()); - mocks.ReplayAll(); - - var failureMechanism = new StabilityStoneCoverFailureMechanism(); - - failureMechanism.Attach(observer); - - var properties = new StabilityStoneCoverFailureMechanismProperties(failureMechanism); - - // Call - properties.ApplyLengthEffectInSection = true; - - // Assert - Assert.IsTrue(failureMechanism.GeneralInput.ApplyLengthEffectInSection); - mocks.VerifyAll(); - } - - [Test] - [TestCase(true)] - [TestCase(false)] - public void DynamicVisibleValidationMethod_DependingOnInAssembly_ReturnExpectedVisibility(bool inAssembly) - { - // Setup - var failureMechanism = new StabilityStoneCoverFailureMechanism - { - InAssembly = inAssembly - }; - var properties = new StabilityStoneCoverFailureMechanismProperties(failureMechanism); - - // Call & Assert - Assert.IsTrue(properties.DynamicVisibleValidationMethod(nameof(properties.Name))); - Assert.IsTrue(properties.DynamicVisibleValidationMethod(nameof(properties.Code))); - Assert.IsTrue(properties.DynamicVisibleValidationMethod(nameof(properties.InAssembly))); - - Assert.AreEqual(inAssembly, properties.DynamicVisibleValidationMethod(nameof(properties.N))); - Assert.AreEqual(inAssembly, properties.DynamicVisibleValidationMethod(nameof(properties.ApplyLengthEffectInSection))); - - Assert.IsTrue(properties.DynamicVisibleValidationMethod(null)); - } } } \ No newline at end of file