Index: Ringtoets/Common/test/Ringtoets.Common.Forms.Test/GuiServices/HydraulicBoundaryLocationCalculationGuiServiceTest.cs =================================================================== diff -u -r2c4404936f53178d527072729e7af7f41fc9fe71 -r58bb28c3d0e0ccfc1a3cfcd29bd4f5e5ead4d0a9 --- Ringtoets/Common/test/Ringtoets.Common.Forms.Test/GuiServices/HydraulicBoundaryLocationCalculationGuiServiceTest.cs (.../HydraulicBoundaryLocationCalculationGuiServiceTest.cs) (revision 2c4404936f53178d527072729e7af7f41fc9fe71) +++ Ringtoets/Common/test/Ringtoets.Common.Forms.Test/GuiServices/HydraulicBoundaryLocationCalculationGuiServiceTest.cs (.../HydraulicBoundaryLocationCalculationGuiServiceTest.cs) (revision 58bb28c3d0e0ccfc1a3cfcd29bd4f5e5ead4d0a9) @@ -417,7 +417,14 @@ IAssessmentSection assessmentSection = AssessmentSectionTestHelper.CreateAssessmentSectionStub(mockRepository); var calculatorFactory = mockRepository.StrictMock(); - calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(testDataPath, "")).Return(new TestWaveHeightCalculator()); + calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(validFilePath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(new TestWaveHeightCalculator()); mockRepository.ReplayAll(); assessmentSection.HydraulicBoundaryDatabase.FilePath = validFilePath; Index: Ringtoets/Common/test/Ringtoets.Common.Service.Test/HydraulicBoundaryLocationCalculationActivityFactoryTest.cs =================================================================== diff -u -r2c4404936f53178d527072729e7af7f41fc9fe71 -r58bb28c3d0e0ccfc1a3cfcd29bd4f5e5ead4d0a9 --- Ringtoets/Common/test/Ringtoets.Common.Service.Test/HydraulicBoundaryLocationCalculationActivityFactoryTest.cs (.../HydraulicBoundaryLocationCalculationActivityFactoryTest.cs) (revision 2c4404936f53178d527072729e7af7f41fc9fe71) +++ Ringtoets/Common/test/Ringtoets.Common.Service.Test/HydraulicBoundaryLocationCalculationActivityFactoryTest.cs (.../HydraulicBoundaryLocationCalculationActivityFactoryTest.cs) (revision 58bb28c3d0e0ccfc1a3cfcd29bd4f5e5ead4d0a9) @@ -204,7 +204,15 @@ var mocks = new MockRepository(); var calculator = new TestWaveHeightCalculator(); var calculatorFactory = mocks.StrictMock(); - calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(testDataPath, usePreprocessor ? validPreprocessorDirectory : "")).Return(calculator); + string preprocessorDirectory = usePreprocessor ? validPreprocessorDirectory : string.Empty; + calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings) invocation.Arguments[0]; + Assert.AreEqual(validFilePath, settings.HlcdFilePath); + Assert.AreEqual(preprocessorDirectory, settings.PreprocessorDirectory); + }) + .Return(calculator); mocks.ReplayAll(); using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) Index: Ringtoets/Common/test/Ringtoets.Common.Service.Test/WaveHeightCalculationActivityTest.cs =================================================================== diff -u -r2a81f01756e227d5ce93717b21b87e8a5cd5fcbb -r58bb28c3d0e0ccfc1a3cfcd29bd4f5e5ead4d0a9 --- Ringtoets/Common/test/Ringtoets.Common.Service.Test/WaveHeightCalculationActivityTest.cs (.../WaveHeightCalculationActivityTest.cs) (revision 2a81f01756e227d5ce93717b21b87e8a5cd5fcbb) +++ Ringtoets/Common/test/Ringtoets.Common.Service.Test/WaveHeightCalculationActivityTest.cs (.../WaveHeightCalculationActivityTest.cs) (revision 58bb28c3d0e0ccfc1a3cfcd29bd4f5e5ead4d0a9) @@ -33,6 +33,7 @@ using Ringtoets.Common.Data.TestUtil; using Ringtoets.Common.Service.TestUtil; using Ringtoets.HydraRing.Calculation.Calculator.Factory; +using Ringtoets.HydraRing.Calculation.Data.Input; using Ringtoets.HydraRing.Calculation.Data.Input.Hydraulics; using Ringtoets.HydraRing.Calculation.TestUtil.Calculator; using Ringtoets.HydraRing.Calculation.TestUtil.IllustrationPoints; @@ -190,7 +191,14 @@ var mockRepository = new MockRepository(); var calculatorFactory = mockRepository.StrictMock(); - calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(testDataPath, validPreprocessorDirectory)).Return(calculator); + calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(validFilePath, settings.HlcdFilePath); + Assert.AreEqual(validPreprocessorDirectory, settings.PreprocessorDirectory); + }) + .Return(calculator); mockRepository.ReplayAll(); var hydraulicBoundaryLocation = new TestHydraulicBoundaryLocation(locationName); @@ -249,7 +257,14 @@ var mockRepository = new MockRepository(); var calculatorFactory = mockRepository.StrictMock(); - calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(testDataPath, validPreprocessorDirectory)).Return(calculator); + calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(validFilePath, settings.HlcdFilePath); + Assert.AreEqual(validPreprocessorDirectory, settings.PreprocessorDirectory); + }) + .Return(calculator); mockRepository.ReplayAll(); var activity = new WaveHeightCalculationActivity(hydraulicBoundaryLocationCalculation, @@ -291,7 +306,14 @@ var mockRepository = new MockRepository(); var calculatorFactory = mockRepository.StrictMock(); - calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(testDataPath, validPreprocessorDirectory)).Return(calculator); + calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(validFilePath, settings.HlcdFilePath); + Assert.AreEqual(validPreprocessorDirectory, settings.PreprocessorDirectory); + }) + .Return(calculator); mockRepository.ReplayAll(); var output = new TestHydraulicBoundaryLocationCalculationOutput(double.NaN, CalculationConvergence.CalculatedConverged); @@ -357,7 +379,14 @@ var mockRepository = new MockRepository(); var calculatorFactory = mockRepository.StrictMock(); - calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(testDataPath, validPreprocessorDirectory)).Return(calculator); + calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(validFilePath, settings.HlcdFilePath); + Assert.AreEqual(validPreprocessorDirectory, settings.PreprocessorDirectory); + }) + .Return(calculator); mockRepository.ReplayAll(); var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation(new TestHydraulicBoundaryLocation(locationName)) Index: Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/TreeNodeInfos/WaveHeightCalculationsContextTreeNodeInfoTest.cs =================================================================== diff -u -r2b7a4d261a11c943ea0f0081d45edea6252887cc -r58bb28c3d0e0ccfc1a3cfcd29bd4f5e5ead4d0a9 --- Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/TreeNodeInfos/WaveHeightCalculationsContextTreeNodeInfoTest.cs (.../WaveHeightCalculationsContextTreeNodeInfoTest.cs) (revision 2b7a4d261a11c943ea0f0081d45edea6252887cc) +++ Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/TreeNodeInfos/WaveHeightCalculationsContextTreeNodeInfoTest.cs (.../WaveHeightCalculationsContextTreeNodeInfoTest.cs) (revision 58bb28c3d0e0ccfc1a3cfcd29bd4f5e5ead4d0a9) @@ -44,6 +44,7 @@ using Ringtoets.Common.Forms.PresentationObjects; using Ringtoets.Common.Service.TestUtil; using Ringtoets.HydraRing.Calculation.Calculator.Factory; +using Ringtoets.HydraRing.Calculation.Data.Input; using Ringtoets.HydraRing.Calculation.Data.Input.Hydraulics; using Ringtoets.HydraRing.Calculation.TestUtil.Calculator; using Ringtoets.Integration.Data; @@ -57,7 +58,8 @@ private const int contextMenuRunWaveHeightCalculationsIndex = 2; private MockRepository mockRepository; - private readonly string testDataPath = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.Integration.Service, "HydraRingCalculation"); + private static readonly string testDataPath = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.Integration.Service, "HydraRingCalculation"); + private static readonly string validFilePath = Path.Combine(testDataPath, "HRD ijsselmeer.sqlite"); [Test] public void Initialized_Always_ExpectedPropertiesSet() @@ -366,7 +368,7 @@ { HydraulicBoundaryDatabase = { - FilePath = Path.Combine(testDataPath, "HRD ijsselmeer.sqlite") + FilePath = validFilePath } }; @@ -395,7 +397,14 @@ var waveHeightCalculator = new TestWaveHeightCalculator(); var calculatorFactory = mockRepository.Stub(); - calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(testDataPath, string.Empty)).Return(waveHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings) invocation.Arguments[0]; + Assert.AreEqual(validFilePath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(waveHeightCalculator); mockRepository.ReplayAll(); DialogBoxHandler = (name, wnd) => @@ -437,7 +446,7 @@ { HydraulicBoundaryDatabase = { - FilePath = Path.Combine(testDataPath, "HRD ijsselmeer.sqlite"), + FilePath = validFilePath, CanUsePreprocessor = true, UsePreprocessor = true, PreprocessorDirectory = preprocessorDirectory @@ -469,7 +478,14 @@ var waveHeightCalculator = new TestWaveHeightCalculator(); var calculatorFactory = mockRepository.Stub(); - calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(testDataPath, preprocessorDirectory)).Return(waveHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings) invocation.Arguments[0]; + Assert.AreEqual(validFilePath, settings.HlcdFilePath); + Assert.AreEqual(preprocessorDirectory, settings.PreprocessorDirectory); + }) + .Return(waveHeightCalculator); mockRepository.ReplayAll(); DialogBoxHandler = (name, wnd) => @@ -510,7 +526,7 @@ { HydraulicBoundaryDatabase = { - FilePath = Path.Combine(testDataPath, "HRD ijsselmeer.sqlite"), + FilePath = validFilePath, CanUsePreprocessor = true, UsePreprocessor = false, PreprocessorDirectory = "InvalidPreprocessorDirectory" @@ -542,7 +558,14 @@ var waveHeightCalculator = new TestWaveHeightCalculator(); var calculatorFactory = mockRepository.Stub(); - calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(testDataPath, string.Empty)).Return(waveHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings) invocation.Arguments[0]; + Assert.AreEqual(validFilePath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(waveHeightCalculator); mockRepository.ReplayAll(); DialogBoxHandler = (name, wnd) => @@ -584,7 +607,7 @@ { HydraulicBoundaryDatabase = { - FilePath = Path.Combine(testDataPath, "HRD ijsselmeer.sqlite") + FilePath = validFilePath }, Id = string.Empty }; @@ -617,7 +640,14 @@ Converged = false }; var calculatorFactory = mockRepository.Stub(); - calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(testDataPath, string.Empty)).Return(calculator); + calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings) invocation.Arguments[0]; + Assert.AreEqual(validFilePath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(calculator); mockRepository.ReplayAll(); DialogBoxHandler = (name, wnd) => Index: Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/TreeNodeInfos/WaveHeightCalculationsGroupContextTreeNodeInfoTest.cs =================================================================== diff -u -r2b7a4d261a11c943ea0f0081d45edea6252887cc -r58bb28c3d0e0ccfc1a3cfcd29bd4f5e5ead4d0a9 --- Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/TreeNodeInfos/WaveHeightCalculationsGroupContextTreeNodeInfoTest.cs (.../WaveHeightCalculationsGroupContextTreeNodeInfoTest.cs) (revision 2b7a4d261a11c943ea0f0081d45edea6252887cc) +++ Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/TreeNodeInfos/WaveHeightCalculationsGroupContextTreeNodeInfoTest.cs (.../WaveHeightCalculationsGroupContextTreeNodeInfoTest.cs) (revision 58bb28c3d0e0ccfc1a3cfcd29bd4f5e5ead4d0a9) @@ -44,6 +44,7 @@ using Ringtoets.Common.Plugin.TestUtil; using Ringtoets.HydraRing.Calculation.Calculator; using Ringtoets.HydraRing.Calculation.Calculator.Factory; +using Ringtoets.HydraRing.Calculation.Data.Input; using Ringtoets.HydraRing.Calculation.TestUtil.Calculator; using RingtoetsCommonFormsResources = Ringtoets.Common.Forms.Properties.Resources; @@ -293,11 +294,12 @@ { // Given var mockRepository = new MockRepository(); + string filePath = Path.Combine(testDataPath, "HRD ijsselmeer.sqlite"); var assessmentSection = new AssessmentSectionStub { HydraulicBoundaryDatabase = { - FilePath = Path.Combine(testDataPath, "HRD ijsselmeer.sqlite") + FilePath = filePath } }; @@ -325,7 +327,14 @@ Converged = false }; var calculatorFactory = mockRepository.Stub(); - calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(testDataPath, string.Empty)).Return(waveHeightCalculator).Repeat.Times(4); + calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings) invocation.Arguments[0]; + Assert.AreEqual(filePath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(waveHeightCalculator).Repeat.Times(4); mockRepository.ReplayAll(); DialogBoxHandler = (name, wnd) =>