Index: Application/Ringtoets/test/Application.Ringtoets.Storage.Test/StorageSqLiteTest.cs =================================================================== diff -u -r9d058b17ead065c9c63d8d11a2bd3d0938355b40 -r598d038fd4e76b2c75ac49e0d334d2fbc987f876 --- Application/Ringtoets/test/Application.Ringtoets.Storage.Test/StorageSqLiteTest.cs (.../StorageSqLiteTest.cs) (revision 9d058b17ead065c9c63d8d11a2bd3d0938355b40) +++ Application/Ringtoets/test/Application.Ringtoets.Storage.Test/StorageSqLiteTest.cs (.../StorageSqLiteTest.cs) (revision 598d038fd4e76b2c75ac49e0d334d2fbc987f876) @@ -359,7 +359,7 @@ // Assert ArgumentException exception = Assert.Throws(test); Assert.AreEqual($"Fout bij het lezen van bestand '{invalidPath}': bestandspad mag niet " - + " leeg of ongedefinieerd zijn.", exception.Message); + + "leeg of ongedefinieerd zijn.", exception.Message); } [Test] Index: Core/Common/src/Core.Common.IO/SqLiteConnectionStringBuilder.cs =================================================================== diff -u -rbece78e24185a5156bc10f7ec7875e4510b6934c -r598d038fd4e76b2c75ac49e0d334d2fbc987f876 --- Core/Common/src/Core.Common.IO/SqLiteConnectionStringBuilder.cs (.../SqLiteConnectionStringBuilder.cs) (revision bece78e24185a5156bc10f7ec7875e4510b6934c) +++ Core/Common/src/Core.Common.IO/SqLiteConnectionStringBuilder.cs (.../SqLiteConnectionStringBuilder.cs) (revision 598d038fd4e76b2c75ac49e0d334d2fbc987f876) @@ -42,9 +42,8 @@ { if (string.IsNullOrWhiteSpace(filePath)) { - throw new ArgumentNullException(nameof(filePath), @"Cannot create a connection " - + @"string without the path to " - + @"the file to connect to."); + const string message = @"Cannot create a connection string without the path to the file to connect to."; + throw new ArgumentNullException(nameof(filePath), message); } return new SQLiteConnectionStringBuilder { Index: Migration/Console/src/Migration.Console/ErrorCode.cs =================================================================== diff -u -r56e690b056dd0901609e651f6ac3c010d3d002b7 -r598d038fd4e76b2c75ac49e0d334d2fbc987f876 --- Migration/Console/src/Migration.Console/ErrorCode.cs (.../ErrorCode.cs) (revision 56e690b056dd0901609e651f6ac3c010d3d002b7) +++ Migration/Console/src/Migration.Console/ErrorCode.cs (.../ErrorCode.cs) (revision 598d038fd4e76b2c75ac49e0d334d2fbc987f876) @@ -24,6 +24,8 @@ /// /// Enumeration that defines the possible exit codes of an application. /// + /// See + /// System Error Codes public enum ErrorCode { /// @@ -32,7 +34,7 @@ ErrorSuccess = 0, /// - /// Exit because the command provide failed. + /// Exit because the command provided failed. /// ErrorBadCommand = 22, Index: Migration/Console/test/Migration.Console.Test/ConsoleHelperTest.cs =================================================================== diff -u -r56e690b056dd0901609e651f6ac3c010d3d002b7 -r598d038fd4e76b2c75ac49e0d334d2fbc987f876 --- Migration/Console/test/Migration.Console.Test/ConsoleHelperTest.cs (.../ConsoleHelperTest.cs) (revision 56e690b056dd0901609e651f6ac3c010d3d002b7) +++ Migration/Console/test/Migration.Console.Test/ConsoleHelperTest.cs (.../ConsoleHelperTest.cs) (revision 598d038fd4e76b2c75ac49e0d334d2fbc987f876) @@ -39,7 +39,7 @@ public void WriteErrorLine_StringNull_ThrowsArgumentNullException() { // Setup - var originalColor = SystemConsole.ForegroundColor; + ConsoleColor originalColor = SystemConsole.ForegroundColor; const string args = "an argument"; // Call @@ -55,7 +55,7 @@ public void WriteErrorLine_ArgsNull_ThrowsArgumentNullException() { // Setup - var originalColor = SystemConsole.ForegroundColor; + ConsoleColor originalColor = SystemConsole.ForegroundColor; const string writeLine = "this is an error line with {0}"; // Call @@ -71,7 +71,7 @@ public void WriteErrorLine_StringAndParamArgs_WritesExpectedLine() { // Setup - var originalColor = SystemConsole.ForegroundColor; + ConsoleColor originalColor = SystemConsole.ForegroundColor; const string writeLine = "this is an error line with {0}"; const string args = "an argument"; string consoleText; @@ -92,7 +92,7 @@ public void WriteErrorLine_String_WritesExpectedLine() { // Setup - var originalColor = SystemConsole.ForegroundColor; + ConsoleColor originalColor = SystemConsole.ForegroundColor; const string writeLine = "this is an error line"; string consoleText; @@ -165,8 +165,8 @@ } // Assert - var expectedText = string.Concat(" ", string.Format(writeLine, args), - Environment.NewLine, Environment.NewLine); + string expectedText = string.Concat(" ", string.Format(writeLine, args), + Environment.NewLine, Environment.NewLine); Assert.AreEqual(expectedText, consoleText); } @@ -185,8 +185,7 @@ } // Assert - var expectedText = string.Concat(" ", writeLine, Environment.NewLine, - Environment.NewLine); + var expectedText = string.Concat(" ", writeLine, Environment.NewLine, Environment.NewLine); Assert.AreEqual(expectedText, consoleText); } Index: Migration/Scripts/src/Migration.Scripts.Data/FileMigrationScript.cs =================================================================== diff -u -r56e690b056dd0901609e651f6ac3c010d3d002b7 -r598d038fd4e76b2c75ac49e0d334d2fbc987f876 --- Migration/Scripts/src/Migration.Scripts.Data/FileMigrationScript.cs (.../FileMigrationScript.cs) (revision 56e690b056dd0901609e651f6ac3c010d3d002b7) +++ Migration/Scripts/src/Migration.Scripts.Data/FileMigrationScript.cs (.../FileMigrationScript.cs) (revision 598d038fd4e76b2c75ac49e0d334d2fbc987f876) @@ -54,7 +54,7 @@ } /// - /// Gets the supported version. + /// Gets the version number from which files can be upgraded by the script. /// /// The supported version. public string SupportedVersion() @@ -63,7 +63,7 @@ } /// - /// Gets the target version. + /// Gets the version number to which files will be upgraded by the script. /// /// The target version. public string TargetVersion() Index: Migration/Scripts/test/Migration.Scripts.Data.Test/CreateScriptTest.cs =================================================================== diff -u -r56e690b056dd0901609e651f6ac3c010d3d002b7 -r598d038fd4e76b2c75ac49e0d334d2fbc987f876 --- Migration/Scripts/test/Migration.Scripts.Data.Test/CreateScriptTest.cs (.../CreateScriptTest.cs) (revision 56e690b056dd0901609e651f6ac3c010d3d002b7) +++ Migration/Scripts/test/Migration.Scripts.Data.Test/CreateScriptTest.cs (.../CreateScriptTest.cs) (revision 598d038fd4e76b2c75ac49e0d334d2fbc987f876) @@ -30,6 +30,8 @@ [TestFixture] public class CreateScriptTest { + private static readonly TestDataPath testPath = TestDataPath.Migration.Core.Storage; + [Test] [TestCase("")] [TestCase(null)] @@ -63,7 +65,7 @@ const string version = "Valid version"; string targetFilename = Path.GetRandomFileName(); - string filePath = TestHelper.GetTestDataPath(TestDataPath.Migration.Core.Storage, targetFilename); + string filePath = TestHelper.GetTestDataPath(testPath, targetFilename); var createScript = new TestCreateScript(version); // Call @@ -99,7 +101,7 @@ const string version = "Valid version"; string filename = Path.GetRandomFileName(); - string filePath = TestHelper.GetTestDataPath(TestDataPath.Migration.Core.Storage, filename); + string filePath = TestHelper.GetTestDataPath(testPath, filename); var createScript = new TestCreateScript(version); using (new FileDisposeHelper(filePath))