Index: Ringtoets/Common/test/Ringtoets.Common.Service.Test/TargetProbabilityCalculationServiceHelperTest.cs =================================================================== diff -u -r601f1061f518bafdba6041148f637b72338c0e74 -r71ecb245fd47868a9e5abf3656a307c90c6e51a3 --- Ringtoets/Common/test/Ringtoets.Common.Service.Test/TargetProbabilityCalculationServiceHelperTest.cs (.../TargetProbabilityCalculationServiceHelperTest.cs) (revision 601f1061f518bafdba6041148f637b72338c0e74) +++ Ringtoets/Common/test/Ringtoets.Common.Service.Test/TargetProbabilityCalculationServiceHelperTest.cs (.../TargetProbabilityCalculationServiceHelperTest.cs) (revision 71ecb245fd47868a9e5abf3656a307c90c6e51a3) @@ -20,6 +20,8 @@ // All rights reserved. using System; +using System.Collections.Generic; +using Core.Common.Util; using NUnit.Framework; namespace Ringtoets.Common.Service.Test @@ -28,10 +30,11 @@ public class TargetProbabilityCalculationServiceHelperTest { [Test] - public void IsValidTargetProbability_ValidTargetProbability_ReturnsTrue() + [TestCaseSource(nameof(ValidTargetProbabilities))] + public void IsValidTargetProbability_ValidTargetProbability_ReturnsTrue(double targetProbability) { // Call - bool isValid = TargetProbabilityCalculationServiceHelper.IsValidTargetProbability(0.005); + bool isValid = TargetProbabilityCalculationServiceHelper.IsValidTargetProbability(targetProbability); // Assert Assert.IsTrue(isValid); @@ -48,10 +51,11 @@ } [Test] - public void IsValidTargetProbability_TargetProbabilityTooBig_ReturnsFalse() + [TestCaseSource(nameof(TargetProbabilitiesThatAreTooBig))] + public void IsValidTargetProbability_TargetProbabilityTooBig_ReturnsFalse(double targetProbability) { // Call - bool isValid = TargetProbabilityCalculationServiceHelper.IsValidTargetProbability(1.0); + bool isValid = TargetProbabilityCalculationServiceHelper.IsValidTargetProbability(targetProbability); // Assert Assert.IsFalse(isValid); @@ -69,13 +73,14 @@ } [Test] - public void ValidateTargetProbability_ValidTargetProbability_ReturnsTrueAndHandlesNoLogMessage() + [TestCaseSource(nameof(ValidTargetProbabilities))] + public void ValidateTargetProbability_ValidTargetProbability_ReturnsTrueAndHandlesNoLogMessage(double targetProbability) { // Setup string logMessage = string.Empty; // Call - bool isValid = TargetProbabilityCalculationServiceHelper.ValidateTargetProbability(0.005, lm => logMessage = lm); + bool isValid = TargetProbabilityCalculationServiceHelper.ValidateTargetProbability(targetProbability, lm => logMessage = lm); // Assert Assert.IsTrue(isValid); @@ -97,17 +102,30 @@ } [Test] - public void ValidateTargetProbability_TargetProbabilityTooBig_ReturnsFalseAndHandlesExpectedLogMessage() + [TestCaseSource(nameof(TargetProbabilitiesThatAreTooBig))] + public void ValidateTargetProbability_TargetProbabilityTooBig_ReturnsFalseAndHandlesExpectedLogMessage(double targetProbability) { // Setup string logMessage = string.Empty; // Call - bool isValid = TargetProbabilityCalculationServiceHelper.ValidateTargetProbability(1.0, lm => logMessage = lm); + bool isValid = TargetProbabilityCalculationServiceHelper.ValidateTargetProbability(targetProbability, lm => logMessage = lm); // Assert Assert.IsFalse(isValid); Assert.AreEqual("Doelkans is te groot om een berekening uit te kunnen voeren.", logMessage); } + + private static IEnumerable ValidTargetProbabilities() + { + yield return new TestCaseData(0.005); + yield return new TestCaseData(StatisticsConverter.ReliabilityToProbability(-1)); + } + + private static IEnumerable TargetProbabilitiesThatAreTooBig() + { + yield return new TestCaseData(StatisticsConverter.ReliabilityToProbability(-1.005)); + yield return new TestCaseData(5.0); + } } } \ No newline at end of file