Index: src/Plugins/Wti/Wti.Calculation/Piping/PipingCalculation.cs =================================================================== diff -u -re61dfe357a722430029affaa9a28e6bd2cbbc281 -r77bd5fae96250f5c6e1eb7acaa848b754d44475d --- src/Plugins/Wti/Wti.Calculation/Piping/PipingCalculation.cs (.../PipingCalculation.cs) (revision e61dfe357a722430029affaa9a28e6bd2cbbc281) +++ src/Plugins/Wti/Wti.Calculation/Piping/PipingCalculation.cs (.../PipingCalculation.cs) (revision 77bd5fae96250f5c6e1eb7acaa848b754d44475d) @@ -26,6 +26,7 @@ /// contains the results of all sub calculations. /// /// A containing the results of the sub calculations. + /// Thrown when any of the invocations of the sub-calculations from the kernel throws an Exception. public PipingCalculationResult Calculate() { try Index: src/Plugins/Wti/Wti.Calculation/Piping/PipingCalculationInput.cs =================================================================== diff -u -re61dfe357a722430029affaa9a28e6bd2cbbc281 -r77bd5fae96250f5c6e1eb7acaa848b754d44475d --- src/Plugins/Wti/Wti.Calculation/Piping/PipingCalculationInput.cs (.../PipingCalculationInput.cs) (revision e61dfe357a722430029affaa9a28e6bd2cbbc281) +++ src/Plugins/Wti/Wti.Calculation/Piping/PipingCalculationInput.cs (.../PipingCalculationInput.cs) (revision 77bd5fae96250f5c6e1eb7acaa848b754d44475d) @@ -32,6 +32,7 @@ /// /// Gets the volumetric weight of water. + /// [kN/m³] /// public double WaterVolumetricWeight { @@ -54,6 +55,7 @@ /// /// Gets the outside high water level. + /// [m] /// public double AssessmentLevel { @@ -65,6 +67,7 @@ /// /// Gets the piezometric head at the exit point. + /// [m] /// public double PiezometricHeadExit { @@ -87,6 +90,7 @@ /// /// Gets the phreatic level at the exit point. + /// [m] /// public double PhreaticLevelExit { @@ -98,6 +102,7 @@ /// /// Gets the piezometric head in the hinterland. + /// [m] /// public double PiezometricHeadPolder { @@ -120,6 +125,7 @@ /// /// Gets the total thickness of the coverage layer at the exit point. + /// [m] /// public double ThicknessCoverageLayer { @@ -152,6 +158,7 @@ /// /// Gets the horizontal distance between entree and exit point. + /// [m] /// public double SeepageLength { @@ -163,6 +170,7 @@ /// /// Gets the (lowerbound) volumic weight of sand grain material of a sand layer under water. + /// [kN/m³] /// public double SandParticlesVolumicWeight { @@ -185,6 +193,7 @@ /// /// Gets the sieve size through which 70% fraction of the grains of the top part of the aquifer passes. + /// [m] /// public double Diameter70 { @@ -196,6 +205,7 @@ /// /// Gets the Darcy-speed with which water flows through the aquifer layer. + /// [m/s] /// public double DarcyPermeability { @@ -207,6 +217,7 @@ /// /// Gets the kinematic viscosity of water at 10 degrees Celsius. + /// [m²/s] /// public double WaterKinematicViscosity { @@ -218,6 +229,7 @@ /// /// Gets the gravitational acceleration. + /// [m/s²] /// public double Gravity { @@ -229,6 +241,7 @@ /// /// Gets the thickness of the aquifer layer. + /// [m] /// public double ThicknessAquiferLayer { @@ -240,6 +253,7 @@ /// /// Gets the mean diameter of small scale tests applied to different kinds of sand, on which the formula of Sellmeijer has been fit. + /// [m] /// public double MeanDiameter70 { @@ -251,6 +265,7 @@ /// /// Gets the angle of the force balance representing the amount in which sand grains resist rolling. + /// [°] /// public double BeddingAngle { @@ -262,6 +277,7 @@ /// /// Gets the x coordinate of the exit point. + /// [m] /// public double ExitPointXCoordinate { @@ -277,28 +293,28 @@ /// Constructs a new , which contains values for the parameters used /// in the piping sub calculations. /// - /// The volumetric weight of water. + /// The volumetric weight of water. [kN/m³] /// The calculation value used to account for uncertainty in the model for uplift. - /// The outside high water level. - /// The piezometric head at the exit point. - /// The damping factor at the exit point. - /// The phreatic level at the exit point. - /// The piezometric head in the hinterland. + /// The outside high water level. [m] + /// The piezometric head at the exit point. [m] + /// The damping factor at the exit point. + /// The phreatic level at the exit point. [m] + /// The piezometric head in the hinterland. [m] /// The critical exit gradient for heave. - /// The total thickness of the coverage layer at the exit point. + /// The total thickness of the coverage layer at the exit point. [m] /// The calculation value used to account for uncertainty in the model for Sellmeijer. /// The reduction factor Sellmeijer. - /// The horizontal distance between entree and exit point. - /// The (lowerbound) volumic weight of sand grain material of a sand layer under water. + /// The horizontal distance between entree and exit point. [m] + /// The (lowerbound) volumic weight of sand grain material of a sand layer under water. [kN/m³] /// The White's drag coefficient. - /// The sieve size through which 70% fraction of the grains of the top part of the aquifer passes. - /// The Darcy-speed with which water flows through the aquifer layer. - /// The kinematic viscosity of water at 10 degrees Celsius. - /// The gravitational acceleration. - /// The thickness of the aquifer layer. - /// The mean diameter of small scale tests applied to different kinds of sand, on which the formula of Sellmeijer has been fit. - /// The angle of the force balance representing the amount in which sand grains resist rolling. - /// The x coordinate of the exit point. + /// The sieve size through which 70% fraction of the grains of the top part of the aquifer passes. [m] + /// The Darcy-speed with which water flows through the aquifer layer. [m/s] + /// The kinematic viscosity of water at 10 degrees Celsius. [m²/s] + /// The gravitational acceleration. [m/s²] + /// The thickness of the aquifer layer. [m] + /// The mean diameter of small scale tests applied to different kinds of sand, on which the formula of Sellmeijer has been fit. [m] + /// The angle of the force balance representing the amount in which sand grains resist rolling. [°] + /// The x coordinate of the exit point. [m] public PipingCalculationInput(double waterVolumetricWeight, double upliftModelFactor, double assessmentLevel, double piezometricHeadExit, double dampingFactorExit, double phreaticLevelExit, double piezometricHeadPolder, double criticalHeaveGradient, double thicknessCoverageLayer, double sellmeijerModelFactor, double sellmeijerReductionFactor, double seepageLength, double sandParticlesVolumicWeight, double whitesDragCoefficient, double diameter70, double darcyPermeability, double waterKinematicViscosity, double gravity, double thicknessAquiferLayer, double meanDiameter70, double beddingAngle, double exitPointXCoordinate) { this.waterVolumetricWeight = waterVolumetricWeight; Index: test/Plugins/Wti/Wti.Calculation.Test/Piping/PipingCalculationTest.cs =================================================================== diff -u -re61dfe357a722430029affaa9a28e6bd2cbbc281 -r77bd5fae96250f5c6e1eb7acaa848b754d44475d --- test/Plugins/Wti/Wti.Calculation.Test/Piping/PipingCalculationTest.cs (.../PipingCalculationTest.cs) (revision e61dfe357a722430029affaa9a28e6bd2cbbc281) +++ test/Plugins/Wti/Wti.Calculation.Test/Piping/PipingCalculationTest.cs (.../PipingCalculationTest.cs) (revision 77bd5fae96250f5c6e1eb7acaa848b754d44475d) @@ -35,6 +35,7 @@ random.NextDouble()); PipingCalculationResult actual = new PipingCalculation(input).Calculate(); + Assert.That(actual, Is.Not.Null); Assert.That(actual.UpliftZValue, Is.Not.NaN); Assert.That(actual.UpliftFactorOfSafety, Is.Not.NaN); Assert.That(actual.HeaveZValue, Is.Not.NaN); Index: test/Plugins/Wti/Wti.Calculation.Test/Piping/PipingSurfaceLineCreatorTest.cs =================================================================== diff -u -r1791d59ecae6050732d7878278154dc4f3bc21f2 -r77bd5fae96250f5c6e1eb7acaa848b754d44475d --- test/Plugins/Wti/Wti.Calculation.Test/Piping/PipingSurfaceLineCreatorTest.cs (.../PipingSurfaceLineCreatorTest.cs) (revision 1791d59ecae6050732d7878278154dc4f3bc21f2) +++ test/Plugins/Wti/Wti.Calculation.Test/Piping/PipingSurfaceLineCreatorTest.cs (.../PipingSurfaceLineCreatorTest.cs) (revision 77bd5fae96250f5c6e1eb7acaa848b754d44475d) @@ -11,7 +11,7 @@ { var pipingSurfaceLineCreator = new PipingSurfaceLineCreator(); PipingSurfaceLine actual = pipingSurfaceLineCreator.Create(); - Assert.That(actual.Points, Is.Not.Empty); + Assert.That(actual.Points.Count, Is.EqualTo(1)); Assert.That(actual.Points[0].X, Is.EqualTo(0)); Assert.That(actual.Points[0].Y, Is.EqualTo(0)); Assert.That(actual.Points[0].Z, Is.EqualTo(0));