Index: Core/Components/src/Core.Components.DotSpatial/Converter/IMapDataConverter.cs =================================================================== diff -u -r4512af7782ee31b36941bb280b54d9da2953dd71 -r7cb5faabd65fb50c17f40c75b76fbd17714cca82 --- Core/Components/src/Core.Components.DotSpatial/Converter/IMapDataConverter.cs (.../IMapDataConverter.cs) (revision 4512af7782ee31b36941bb280b54d9da2953dd71) +++ Core/Components/src/Core.Components.DotSpatial/Converter/IMapDataConverter.cs (.../IMapDataConverter.cs) (revision 7cb5faabd65fb50c17f40c75b76fbd17714cca82) @@ -35,8 +35,8 @@ /// Checks whether the can convert the . /// /// The to check for. - /// True if the can be converter by the - /// , false otheriwse. + /// true if the can be converted by the + /// , false otherwise. bool CanConvertMapData(MapData data); /// Index: Core/Components/src/Core.Components.DotSpatial/Converter/MapDataCollectionConverter.cs =================================================================== diff -u -r4512af7782ee31b36941bb280b54d9da2953dd71 -r7cb5faabd65fb50c17f40c75b76fbd17714cca82 --- Core/Components/src/Core.Components.DotSpatial/Converter/MapDataCollectionConverter.cs (.../MapDataCollectionConverter.cs) (revision 4512af7782ee31b36941bb280b54d9da2953dd71) +++ Core/Components/src/Core.Components.DotSpatial/Converter/MapDataCollectionConverter.cs (.../MapDataCollectionConverter.cs) (revision 7cb5faabd65fb50c17f40c75b76fbd17714cca82) @@ -20,6 +20,7 @@ // All rights reserved. using System.Collections.Generic; +using System.Linq; using Core.Components.DotSpatial.Data; using DotSpatial.Data; @@ -33,12 +34,8 @@ protected override IList Convert(MapDataCollection data) { var factory = new MapDataFactory(); - var featureSets = new List(); - foreach (var mapData in data.List) - { - featureSets.AddRange(factory.Create(mapData)); - } - return featureSets; + + return data.List.SelectMany(md => factory.Create(md)).ToList(); } } } Index: Core/Components/src/Core.Components.DotSpatial/Converter/MapLineDataConverter.cs =================================================================== diff -u -r4512af7782ee31b36941bb280b54d9da2953dd71 -r7cb5faabd65fb50c17f40c75b76fbd17714cca82 --- Core/Components/src/Core.Components.DotSpatial/Converter/MapLineDataConverter.cs (.../MapLineDataConverter.cs) (revision 4512af7782ee31b36941bb280b54d9da2953dd71) +++ Core/Components/src/Core.Components.DotSpatial/Converter/MapLineDataConverter.cs (.../MapLineDataConverter.cs) (revision 7cb5faabd65fb50c17f40c75b76fbd17714cca82) @@ -28,25 +28,22 @@ namespace Core.Components.DotSpatial.Converter { /// - /// The converter that converts into a containing . + /// The converter that converts into a containing a . /// public class MapLineDataConverter : MapDataConverter { protected override IList Convert(MapLineData data) { - var points = data.Points.ToList(); + var coordinates = data.Points.Select(p => new Coordinate(p.Item1, p.Item2)); + var lineString = new LineString(coordinates); var featureSet = new FeatureSet(FeatureType.Line); - Coordinate[] coordinates = new Coordinate[points.Count()]; - for (int i = 0; i < points.Count(); i++) - { - coordinates[i] = new Coordinate(points[i].Item1, points[i].Item2); - } - var lineString = new LineString(coordinates); - var feature = new Feature(lineString); - featureSet.Features.Add(feature); + featureSet.Features.Add(lineString); - return new List { featureSet }; + return new List + { + featureSet + }; } } } Index: Core/Components/src/Core.Components.DotSpatial/Converter/MapPointDataConverter.cs =================================================================== diff -u -r4512af7782ee31b36941bb280b54d9da2953dd71 -r7cb5faabd65fb50c17f40c75b76fbd17714cca82 --- Core/Components/src/Core.Components.DotSpatial/Converter/MapPointDataConverter.cs (.../MapPointDataConverter.cs) (revision 4512af7782ee31b36941bb280b54d9da2953dd71) +++ Core/Components/src/Core.Components.DotSpatial/Converter/MapPointDataConverter.cs (.../MapPointDataConverter.cs) (revision 7cb5faabd65fb50c17f40c75b76fbd17714cca82) @@ -27,7 +27,7 @@ namespace Core.Components.DotSpatial.Converter { /// - /// The converter that converts into . + /// The converter that converts into a containing one or more . /// public class MapPointDataConverter : MapDataConverter { @@ -37,8 +37,7 @@ foreach (var point in data.Points) { - var coordinate = new Coordinate(point.Item1, point.Item2); - featureSet.Features.Add(coordinate); + featureSet.Features.Add(new Coordinate(point.Item1, point.Item2)); } return new List { featureSet }; Index: Core/Components/src/Core.Components.DotSpatial/Converter/MapPolygonDataConverter.cs =================================================================== diff -u -r4512af7782ee31b36941bb280b54d9da2953dd71 -r7cb5faabd65fb50c17f40c75b76fbd17714cca82 --- Core/Components/src/Core.Components.DotSpatial/Converter/MapPolygonDataConverter.cs (.../MapPolygonDataConverter.cs) (revision 4512af7782ee31b36941bb280b54d9da2953dd71) +++ Core/Components/src/Core.Components.DotSpatial/Converter/MapPolygonDataConverter.cs (.../MapPolygonDataConverter.cs) (revision 7cb5faabd65fb50c17f40c75b76fbd17714cca82) @@ -19,9 +19,7 @@ // Stichting Deltares and remain full property of Stichting Deltares at all times. // All rights reserved. -using System; using System.Collections.Generic; -using System.Collections.ObjectModel; using System.Linq; using Core.Components.DotSpatial.Data; using DotSpatial.Data; @@ -30,25 +28,22 @@ namespace Core.Components.DotSpatial.Converter { /// - /// The converter that converts into containing . + /// The converter that converts into a containing a . /// public class MapPolygonDataConverter : MapDataConverter { protected override IList Convert(MapPolygonData data) { + var coordinates = data.Points.Select(p => new Coordinate(p.Item1, p.Item2)); + var polygon = new Polygon(coordinates); var featureSet = new FeatureSet(FeatureType.Polygon); - var points = data.Points.ToArray(); - - var coordinates = new Collection(); - for (int i = 0; i < points.Length; i++) - { - coordinates.Add(new Coordinate(points[i].Item1, points[i].Item2)); - } - var polygon = new Polygon(coordinates); featureSet.Features.Add(polygon); - return new List { featureSet }; + return new List + { + featureSet + }; } } }