Index: Core/Common/src/Core.Common.Gui/Settings/SettingsHelper.cs =================================================================== diff -u -r72da35fee21360783bf87322879144f16d7e7589 -r7d6e4c28a40fb056c182d0691dda2b2e88aeebfd --- Core/Common/src/Core.Common.Gui/Settings/SettingsHelper.cs (.../SettingsHelper.cs) (revision 72da35fee21360783bf87322879144f16d7e7589) +++ Core/Common/src/Core.Common.Gui/Settings/SettingsHelper.cs (.../SettingsHelper.cs) (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -59,7 +59,7 @@ /// /// The postfix path to use after the local application data folder (if any). /// Directory path where the user settings can be found. - /// Thown when the application local user settings directory could not be created. + /// Thrown when the application local user settings directory could not be created. public static string GetApplicationLocalUserSettingsDirectory(string postfix) { var appSettingsDirectoryPath = string.IsNullOrWhiteSpace(postfix) ? localSettingsDirectoryPath : Path.Combine(localSettingsDirectoryPath, postfix); Index: Core/Common/test/Core.Common.TestUtil.Test/Core.Common.TestUtil.Test.csproj =================================================================== diff -u -rb1b25abeb595bff11389bbf0e695851995ef5221 -r7d6e4c28a40fb056c182d0691dda2b2e88aeebfd --- Core/Common/test/Core.Common.TestUtil.Test/Core.Common.TestUtil.Test.csproj (.../Core.Common.TestUtil.Test.csproj) (revision b1b25abeb595bff11389bbf0e695851995ef5221) +++ Core/Common/test/Core.Common.TestUtil.Test/Core.Common.TestUtil.Test.csproj (.../Core.Common.TestUtil.Test.csproj) (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -44,6 +44,10 @@ ..\..\..\..\packages\NUnit.2.6.4\lib\nunit.framework.dll + + ..\..\..\..\packages\RhinoMocks.3.6.1\lib\net\Rhino.Mocks.dll + True + @@ -57,6 +61,7 @@ + True True @@ -77,6 +82,10 @@ {3bbfd65b-b277-4e50-ae6d-bd24c3434609} Core.Common.Base + + {30e4c2ae-719e-4d70-9fa9-668a9767fbfa} + Core.Common.Gui + {D749EE4C-CE50-4C17-BF01-9A953028C126} Core.Common.TestUtil Index: Core/Common/test/Core.Common.TestUtil.Test/PropertiesTestHelperTest.cs =================================================================== diff -u --- Core/Common/test/Core.Common.TestUtil.Test/PropertiesTestHelperTest.cs (revision 0) +++ Core/Common/test/Core.Common.TestUtil.Test/PropertiesTestHelperTest.cs (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -0,0 +1,115 @@ +// Copyright (C) Stichting Deltares 2016. All rights reserved. +// +// This file is part of Ringtoets. +// +// Ringtoets is free software: you can redistribute it and/or modify +// it under the terms of the GNU Lesser General Public License as published by +// the Free Software Foundation, either version 3 of the License, or +// (at your option) any later version. +// +// This program is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU Lesser General Public License for more details. +// +// You should have received a copy of the GNU Lesser General Public License +// along with this program. If not, see . +// +// All names, logos, and references to "Deltares" are registered trademarks of +// Stichting Deltares and remain full property of Stichting Deltares at all times. +// All rights reserved. + +using System.ComponentModel; +using Core.Common.Gui.PropertyBag; +using NUnit.Framework; +using Rhino.Mocks; + +namespace Core.Common.TestUtil.Test +{ + [TestFixture] + public class PropertiesTestHelperTest + { + [Test] + public void GetAllVisiblePropertyDescriptors_NoProperties_ReturnEmpty() + { + // Setup + var propertiesObject = new NoProperties(); + + // Call + PropertyDescriptorCollection visibleProperties = PropertiesTestHelper.GetAllVisiblePropertyDescriptors(propertiesObject); + + // Assert + CollectionAssert.IsEmpty(visibleProperties); + } + + [Test] + public void GetAllVisiblePropertyDescriptors_HiddenProperties_ReturnEmpty() + { + // Setup + var propertiesObject = new HiddenProperties(); + + // Call + PropertyDescriptorCollection visibleProperties = PropertiesTestHelper.GetAllVisiblePropertyDescriptors(propertiesObject); + + // Assert + CollectionAssert.IsEmpty(visibleProperties); + } + + [Test] + public void GetAllVisiblePropertyDescriptors_VisibleProperties_ReturnEmpty() + { + // Setup + var propertiesObject = new VisibleProperties(); + + // Call + PropertyDescriptorCollection visibleProperties = PropertiesTestHelper.GetAllVisiblePropertyDescriptors(propertiesObject); + + // Assert + Assert.AreEqual(2, visibleProperties.Count); + } + + [Test] + [TestCase(true, "", "", "")] + [TestCase(false, "A", "B", "C")] + public void AssertRequiredPropertyDescriptorProperties_PropertyDescriptor_AssertParameters( + bool isReadOnly, string category, string displayName, string description) + { + // Setup + var mocks = new MockRepository(); + var propertyDescriptor = mocks.Stub("stub", null); + propertyDescriptor.Stub(pd => pd.IsReadOnly).Return(isReadOnly); + propertyDescriptor.Stub(pd => pd.Category).Return(category); + propertyDescriptor.Stub(pd => pd.DisplayName).Return(displayName); + propertyDescriptor.Stub(pd => pd.Description).Return(description); + mocks.ReplayAll(); + + // Call + PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(propertyDescriptor, + category, + displayName, + description, + isReadOnly); + + // Assert + mocks.VerifyAll(); + } + + private class NoProperties : ObjectProperties {} + + private class HiddenProperties : ObjectProperties + { + [Browsable(false)] + public string HiddenProperty1 { get; set; } + + [Browsable(false)] + public string HiddenProperty2 { get; set; } + } + + private class VisibleProperties : ObjectProperties + { + public string Property1 { get; set; } + + public string Property2 { get; set; } + } + } +} \ No newline at end of file Index: Core/Common/test/Core.Common.TestUtil.Test/TestHelperTest.cs =================================================================== diff -u -r5d503cf8885ced4799e5ad44242038d99e04b162 -r7d6e4c28a40fb056c182d0691dda2b2e88aeebfd --- Core/Common/test/Core.Common.TestUtil.Test/TestHelperTest.cs (.../TestHelperTest.cs) (revision 5d503cf8885ced4799e5ad44242038d99e04b162) +++ Core/Common/test/Core.Common.TestUtil.Test/TestHelperTest.cs (.../TestHelperTest.cs) (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -118,6 +118,12 @@ path = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.HeightStructures.Integration); Assert.IsTrue(Directory.Exists(path)); + path = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.ClosingStructures.IO); + Assert.IsTrue(Directory.Exists(path)); + + path = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.StabilityPointStructures.IO); + Assert.IsTrue(Directory.Exists(path)); + path = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.Piping.IO); Assert.IsTrue(Directory.Exists(path)); path = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.Piping.Plugin); Index: Core/Common/test/Core.Common.TestUtil.Test/packages.config =================================================================== diff -u -rfea3ed82dfb6dfcad535eef16efcbaa9c01564ed -r7d6e4c28a40fb056c182d0691dda2b2e88aeebfd --- Core/Common/test/Core.Common.TestUtil.Test/packages.config (.../packages.config) (revision fea3ed82dfb6dfcad535eef16efcbaa9c01564ed) +++ Core/Common/test/Core.Common.TestUtil.Test/packages.config (.../packages.config) (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -24,4 +24,5 @@ + \ No newline at end of file Index: Core/Common/test/Core.Common.TestUtil/Core.Common.TestUtil.csproj =================================================================== diff -u -r96c96a5f55735cb1d019a5fd8677200e2079284d -r7d6e4c28a40fb056c182d0691dda2b2e88aeebfd --- Core/Common/test/Core.Common.TestUtil/Core.Common.TestUtil.csproj (.../Core.Common.TestUtil.csproj) (revision 96c96a5f55735cb1d019a5fd8677200e2079284d) +++ Core/Common/test/Core.Common.TestUtil/Core.Common.TestUtil.csproj (.../Core.Common.TestUtil.csproj) (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -94,6 +94,7 @@ + Resources.resx @@ -117,6 +118,10 @@ {3bbfd65b-b277-4e50-ae6d-bd24c3434609} Core.Common.Base + + {30e4c2ae-719e-4d70-9fa9-668a9767fbfa} + Core.Common.Gui + {f49bd8b2-332a-4c91-a196-8cce0a2c7d98} Core.Common.Utils Index: Core/Common/test/Core.Common.TestUtil/PropertiesTestHelper.cs =================================================================== diff -u --- Core/Common/test/Core.Common.TestUtil/PropertiesTestHelper.cs (revision 0) +++ Core/Common/test/Core.Common.TestUtil/PropertiesTestHelper.cs (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -0,0 +1,70 @@ +// Copyright (C) Stichting Deltares 2016. All rights reserved. +// +// This file is part of Ringtoets. +// +// Ringtoets is free software: you can redistribute it and/or modify +// it under the terms of the GNU Lesser General Public License as published by +// the Free Software Foundation, either version 3 of the License, or +// (at your option) any later version. +// +// This program is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU Lesser General Public License for more details. +// +// You should have received a copy of the GNU Lesser General Public License +// along with this program. If not, see . +// +// All names, logos, and references to "Deltares" are registered trademarks of +// Stichting Deltares and remain full property of Stichting Deltares at all times. +// All rights reserved. + +using System; +using System.ComponentModel; +using System.Windows.Forms; +using Core.Common.Gui.PropertyBag; +using NUnit.Framework; + +namespace Core.Common.TestUtil +{ + /// + /// Helper class when dealing with implementations or + /// other objects that are meant to be shown in the . + /// + public static class PropertiesTestHelper + { + /// + /// Gets all visible property descriptors for a given 'object properties' object. + /// + /// The properties object. + /// All visible property descriptors. + public static PropertyDescriptorCollection GetAllVisiblePropertyDescriptors(object propertiesObject) + { + var dynamicPropertyBag = new DynamicPropertyBag(propertiesObject); + return dynamicPropertyBag.GetProperties(new Attribute[] + { + BrowsableAttribute.Yes + }); + } + + /// + /// Asserts the properties of a on required subjects. + /// + /// The property to be checked. + /// The expected category. + /// The expected name of the property shown to the user. + /// The expected description of the property shown to the user. + /// Indicates whether or not the property is read-only. + public static void AssertRequiredPropertyDescriptorProperties(PropertyDescriptor property, + string expectedCategory, + string expectedDisplayName, + string expectedDescription, + bool isReadOnly = false) + { + Assert.AreEqual(isReadOnly, property.IsReadOnly); + Assert.AreEqual(expectedCategory, property.Category); + Assert.AreEqual(expectedDisplayName, property.DisplayName); + Assert.AreEqual(expectedDescription, property.Description); + } + } +} \ No newline at end of file Index: Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Data/ClosingStructure.cs =================================================================== diff -u -r89e6554de0313cdaa6876ba510240ee98c8547bb -r7d6e4c28a40fb056c182d0691dda2b2e88aeebfd --- Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Data/ClosingStructure.cs (.../ClosingStructure.cs) (revision 89e6554de0313cdaa6876ba510240ee98c8547bb) +++ Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Data/ClosingStructure.cs (.../ClosingStructure.cs) (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -36,7 +36,7 @@ /// /// The construction properties. /// Thrown when - /// or is null , empty or consists of whitespace. + /// or is null, empty or consists of whitespace. /// Thrown when is null. public ClosingStructure(ConstructionProperties constructionProperties) : base(constructionProperties) { @@ -250,30 +250,30 @@ public LogNormalDistribution FlowWidthAtBottomProtection { get; private set; } /// - /// Gets the probability of the closing structure being open before flooding. + /// Gets or sets the probability of the closing structure being open before flooding. /// [1/year] /// public double ProbabilityOpenStructureBeforeFlooding { get; set; } /// - /// Gets the probability of failing to close the closing structure. + /// Gets or sets the probability of failing to close the closing structure. /// [1/year] /// public double FailureProbabilityOpenStructure { get; set; } /// - /// Gets the number of identical apertures of the closing structure. + /// Gets or sets the number of identical apertures of the closing structure. /// public int IdenticalApertures { get; set; } /// - /// Gets the probability of failing to repair a failed closure of the closing structure. + /// Gets or sets the probability of failing to repair a failed closure of the closing structure. /// [1/year] /// public double FailureProbabilityReparation { get; set; } /// - /// Gets the type of closing structure inflow model. + /// Gets or sets the type of closing structure inflow model. /// public ClosingStructureInflowModelType InflowModelType { get; set; } } Index: Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructureProperties.cs =================================================================== diff -u -r790d12a1b8f6bb77d03a9fb4ef48892f71d7f778 -r7d6e4c28a40fb056c182d0691dda2b2e88aeebfd --- Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructureProperties.cs (.../ClosingStructureProperties.cs) (revision 790d12a1b8f6bb77d03a9fb4ef48892f71d7f778) +++ Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructureProperties.cs (.../ClosingStructureProperties.cs) (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -112,11 +112,11 @@ [ResourcesCategory(typeof(RingtoetsCommonFormsResources), "Categories_Schematization")] [ResourcesDisplayName(typeof(RingtoetsCommonFormsResources), "Structure_WidthFlowApertures_DisplayName")] [ResourcesDescription(typeof(RingtoetsCommonFormsResources), "Structure_WidthFlowApertures_Description")] - public NormalDistributionVariationProperties WidthFlowApertures + public VariationCoefficientNormalDistributionProperties WidthFlowApertures { get { - return new NormalDistributionVariationProperties + return new VariationCoefficientNormalDistributionProperties { Data = data.WidthFlowApertures }; @@ -172,11 +172,11 @@ [ResourcesCategory(typeof(RingtoetsCommonFormsResources), "Categories_Schematization")] [ResourcesDisplayName(typeof(RingtoetsCommonFormsResources), "Structure_StorageStructureArea_DisplayName")] [ResourcesDescription(typeof(RingtoetsCommonFormsResources), "Structure_StorageStructureArea_Description")] - public LogNormalDistributionVariationProperties StorageStructureArea + public VariationCoefficientLogNormalDistributionProperties StorageStructureArea { get { - return new LogNormalDistributionVariationProperties + return new VariationCoefficientLogNormalDistributionProperties { Data = data.StorageStructureArea }; @@ -252,11 +252,11 @@ [ResourcesCategory(typeof(RingtoetsCommonFormsResources), "Categories_Schematization")] [ResourcesDisplayName(typeof(RingtoetsCommonFormsResources), "Structure_CriticalOvertoppingDischarge_DisplayName")] [ResourcesDescription(typeof(RingtoetsCommonFormsResources), "Structure_CriticalOvertoppingDischarge_Description")] - public LogNormalDistributionVariationProperties CriticalOvertoppingDischarge + public VariationCoefficientLogNormalDistributionProperties CriticalOvertoppingDischarge { get { - return new LogNormalDistributionVariationProperties + return new VariationCoefficientLogNormalDistributionProperties { Data = data.CriticalOvertoppingDischarge }; Index: Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.IO/ClosingStructuresImporter.cs =================================================================== diff -u -r0dd52355d7e8eedc01afd118d8936dca2dc3b7be -r7d6e4c28a40fb056c182d0691dda2b2e88aeebfd --- Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.IO/ClosingStructuresImporter.cs (.../ClosingStructuresImporter.cs) (revision 0dd52355d7e8eedc01afd118d8936dca2dc3b7be) +++ Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.IO/ClosingStructuresImporter.cs (.../ClosingStructuresImporter.cs) (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -167,13 +167,17 @@ private static ClosingStructureInflowModelType GetClosingStructureInflowModelType(StructuresParameterRow structureParameterRow) { string keywordValue = structureParameterRow.AlphanumericValue.ToLower(); - if (keywordValue == "verticalewand") + switch (keywordValue) { - return ClosingStructureInflowModelType.VerticalWall; + case StructureFilesKeywords.InflowModelTypeVerticalWall: + return ClosingStructureInflowModelType.VerticalWall; + case StructureFilesKeywords.InflowModelTypeLowSill: + return ClosingStructureInflowModelType.LowSill; + case StructureFilesKeywords.InflowModelTypeFloodedCulvert: + return ClosingStructureInflowModelType.FloodedCulvert; + default: + throw new NotSupportedException(); } - return keywordValue == "lagedrempel" - ? ClosingStructureInflowModelType.LowSill - : ClosingStructureInflowModelType.FloodedCulvert; } } } \ No newline at end of file Index: Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Data.TestUtil.Test/TestClosingStructureTest.cs =================================================================== diff -u -r2698972311ca90c3af1171c554c4dec237e34111 -r7d6e4c28a40fb056c182d0691dda2b2e88aeebfd --- Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Data.TestUtil.Test/TestClosingStructureTest.cs (.../TestClosingStructureTest.cs) (revision 2698972311ca90c3af1171c554c4dec237e34111) +++ Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Data.TestUtil.Test/TestClosingStructureTest.cs (.../TestClosingStructureTest.cs) (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -35,42 +35,7 @@ // Assert Assert.AreEqual("test", structure.Name); - Assert.AreEqual("id", structure.Id); - Assert.AreEqual(new Point2D(12345.56789, 9876.54321), structure.Location); - Assert.AreEqual(10.0, structure.StructureNormalOrientation.Value); - - Assert.AreEqual(20000, structure.StorageStructureArea.Mean.Value); - Assert.AreEqual(0.1, structure.StorageStructureArea.CoefficientOfVariation.Value); - - Assert.AreEqual(0.2, structure.AllowedLevelIncreaseStorage.Mean.Value); - Assert.AreEqual(0.1, structure.AllowedLevelIncreaseStorage.StandardDeviation.Value); - - Assert.AreEqual(21, structure.WidthFlowApertures.Mean.Value); - Assert.AreEqual(0.05, structure.WidthFlowApertures.CoefficientOfVariation.Value); - - Assert.AreEqual(4.95, structure.LevelCrestStructureNotClosing.Mean.Value); - Assert.AreEqual(0.05, structure.LevelCrestStructureNotClosing.StandardDeviation.Value); - - Assert.AreEqual(0.5, structure.InsideWaterLevel.Mean.Value); - Assert.AreEqual(0.1, structure.InsideWaterLevel.StandardDeviation.Value); - - Assert.AreEqual(4.95, structure.ThresholdHeightOpenWeir.Mean.Value); - Assert.AreEqual(0.1, structure.ThresholdHeightOpenWeir.StandardDeviation.Value); - - Assert.AreEqual(31.5, structure.AreaFlowApertures.Mean.Value); - Assert.AreEqual(0.01, structure.AreaFlowApertures.StandardDeviation.Value); - - Assert.AreEqual(1.0, structure.CriticalOvertoppingDischarge.Mean.Value); - Assert.AreEqual(0.15, structure.CriticalOvertoppingDischarge.CoefficientOfVariation.Value); - - Assert.AreEqual(25.0, structure.FlowWidthAtBottomProtection.Mean.Value); - Assert.AreEqual(0.05, structure.FlowWidthAtBottomProtection.StandardDeviation.Value); - - Assert.AreEqual(1.0, structure.ProbabilityOpenStructureBeforeFlooding); - Assert.AreEqual(0.1, structure.FailureProbabilityOpenStructure); - Assert.AreEqual(4, structure.IdenticalApertures); - Assert.AreEqual(1.0, structure.FailureProbabilityReparation); - Assert.AreEqual(ClosingStructureInflowModelType.VerticalWall, structure.InflowModelType); + AssertTestClosingStructureDefaults(structure); } [Test] @@ -84,6 +49,11 @@ // Assert Assert.AreEqual(name, structure.Name); + AssertTestClosingStructureDefaults(structure); + } + + private static void AssertTestClosingStructureDefaults(ClosingStructure structure) + { Assert.AreEqual("id", structure.Id); Assert.AreEqual(new Point2D(12345.56789, 9876.54321), structure.Location); Assert.AreEqual(10.0, structure.StructureNormalOrientation.Value); Index: Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Data.TestUtil.Test/packages.config =================================================================== diff -u -rf9e4f420b403e6417f5dc2ba6d7beab9424baf89 -r7d6e4c28a40fb056c182d0691dda2b2e88aeebfd --- Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Data.TestUtil.Test/packages.config (.../packages.config) (revision f9e4f420b403e6417f5dc2ba6d7beab9424baf89) +++ Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Data.TestUtil.Test/packages.config (.../packages.config) (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -1,4 +1,26 @@  + \ No newline at end of file Index: Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructurePropertiesTest.cs =================================================================== diff -u -r89e6554de0313cdaa6876ba510240ee98c8547bb -r7d6e4c28a40fb056c182d0691dda2b2e88aeebfd --- Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructurePropertiesTest.cs (.../ClosingStructurePropertiesTest.cs) (revision 89e6554de0313cdaa6876ba510240ee98c8547bb) +++ Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructurePropertiesTest.cs (.../ClosingStructurePropertiesTest.cs) (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -22,6 +22,7 @@ using System; using System.ComponentModel; using Core.Common.Gui.PropertyBag; +using Core.Common.TestUtil; using NUnit.Framework; using Ringtoets.ClosingStructures.Data; using Ringtoets.ClosingStructures.Data.TestUtil; @@ -144,118 +145,141 @@ }; // Assert - var dynamicPropertyBag = new DynamicPropertyBag(properties); - PropertyDescriptorCollection dynamicProperties = dynamicPropertyBag.GetProperties(new Attribute[] - { - BrowsableAttribute.Yes - }); + PropertyDescriptorCollection dynamicProperties = PropertiesTestHelper.GetAllVisiblePropertyDescriptors(properties); Assert.AreEqual(17, dynamicProperties.Count); const string schematizationCategory = "Schematisatie"; const string hydraulicDataCategory = "Hydraulische gegevens"; const string generalCategory = "Algemeen"; PropertyDescriptor nameProperty = dynamicProperties[namePropertyIndex]; - Assert.IsTrue(nameProperty.IsReadOnly); - Assert.AreEqual(generalCategory, nameProperty.Category); - Assert.AreEqual("Naam", nameProperty.DisplayName); - Assert.AreEqual("De naam van het kunstwerk.", nameProperty.Description); + PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(nameProperty, + generalCategory, + "Naam", + "De naam van het kunstwerk.", + true); PropertyDescriptor locationProperty = dynamicProperties[locationPropertyIndex]; - Assert.IsTrue(locationProperty.IsReadOnly); - Assert.AreEqual(generalCategory, locationProperty.Category); - Assert.AreEqual("Locatie (RD) [m]", locationProperty.DisplayName); - Assert.AreEqual("De coördinaten van de locatie van het kunstwerk in het Rijksdriehoeksstelsel.", locationProperty.Description); + PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(locationProperty, + generalCategory, + "Locatie (RD) [m]", + "De coördinaten van de locatie van het kunstwerk in het Rijksdriehoeksstelsel.", + true); PropertyDescriptor structureNormalOrientationProperty = dynamicProperties[structureNormalOrientationPropertyIndex]; - Assert.IsTrue(structureNormalOrientationProperty.IsReadOnly); - Assert.AreEqual(schematizationCategory, structureNormalOrientationProperty.Category); - Assert.AreEqual("Oriëntatie [°]", structureNormalOrientationProperty.DisplayName); - Assert.AreEqual("Oriëntatie van de normaal van het kunstwerk ten opzichte van het noorden.", structureNormalOrientationProperty.Description); + PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(structureNormalOrientationProperty, + schematizationCategory, + "Oriëntatie [°]", + "Oriëntatie van de normaal van het kunstwerk ten opzichte van het noorden.", + true); PropertyDescriptor inflowModelTypeProperty = dynamicProperties[inflowModelTypePropertyIndex]; Assert.IsInstanceOf(inflowModelTypeProperty.Converter); - Assert.AreEqual(schematizationCategory, inflowModelTypeProperty.Category); - Assert.AreEqual("Instroommodel", inflowModelTypeProperty.DisplayName); - Assert.AreEqual("Instroommodel van het kunstwerk.", inflowModelTypeProperty.Description); + PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(inflowModelTypeProperty, + schematizationCategory, + "Instroommodel", + "Instroommodel van het kunstwerk.", + true); PropertyDescriptor widthFlowAperturesProperty = dynamicProperties[widthFlowAperturesPropertyIndex]; Assert.IsInstanceOf(widthFlowAperturesProperty.Converter); - Assert.AreEqual(schematizationCategory, widthFlowAperturesProperty.Category); - Assert.AreEqual("Breedte van doorstroomopening [m]", widthFlowAperturesProperty.DisplayName); - Assert.AreEqual("Breedte van de doorstroomopening.", widthFlowAperturesProperty.Description); + PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(widthFlowAperturesProperty, + schematizationCategory, + "Breedte van doorstroomopening [m]", + "Breedte van de doorstroomopening.", + true); PropertyDescriptor areaFlowAperturesProperty = dynamicProperties[areaFlowAperturesPropertyIndex]; Assert.IsInstanceOf(areaFlowAperturesProperty.Converter); - Assert.AreEqual(schematizationCategory, areaFlowAperturesProperty.Category); - Assert.AreEqual("Doorstroomoppervlak [m²]", areaFlowAperturesProperty.DisplayName); - Assert.AreEqual("Doorstroomoppervlak van doorstroomopeningen.", areaFlowAperturesProperty.Description); + PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(areaFlowAperturesProperty, + schematizationCategory, + "Doorstroomoppervlak [m²]", + "Doorstroomoppervlak van doorstroomopeningen.", + true); PropertyDescriptor identicalAperturesProperty = dynamicProperties[identicalAperturesPropertyIndex]; - Assert.IsTrue(identicalAperturesProperty.IsReadOnly); - Assert.AreEqual(schematizationCategory, identicalAperturesProperty.Category); - Assert.AreEqual("Aantal identieke doorstroomopeningen [-]", identicalAperturesProperty.DisplayName); - Assert.AreEqual("Aantal identieke doorstroomopeningen.", identicalAperturesProperty.Description); + PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(identicalAperturesProperty, + schematizationCategory, + "Aantal identieke doorstroomopeningen [-]", + "Aantal identieke doorstroomopeningen.", + true); PropertyDescriptor flowWidthAtBottomProtectionProperty = dynamicProperties[flowWidthAtBottomProtectionPropertyIndex]; Assert.IsInstanceOf(flowWidthAtBottomProtectionProperty.Converter); - Assert.AreEqual(schematizationCategory, flowWidthAtBottomProtectionProperty.Category); - Assert.AreEqual("Stroomvoerende breedte bodembescherming [m]", flowWidthAtBottomProtectionProperty.DisplayName); - Assert.AreEqual("Stroomvoerende breedte bodembescherming.", flowWidthAtBottomProtectionProperty.Description); + PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(flowWidthAtBottomProtectionProperty, + schematizationCategory, + "Stroomvoerende breedte bodembescherming [m]", + "Stroomvoerende breedte bodembescherming.", + true); PropertyDescriptor storageStructureAreaProperty = dynamicProperties[storageStructureAreaPropertyIndex]; Assert.IsInstanceOf(storageStructureAreaProperty.Converter); - Assert.AreEqual(schematizationCategory, storageStructureAreaProperty.Category); - Assert.AreEqual("Kombergend oppervlak [m²]", storageStructureAreaProperty.DisplayName); - Assert.AreEqual("Kombergend oppervlak.", storageStructureAreaProperty.Description); + PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(storageStructureAreaProperty, + schematizationCategory, + "Kombergend oppervlak [m²]", + "Kombergend oppervlak.", + true); PropertyDescriptor allowedLevelIncreaseStorageProperty = dynamicProperties[allowedLevelIncreaseStoragePropertyIndex]; Assert.IsInstanceOf(allowedLevelIncreaseStorageProperty.Converter); - Assert.AreEqual(schematizationCategory, allowedLevelIncreaseStorageProperty.Category); - Assert.AreEqual("Toegestane peilverhoging komberging [m]", allowedLevelIncreaseStorageProperty.DisplayName); - Assert.AreEqual("Toegestane peilverhoging komberging.", allowedLevelIncreaseStorageProperty.Description); + PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(allowedLevelIncreaseStorageProperty, + schematizationCategory, + "Toegestane peilverhoging komberging [m]", + "Toegestane peilverhoging komberging.", + true); PropertyDescriptor levelCrestStructureNotClosingProperty = dynamicProperties[levelCrestStructureNotClosingPropertyIndex]; Assert.IsInstanceOf(levelCrestStructureNotClosingProperty.Converter); - Assert.AreEqual(schematizationCategory, levelCrestStructureNotClosingProperty.Category); - Assert.AreEqual("Kruinhoogte niet gesloten kering [m+NAP]", levelCrestStructureNotClosingProperty.DisplayName); - Assert.AreEqual("Niveau kruin bij niet gesloten maximaal kerende keermiddelen.", levelCrestStructureNotClosingProperty.Description); + PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(levelCrestStructureNotClosingProperty, + schematizationCategory, + "Kruinhoogte niet gesloten kering [m+NAP]", + "Niveau kruin bij niet gesloten maximaal kerende keermiddelen.", + true); PropertyDescriptor thresholdHeightOpenWeirProperty = dynamicProperties[thresholdHeightOpenWeirPropertyIndex]; Assert.IsInstanceOf(thresholdHeightOpenWeirProperty.Converter); - Assert.AreEqual(schematizationCategory, thresholdHeightOpenWeirProperty.Category); - Assert.AreEqual("Drempelhoogte [m+NAP]", thresholdHeightOpenWeirProperty.DisplayName); - Assert.AreEqual("Drempelhoogte niet gesloten kering of hoogte van de onderkant van de wand/drempel.", thresholdHeightOpenWeirProperty.Description); + PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(thresholdHeightOpenWeirProperty, + schematizationCategory, + "Drempelhoogte [m+NAP]", + "Drempelhoogte niet gesloten kering of hoogte van de onderkant van de wand/drempel.", + true); PropertyDescriptor insideWaterLevelProperty = dynamicProperties[insideWaterLevelPropertyIndex]; Assert.IsInstanceOf(insideWaterLevelProperty.Converter); - Assert.AreEqual(hydraulicDataCategory, insideWaterLevelProperty.Category); - Assert.AreEqual("Binnenwaterstand [m+NAP]", insideWaterLevelProperty.DisplayName); - Assert.AreEqual("Binnenwaterstand.", insideWaterLevelProperty.Description); + PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(insideWaterLevelProperty, + hydraulicDataCategory, + "Binnenwaterstand [m+NAP]", + "Binnenwaterstand.", + true); PropertyDescriptor criticalOvertoppingDischargeProperty = dynamicProperties[criticalOvertoppingDischargePropertyIndex]; Assert.IsInstanceOf(criticalOvertoppingDischargeProperty.Converter); - Assert.AreEqual(schematizationCategory, criticalOvertoppingDischargeProperty.Category); - Assert.AreEqual("Kritiek instromend debiet [m³/s/m]", criticalOvertoppingDischargeProperty.DisplayName); - Assert.AreEqual("Kritiek instromend debiet directe invoer per strekkende meter.", criticalOvertoppingDischargeProperty.Description); + PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(criticalOvertoppingDischargeProperty, + schematizationCategory, + "Kritiek instromend debiet [m³/s/m]", + "Kritiek instromend debiet directe invoer per strekkende meter.", + true); PropertyDescriptor probabilityOpenStructureBeforeFloodingProperty = dynamicProperties[probabilityOpenStructureBeforeFloodingPropertyIndex]; - Assert.IsTrue(probabilityOpenStructureBeforeFloodingProperty.IsReadOnly); - Assert.AreEqual(schematizationCategory, probabilityOpenStructureBeforeFloodingProperty.Category); - Assert.AreEqual("Kans op open staan bij naderend hoogwater [1/jaar]", probabilityOpenStructureBeforeFloodingProperty.DisplayName); - Assert.AreEqual("Kans op open staan bij naderend hoogwater.", probabilityOpenStructureBeforeFloodingProperty.Description); + PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(probabilityOpenStructureBeforeFloodingProperty, + schematizationCategory, + "Kans op open staan bij naderend hoogwater [1/jaar]", + "Kans op open staan bij naderend hoogwater.", + true); PropertyDescriptor failureProbabilityOpenStructureProperty = dynamicProperties[failureProbabilityOpenStructurePropertyIndex]; - Assert.IsTrue(failureProbabilityOpenStructureProperty.IsReadOnly); - Assert.AreEqual(schematizationCategory, failureProbabilityOpenStructureProperty.Category); - Assert.AreEqual("Kans mislukken sluiting [1/jaar]", failureProbabilityOpenStructureProperty.DisplayName); - Assert.AreEqual("Kans op mislukken sluiting van geopend kunstwerk.", failureProbabilityOpenStructureProperty.Description); + PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(failureProbabilityOpenStructureProperty, + schematizationCategory, + "Kans mislukken sluiting [1/jaar]", + "Kans op mislukken sluiting van geopend kunstwerk.", + true); PropertyDescriptor failureProbabilityReparationProperty = dynamicProperties[failureProbabilityReparationPropertyIndex]; - Assert.IsTrue(failureProbabilityReparationProperty.IsReadOnly); - Assert.AreEqual(schematizationCategory, failureProbabilityReparationProperty.Category); - Assert.AreEqual("Faalkans herstel van gefaalde situatie [1/jaar]", failureProbabilityReparationProperty.DisplayName); - Assert.AreEqual("Faalkans herstel van gefaalde situatie.", failureProbabilityReparationProperty.Description); + PropertiesTestHelper.AssertRequiredPropertyDescriptorProperties(failureProbabilityReparationProperty, + schematizationCategory, + "Faalkans herstel van gefaalde situatie [1/jaar]", + "Faalkans herstel van gefaalde situatie.", + true); } } } \ No newline at end of file Index: Ringtoets/Common/src/Ringtoets.Common.Data/Probabilistics/IVariationCoefficientDistribution.cs =================================================================== diff -u -r238800aea14ad46b711dc0520d9416a05f6693ae -r7d6e4c28a40fb056c182d0691dda2b2e88aeebfd --- Ringtoets/Common/src/Ringtoets.Common.Data/Probabilistics/IVariationCoefficientDistribution.cs (.../IVariationCoefficientDistribution.cs) (revision 238800aea14ad46b711dc0520d9416a05f6693ae) +++ Ringtoets/Common/src/Ringtoets.Common.Data/Probabilistics/IVariationCoefficientDistribution.cs (.../IVariationCoefficientDistribution.cs) (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -41,7 +41,8 @@ /// Gets or sets the coefficient of variation (CV, also known as relative standard /// deviation (SRD). Defined as standard deviation / |E(X)|) of the distribution. /// - /// Coefficient of variation is less than 0. + /// Thrown when coefficient of variation + /// is less than 0. RoundedDouble CoefficientOfVariation { get; set; } } } \ No newline at end of file Index: Ringtoets/Common/src/Ringtoets.Common.Data/Probabilistics/LogNormalDistribution.cs =================================================================== diff -u -r238800aea14ad46b711dc0520d9416a05f6693ae -r7d6e4c28a40fb056c182d0691dda2b2e88aeebfd --- Ringtoets/Common/src/Ringtoets.Common.Data/Probabilistics/LogNormalDistribution.cs (.../LogNormalDistribution.cs) (revision 238800aea14ad46b711dc0520d9416a05f6693ae) +++ Ringtoets/Common/src/Ringtoets.Common.Data/Probabilistics/LogNormalDistribution.cs (.../LogNormalDistribution.cs) (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -26,7 +26,7 @@ namespace Ringtoets.Common.Data.Probabilistics { /// - /// Class representing a log-normal distribution. + /// Class representing a log-normal distribution expressed in terms of standard deviation. /// /// public class LogNormalDistribution : IDistribution @@ -83,8 +83,8 @@ /// Gets or sets the mean of the normal distribution which is the log of the /// log-normal distribution. /// - /// Expected value is less than or - /// equal to 0 or less then . + /// Thrown when value is less than or + /// equal to 0 or less than . public RoundedDouble Mean { get @@ -126,7 +126,7 @@ if (roundedValue < 0) { - throw new ArgumentOutOfRangeException("value", Resources.StandardDeviation_Should_be_greater_than_zero); + throw new ArgumentOutOfRangeException("value", Resources.StandardDeviation_Should_be_greater_or_equal_zero); } standardDeviation = roundedValue; Index: Ringtoets/Common/src/Ringtoets.Common.Data/Probabilistics/NormalDistribution.cs =================================================================== diff -u -r238800aea14ad46b711dc0520d9416a05f6693ae -r7d6e4c28a40fb056c182d0691dda2b2e88aeebfd --- Ringtoets/Common/src/Ringtoets.Common.Data/Probabilistics/NormalDistribution.cs (.../NormalDistribution.cs) (revision 238800aea14ad46b711dc0520d9416a05f6693ae) +++ Ringtoets/Common/src/Ringtoets.Common.Data/Probabilistics/NormalDistribution.cs (.../NormalDistribution.cs) (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -26,7 +26,8 @@ namespace Ringtoets.Common.Data.Probabilistics { /// - /// Class representing a normal (or Gaussian) distribution. + /// Class representing a normal (or Gaussian) distribution expressed in terms of standard + /// deviation. /// /// public class NormalDistribution : IDistribution @@ -72,7 +73,7 @@ if (roundedValue < 0) { - throw new ArgumentOutOfRangeException("value", Resources.StandardDeviation_Should_be_greater_than_zero); + throw new ArgumentOutOfRangeException("value", Resources.StandardDeviation_Should_be_greater_or_equal_zero); } standardDeviation = roundedValue; Index: Ringtoets/Common/src/Ringtoets.Common.Data/Probabilistics/VariationCoefficientLogNormalDistribution.cs =================================================================== diff -u -r238800aea14ad46b711dc0520d9416a05f6693ae -r7d6e4c28a40fb056c182d0691dda2b2e88aeebfd --- Ringtoets/Common/src/Ringtoets.Common.Data/Probabilistics/VariationCoefficientLogNormalDistribution.cs (.../VariationCoefficientLogNormalDistribution.cs) (revision 238800aea14ad46b711dc0520d9416a05f6693ae) +++ Ringtoets/Common/src/Ringtoets.Common.Data/Probabilistics/VariationCoefficientLogNormalDistribution.cs (.../VariationCoefficientLogNormalDistribution.cs) (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -27,7 +27,7 @@ { /// /// Class representing a log-normal distribution expressed in terms of a coefficient - /// of variation instead of standard deviation. + /// of variation. /// /// public class VariationCoefficientLogNormalDistribution : IVariationCoefficientDistribution @@ -49,9 +49,11 @@ } /// - /// Gets or sets the mean of the normal distribution which is the log of the log-normal distribution. + /// Gets or sets the mean (expected value, E(X)) of the distribution. /// /// Expected value is less than or equal to 0. + /// As cannot be negative, the absolute + /// value of the mean is used when the standard deviation needs to be calculated. public RoundedDouble Mean { get @@ -71,11 +73,6 @@ } } - /// - /// Gets or sets the coefficient of variation of the normal distribution which is - /// the log of the log-normal distribution. - /// - /// Thrown when set to a value less then 0. public RoundedDouble CoefficientOfVariation { get Index: Ringtoets/Common/src/Ringtoets.Common.Data/Probabilistics/VariationCoefficientNormalDistribution.cs =================================================================== diff -u -r238800aea14ad46b711dc0520d9416a05f6693ae -r7d6e4c28a40fb056c182d0691dda2b2e88aeebfd --- Ringtoets/Common/src/Ringtoets.Common.Data/Probabilistics/VariationCoefficientNormalDistribution.cs (.../VariationCoefficientNormalDistribution.cs) (revision 238800aea14ad46b711dc0520d9416a05f6693ae) +++ Ringtoets/Common/src/Ringtoets.Common.Data/Probabilistics/VariationCoefficientNormalDistribution.cs (.../VariationCoefficientNormalDistribution.cs) (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -27,7 +27,7 @@ { /// /// Class representing a normal (or Gaussian) distribution expressed in terms of a - /// coefficient of variation instead of standard deviation. + /// coefficient of variation. /// /// public class VariationCoefficientNormalDistribution : IVariationCoefficientDistribution @@ -75,7 +75,7 @@ throw new ArgumentOutOfRangeException("value", Resources.CoefficientOfVariation_Should_be_greater_or_equal_to_zero); } - coefficientOfVariation = value.ToPrecision(coefficientOfVariation.NumberOfDecimalPlaces); + coefficientOfVariation = roundedValue; } } } Index: Ringtoets/Common/src/Ringtoets.Common.Data/Properties/Resources.Designer.cs =================================================================== diff -u -r11b25a9a8ba5c1fcadad1e32fa072e159aafff26 -r7d6e4c28a40fb056c182d0691dda2b2e88aeebfd --- Ringtoets/Common/src/Ringtoets.Common.Data/Properties/Resources.Designer.cs (.../Resources.Designer.cs) (revision 11b25a9a8ba5c1fcadad1e32fa072e159aafff26) +++ Ringtoets/Common/src/Ringtoets.Common.Data/Properties/Resources.Designer.cs (.../Resources.Designer.cs) (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -22,7 +22,7 @@ //------------------------------------------------------------------------------ // // This code was generated by a tool. -// Runtime Version:4.0.30319.42000 +// Runtime Version:4.0.30319.18444 // // Changes to this file may cause incorrect behavior and will be lost if // the code is regenerated. @@ -409,11 +409,11 @@ } /// - /// Looks up a localized string similar to Standaard afwijking (σ) moet groter zijn dan 0.. + /// Looks up a localized string similar to Standaard afwijking (σ) moet groter zijn dan of gelijk aan 0.. /// - public static string StandardDeviation_Should_be_greater_than_zero { + public static string StandardDeviation_Should_be_greater_or_equal_zero { get { - return ResourceManager.GetString("StandardDeviation_Should_be_greater_than_zero", resourceCulture); + return ResourceManager.GetString("StandardDeviation_Should_be_greater_or_equal_zero", resourceCulture); } } @@ -434,14 +434,5 @@ return ResourceManager.GetString("StructureInflowModelType_LowSill_DisplayName", resourceCulture); } } - - /// - /// Looks up a localized string similar to Variatiecoëfficiënt moet groter zijn dan 0.. - /// - public static string VariationCoefficient_Should_be_greater_than_zero { - get { - return ResourceManager.GetString("VariationCoefficient_Should_be_greater_than_zero", resourceCulture); - } - } } } Index: Ringtoets/Common/src/Ringtoets.Common.Data/Properties/Resources.resx =================================================================== diff -u -r11b25a9a8ba5c1fcadad1e32fa072e159aafff26 -r7d6e4c28a40fb056c182d0691dda2b2e88aeebfd --- Ringtoets/Common/src/Ringtoets.Common.Data/Properties/Resources.resx (.../Resources.resx) (revision 11b25a9a8ba5c1fcadad1e32fa072e159aafff26) +++ Ringtoets/Common/src/Ringtoets.Common.Data/Properties/Resources.resx (.../Resources.resx) (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -156,8 +156,8 @@ Gemiddelde moet groter zijn dan 0. - - Standaard afwijking (σ) moet groter zijn dan 0. + + Standaard afwijking (σ) moet groter zijn dan of gelijk aan 0. Nieuwe map @@ -183,9 +183,6 @@ De waarde voor de faalkans moet in het bereik [0, 1] liggen. - - Variatiecoëfficiënt moet groter zijn dan 0. - Kans moet in het bereik [0, 1] opgegeven worden. Index: Ringtoets/Common/src/Ringtoets.Common.Data/StructureBase.cs =================================================================== diff -u -r107c9d6382bd676d6c36f797a040988f7b324b0b -r7d6e4c28a40fb056c182d0691dda2b2e88aeebfd --- Ringtoets/Common/src/Ringtoets.Common.Data/StructureBase.cs (.../StructureBase.cs) (revision 107c9d6382bd676d6c36f797a040988f7b324b0b) +++ Ringtoets/Common/src/Ringtoets.Common.Data/StructureBase.cs (.../StructureBase.cs) (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -36,7 +36,7 @@ /// The parameters required to construct a new /// instance of . /// Thrown when - /// or is null , empty or consists of whitespace. + /// or is null, empty or consists of whitespace. /// Thrown when is null. protected StructureBase(ConstructionProperties constructionProperties) { @@ -110,22 +110,22 @@ public class ConstructionProperties { /// - /// Gets the name of the structure. + /// Gets or sets the name of the structure. /// public string Name { get; set; } /// - /// Gets the identifier of the structure. + /// Gets or sets the identifier of the structure. /// public string Id { get; set; } /// - /// Gets the location of the structure. + /// Gets or sets the location of the structure. /// public Point2D Location { get; set; } /// - /// Gets the orientation of the closing structure, relative to north. + /// Gets or sets the orientation of the closing structure, relative to north. /// [degrees] /// public double StructureNormalOrientation { get; set; } Index: Ringtoets/Common/src/Ringtoets.Common.Data/Structures/StructuresInputBase.cs =================================================================== diff -u -r5efc7525e9ab2125a64b2e9b207b064c643f6514 -r7d6e4c28a40fb056c182d0691dda2b2e88aeebfd --- Ringtoets/Common/src/Ringtoets.Common.Data/Structures/StructuresInputBase.cs (.../StructuresInputBase.cs) (revision 5efc7525e9ab2125a64b2e9b207b064c643f6514) +++ Ringtoets/Common/src/Ringtoets.Common.Data/Structures/StructuresInputBase.cs (.../StructuresInputBase.cs) (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -177,7 +177,7 @@ /// Gets or sets the orientation of the normal of the structure. /// [degrees] /// - ///Thown when the value for the orientation is not between [0,360] degrees. + ///Thrown when the value for the orientation is not between [0,360] degrees. public RoundedDouble StructureNormalOrientation { get Index: Ringtoets/Common/src/Ringtoets.Common.Data/packages.config =================================================================== diff -u -rd6cea50606db045ee68e37f6cf98682f7ff7649e -r7d6e4c28a40fb056c182d0691dda2b2e88aeebfd --- Ringtoets/Common/src/Ringtoets.Common.Data/packages.config (.../packages.config) (revision d6cea50606db045ee68e37f6cf98682f7ff7649e) +++ Ringtoets/Common/src/Ringtoets.Common.Data/packages.config (.../packages.config) (revision 7d6e4c28a40fb056c182d0691dda2b2e88aeebfd) @@ -1,5 +1,4 @@  - \ No newline at end of file