Index: Ringtoets/Common/src/Ringtoets.Common.Forms/Helpers/HydraulicBoundaryLocationCalculationActivityFactory.cs =================================================================== diff -u -r1a595dde70f3b4eadd73cab397c994825bdb13ab -r7dbedcc91cd2472b7d696e393d42b2a02a0597fd --- Ringtoets/Common/src/Ringtoets.Common.Forms/Helpers/HydraulicBoundaryLocationCalculationActivityFactory.cs (.../HydraulicBoundaryLocationCalculationActivityFactory.cs) (revision 1a595dde70f3b4eadd73cab397c994825bdb13ab) +++ Ringtoets/Common/src/Ringtoets.Common.Forms/Helpers/HydraulicBoundaryLocationCalculationActivityFactory.cs (.../HydraulicBoundaryLocationCalculationActivityFactory.cs) (revision 7dbedcc91cd2472b7d696e393d42b2a02a0597fd) @@ -28,24 +28,25 @@ namespace Ringtoets.Common.Forms.Helpers { /// - /// Factory for creating hydraulic boundary location calculation activities. + /// This class defines factory methods that can be used to create instances of for + /// hydraulic boundary location calculations. /// public static class HydraulicBoundaryLocationCalculationActivityFactory { /// - /// Creates a collection of based on the - /// given parameters. + /// Creates a collection of for wave height calculations + /// based on the given parameters. /// /// The path of the hydraulic boundary database file. /// The preprocessor directory. /// The collection of to create /// the activities for. /// The norm to use during the calculations. /// The category boundary name for the calculations. - /// A collection of . + /// A collection of . /// Thrown when is null. /// Thrown when is null or empty. - public static IEnumerable CreateWaveHeightCalculationActivities( + public static IEnumerable CreateWaveHeightCalculationActivities( string hydraulicBoundaryDatabaseFilePath, string preprocessorDirectory, IEnumerable calculations, @@ -70,19 +71,19 @@ } /// - /// Creates a collection of based on the - /// given parameters. + /// Creates a collection of for design water level calculations + /// based on the given parameters. /// /// The path of the hydraulic boundary database file. /// The preprocessor directory. /// The collection of to create /// the activities for. /// The norm to use during the calculations. /// The category boundary name to use for the activities. - /// A collection of . + /// A collection of . /// Thrown when is null. /// Thrown when is null or empty. - public static IEnumerable CreateDesignWaterLevelCalculationActivities( + public static IEnumerable CreateDesignWaterLevelCalculationActivities( string hydraulicBoundaryDatabaseFilePath, string preprocessorDirectory, IEnumerable calculations, Index: Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Helpers/HydraulicBoundaryLocationCalculationActivityFactoryTest.cs =================================================================== diff -u -r1a595dde70f3b4eadd73cab397c994825bdb13ab -r7dbedcc91cd2472b7d696e393d42b2a02a0597fd --- Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Helpers/HydraulicBoundaryLocationCalculationActivityFactoryTest.cs (.../HydraulicBoundaryLocationCalculationActivityFactoryTest.cs) (revision 1a595dde70f3b4eadd73cab397c994825bdb13ab) +++ Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Helpers/HydraulicBoundaryLocationCalculationActivityFactoryTest.cs (.../HydraulicBoundaryLocationCalculationActivityFactoryTest.cs) (revision 7dbedcc91cd2472b7d696e393d42b2a02a0597fd) @@ -84,7 +84,7 @@ var hydraulicBoundaryLocation = new TestHydraulicBoundaryLocation(locationName); // Call - IEnumerable activities = HydraulicBoundaryLocationCalculationActivityFactory.CreateWaveHeightCalculationActivities( + IEnumerable activities = HydraulicBoundaryLocationCalculationActivityFactory.CreateWaveHeightCalculationActivities( validFilePath, validPreprocessorDirectory, new[] @@ -95,7 +95,9 @@ categoryBoundaryName); // Assert - WaveHeightCalculationActivity activity = activities.Single(); + CollectionAssert.AllItemsAreInstancesOfType(activities, typeof(WaveHeightCalculationActivity)); + + CalculatableActivity activity = activities.Single(); using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { Action call = () => activity.Run(); @@ -158,7 +160,7 @@ var hydraulicBoundaryLocation = new TestHydraulicBoundaryLocation(locationName); // Call - IEnumerable activities = HydraulicBoundaryLocationCalculationActivityFactory.CreateDesignWaterLevelCalculationActivities( + IEnumerable activities = HydraulicBoundaryLocationCalculationActivityFactory.CreateDesignWaterLevelCalculationActivities( validFilePath, validPreprocessorDirectory, new[] @@ -169,7 +171,9 @@ categoryBoundaryName); // Assert - DesignWaterLevelCalculationActivity activity = activities.Single(); + CollectionAssert.AllItemsAreInstancesOfType(activities, typeof(DesignWaterLevelCalculationActivity)); + + CalculatableActivity activity = activities.Single(); using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { Action call = () => activity.Run(); Index: Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Plugin/GrassCoverErosionOutwardsPlugin.cs =================================================================== diff -u -rcf5f7a2fbcaf236ba2d6edfc111d6f89eacbd05e -r7dbedcc91cd2472b7d696e393d42b2a02a0597fd --- Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Plugin/GrassCoverErosionOutwardsPlugin.cs (.../GrassCoverErosionOutwardsPlugin.cs) (revision cf5f7a2fbcaf236ba2d6edfc111d6f89eacbd05e) +++ Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Plugin/GrassCoverErosionOutwardsPlugin.cs (.../GrassCoverErosionOutwardsPlugin.cs) (revision 7dbedcc91cd2472b7d696e393d42b2a02a0597fd) @@ -1024,7 +1024,7 @@ return; } - IEnumerable activities = + IEnumerable activities = DesignWaterLevelCalculationsGroupContextChildNodeObjects(nodeData) .Cast() .SelectMany(context => HydraulicBoundaryLocationCalculationActivityFactory.CreateDesignWaterLevelCalculationActivities( @@ -1105,7 +1105,7 @@ return; } - IEnumerable activities = + IEnumerable activities = WaveHeightCalculationsGroupContextChildNodeObjects(nodeData) .Cast() .SelectMany(context => HydraulicBoundaryLocationCalculationActivityFactory.CreateWaveHeightCalculationActivities( Index: Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs =================================================================== diff -u -r5c66fb80e9e112408005c4bed85752bef43d08ce -r7dbedcc91cd2472b7d696e393d42b2a02a0597fd --- Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs (.../RingtoetsPlugin.cs) (revision 5c66fb80e9e112408005c4bed85752bef43d08ce) +++ Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs (.../RingtoetsPlugin.cs) (revision 7dbedcc91cd2472b7d696e393d42b2a02a0597fd) @@ -2089,7 +2089,7 @@ return; } - IEnumerable activities = + IEnumerable activities = DesignWaterLevelCalculationsGroupContextChildNodeObjects(nodeData) .Cast() .SelectMany(context => HydraulicBoundaryLocationCalculationActivityFactory.CreateDesignWaterLevelCalculationActivities( @@ -2128,7 +2128,7 @@ return; } - IEnumerable activities = + IEnumerable activities = WaveHeightCalculationsGroupContextChildNodeObjects(nodeData) .Cast() .SelectMany(context => HydraulicBoundaryLocationCalculationActivityFactory.CreateWaveHeightCalculationActivities(