Index: Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/AssessmentSectionHelperTest.cs =================================================================== diff -u -rd79d26d2ad423b4287d5cdaeb0ac267089a54bf9 -r7fa4481428458d47cc3ec2fe6e75b12a1c539c8d --- Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/AssessmentSectionHelperTest.cs (.../AssessmentSectionHelperTest.cs) (revision d79d26d2ad423b4287d5cdaeb0ac267089a54bf9) +++ Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/AssessmentSectionHelperTest.cs (.../AssessmentSectionHelperTest.cs) (revision 7fa4481428458d47cc3ec2fe6e75b12a1c539c8d) @@ -30,7 +30,7 @@ public class AssessmentSectionHelperTest { [Test] - public void CreateAssessmentSectionStub_Always_ReturnsStubbedAssessmentSection() + public void CreateAssessmentSectionStub_WithoutFilePathSet_ReturnsStubbedAssessmentSectionWithHRDWithoutPath() { // Setup var failureMechanism = new TestFailureMechanism(); @@ -45,12 +45,56 @@ Assert.AreEqual("21", assessmentSectionStub.Id); var hydraulicBoundaryDatabase = assessmentSectionStub.HydraulicBoundaryDatabase; Assert.IsNotNull(hydraulicBoundaryDatabase); + Assert.IsNull(hydraulicBoundaryDatabase.FilePath); Assert.AreEqual(1, hydraulicBoundaryDatabase.Locations.Count); var hydraulicBoundaryLocation = hydraulicBoundaryDatabase.Locations.First(); Assert.AreEqual(1300001, hydraulicBoundaryLocation.Id); Assert.AreEqual(string.Empty, hydraulicBoundaryLocation.Name); Assert.AreEqual(new Point2D(0, 0), hydraulicBoundaryLocation.Location); mocks.VerifyAll(); } + + [Test] + public void CreateAssessmentSectionStub_WithFilePathSet_ReturnsStubbedAssessmentSectionWithHRDWithPath() + { + // Setup + var path = "C://temp"; + var failureMechanism = new TestFailureMechanism(); + var mocks = new MockRepository(); + + // Call + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStub(failureMechanism, mocks, path); + mocks.ReplayAll(); + + // Assert + Assert.IsNotNull(assessmentSectionStub); + Assert.AreEqual("21", assessmentSectionStub.Id); + var hydraulicBoundaryDatabase = assessmentSectionStub.HydraulicBoundaryDatabase; + Assert.IsNotNull(hydraulicBoundaryDatabase); + Assert.AreEqual(path, hydraulicBoundaryDatabase.FilePath); + Assert.AreEqual(1, hydraulicBoundaryDatabase.Locations.Count); + var hydraulicBoundaryLocation = hydraulicBoundaryDatabase.Locations.First(); + Assert.AreEqual(1300001, hydraulicBoundaryLocation.Id); + Assert.AreEqual(string.Empty, hydraulicBoundaryLocation.Name); + Assert.AreEqual(new Point2D(0, 0), hydraulicBoundaryLocation.Location); + mocks.VerifyAll(); + } + + [Test] + public void CreateAssessmentSectionStubWithoutBoundaryDatabase_Always_ReturnsStubbedAssessmentSectionWithoutHRD() + { + var failureMechanism = new TestFailureMechanism(); + var mocks = new MockRepository(); + + // Call + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase(failureMechanism, mocks); + mocks.ReplayAll(); + + // Assert + Assert.IsNotNull(assessmentSectionStub); + Assert.AreEqual("21", assessmentSectionStub.Id); + Assert.IsNull(assessmentSectionStub.HydraulicBoundaryDatabase); + mocks.VerifyAll(); + } } } \ No newline at end of file Index: Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/AssessmentSectionHelper.cs =================================================================== diff -u -rd79d26d2ad423b4287d5cdaeb0ac267089a54bf9 -r7fa4481428458d47cc3ec2fe6e75b12a1c539c8d --- Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/AssessmentSectionHelper.cs (.../AssessmentSectionHelper.cs) (revision d79d26d2ad423b4287d5cdaeb0ac267089a54bf9) +++ Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/AssessmentSectionHelper.cs (.../AssessmentSectionHelper.cs) (revision 7fa4481428458d47cc3ec2fe6e75b12a1c539c8d) @@ -33,27 +33,61 @@ public static class AssessmentSectionHelper { /// - /// Creates a stub of . + /// Creates a stub of without the set. /// /// The failure mechanism to set the contribution for. /// The mock repository to create the stub with. /// A stubbed . - public static IAssessmentSection CreateAssessmentSectionStub(IFailureMechanism failureMechanism, MockRepository mockRepository) + public static IAssessmentSection CreateAssessmentSectionStubWithoutBoundaryDatabase(IFailureMechanism failureMechanism, + MockRepository mockRepository) { + return CreateAssessmentSectionStub(failureMechanism, mockRepository, false, null); + } + + /// + /// Creates a stub of with the set. + /// + /// The failure mechanism to set the contribution for. + /// The mock repository to create the stub with. + /// The file path to the hydraulic boundary database. + /// A stubbed . + public static IAssessmentSection CreateAssessmentSectionStub(IFailureMechanism failureMechanism, + MockRepository mockRepository, + string filePath = null) + { + return CreateAssessmentSectionStub(failureMechanism, mockRepository, true, filePath); + } + + private static IAssessmentSection CreateAssessmentSectionStub(IFailureMechanism failureMechanism, + MockRepository mockRepository, + bool addBoundaryDatabase, + string filePath) + { var assessmentSectionStub = mockRepository.Stub(); assessmentSectionStub.Stub(a => a.Id).Return("21"); assessmentSectionStub.Stub(a => a.FailureMechanismContribution).Return(new FailureMechanismContribution(new[] { failureMechanism }, 1, 2)); - assessmentSectionStub.HydraulicBoundaryDatabase = new HydraulicBoundaryDatabase + + if (addBoundaryDatabase) { + assessmentSectionStub.HydraulicBoundaryDatabase = GetHydraulicBoundaryDatabase(filePath); + } + + return assessmentSectionStub; + } + + private static HydraulicBoundaryDatabase GetHydraulicBoundaryDatabase(string filePath = null) + { + return new HydraulicBoundaryDatabase + { + FilePath = filePath, Locations = { new HydraulicBoundaryLocation(1300001, string.Empty, 0, 0) } }; - return assessmentSectionStub; } } } \ No newline at end of file Index: Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Service.Test/GrassCoverErosionInwardsCalculationServiceTest.cs =================================================================== diff -u -r16cb360eae0014270ebb6700054afdbbd565ae65 -r7fa4481428458d47cc3ec2fe6e75b12a1c539c8d --- Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Service.Test/GrassCoverErosionInwardsCalculationServiceTest.cs (.../GrassCoverErosionInwardsCalculationServiceTest.cs) (revision 16cb360eae0014270ebb6700054afdbbd565ae65) +++ Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Service.Test/GrassCoverErosionInwardsCalculationServiceTest.cs (.../GrassCoverErosionInwardsCalculationServiceTest.cs) (revision 7fa4481428458d47cc3ec2fe6e75b12a1c539c8d) @@ -27,10 +27,9 @@ using Core.Common.TestUtil; using NUnit.Framework; using Rhino.Mocks; -using Ringtoets.Common.Data.AssessmentSection; -using Ringtoets.Common.Data.Contribution; using Ringtoets.Common.Data.DikeProfiles; using Ringtoets.Common.Data.FailureMechanism; +using Ringtoets.Common.Data.TestUtil; using Ringtoets.GrassCoverErosionInwards.Data; using Ringtoets.HydraRing.Calculation.Calculator.Factory; using Ringtoets.HydraRing.Calculation.Parsers; @@ -50,8 +49,10 @@ // Setup var grassCoverErosionInwardsFailureMechanism = new GrassCoverErosionInwardsFailureMechanism(); + var filePath = Path.Combine(testDataPath, "HRD dutch coast south.sqlite"); + var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository, filePath); mockRepository.ReplayAll(); assessmentSectionStub.HydraulicBoundaryDatabase = null; @@ -92,8 +93,10 @@ // Setup var grassCoverErosionInwardsFailureMechanism = new GrassCoverErosionInwardsFailureMechanism(); + var filePath = Path.Combine(testDataPath, "HRD dutch coast south.sqlite"); + var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository, filePath); mockRepository.ReplayAll(); const string name = ""; @@ -132,8 +135,10 @@ // Setup var grassCoverErosionInwardsFailureMechanism = new GrassCoverErosionInwardsFailureMechanism(); + var filePath = Path.Combine(testDataPath, "HRD dutch coast south.sqlite"); + var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository, filePath); mockRepository.ReplayAll(); assessmentSectionStub.HydraulicBoundaryDatabase.FilePath = Path.Combine(testDataPath, "notexisting.sqlite"); @@ -175,8 +180,10 @@ // Setup var grassCoverErosionInwardsFailureMechanism = new GrassCoverErosionInwardsFailureMechanism(); + var filePath = Path.Combine(testDataPath, "HRD dutch coast south.sqlite"); + var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository, filePath); mockRepository.ReplayAll(); const string name = ""; @@ -218,8 +225,10 @@ // Setup var grassCoverErosionInwardsFailureMechanism = new GrassCoverErosionInwardsFailureMechanism(); + var filePath = Path.Combine(testDataPath, "HRD dutch coast south.sqlite"); + var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository, filePath); mockRepository.ReplayAll(); const string name = ""; @@ -251,8 +260,10 @@ // Setup var grassCoverErosionInwardsFailureMechanism = new GrassCoverErosionInwardsFailureMechanism(); + var filePath = Path.Combine(testDataPath, "HRD dutch coast south.sqlite"); + var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository, filePath); mockRepository.ReplayAll(); const string name = ""; @@ -300,8 +311,10 @@ // Setup var grassCoverErosionInwardsFailureMechanism = new GrassCoverErosionInwardsFailureMechanism(); + var filePath = Path.Combine(testDataPath, "HRD dutch coast south.sqlite"); + var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository, filePath); mockRepository.ReplayAll(); const string name = ""; @@ -332,8 +345,10 @@ // Setup var grassCoverErosionInwardsFailureMechanism = new GrassCoverErosionInwardsFailureMechanism(); + var filePath = Path.Combine(testDataPath, "HRD dutch coast south.sqlite"); + var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository, filePath); mockRepository.ReplayAll(); const string name = ""; @@ -375,8 +390,10 @@ var grassCoverErosionInwardsFailureMechanism = new GrassCoverErosionInwardsFailureMechanism(); AddSectionToFailureMechanism(grassCoverErosionInwardsFailureMechanism); + var filePath = Path.Combine(testDataPath, "HRD dutch coast south.sqlite"); + var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository, filePath); mockRepository.ReplayAll(); var dikeProfile = GetDikeProfile(); @@ -427,8 +444,10 @@ var grassCoverErosionInwardsFailureMechanism = new GrassCoverErosionInwardsFailureMechanism(); AddSectionToFailureMechanism(grassCoverErosionInwardsFailureMechanism); + var filePath = Path.Combine(testDataPath, "HRD dutch coast south.sqlite"); + var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository, filePath); mockRepository.ReplayAll(); var dikeProfile = GetDikeProfile(); @@ -494,8 +513,10 @@ var grassCoverErosionInwardsFailureMechanism = new GrassCoverErosionInwardsFailureMechanism(); AddSectionToFailureMechanism(grassCoverErosionInwardsFailureMechanism); + var filePath = Path.Combine(testDataPath, "HRD dutch coast south.sqlite"); + var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository, filePath); mockRepository.ReplayAll(); var dikeProfile = GetDikeProfile(); @@ -559,8 +580,10 @@ var grassCoverErosionInwardsFailureMechanism = new GrassCoverErosionInwardsFailureMechanism(); AddSectionToFailureMechanism(grassCoverErosionInwardsFailureMechanism); + var filePath = Path.Combine(testDataPath, "HRD dutch coast south.sqlite"); + var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository, filePath); mockRepository.ReplayAll(); const string name = ""; @@ -606,9 +629,11 @@ // Setup var grassCoverErosionInwardsFailureMechanism = new GrassCoverErosionInwardsFailureMechanism(); AddSectionToFailureMechanism(grassCoverErosionInwardsFailureMechanism); + + var filePath = Path.Combine(testDataPath, "HRD dutch coast south.sqlite"); var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStub(grassCoverErosionInwardsFailureMechanism, mockRepository, filePath); mockRepository.ReplayAll(); const string name = ""; @@ -716,24 +741,5 @@ } }; } - - private static IAssessmentSection CreateAssessmentSectionStub(IFailureMechanism failureMechanism, MockRepository mockRepository) - { - var assessmentSectionStub = mockRepository.Stub(); - assessmentSectionStub.Stub(a => a.Id).Return("21"); - assessmentSectionStub.Stub(a => a.FailureMechanismContribution).Return(new FailureMechanismContribution(new[] - { - failureMechanism - }, 1, 2)); - assessmentSectionStub.HydraulicBoundaryDatabase = new HydraulicBoundaryDatabase - { - FilePath = Path.Combine(testDataPath, "HRD dutch coast south.sqlite"), - Locations = - { - new HydraulicBoundaryLocation(1300001, String.Empty, 0, 0) - } - }; - return assessmentSectionStub; - } } } \ No newline at end of file Index: Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Service.Test/Ringtoets.GrassCoverErosionInwards.Service.Test.csproj =================================================================== diff -u -r171bef69ca437d9501abcfe0ab858c6e7ce89061 -r7fa4481428458d47cc3ec2fe6e75b12a1c539c8d --- Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Service.Test/Ringtoets.GrassCoverErosionInwards.Service.Test.csproj (.../Ringtoets.GrassCoverErosionInwards.Service.Test.csproj) (revision 171bef69ca437d9501abcfe0ab858c6e7ce89061) +++ Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Service.Test/Ringtoets.GrassCoverErosionInwards.Service.Test.csproj (.../Ringtoets.GrassCoverErosionInwards.Service.Test.csproj) (revision 7fa4481428458d47cc3ec2fe6e75b12a1c539c8d) @@ -79,6 +79,10 @@ {d4200f43-3f72-4f42-af0a-8ced416a38ec} Ringtoets.Common.Data + + {4843D6E5-066F-4795-94F5-1D53932DD03C} + Ringtoets.Common.Data.TestUtil + {888d4097-8bc2-4703-9fb1-8744c94d525e} Ringtoets.HydraRing.Calculation Index: Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Service.Test/GrassCoverErosionOutwardsWaveConditionsCalculationServiceTest.cs =================================================================== diff -u -ra14d1309ecf82ff5b0385a2f6e3b2c4a216a4184 -r7fa4481428458d47cc3ec2fe6e75b12a1c539c8d --- Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Service.Test/GrassCoverErosionOutwardsWaveConditionsCalculationServiceTest.cs (.../GrassCoverErosionOutwardsWaveConditionsCalculationServiceTest.cs) (revision a14d1309ecf82ff5b0385a2f6e3b2c4a216a4184) +++ Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Service.Test/GrassCoverErosionOutwardsWaveConditionsCalculationServiceTest.cs (.../GrassCoverErosionOutwardsWaveConditionsCalculationServiceTest.cs) (revision 7fa4481428458d47cc3ec2fe6e75b12a1c539c8d) @@ -27,10 +27,8 @@ using Core.Common.TestUtil; using NUnit.Framework; using Rhino.Mocks; -using Ringtoets.Common.Data.AssessmentSection; -using Ringtoets.Common.Data.Contribution; using Ringtoets.Common.Data.DikeProfiles; -using Ringtoets.Common.Data.FailureMechanism; +using Ringtoets.Common.Data.TestUtil; using Ringtoets.GrassCoverErosionOutwards.Data; using Ringtoets.HydraRing.Calculation.Calculator.Factory; using Ringtoets.HydraRing.Calculation.Data; @@ -266,10 +264,13 @@ calculation.InputParameters.ForeshoreProfile = CreateForeshoreProfile(new BreakWater(BreakWaterType.Dam, breakWaterHeight)); calculation.InputParameters.UseBreakWater = false; - GrassCoverErosionOutwardsFailureMechanism grassCoverErosionOutwardsFailureMechanism = new GrassCoverErosionOutwardsFailureMechanism(); + GrassCoverErosionOutwardsFailureMechanism grassCoverErosionOutwardsFailureMechanism = new GrassCoverErosionOutwardsFailureMechanism + { + Contribution = 20 + }; var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(grassCoverErosionOutwardsFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase(grassCoverErosionOutwardsFailureMechanism, mockRepository); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -311,10 +312,13 @@ { // Setup GrassCoverErosionOutwardsWaveConditionsCalculation calculation = GetDefaultCalculation(); - var grassCoverErosionOutwardsFailureMechanism = new GrassCoverErosionOutwardsFailureMechanism(); + GrassCoverErosionOutwardsFailureMechanism grassCoverErosionOutwardsFailureMechanism = new GrassCoverErosionOutwardsFailureMechanism + { + Contribution = 20 + }; var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(grassCoverErosionOutwardsFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase(grassCoverErosionOutwardsFailureMechanism, mockRepository); mockRepository.ReplayAll(); switch (calculationType) @@ -368,10 +372,13 @@ { // Setup GrassCoverErosionOutwardsWaveConditionsCalculation calculation = GetValidCalculation(); - var grassCoverErosionOutwardsFailureMechanism = new GrassCoverErosionOutwardsFailureMechanism(); + GrassCoverErosionOutwardsFailureMechanism grassCoverErosionOutwardsFailureMechanism = new GrassCoverErosionOutwardsFailureMechanism + { + Contribution = 20 + }; var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(grassCoverErosionOutwardsFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase(grassCoverErosionOutwardsFailureMechanism, mockRepository); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -419,10 +426,13 @@ { // Setup GrassCoverErosionOutwardsWaveConditionsCalculation calculation = GetDefaultCalculation(); - var grassCoverErosionOutwardsFailureMechanism = new GrassCoverErosionOutwardsFailureMechanism(); + GrassCoverErosionOutwardsFailureMechanism grassCoverErosionOutwardsFailureMechanism = new GrassCoverErosionOutwardsFailureMechanism + { + Contribution = 20 + }; var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(grassCoverErosionOutwardsFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase(grassCoverErosionOutwardsFailureMechanism, mockRepository); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -447,10 +457,13 @@ { // Setup GrassCoverErosionOutwardsWaveConditionsCalculation calculation = GetDefaultCalculation(); - var grassCoverErosionOutwardsFailureMechanism = new GrassCoverErosionOutwardsFailureMechanism(); + GrassCoverErosionOutwardsFailureMechanism grassCoverErosionOutwardsFailureMechanism = new GrassCoverErosionOutwardsFailureMechanism + { + Contribution = 20 + }; var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(grassCoverErosionOutwardsFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase(grassCoverErosionOutwardsFailureMechanism, mockRepository); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -478,10 +491,13 @@ { // Setup GrassCoverErosionOutwardsWaveConditionsCalculation calculation = GetValidCalculation(); - var grassCoverErosionOutwardsFailureMechanism = new GrassCoverErosionOutwardsFailureMechanism(); + GrassCoverErosionOutwardsFailureMechanism grassCoverErosionOutwardsFailureMechanism = new GrassCoverErosionOutwardsFailureMechanism + { + Contribution = 20 + }; var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(grassCoverErosionOutwardsFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase(grassCoverErosionOutwardsFailureMechanism, mockRepository); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -503,10 +519,13 @@ { // Setup GrassCoverErosionOutwardsWaveConditionsCalculation calculation = GetValidCalculation(); - GrassCoverErosionOutwardsFailureMechanism grassCoverErosionOutwardsFailureMechanism = new GrassCoverErosionOutwardsFailureMechanism(); + GrassCoverErosionOutwardsFailureMechanism grassCoverErosionOutwardsFailureMechanism = new GrassCoverErosionOutwardsFailureMechanism + { + Contribution = 20 + }; var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(grassCoverErosionOutwardsFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase(grassCoverErosionOutwardsFailureMechanism, mockRepository); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -533,18 +552,6 @@ ForeshoreWithoutBreakWater } - private static IAssessmentSection CreateAssessmentSectionStub(IFailureMechanism failureMechanism, MockRepository mockRepository) - { - failureMechanism.Contribution = 20; - var assessmentSectionStub = mockRepository.Stub(); - assessmentSectionStub.Stub(a => a.Id).Return("21"); - assessmentSectionStub.Stub(a => a.FailureMechanismContribution).Return(new FailureMechanismContribution(new[] - { - failureMechanism - }, 1, 2)); - return assessmentSectionStub; - } - private static GrassCoverErosionOutwardsWaveConditionsCalculation GetValidCalculation() { var calculation = new GrassCoverErosionOutwardsWaveConditionsCalculation Index: Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Service.Test/Ringtoets.GrassCoverErosionOutwards.Service.Test.csproj =================================================================== diff -u -r8577bc9fb1f6f28a32d09587ba6991183accd787 -r7fa4481428458d47cc3ec2fe6e75b12a1c539c8d --- Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Service.Test/Ringtoets.GrassCoverErosionOutwards.Service.Test.csproj (.../Ringtoets.GrassCoverErosionOutwards.Service.Test.csproj) (revision 8577bc9fb1f6f28a32d09587ba6991183accd787) +++ Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Service.Test/Ringtoets.GrassCoverErosionOutwards.Service.Test.csproj (.../Ringtoets.GrassCoverErosionOutwards.Service.Test.csproj) (revision 7fa4481428458d47cc3ec2fe6e75b12a1c539c8d) @@ -86,6 +86,10 @@ {d951d6da-fe83-4920-9fdb-63bf96480b54} Ringtoets.Common.Service + + {4843D6E5-066F-4795-94F5-1D53932DD03C} + Ringtoets.Common.Data.TestUtil + {888D4097-8BC2-4703-9FB1-8744C94D525E} Ringtoets.HydraRing.Calculation Index: Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Integration.Test/Ringtoets.StabilityStoneCover.Integration.Test.csproj =================================================================== diff -u -re4f43547afaab47559c5aa667b1aac661a0d1a8b -r7fa4481428458d47cc3ec2fe6e75b12a1c539c8d --- Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Integration.Test/Ringtoets.StabilityStoneCover.Integration.Test.csproj (.../Ringtoets.StabilityStoneCover.Integration.Test.csproj) (revision e4f43547afaab47559c5aa667b1aac661a0d1a8b) +++ Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Integration.Test/Ringtoets.StabilityStoneCover.Integration.Test.csproj (.../Ringtoets.StabilityStoneCover.Integration.Test.csproj) (revision 7fa4481428458d47cc3ec2fe6e75b12a1c539c8d) @@ -78,6 +78,10 @@ {d4200f43-3f72-4f42-af0a-8ced416a38ec} Ringtoets.Common.Data + + {4843D6E5-066F-4795-94F5-1D53932DD03C} + Ringtoets.Common.Data.TestUtil + {888d4097-8bc2-4703-9fb1-8744c94d525e} Ringtoets.HydraRing.Calculation Index: Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Integration.Test/StabilityStoneCoverWaveConditionsCalculationActivityIntegrationTest.cs =================================================================== diff -u -ra14d1309ecf82ff5b0385a2f6e3b2c4a216a4184 -r7fa4481428458d47cc3ec2fe6e75b12a1c539c8d --- Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Integration.Test/StabilityStoneCoverWaveConditionsCalculationActivityIntegrationTest.cs (.../StabilityStoneCoverWaveConditionsCalculationActivityIntegrationTest.cs) (revision a14d1309ecf82ff5b0385a2f6e3b2c4a216a4184) +++ Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Integration.Test/StabilityStoneCoverWaveConditionsCalculationActivityIntegrationTest.cs (.../StabilityStoneCoverWaveConditionsCalculationActivityIntegrationTest.cs) (revision 7fa4481428458d47cc3ec2fe6e75b12a1c539c8d) @@ -29,10 +29,8 @@ using Core.Common.TestUtil; using NUnit.Framework; using Rhino.Mocks; -using Ringtoets.Common.Data.AssessmentSection; -using Ringtoets.Common.Data.Contribution; using Ringtoets.Common.Data.DikeProfiles; -using Ringtoets.Common.Data.FailureMechanism; +using Ringtoets.Common.Data.TestUtil; using Ringtoets.HydraRing.Calculation.Calculator.Factory; using Ringtoets.HydraRing.Calculation.Data; using Ringtoets.HydraRing.Calculation.Data.Input.WaveConditions; @@ -70,10 +68,10 @@ UseForeshore = true, UseBreakWater = true, StepSize = WaveConditionsInputStepSize.Half, - LowerBoundaryRevetment = (RoundedDouble)5.3, - UpperBoundaryRevetment = (RoundedDouble)10, - UpperBoundaryWaterLevels = (RoundedDouble)5.4, - LowerBoundaryWaterLevels = (RoundedDouble)5 + LowerBoundaryRevetment = (RoundedDouble) 5.3, + UpperBoundaryRevetment = (RoundedDouble) 10, + UpperBoundaryWaterLevels = (RoundedDouble) 5.4, + LowerBoundaryWaterLevels = (RoundedDouble) 5 } }; @@ -82,7 +80,8 @@ var activity = new StabilityStoneCoverWaveConditionsCalculationActivity(calculation, testFilePath, stabilityStoneCoverFailureMechanism, - CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository)); + AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository)); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -118,17 +117,18 @@ UseForeshore = true, UseBreakWater = true, StepSize = WaveConditionsInputStepSize.Half, - LowerBoundaryRevetment = (RoundedDouble)5.3, - UpperBoundaryRevetment = (RoundedDouble)10, - UpperBoundaryWaterLevels = (RoundedDouble)5.4, - LowerBoundaryWaterLevels = (RoundedDouble)5 + LowerBoundaryRevetment = (RoundedDouble) 5.3, + UpperBoundaryRevetment = (RoundedDouble) 10, + UpperBoundaryWaterLevels = (RoundedDouble) 5.4, + LowerBoundaryWaterLevels = (RoundedDouble) 5 } }; var testFilePath = Path.Combine(testDataPath, "corruptschema.sqlite"); var activity = new StabilityStoneCoverWaveConditionsCalculationActivity(calculation, testFilePath, stabilityStoneCoverFailureMechanism, - CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository)); + AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository)); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -163,18 +163,19 @@ UseForeshore = true, UseBreakWater = true, StepSize = WaveConditionsInputStepSize.Half, - LowerBoundaryRevetment = (RoundedDouble)5.3, - UpperBoundaryRevetment = (RoundedDouble)10, - UpperBoundaryWaterLevels = (RoundedDouble)5.4, - LowerBoundaryWaterLevels = (RoundedDouble)5 + LowerBoundaryRevetment = (RoundedDouble) 5.3, + UpperBoundaryRevetment = (RoundedDouble) 10, + UpperBoundaryWaterLevels = (RoundedDouble) 5.4, + LowerBoundaryWaterLevels = (RoundedDouble) 5 } }; StabilityStoneCoverFailureMechanism stabilityStoneCoverFailureMechanism = new StabilityStoneCoverFailureMechanism(); var activity = new StabilityStoneCoverWaveConditionsCalculationActivity(calculation, validFilePath, stabilityStoneCoverFailureMechanism, - CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository)); + AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository)); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -210,18 +211,19 @@ UseForeshore = true, UseBreakWater = true, StepSize = WaveConditionsInputStepSize.Half, - LowerBoundaryRevetment = (RoundedDouble)5.3, - UpperBoundaryRevetment = (RoundedDouble)10, - UpperBoundaryWaterLevels = (RoundedDouble)5.4, - LowerBoundaryWaterLevels = (RoundedDouble)5 + LowerBoundaryRevetment = (RoundedDouble) 5.3, + UpperBoundaryRevetment = (RoundedDouble) 10, + UpperBoundaryWaterLevels = (RoundedDouble) 5.4, + LowerBoundaryWaterLevels = (RoundedDouble) 5 } }; StabilityStoneCoverFailureMechanism stabilityStoneCoverFailureMechanism = new StabilityStoneCoverFailureMechanism(); var activity = new StabilityStoneCoverWaveConditionsCalculationActivity(calculation, validFilePath, stabilityStoneCoverFailureMechanism, - CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository)); + AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository)); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -256,24 +258,25 @@ { HydraulicBoundaryLocation = new HydraulicBoundaryLocation(13001, string.Empty, 0, 0) { - DesignWaterLevel = (RoundedDouble)12.0 + DesignWaterLevel = (RoundedDouble) 12.0 }, ForeshoreProfile = CreateForeshoreProfile(), UseForeshore = true, UseBreakWater = true, StepSize = WaveConditionsInputStepSize.Half, - LowerBoundaryRevetment = (RoundedDouble)lowerBoundaryRevetment, - UpperBoundaryRevetment = (RoundedDouble)upperBoundaryRevetment, - UpperBoundaryWaterLevels = (RoundedDouble)5.4, - LowerBoundaryWaterLevels = (RoundedDouble)5 + LowerBoundaryRevetment = (RoundedDouble) lowerBoundaryRevetment, + UpperBoundaryRevetment = (RoundedDouble) upperBoundaryRevetment, + UpperBoundaryWaterLevels = (RoundedDouble) 5.4, + LowerBoundaryWaterLevels = (RoundedDouble) 5 } }; StabilityStoneCoverFailureMechanism stabilityStoneCoverFailureMechanism = new StabilityStoneCoverFailureMechanism(); var activity = new StabilityStoneCoverWaveConditionsCalculationActivity(calculation, validFilePath, stabilityStoneCoverFailureMechanism, - CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository)); + AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository)); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -312,7 +315,8 @@ var activity = new StabilityStoneCoverWaveConditionsCalculationActivity(calculation, validFilePath, stabilityStoneCoverFailureMechanism, - CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository)); + AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository)); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -376,7 +380,8 @@ var activity = new StabilityStoneCoverWaveConditionsCalculationActivity(calculation, validFilePath, stabilityStoneCoverFailureMechanism, - CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository)); + AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository)); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -412,7 +417,8 @@ var activity = new StabilityStoneCoverWaveConditionsCalculationActivity(calculation, validFilePath, stabilityStoneCoverFailureMechanism, - CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository)); + AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository)); mockRepository.ReplayAll(); switch (calculationType) @@ -486,7 +492,8 @@ var activity = new StabilityStoneCoverWaveConditionsCalculationActivity(calculation, validFilePath, stabilityStoneCoverFailureMechanism, - CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository)); + AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository)); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -499,10 +506,10 @@ // Assert var waterLevels = calculation.InputParameters.WaterLevels.ToArray(); - var totalSteps = waterLevels.Length * 2; + var totalSteps = waterLevels.Length*2; for (var i = 0; i < totalSteps; i++) { - var text = string.Format("Stap {0} van {1} | Waterstand '{2}' berekenen.", i + 1, totalSteps, waterLevels[i % waterLevels.Length]); + var text = string.Format("Stap {0} van {1} | Waterstand '{2}' berekenen.", i + 1, totalSteps, waterLevels[i%waterLevels.Length]); Assert.AreEqual(text, progessTexts[i]); } } @@ -517,7 +524,8 @@ StabilityStoneCoverWaveConditionsCalculation calculation = GetValidCalculation(); StabilityStoneCoverFailureMechanism stabilityStoneCoverFailureMechanism = new StabilityStoneCoverFailureMechanism(); - var assessmentSectionStub = CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository); var activity = new StabilityStoneCoverWaveConditionsCalculationActivity(calculation, validFilePath, stabilityStoneCoverFailureMechanism, @@ -526,7 +534,7 @@ using (new HydraRingCalculatorFactoryConfig()) { - var testWaveConditionsCosineCalculator = ((TestHydraRingCalculatorFactory)HydraRingCalculatorFactory.Instance).WaveConditionsCosineCalculator; + var testWaveConditionsCosineCalculator = ((TestHydraRingCalculatorFactory) HydraRingCalculatorFactory.Instance).WaveConditionsCosineCalculator; // Call activity.Run(); @@ -543,14 +551,14 @@ Assert.AreEqual(assessmentSectionStub.Id, testWaveConditionsCosineCalculator.RingId); int waterLevelIndex = 0; - for (int i = 0; i < testWaveConditionsInputs.Length / 2; i++) + for (int i = 0; i < testWaveConditionsInputs.Length/2; i++) { var expectedInput = new WaveConditionsCosineCalculationInput(1, input.Orientation, input.HydraulicBoundaryLocation.Id, assessmentSectionStub.FailureMechanismContribution.Norm, input.ForeshoreProfile.Geometry.Select(c => new HydraRingForelandPoint(c.X, c.Y)), - new HydraRingBreakWater((int)input.BreakWater.Type, input.BreakWater.Height), + new HydraRingBreakWater((int) input.BreakWater.Type, input.BreakWater.Height), input.WaterLevels.ElementAt(waterLevelIndex++), generalInput.GeneralBlocksWaveConditionsInput.A, generalInput.GeneralBlocksWaveConditionsInput.B, @@ -560,14 +568,14 @@ } waterLevelIndex = 0; - for (int i = testWaveConditionsInputs.Length / 2; i < testWaveConditionsInputs.Length; i++) + for (int i = testWaveConditionsInputs.Length/2; i < testWaveConditionsInputs.Length; i++) { var expectedInput = new WaveConditionsCosineCalculationInput(1, input.Orientation, input.HydraulicBoundaryLocation.Id, assessmentSectionStub.FailureMechanismContribution.Norm, input.ForeshoreProfile.Geometry.Select(c => new HydraRingForelandPoint(c.X, c.Y)), - new HydraRingBreakWater((int)input.BreakWater.Type, input.BreakWater.Height), + new HydraRingBreakWater((int) input.BreakWater.Type, input.BreakWater.Height), input.WaterLevels.ElementAt(waterLevelIndex++), generalInput.GeneralColumnsWaveConditionsInput.A, generalInput.GeneralColumnsWaveConditionsInput.B, @@ -589,7 +597,8 @@ var activity = new StabilityStoneCoverWaveConditionsCalculationActivity(calculation, validFilePath, stabilityStoneCoverFailureMechanism, - CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository)); + AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository)); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -638,7 +647,8 @@ var activity = new StabilityStoneCoverWaveConditionsCalculationActivity(calculation, validFilePath, stabilityStoneCoverFailureMechanism, - CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository)); + AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository)); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -697,7 +707,8 @@ var activity = new StabilityStoneCoverWaveConditionsCalculationActivity(calculation, validFilePath, stabilityStoneCoverFailureMechanism, - CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository)); + AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository)); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -733,7 +744,8 @@ var activity = new StabilityStoneCoverWaveConditionsCalculationActivity(calculation, validFilePath, stabilityStoneCoverFailureMechanism, - CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository)); + AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository)); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -760,12 +772,13 @@ var activity = new StabilityStoneCoverWaveConditionsCalculationActivity(calculation, validFilePath, stabilityStoneCoverFailureMechanism, - CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository)); + AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository)); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) { - var calculator = ((TestHydraRingCalculatorFactory)HydraRingCalculatorFactory.Instance).WaveConditionsCosineCalculator; + var calculator = ((TestHydraRingCalculatorFactory) HydraRingCalculatorFactory.Instance).WaveConditionsCosineCalculator; calculator.EndInFailure = true; // Call @@ -777,17 +790,6 @@ mockRepository.VerifyAll(); } - private static IAssessmentSection CreateAssessmentSectionStub(IFailureMechanism failureMechanism, MockRepository mockRepository) - { - var assessmentSectionStub = mockRepository.Stub(); - assessmentSectionStub.Stub(a => a.Id).Return("21"); - assessmentSectionStub.Stub(a => a.FailureMechanismContribution).Return(new FailureMechanismContribution(new[] - { - failureMechanism - }, 1, 2)); - return assessmentSectionStub; - } - public enum CalculationType { NoForeshore, @@ -803,16 +805,16 @@ { HydraulicBoundaryLocation = new HydraulicBoundaryLocation(1300001, "locationName", 0, 0) { - DesignWaterLevel = (RoundedDouble)9.3 + DesignWaterLevel = (RoundedDouble) 9.3 }, ForeshoreProfile = CreateForeshoreProfile(), UseForeshore = true, UseBreakWater = true, StepSize = WaveConditionsInputStepSize.Half, - LowerBoundaryRevetment = (RoundedDouble)4, - UpperBoundaryRevetment = (RoundedDouble)10, - UpperBoundaryWaterLevels = (RoundedDouble)8, - LowerBoundaryWaterLevels = (RoundedDouble)7.1 + LowerBoundaryRevetment = (RoundedDouble) 4, + UpperBoundaryRevetment = (RoundedDouble) 10, + UpperBoundaryWaterLevels = (RoundedDouble) 8, + LowerBoundaryWaterLevels = (RoundedDouble) 7.1 } }; return calculation; @@ -821,8 +823,8 @@ private static StabilityStoneCoverWaveConditionsCalculation GetDefaultCalculation() { StabilityStoneCoverWaveConditionsCalculation calculation = GetValidCalculation(); - calculation.InputParameters.LowerBoundaryWaterLevels = (RoundedDouble)5; - calculation.InputParameters.UpperBoundaryWaterLevels = (RoundedDouble)5.4; + calculation.InputParameters.LowerBoundaryWaterLevels = (RoundedDouble) 5; + calculation.InputParameters.UpperBoundaryWaterLevels = (RoundedDouble) 5.4; return calculation; } Index: Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Service.Test/Ringtoets.StabilityStoneCover.Service.Test.csproj =================================================================== diff -u -re69acb9595f7bf1d202ddd1fb51934b66768b75d -r7fa4481428458d47cc3ec2fe6e75b12a1c539c8d --- Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Service.Test/Ringtoets.StabilityStoneCover.Service.Test.csproj (.../Ringtoets.StabilityStoneCover.Service.Test.csproj) (revision e69acb9595f7bf1d202ddd1fb51934b66768b75d) +++ Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Service.Test/Ringtoets.StabilityStoneCover.Service.Test.csproj (.../Ringtoets.StabilityStoneCover.Service.Test.csproj) (revision 7fa4481428458d47cc3ec2fe6e75b12a1c539c8d) @@ -80,6 +80,10 @@ {d4200f43-3f72-4f42-af0a-8ced416a38ec} Ringtoets.Common.Data + + {4843D6E5-066F-4795-94F5-1D53932DD03C} + Ringtoets.Common.Data.TestUtil + {888d4097-8bc2-4703-9fb1-8744c94d525e} Ringtoets.HydraRing.Calculation Index: Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Service.Test/StabilityStoneCoverWaveConditionsCalculationServiceTest.cs =================================================================== diff -u -ra14d1309ecf82ff5b0385a2f6e3b2c4a216a4184 -r7fa4481428458d47cc3ec2fe6e75b12a1c539c8d --- Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Service.Test/StabilityStoneCoverWaveConditionsCalculationServiceTest.cs (.../StabilityStoneCoverWaveConditionsCalculationServiceTest.cs) (revision a14d1309ecf82ff5b0385a2f6e3b2c4a216a4184) +++ Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Service.Test/StabilityStoneCoverWaveConditionsCalculationServiceTest.cs (.../StabilityStoneCoverWaveConditionsCalculationServiceTest.cs) (revision 7fa4481428458d47cc3ec2fe6e75b12a1c539c8d) @@ -27,10 +27,8 @@ using Core.Common.TestUtil; using NUnit.Framework; using Rhino.Mocks; -using Ringtoets.Common.Data.AssessmentSection; -using Ringtoets.Common.Data.Contribution; using Ringtoets.Common.Data.DikeProfiles; -using Ringtoets.Common.Data.FailureMechanism; +using Ringtoets.Common.Data.TestUtil; using Ringtoets.HydraRing.Calculation.Calculator.Factory; using Ringtoets.HydraRing.Calculation.Data; using Ringtoets.HydraRing.Calculation.Data.Input.WaveConditions; @@ -241,7 +239,8 @@ StabilityStoneCoverFailureMechanism stabilityStoneCoverFailureMechanism = new StabilityStoneCoverFailureMechanism(); var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -297,7 +296,8 @@ StabilityStoneCoverFailureMechanism stabilityStoneCoverFailureMechanism = new StabilityStoneCoverFailureMechanism(); var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository); mockRepository.ReplayAll(); switch (calculationType) @@ -365,7 +365,8 @@ StabilityStoneCoverFailureMechanism stabilityStoneCoverFailureMechanism = new StabilityStoneCoverFailureMechanism(); var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -399,7 +400,8 @@ StabilityStoneCoverFailureMechanism stabilityStoneCoverFailureMechanism = new StabilityStoneCoverFailureMechanism(); var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -466,7 +468,8 @@ StabilityStoneCoverFailureMechanism stabilityStoneCoverFailureMechanism = new StabilityStoneCoverFailureMechanism(); var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -492,16 +495,16 @@ StabilityStoneCoverFailureMechanism stabilityStoneCoverFailureMechanism = new StabilityStoneCoverFailureMechanism(); var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) { - var testWaveConditionsCosineCalculator = ((TestHydraRingCalculatorFactory)HydraRingCalculatorFactory.Instance).WaveConditionsCosineCalculator; + var testWaveConditionsCosineCalculator = ((TestHydraRingCalculatorFactory) HydraRingCalculatorFactory.Instance).WaveConditionsCosineCalculator; var stabilityStoneCoverWaveConditionsCalculationService = new StabilityStoneCoverWaveConditionsCalculationService(); testWaveConditionsCosineCalculator.CalculationFinishedHandler += (s, e) => stabilityStoneCoverWaveConditionsCalculationService.Cancel(); - // Call stabilityStoneCoverWaveConditionsCalculationService.Calculate(calculation, assessmentSectionStub, stabilityStoneCoverFailureMechanism.GeneralInput, validFilePath); @@ -521,7 +524,8 @@ StabilityStoneCoverFailureMechanism stabilityStoneCoverFailureMechanism = new StabilityStoneCoverFailureMechanism(); var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -546,7 +550,8 @@ StabilityStoneCoverFailureMechanism stabilityStoneCoverFailureMechanism = new StabilityStoneCoverFailureMechanism(); var mockRepository = new MockRepository(); - var assessmentSectionStub = CreateAssessmentSectionStub(stabilityStoneCoverFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + stabilityStoneCoverFailureMechanism, mockRepository); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -564,17 +569,6 @@ mockRepository.VerifyAll(); } - private static IAssessmentSection CreateAssessmentSectionStub(IFailureMechanism failureMechanism, MockRepository mockRepository) - { - var assessmentSectionStub = mockRepository.Stub(); - assessmentSectionStub.Stub(a => a.Id).Return("21"); - assessmentSectionStub.Stub(a => a.FailureMechanismContribution).Return(new FailureMechanismContribution(new[] - { - failureMechanism - }, 1, 2)); - return assessmentSectionStub; - } - public enum CalculationType { NoForeshore, Index: Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Service.Test/Ringtoets.WaveImpactAsphaltCover.Service.Test.csproj =================================================================== diff -u -r8577bc9fb1f6f28a32d09587ba6991183accd787 -r7fa4481428458d47cc3ec2fe6e75b12a1c539c8d --- Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Service.Test/Ringtoets.WaveImpactAsphaltCover.Service.Test.csproj (.../Ringtoets.WaveImpactAsphaltCover.Service.Test.csproj) (revision 8577bc9fb1f6f28a32d09587ba6991183accd787) +++ Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Service.Test/Ringtoets.WaveImpactAsphaltCover.Service.Test.csproj (.../Ringtoets.WaveImpactAsphaltCover.Service.Test.csproj) (revision 7fa4481428458d47cc3ec2fe6e75b12a1c539c8d) @@ -80,6 +80,10 @@ {d4200f43-3f72-4f42-af0a-8ced416a38ec} Ringtoets.Common.Data + + {4843D6E5-066F-4795-94F5-1D53932DD03C} + Ringtoets.Common.Data.TestUtil + {888D4097-8BC2-4703-9FB1-8744C94D525E} Ringtoets.HydraRing.Calculation Index: Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Service.Test/WaveImpactAsphaltCoverWaveConditionsCalculationServiceTest.cs =================================================================== diff -u -ra14d1309ecf82ff5b0385a2f6e3b2c4a216a4184 -r7fa4481428458d47cc3ec2fe6e75b12a1c539c8d --- Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Service.Test/WaveImpactAsphaltCoverWaveConditionsCalculationServiceTest.cs (.../WaveImpactAsphaltCoverWaveConditionsCalculationServiceTest.cs) (revision a14d1309ecf82ff5b0385a2f6e3b2c4a216a4184) +++ Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Service.Test/WaveImpactAsphaltCoverWaveConditionsCalculationServiceTest.cs (.../WaveImpactAsphaltCoverWaveConditionsCalculationServiceTest.cs) (revision 7fa4481428458d47cc3ec2fe6e75b12a1c539c8d) @@ -28,9 +28,8 @@ using NUnit.Framework; using Rhino.Mocks; using Ringtoets.Common.Data.AssessmentSection; -using Ringtoets.Common.Data.Contribution; using Ringtoets.Common.Data.DikeProfiles; -using Ringtoets.Common.Data.FailureMechanism; +using Ringtoets.Common.Data.TestUtil; using Ringtoets.HydraRing.Calculation.Calculator.Factory; using Ringtoets.HydraRing.Calculation.Data; using Ringtoets.HydraRing.Calculation.Data.Input.WaveConditions; @@ -251,7 +250,8 @@ WaveImpactAsphaltCoverFailureMechanism waveImpactAsphaltCoverFailureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); var mockRepository = new MockRepository(); - IAssessmentSection assessmentSectionStub = CreateAssessmentSectionStub(waveImpactAsphaltCoverFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + waveImpactAsphaltCoverFailureMechanism, mockRepository); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -296,7 +296,8 @@ var waveImpactAsphaltCoverFailureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); var mockRepository = new MockRepository(); - IAssessmentSection assessmentSectionStub = CreateAssessmentSectionStub(waveImpactAsphaltCoverFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + waveImpactAsphaltCoverFailureMechanism, mockRepository); mockRepository.ReplayAll(); switch (calculationType) @@ -353,7 +354,8 @@ var waveImpactAsphaltCoverFailureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); var mockRepository = new MockRepository(); - IAssessmentSection assessmentSectionStub = CreateAssessmentSectionStub(waveImpactAsphaltCoverFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + waveImpactAsphaltCoverFailureMechanism, mockRepository); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -403,7 +405,8 @@ var waveImpactAsphaltCoverFailureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); var mockRepository = new MockRepository(); - IAssessmentSection assessmentSectionStub = CreateAssessmentSectionStub(waveImpactAsphaltCoverFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + waveImpactAsphaltCoverFailureMechanism, mockRepository); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -431,7 +434,8 @@ var waveImpactAsphaltCoverFailureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); var mockRepository = new MockRepository(); - IAssessmentSection assessmentSectionStub = CreateAssessmentSectionStub(waveImpactAsphaltCoverFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + waveImpactAsphaltCoverFailureMechanism, mockRepository); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -461,7 +465,8 @@ var waveImpactAsphaltCoverFailureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); var mockRepository = new MockRepository(); - IAssessmentSection assessmentSectionStub = CreateAssessmentSectionStub(waveImpactAsphaltCoverFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + waveImpactAsphaltCoverFailureMechanism, mockRepository); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -486,7 +491,8 @@ WaveImpactAsphaltCoverFailureMechanism waveImpactAsphaltCoverFailureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); var mockRepository = new MockRepository(); - IAssessmentSection assessmentSectionStub = CreateAssessmentSectionStub(waveImpactAsphaltCoverFailureMechanism, mockRepository); + var assessmentSectionStub = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( + waveImpactAsphaltCoverFailureMechanism, mockRepository); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig()) @@ -513,17 +519,6 @@ ForeshoreWithoutBreakWater } - private static IAssessmentSection CreateAssessmentSectionStub(IFailureMechanism failureMechanism, MockRepository mockRepository) - { - var assessmentSectionStub = mockRepository.Stub(); - assessmentSectionStub.Stub(a => a.Id).Return("21"); - assessmentSectionStub.Stub(a => a.FailureMechanismContribution).Return(new FailureMechanismContribution(new[] - { - failureMechanism - }, 1, 2)); - return assessmentSectionStub; - } - private static WaveImpactAsphaltCoverWaveConditionsCalculation GetValidCalculation() { var calculation = new WaveImpactAsphaltCoverWaveConditionsCalculation