Index: Riskeer/GrassCoverErosionOutwards/test/Riskeer.GrassCoverErosionOutwards.Plugin.Test/TreeNodeInfos/GrassCoverErosionOutwardsCalculationGroupContextTreeNodeInfoTest.cs =================================================================== diff -u -r8339953df3276b6c7b4a3d9f5a278e4c19e85be3 -r8915901c4005e4b33972612146ac060b59be5587 --- Riskeer/GrassCoverErosionOutwards/test/Riskeer.GrassCoverErosionOutwards.Plugin.Test/TreeNodeInfos/GrassCoverErosionOutwardsCalculationGroupContextTreeNodeInfoTest.cs (.../GrassCoverErosionOutwardsCalculationGroupContextTreeNodeInfoTest.cs) (revision 8339953df3276b6c7b4a3d9f5a278e4c19e85be3) +++ Riskeer/GrassCoverErosionOutwards/test/Riskeer.GrassCoverErosionOutwards.Plugin.Test/TreeNodeInfos/GrassCoverErosionOutwardsCalculationGroupContextTreeNodeInfoTest.cs (.../GrassCoverErosionOutwardsCalculationGroupContextTreeNodeInfoTest.cs) (revision 8915901c4005e4b33972612146ac060b59be5587) @@ -897,182 +897,16 @@ } [Test] - public void ValidateAllViaContextMenuStrip_HydraulicBoundaryDatabaseWithCanUsePreprocessorFalse_NoValidationErrorsLogged() + public void ValidateAllViaContextMenuStrip_MissingPreprocessorClosureDatabase_ValidationErrorsLogged() { // Setup - AssessmentSectionStub assessmentSection = CreateAssessmentSection(); + AssessmentSectionStub assessmentSection = CreateAssessmentSection(true); assessmentSection.SetHydraulicBoundaryLocationCalculations(new[] { new TestHydraulicBoundaryLocation() }); ConfigureAssessmentSectionWithHydraulicBoundaryOutput(assessmentSection); - GrassCoverErosionOutwardsWaveConditionsCalculation calculation = GetValidCalculation(assessmentSection.HydraulicBoundaryData.Locations.First()); - - var group = new CalculationGroup(); - group.Children.Add(calculation); - - var failureMechanism = new GrassCoverErosionOutwardsFailureMechanism(); - failureMechanism.CalculationsGroup.Children.Add(group); - var nodeData = new GrassCoverErosionOutwardsCalculationGroupContext(group, - failureMechanism.CalculationsGroup, - failureMechanism, - assessmentSection); - var parentNodeData = new GrassCoverErosionOutwardsCalculationGroupContext(failureMechanism.CalculationsGroup, - null, - failureMechanism, - assessmentSection); - - var menuBuilder = new CustomItemsOnlyContextMenuBuilder(); - - using (var treeViewControl = new TreeViewControl()) - { - gui.Stub(g => g.Get(nodeData, treeViewControl)).Return(menuBuilder); - gui.Stub(g => g.MainWindow).Return(mocks.Stub()); - mocks.ReplayAll(); - - using (ContextMenuStrip contextMenu = info.ContextMenuStrip(nodeData, parentNodeData, treeViewControl)) - { - // Call - void Call() => contextMenu.Items[contextMenuValidateAllIndexNestedGroup].PerformClick(); - - // Assert - TestHelper.AssertLogMessages(Call, m => - { - string[] messages = m.ToArray(); - Assert.AreEqual(2, messages.Length); - CalculationServiceTestHelper.AssertValidationStartMessage(messages[0]); - CalculationServiceTestHelper.AssertValidationEndMessage(messages[1]); - }); - } - } - } - - [Test] - public void ValidateAllViaContextMenuStrip_HydraulicBoundaryDatabaseWithUsePreprocessorFalse_NoValidationErrorsLogged() - { - // Setup - AssessmentSectionStub assessmentSection = CreateAssessmentSection(); - assessmentSection.SetHydraulicBoundaryLocationCalculations(new[] - { - new TestHydraulicBoundaryLocation() - }); - ConfigureAssessmentSectionWithHydraulicBoundaryOutput(assessmentSection); - - assessmentSection.HydraulicBoundaryData.HydraulicLocationConfigurationSettings.CanUsePreprocessor = true; - assessmentSection.HydraulicBoundaryData.HydraulicLocationConfigurationSettings.UsePreprocessor = false; - assessmentSection.HydraulicBoundaryData.HydraulicLocationConfigurationSettings.PreprocessorDirectory = "InvalidPreprocessorDirectory"; - - GrassCoverErosionOutwardsWaveConditionsCalculation calculation = GetValidCalculation(assessmentSection.HydraulicBoundaryData.Locations.First()); - - var group = new CalculationGroup(); - group.Children.Add(calculation); - - var failureMechanism = new GrassCoverErosionOutwardsFailureMechanism(); - failureMechanism.CalculationsGroup.Children.Add(group); - - var nodeData = new GrassCoverErosionOutwardsCalculationGroupContext(group, - failureMechanism.CalculationsGroup, - failureMechanism, - assessmentSection); - var parentNodeData = new GrassCoverErosionOutwardsCalculationGroupContext(failureMechanism.CalculationsGroup, - null, - failureMechanism, - assessmentSection); - - var menuBuilder = new CustomItemsOnlyContextMenuBuilder(); - - using (var treeViewControl = new TreeViewControl()) - { - gui.Stub(g => g.Get(nodeData, treeViewControl)).Return(menuBuilder); - gui.Stub(g => g.MainWindow).Return(mocks.Stub()); - mocks.ReplayAll(); - - using (ContextMenuStrip contextMenu = info.ContextMenuStrip(nodeData, parentNodeData, treeViewControl)) - { - // Call - void Call() => contextMenu.Items[contextMenuValidateAllIndexNestedGroup].PerformClick(); - - // Assert - TestHelper.AssertLogMessages(Call, m => - { - string[] messages = m.ToArray(); - Assert.AreEqual(2, messages.Length); - CalculationServiceTestHelper.AssertValidationStartMessage(messages[0]); - CalculationServiceTestHelper.AssertValidationEndMessage(messages[1]); - }); - } - } - } - - [Test] - public void ValidateAllViaContextMenuStrip_HydraulicBoundaryDatabaseWithUsePreprocessorTrue_NoValidationErrorsLogged() - { - // Setup - AssessmentSectionStub assessmentSection = CreateAssessmentSection(); - assessmentSection.SetHydraulicBoundaryLocationCalculations(new[] - { - new TestHydraulicBoundaryLocation() - }); - ConfigureAssessmentSectionWithHydraulicBoundaryOutput(assessmentSection); - - assessmentSection.HydraulicBoundaryData.HydraulicLocationConfigurationSettings.CanUsePreprocessor = true; - assessmentSection.HydraulicBoundaryData.HydraulicLocationConfigurationSettings.UsePreprocessor = true; - assessmentSection.HydraulicBoundaryData.HydraulicLocationConfigurationSettings.PreprocessorDirectory = TestHelper.GetScratchPadPath(); - - GrassCoverErosionOutwardsWaveConditionsCalculation calculation = GetValidCalculation(assessmentSection.HydraulicBoundaryData.Locations.First()); - - var group = new CalculationGroup(); - group.Children.Add(calculation); - - var failureMechanism = new GrassCoverErosionOutwardsFailureMechanism(); - failureMechanism.CalculationsGroup.Children.Add(group); - - var nodeData = new GrassCoverErosionOutwardsCalculationGroupContext(group, - failureMechanism.CalculationsGroup, - failureMechanism, - assessmentSection); - var parentNodeData = new GrassCoverErosionOutwardsCalculationGroupContext(failureMechanism.CalculationsGroup, - null, - failureMechanism, - assessmentSection); - - var menuBuilder = new CustomItemsOnlyContextMenuBuilder(); - - using (var treeViewControl = new TreeViewControl()) - { - gui.Stub(g => g.Get(nodeData, treeViewControl)).Return(menuBuilder); - gui.Stub(g => g.MainWindow).Return(mocks.Stub()); - mocks.ReplayAll(); - - using (ContextMenuStrip contextMenu = info.ContextMenuStrip(nodeData, parentNodeData, treeViewControl)) - { - // Call - void Call() => contextMenu.Items[contextMenuValidateAllIndexNestedGroup].PerformClick(); - - // Assert - TestHelper.AssertLogMessages(Call, m => - { - string[] messages = m.ToArray(); - Assert.AreEqual(2, messages.Length); - CalculationServiceTestHelper.AssertValidationStartMessage(messages[0]); - CalculationServiceTestHelper.AssertValidationEndMessage(messages[1]); - }); - } - } - } - - [Test] - public void ValidateAllViaContextMenuStrip_HydraulicBoundaryDatabaseWithUsePreprocessorTrue_ValidationErrorsLogged() - { - // Setup - AssessmentSectionStub assessmentSection = CreateAssessmentSection(); - assessmentSection.SetHydraulicBoundaryLocationCalculations(new[] - { - new TestHydraulicBoundaryLocation() - }); - ConfigureAssessmentSectionWithHydraulicBoundaryOutput(assessmentSection); - var calculation = new GrassCoverErosionOutwardsWaveConditionsCalculation { Name = "A", @@ -1094,10 +928,6 @@ var failureMechanism = new GrassCoverErosionOutwardsFailureMechanism(); failureMechanism.CalculationsGroup.Children.Add(group); - assessmentSection.HydraulicBoundaryData.HydraulicLocationConfigurationSettings.CanUsePreprocessor = true; - assessmentSection.HydraulicBoundaryData.HydraulicLocationConfigurationSettings.UsePreprocessor = true; - assessmentSection.HydraulicBoundaryData.HydraulicLocationConfigurationSettings.PreprocessorDirectory = "InvalidPreprocessorDirectory"; - var nodeData = new GrassCoverErosionOutwardsCalculationGroupContext(group, failureMechanism.CalculationsGroup, failureMechanism, @@ -1126,7 +956,7 @@ string[] messages = m.ToArray(); Assert.AreEqual(3, messages.Length); CalculationServiceTestHelper.AssertValidationStartMessage(messages[0]); - Assert.AreEqual("De bestandsmap waar de preprocessor bestanden opslaat is ongeldig. De bestandsmap bestaat niet.", messages[1]); + Assert.AreEqual("Fixme", messages[1]); CalculationServiceTestHelper.AssertValidationEndMessage(messages[2]); }); } @@ -1902,7 +1732,7 @@ mocks.VerifyAll(); } - private AssessmentSectionStub CreateAssessmentSection() + private AssessmentSectionStub CreateAssessmentSection(bool usePreprocessorClosure = false) { var assessmentSection = new AssessmentSectionStub { @@ -1911,8 +1741,9 @@ FilePath = validFilePath } }; - HydraulicBoundaryDataTestHelper.SetHydraulicLocationConfigurationSettings(assessmentSection.HydraulicBoundaryData); + HydraulicBoundaryDataTestHelper.SetHydraulicLocationConfigurationSettings(assessmentSection.HydraulicBoundaryData, usePreprocessorClosure); + return assessmentSection; }