Index: Riskeer/StabilityStoneCover/test/Riskeer.StabilityStoneCover.Plugin.Test/TreeNodeInfos/StabilityStoneCoverWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs =================================================================== diff -u -rb7678858ad514d847ac8fe5c445e1327200b2ac3 -r8f777e52ebf7549631b5bc0165db5e2a2435f227 --- Riskeer/StabilityStoneCover/test/Riskeer.StabilityStoneCover.Plugin.Test/TreeNodeInfos/StabilityStoneCoverWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs (.../StabilityStoneCoverWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs) (revision b7678858ad514d847ac8fe5c445e1327200b2ac3) +++ Riskeer/StabilityStoneCover/test/Riskeer.StabilityStoneCover.Plugin.Test/TreeNodeInfos/StabilityStoneCoverWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs (.../StabilityStoneCoverWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs) (revision 8f777e52ebf7549631b5bc0165db5e2a2435f227) @@ -884,11 +884,7 @@ public void ValidateAllViaContextMenuStrip_HydraulicBoundaryDatabaseWithCanUsePreprocessorFalse_NoValidationErrorsLogged() { // Setup - var failureMechanism = new StabilityStoneCoverFailureMechanism - { - Contribution = 5 - }; - + var failureMechanism = new StabilityStoneCoverFailureMechanism(); IAssessmentSection assessmentSection = CreateAssessmentSectionWithHydraulicBoundaryOutput(); StabilityStoneCoverWaveConditionsCalculation calculation = GetValidCalculation(assessmentSection.HydraulicBoundaryDatabase.Locations.First()); @@ -936,11 +932,7 @@ public void ValidateAllViaContextMenuStrip_HydraulicBoundaryDatabaseWithUsePreprocessorFalse_NoValidationErrorsLogged() { // Setup - var failureMechanism = new StabilityStoneCoverFailureMechanism - { - Contribution = 5 - }; - + var failureMechanism = new StabilityStoneCoverFailureMechanism(); IAssessmentSection assessmentSection = CreateAssessmentSectionWithHydraulicBoundaryOutput(); StabilityStoneCoverWaveConditionsCalculation calculation = GetValidCalculation(assessmentSection.HydraulicBoundaryDatabase.Locations.First()); @@ -992,11 +984,7 @@ public void ValidateAllViaContextMenuStrip_HydraulicBoundaryDatabaseWithUsePreprocessorTrue_NoValidationErrorsLogged() { // Setup - var failureMechanism = new StabilityStoneCoverFailureMechanism - { - Contribution = 5 - }; - + var failureMechanism = new StabilityStoneCoverFailureMechanism(); IAssessmentSection assessmentSection = CreateAssessmentSectionWithHydraulicBoundaryOutput(); StabilityStoneCoverWaveConditionsCalculation calculation = GetValidCalculation(assessmentSection.HydraulicBoundaryDatabase.Locations.First()); @@ -1048,11 +1036,7 @@ public void ValidateAllViaContextMenuStrip_HydraulicBoundaryDatabaseWithUsePreprocessorTrue_ValidationErrorsLogged() { // Setup - var failureMechanism = new StabilityStoneCoverFailureMechanism - { - Contribution = 5 - }; - + var failureMechanism = new StabilityStoneCoverFailureMechanism(); IAssessmentSection assessmentSection = CreateAssessmentSectionWithHydraulicBoundaryOutput(); var calculation = new StabilityStoneCoverWaveConditionsCalculation @@ -1678,7 +1662,7 @@ { var appFeatureCommandHandler = mocks.Stub(); var importHandler = mocks.Stub(); - importHandler.Stub(ih => ih.GetSupportedImportInfos(context)).Return(new ImportInfo[0]); + importHandler.Stub(ih => ih.GetSupportedImportInfos(context)).Return(Array.Empty()); var exportHandler = mocks.Stub(); var updateHandler = mocks.Stub(); var viewCommands = mocks.Stub(); @@ -1727,7 +1711,7 @@ { var appFeatureCommandHandler = mocks.Stub(); var importHandler = mocks.Stub(); - importHandler.Stub(ih => ih.GetSupportedImportInfos(context)).Return(new ImportInfo[0]); + importHandler.Stub(ih => ih.GetSupportedImportInfos(context)).Return(Array.Empty()); var exportHandler = mocks.Stub(); var updateHandler = mocks.Stub(); var viewCommands = mocks.Stub(); Index: Riskeer/StabilityStoneCover/test/Riskeer.StabilityStoneCover.Service.Test/StabilityStoneCoverWaveConditionsCalculationActivityFactoryTest.cs =================================================================== diff -u -rb44e7692360de39230f35febfbc32f4366aec94a -r8f777e52ebf7549631b5bc0165db5e2a2435f227 --- Riskeer/StabilityStoneCover/test/Riskeer.StabilityStoneCover.Service.Test/StabilityStoneCoverWaveConditionsCalculationActivityFactoryTest.cs (.../StabilityStoneCoverWaveConditionsCalculationActivityFactoryTest.cs) (revision b44e7692360de39230f35febfbc32f4366aec94a) +++ Riskeer/StabilityStoneCover/test/Riskeer.StabilityStoneCover.Service.Test/StabilityStoneCoverWaveConditionsCalculationActivityFactoryTest.cs (.../StabilityStoneCoverWaveConditionsCalculationActivityFactoryTest.cs) (revision 8f777e52ebf7549631b5bc0165db5e2a2435f227) @@ -82,7 +82,7 @@ { // Setup AssessmentSectionStub assessmentSection = CreateAssessmentSection(); - StabilityStoneCoverFailureMechanism failureMechanism = CreateFailureMechanism(); + StabilityStoneCoverFailureMechanism failureMechanism = new StabilityStoneCoverFailureMechanism(); var hydraulicBoundaryLocation = new TestHydraulicBoundaryLocation("locationName 1"); SetHydraulicBoundaryLocationToAssessmentSection(assessmentSection, hydraulicBoundaryLocation); @@ -168,7 +168,7 @@ public void CreateCalculationActivity_WithValidCalculation_ReturnsStabilityStoneCoverWaveConditionsCalculationActivityWithParametersSet() { // Setup - StabilityStoneCoverFailureMechanism failureMechanism = CreateFailureMechanism(); + StabilityStoneCoverFailureMechanism failureMechanism = new StabilityStoneCoverFailureMechanism(); AssessmentSectionStub assessmentSection = CreateAssessmentSection(); var hydraulicBoundaryLocation = new TestHydraulicBoundaryLocation(); @@ -244,7 +244,7 @@ public void CreateCalculationActivitiesForCalculationGroup_WithValidCalculations_ReturnsStabilityStoneCoverWaveConditionsCalculationActivitiesWithParametersSet() { // Setup - StabilityStoneCoverFailureMechanism failureMechanism = CreateFailureMechanism(); + StabilityStoneCoverFailureMechanism failureMechanism = new StabilityStoneCoverFailureMechanism(); AssessmentSectionStub assessmentSection = CreateAssessmentSection(); var hydraulicBoundaryLocation = new TestHydraulicBoundaryLocation(); @@ -285,14 +285,6 @@ assessmentSection.WaterLevelCalculationsForSignalingNorm.Single().Output = new TestHydraulicBoundaryLocationCalculationOutput(2.0); } - private static StabilityStoneCoverFailureMechanism CreateFailureMechanism() - { - return new StabilityStoneCoverFailureMechanism - { - Contribution = 10 - }; - } - private static AssessmentSectionStub CreateAssessmentSection() { var assessmentSection = new AssessmentSectionStub Index: Riskeer/StabilityStoneCover/test/Riskeer.StabilityStoneCover.Service.Test/StabilityStoneCoverWaveConditionsCalculationServiceTest.cs =================================================================== diff -u -r60051f2e130e94f8005499c5c6d84ac48b59a1d3 -r8f777e52ebf7549631b5bc0165db5e2a2435f227 --- Riskeer/StabilityStoneCover/test/Riskeer.StabilityStoneCover.Service.Test/StabilityStoneCoverWaveConditionsCalculationServiceTest.cs (.../StabilityStoneCoverWaveConditionsCalculationServiceTest.cs) (revision 60051f2e130e94f8005499c5c6d84ac48b59a1d3) +++ Riskeer/StabilityStoneCover/test/Riskeer.StabilityStoneCover.Service.Test/StabilityStoneCoverWaveConditionsCalculationServiceTest.cs (.../StabilityStoneCoverWaveConditionsCalculationServiceTest.cs) (revision 8f777e52ebf7549631b5bc0165db5e2a2435f227) @@ -569,10 +569,7 @@ string detailedReport) { // Setup - var failureMechanism = new StabilityStoneCoverFailureMechanism - { - Contribution = 20 - }; + var failureMechanism = new StabilityStoneCoverFailureMechanism(); var calculatorThatFails = new TestWaveConditionsCosineCalculator { EndInFailure = endInFailure, @@ -658,10 +655,7 @@ string detailedReport) { // Setup - var failureMechanism = new StabilityStoneCoverFailureMechanism - { - Contribution = 20 - }; + var failureMechanism = new StabilityStoneCoverFailureMechanism(); var calculatorThatFails = new TestWaveConditionsCosineCalculator { EndInFailure = endInFailure, @@ -756,10 +750,7 @@ string detailedReport) { // Setup - var failureMechanism = new StabilityStoneCoverFailureMechanism - { - Contribution = 20 - }; + var failureMechanism = new StabilityStoneCoverFailureMechanism(); var calculatorThatFails = new TestWaveConditionsCosineCalculator { EndInFailure = endInFailure, Index: Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Plugin.Test/TreeNodeInfos/WaveImpactAsphaltCoverWaveConditionsCalculationContextTreeNodeInfoTest.cs =================================================================== diff -u -rb7678858ad514d847ac8fe5c445e1327200b2ac3 -r8f777e52ebf7549631b5bc0165db5e2a2435f227 --- Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Plugin.Test/TreeNodeInfos/WaveImpactAsphaltCoverWaveConditionsCalculationContextTreeNodeInfoTest.cs (.../WaveImpactAsphaltCoverWaveConditionsCalculationContextTreeNodeInfoTest.cs) (revision b7678858ad514d847ac8fe5c445e1327200b2ac3) +++ Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Plugin.Test/TreeNodeInfos/WaveImpactAsphaltCoverWaveConditionsCalculationContextTreeNodeInfoTest.cs (.../WaveImpactAsphaltCoverWaveConditionsCalculationContextTreeNodeInfoTest.cs) (revision 8f777e52ebf7549631b5bc0165db5e2a2435f227) @@ -1042,11 +1042,7 @@ public void GivenHydraulicBoundaryDatabaseWithCanUsePreprocessorFalse_WhenValidatingCalculation_ThenNoValidationErrorsLogged() { // Given - var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism - { - Contribution = 5 - }; - + var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); IAssessmentSection assessmentSection = CreateAssessmentSectionWithHydraulicBoundaryOutput(); var parent = new CalculationGroup(); @@ -1100,11 +1096,7 @@ public void GivenHydraulicBoundaryDatabaseWithUsePreprocessorFalse_WhenValidatingCalculation_ThenNoValidationErrorsLogged() { // Given - var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism - { - Contribution = 5 - }; - + var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); IAssessmentSection assessmentSection = CreateAssessmentSectionWithHydraulicBoundaryOutput(); assessmentSection.HydraulicBoundaryDatabase.HydraulicLocationConfigurationSettings.CanUsePreprocessor = true; @@ -1162,11 +1154,7 @@ public void GivenHydraulicBoundaryDatabaseWithUsePreprocessorTrue_WhenValidatingCalculation_ThenNoValidationErrorsLogged() { // Given - var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism - { - Contribution = 5 - }; - + var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); IAssessmentSection assessmentSection = CreateAssessmentSectionWithHydraulicBoundaryOutput(); assessmentSection.HydraulicBoundaryDatabase.HydraulicLocationConfigurationSettings.CanUsePreprocessor = true; @@ -1224,11 +1212,7 @@ public void GivenHydraulicBoundaryDatabaseWithUsePreprocessorTrue_WhenValidatingCalculation_ThenValidationErrorsLogged() { // Given - var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism - { - Contribution = 5 - }; - + var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); IAssessmentSection assessmentSection = CreateAssessmentSectionWithHydraulicBoundaryOutput(); assessmentSection.HydraulicBoundaryDatabase.HydraulicLocationConfigurationSettings.CanUsePreprocessor = true; Index: Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Plugin.Test/TreeNodeInfos/WaveImpactAsphaltCoverWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs =================================================================== diff -u -rb7678858ad514d847ac8fe5c445e1327200b2ac3 -r8f777e52ebf7549631b5bc0165db5e2a2435f227 --- Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Plugin.Test/TreeNodeInfos/WaveImpactAsphaltCoverWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs (.../WaveImpactAsphaltCoverWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs) (revision b7678858ad514d847ac8fe5c445e1327200b2ac3) +++ Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Plugin.Test/TreeNodeInfos/WaveImpactAsphaltCoverWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs (.../WaveImpactAsphaltCoverWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs) (revision 8f777e52ebf7549631b5bc0165db5e2a2435f227) @@ -898,11 +898,7 @@ public void ValidateAllViaContextMenuStrip_HydraulicBoundaryDatabaseWithCanUsePreprocessorFalse_NoValidationErrorsLogged() { // Setup - var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism - { - Contribution = 5 - }; - + var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); IAssessmentSection assessmentSection = CreateAssessmentSectionWithHydraulicBoundaryOutput(); WaveImpactAsphaltCoverWaveConditionsCalculation calculation = GetValidCalculation(assessmentSection.HydraulicBoundaryDatabase.Locations.First()); @@ -950,11 +946,7 @@ public void ValidateAllViaContextMenuStrip_HydraulicBoundaryDatabaseWithUsePreprocessorFalse_NoValidationErrorsLogged() { // Setup - var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism - { - Contribution = 5 - }; - + var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); IAssessmentSection assessmentSection = CreateAssessmentSectionWithHydraulicBoundaryOutput(); WaveImpactAsphaltCoverWaveConditionsCalculation calculation = GetValidCalculation(assessmentSection.HydraulicBoundaryDatabase.Locations.First()); @@ -1006,11 +998,7 @@ public void ValidateAllViaContextMenuStrip_HydraulicBoundaryDatabaseWithUsePreprocessorTrue_NoValidationErrorsLogged() { // Setup - var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism - { - Contribution = 5 - }; - + var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); IAssessmentSection assessmentSection = CreateAssessmentSectionWithHydraulicBoundaryOutput(); WaveImpactAsphaltCoverWaveConditionsCalculation calculation = GetValidCalculation(assessmentSection.HydraulicBoundaryDatabase.Locations.First()); @@ -1062,11 +1050,7 @@ public void ValidateAllViaContextMenuStrip_HydraulicBoundaryDatabaseWithUsePreprocessorTrue_ValidationErrorsLogged() { // Setup - var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism - { - Contribution = 5 - }; - + var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); IAssessmentSection assessmentSection = CreateAssessmentSectionWithHydraulicBoundaryOutput(); var calculation = new WaveImpactAsphaltCoverWaveConditionsCalculation @@ -1701,7 +1685,7 @@ { var appFeatureCommandHandler = mocks.Stub(); var importHandler = mocks.Stub(); - importHandler.Stub(ih => ih.GetSupportedImportInfos(context)).Return(new ImportInfo[0]); + importHandler.Stub(ih => ih.GetSupportedImportInfos(context)).Return(Array.Empty()); var exportHandler = mocks.Stub(); var updateHandler = mocks.Stub(); var viewCommands = mocks.Stub(); @@ -1750,7 +1734,7 @@ { var appFeatureCommandHandler = mocks.Stub(); var importHandler = mocks.Stub(); - importHandler.Stub(ih => ih.GetSupportedImportInfos(context)).Return(new ImportInfo[0]); + importHandler.Stub(ih => ih.GetSupportedImportInfos(context)).Return(Array.Empty()); var exportHandler = mocks.Stub(); var updateHandler = mocks.Stub(); var viewCommands = mocks.Stub(); Index: Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Service.Test/WaveImpactAsphaltCoverWaveConditionsCalculationActivityFactoryTest.cs =================================================================== diff -u -r68f5444efbb1c5b14f681c993d430fdf7589df18 -r8f777e52ebf7549631b5bc0165db5e2a2435f227 --- Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Service.Test/WaveImpactAsphaltCoverWaveConditionsCalculationActivityFactoryTest.cs (.../WaveImpactAsphaltCoverWaveConditionsCalculationActivityFactoryTest.cs) (revision 68f5444efbb1c5b14f681c993d430fdf7589df18) +++ Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Service.Test/WaveImpactAsphaltCoverWaveConditionsCalculationActivityFactoryTest.cs (.../WaveImpactAsphaltCoverWaveConditionsCalculationActivityFactoryTest.cs) (revision 8f777e52ebf7549631b5bc0165db5e2a2435f227) @@ -82,7 +82,7 @@ { // Setup AssessmentSectionStub assessmentSection = CreateAssessmentSection(); - WaveImpactAsphaltCoverFailureMechanism failureMechanism = CreateFailureMechanism(); + WaveImpactAsphaltCoverFailureMechanism failureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); var hydraulicBoundaryLocation = new TestHydraulicBoundaryLocation("locationName 1"); SetHydraulicBoundaryLocationToAssessmentSection(assessmentSection, hydraulicBoundaryLocation); @@ -168,7 +168,7 @@ public void CreateCalculationActivity_WithValidCalculation_ReturnsWaveImpactAsphaltCoverWaveConditionsCalculationActivityWithParametersSet() { // Setup - WaveImpactAsphaltCoverFailureMechanism failureMechanism = CreateFailureMechanism(); + WaveImpactAsphaltCoverFailureMechanism failureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); AssessmentSectionStub assessmentSection = CreateAssessmentSection(); var hydraulicBoundaryLocation = new TestHydraulicBoundaryLocation(); @@ -244,7 +244,7 @@ public void CreateCalculationActivitiesForCalculationGroup_WithValidCalculations_ReturnsWaveImpactAsphaltCoverWaveConditionsCalculationActivitiesWithParametersSet() { // Setup - WaveImpactAsphaltCoverFailureMechanism failureMechanism = CreateFailureMechanism(); + WaveImpactAsphaltCoverFailureMechanism failureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); AssessmentSectionStub assessmentSection = CreateAssessmentSection(); var hydraulicBoundaryLocation = new TestHydraulicBoundaryLocation(); @@ -285,14 +285,6 @@ assessmentSection.WaterLevelCalculationsForSignalingNorm.Single().Output = new TestHydraulicBoundaryLocationCalculationOutput(2.0); } - private static WaveImpactAsphaltCoverFailureMechanism CreateFailureMechanism() - { - return new WaveImpactAsphaltCoverFailureMechanism - { - Contribution = 10 - }; - } - private static AssessmentSectionStub CreateAssessmentSection() { var assessmentSection = new AssessmentSectionStub