Index: Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCalculationCollectionCreateExtensionsTest.cs =================================================================== diff -u -r879d46016d425a19663a7dc1aea55613f6a4525f -r94a162cd5c8d44f206a2a0f5e30b1fa7d29395bc --- Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCalculationCollectionCreateExtensionsTest.cs (.../DuneLocationCalculationCollectionCreateExtensionsTest.cs) (revision 879d46016d425a19663a7dc1aea55613f6a4525f) +++ Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCalculationCollectionCreateExtensionsTest.cs (.../DuneLocationCalculationCollectionCreateExtensionsTest.cs) (revision 94a162cd5c8d44f206a2a0f5e30b1fa7d29395bc) @@ -39,7 +39,7 @@ { // Call TestDelegate call = () => - ((IEnumerable)null).Create(new PersistenceRegistry()); + ((IEnumerable) null).Create(new PersistenceRegistry()); // Assert var exception = Assert.Throws(call); @@ -67,7 +67,7 @@ // Setup var duneLocation = new TestDuneLocation(); var calculation = new DuneLocationCalculation(duneLocation); - var calculations = new[] + DuneLocationCalculation[] calculations = { calculation }; Index: Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCalculationOutputCreateExtensionsTest.cs =================================================================== diff -u -r879d46016d425a19663a7dc1aea55613f6a4525f -r94a162cd5c8d44f206a2a0f5e30b1fa7d29395bc --- Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCalculationOutputCreateExtensionsTest.cs (.../DuneLocationCalculationOutputCreateExtensionsTest.cs) (revision 879d46016d425a19663a7dc1aea55613f6a4525f) +++ Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCalculationOutputCreateExtensionsTest.cs (.../DuneLocationCalculationOutputCreateExtensionsTest.cs) (revision 94a162cd5c8d44f206a2a0f5e30b1fa7d29395bc) @@ -83,13 +83,13 @@ var random = new Random(21); var output = new DuneLocationCalculationOutput(random.NextEnumValue(), new DuneLocationCalculationOutput.ConstructionProperties { - WaterLevel = RoundedDouble.NaN, - WaveHeight = RoundedDouble.NaN, - WavePeriod = RoundedDouble.NaN, - TargetProbability = RoundedDouble.NaN, - TargetReliability = RoundedDouble.NaN, - CalculatedProbability = RoundedDouble.NaN, - CalculatedReliability = RoundedDouble.NaN + WaterLevel = double.NaN, + WaveHeight = double.NaN, + WavePeriod = double.NaN, + TargetProbability = double.NaN, + TargetReliability = double.NaN, + CalculatedProbability = double.NaN, + CalculatedReliability = double.NaN }); // Call Index: Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCreateExtensionsTest.cs =================================================================== diff -u -rc7ef5f92b11bf6bd26ce6580c8bbfbadb1431b6c -r94a162cd5c8d44f206a2a0f5e30b1fa7d29395bc --- Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCreateExtensionsTest.cs (.../DuneLocationCreateExtensionsTest.cs) (revision c7ef5f92b11bf6bd26ce6580c8bbfbadb1431b6c) +++ Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCreateExtensionsTest.cs (.../DuneLocationCreateExtensionsTest.cs) (revision 94a162cd5c8d44f206a2a0f5e30b1fa7d29395bc) @@ -46,7 +46,7 @@ } [Test] - public void Create_WithoutPersistenceRegistry_ThrowsArgumentNullException() + public void Create_PersistenceRegistryNull_ThrowsArgumentNullException() { // Setup var location = new TestDuneLocation(); Index: Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs =================================================================== diff -u -r325db88a5aae33ac33e7293af9a608d6fb1a1019 -r94a162cd5c8d44f206a2a0f5e30b1fa7d29395bc --- Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs (.../MigrationTo181IntegrationTest.cs) (revision 325db88a5aae33ac33e7293af9a608d6fb1a1019) +++ Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs (.../MigrationTo181IntegrationTest.cs) (revision 94a162cd5c8d44f206a2a0f5e30b1fa7d29395bc) @@ -132,7 +132,7 @@ private static void AssertTablesContentMigrated(MigratedDatabaseReader reader, string sourceFilePath) { - var tables = new[] + string[] tables = { "AssessmentSectionEntity", "BackgroundDataEntity", @@ -769,12 +769,12 @@ #region Dune Locations /// - /// Class to generate queries which can be used if the dune locations are correctly migrated. + /// Class to generate queries which can be used to assert if the dune locations are correctly migrated. /// private class DuneErosionFailureMechanismValidationQueryGenerator { /// - /// Enum to indicate the hydraulic location calculation type. + /// Enum to indicate the dune location calculation type. /// public enum CalculationType { @@ -891,8 +891,8 @@ /// A query to validate the dune location outputs. /// Thrown when /// is an invalid value of . - /// Thrown when is an unsupported value, - /// but is unsupported. + /// Thrown when is a valid value, + /// but unsupported public string GetMigratedDuneLocationCalculationOutputValidationQuery(NormativeNormType normType) { return $"ATTACH DATABASE \"{sourceFilePath}\" AS SOURCEPROJECT; " + @@ -934,7 +934,7 @@ /// Thrown when /// is an invalid value of . /// Thrown when is a valid value, - /// but is unsupported. + /// but unsupported private static CalculationType ConvertToCalculationType(NormativeNormType normType) { if (!Enum.IsDefined(typeof(NormativeNormType), normType)) @@ -1400,7 +1400,7 @@ } /// - /// Class to generate queries which can be used if the hydraulic boundary locations + /// Class to generate queries which can be used to assert if the hydraulic boundary locations /// are correctly migrated on the assessment section level. /// private class HydraulicLocationCalculationOnAssessmentSectionValidationQueryGenerator @@ -1526,8 +1526,8 @@ /// A query to validate the hydraulic boundary location calculation input for the design water level calculations. /// Thrown when /// is an invalid value of . - /// Thrown when is an unsupported value, - /// but is unsupported. + /// Thrown when is a valid value, + /// but unsupported public string GetMigratedDesignWaterLevelCalculationsValidationQuery(NormativeNormType normType) { CalculationType calculationType = ConvertToDesignWaterLevelCalculationType(normType); @@ -1552,8 +1552,8 @@ /// A query to validate the hydraulic boundary location calculation outputs. /// Thrown when /// is an invalid value of . - /// Thrown when is an unsupported value, - /// but is unsupported. + /// Thrown when is a valid value, + /// but unsupported public string GetMigratedDesignWaterLevelCalculationOutputsValidationQuery(NormativeNormType normType) { CalculationType calculationType = ConvertToDesignWaterLevelCalculationType(normType); @@ -1582,7 +1582,7 @@ /// Thrown when /// is an invalid value of . /// Thrown when is a valid value, - /// but is unsupported. + /// but unsupported public string GetMigratedWaveHeightCalculationsValidationQuery(NormativeNormType normType) { CalculationType calculationType = ConvertToWaveHeightCalculationType(normType); @@ -1607,8 +1607,8 @@ /// A query to validate the hydraulic boundary location calculation outputs. /// Thrown when /// is an invalid value of . - /// Thrown when is an unsupported value, - /// but is unsupported. + /// Thrown when is a valid value, + /// but unsupported public string GetMigratedWaveHeightCalculationOutputsValidationQuery(NormativeNormType normType) { CalculationType calculationType = ConvertToDesignWaterLevelCalculationType(normType); @@ -1684,7 +1684,7 @@ /// Thrown when /// is an invalid value of . /// Thrown when is a valid value, - /// but is unsupported. + /// but unsupported private static CalculationType ConvertToDesignWaterLevelCalculationType(NormativeNormType normType) { if (!Enum.IsDefined(typeof(NormativeNormType), normType)) @@ -1711,7 +1711,7 @@ /// Thrown when /// is an invalid value of . /// Thrown when is a valid value, - /// but is unsupported. + /// but unsupported private static CalculationType ConvertToWaveHeightCalculationType(NormativeNormType normType) { if (!Enum.IsDefined(typeof(NormativeNormType), normType)) @@ -1778,7 +1778,7 @@ } /// - /// Class to generate queries which can be used if the hydraulic boundary locations + /// Class to generate queries which can be used to assert if the hydraulic boundary locations /// are correctly migrated on the grass cover erosion outwards failure mechanism level. /// private class HydraulicLocationOnGrassCoverErosionOutwardsFailureMechanismValidationQueryGenerator @@ -1895,7 +1895,7 @@ /// Thrown when /// is an invalid value of . /// Thrown when is a valid value, - /// but is unsupported. + /// but unsupported public string GetMigratedDesignWaterLevelCalculationsValidationQuery(NormativeNormType normType) { CalculationType calculationType = ConvertToDesignWaterLevelCalculationType(normType); @@ -1930,8 +1930,8 @@ /// A query to validate the hydraulic boundary location calculation outputs. /// Thrown when /// is an invalid value of . - /// Thrown when is an unsupported value, - /// but is unsupported. + /// Thrown when is a valid value, + /// but unsupported public string GetMigratedDesignWaterLevelCalculationOutputsValidationQuery(NormativeNormType normType) { CalculationType calculationType = ConvertToDesignWaterLevelCalculationType(normType); @@ -1960,7 +1960,7 @@ /// Thrown when /// is an invalid value of . /// Thrown when is a valid value, - /// but is unsupported. + /// but unsupported public string GetMigratedWaveHeightCalculationsValidationQuery(NormativeNormType normType) { CalculationType calculationType = ConvertToWaveHeightCalculationType(normType); @@ -1995,8 +1995,8 @@ /// A query to validate the hydraulic boundary location calculation outputs. /// Thrown when /// is an invalid value of . - /// Thrown when is an unsupported value, - /// but is unsupported. + /// Thrown when is a valid value, + /// but unsupported public string GetMigratedWaveHeightCalculationOutputsValidationQuery(NormativeNormType normType) { CalculationType calculationType = ConvertToWaveHeightCalculationType(normType); @@ -2089,7 +2089,7 @@ /// Thrown when /// is an invalid value of . /// Thrown when is a valid value, - /// but is unsupported. + /// but unsupported private static CalculationType ConvertToDesignWaterLevelCalculationType(NormativeNormType normType) { if (!Enum.IsDefined(typeof(NormativeNormType), normType)) @@ -2116,7 +2116,7 @@ /// Thrown when /// is an invalid value of . /// Thrown when is a valid value, - /// but is unsupported. + /// but unsupported private static CalculationType ConvertToWaveHeightCalculationType(NormativeNormType normType) { if (!Enum.IsDefined(typeof(NormativeNormType), normType)) @@ -2155,7 +2155,7 @@ } /// - /// Class to generate queries which can be used if the wave conditions calculations + /// Class to generate queries which can be used to assert if the wave conditions calculations /// are correctly migrated. /// private class WaveConditionsCalculationValidationQueryGenerator @@ -2187,7 +2187,7 @@ /// Thrown when /// is an invalid value of . /// Thrown when is a valid value, - /// but is unsupported. + /// but unsupported public string GetGrassCoverErosionOutwardsCalculationValidationQuery(NormativeNormType normType) { FailureMechanismCategoryType categoryType = ConvertToFailureMechanismCategoryType(normType); @@ -2246,7 +2246,7 @@ /// Thrown when /// is an invalid value of . /// Thrown when is a valid value, - /// but is unsupported. + /// but unsupported public string GetStabilityStoneCoverCalculationValidationQuery(NormativeNormType normType) { AssessmentSectionCategoryType categoryType = ConvertToAssessmentSectionCategoryType(normType); @@ -2278,7 +2278,7 @@ /// Thrown when /// is an invalid value of . /// Thrown when is a valid value, - /// but is unsupported. + /// but unsupported public string GetWaveImpactAsphaltCoverCalculationValidationQuery(NormativeNormType normType) { AssessmentSectionCategoryType categoryType = ConvertToAssessmentSectionCategoryType(normType); @@ -2333,7 +2333,7 @@ /// Thrown when /// is an invalid value of . /// Thrown when is a valid value, - /// but is unsupported. + /// but unsupported private static FailureMechanismCategoryType ConvertToFailureMechanismCategoryType(NormativeNormType normType) { if (!Enum.IsDefined(typeof(NormativeNormType), normType)) @@ -2360,7 +2360,7 @@ /// Thrown when /// is an invalid value of . /// Thrown when is a valid value, - /// but is unsupported. + /// but unsupported private static AssessmentSectionCategoryType ConvertToAssessmentSectionCategoryType(NormativeNormType normType) { if (!Enum.IsDefined(typeof(NormativeNormType), normType)) Index: Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationCalculationCollectionEntityReadExtensionsTest.cs =================================================================== diff -u -r879d46016d425a19663a7dc1aea55613f6a4525f -r94a162cd5c8d44f206a2a0f5e30b1fa7d29395bc --- Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationCalculationCollectionEntityReadExtensionsTest.cs (.../DuneLocationCalculationCollectionEntityReadExtensionsTest.cs) (revision 879d46016d425a19663a7dc1aea55613f6a4525f) +++ Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationCalculationCollectionEntityReadExtensionsTest.cs (.../DuneLocationCalculationCollectionEntityReadExtensionsTest.cs) (revision 94a162cd5c8d44f206a2a0f5e30b1fa7d29395bc) @@ -89,7 +89,7 @@ var calculationEntityWithOutput = new DuneLocationCalculationEntity { DuneLocationEntity = duneLocationEntityTwo, - DuneLocationCalculationOutputEntities = + DuneLocationCalculationOutputEntities = { new DuneLocationCalculationOutputEntity() } @@ -114,7 +114,7 @@ var calculationTwo = new DuneLocationCalculation(duneLocationTwo); // Call - collectionEntity.Read(new [] + collectionEntity.Read(new[] { calculationOne, calculationTwo Index: Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationCalculationEntityReadExtensionsTest.cs =================================================================== diff -u -r879d46016d425a19663a7dc1aea55613f6a4525f -r94a162cd5c8d44f206a2a0f5e30b1fa7d29395bc --- Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationCalculationEntityReadExtensionsTest.cs (.../DuneLocationCalculationEntityReadExtensionsTest.cs) (revision 879d46016d425a19663a7dc1aea55613f6a4525f) +++ Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationCalculationEntityReadExtensionsTest.cs (.../DuneLocationCalculationEntityReadExtensionsTest.cs) (revision 94a162cd5c8d44f206a2a0f5e30b1fa7d29395bc) @@ -95,9 +95,9 @@ var entity = new DuneLocationCalculationEntity { - DuneLocationCalculationOutputEntities = + DuneLocationCalculationOutputEntities = { - new DuneLocationCalculationOutputEntity() + new DuneLocationCalculationOutputEntity { WaterLevel = waterLevel, WaveHeight = waveHeight, @@ -106,7 +106,7 @@ TargetReliability = targetReliability, CalculatedProbability = calculatedProbability, CalculatedReliability = calculatedReliability, - CalculationConvergence = (byte) convergence + CalculationConvergence = Convert.ToByte(convergence) } } }; Index: Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationCalculationOutputEntityReadExtensionsTest.cs =================================================================== diff -u -r879d46016d425a19663a7dc1aea55613f6a4525f -r94a162cd5c8d44f206a2a0f5e30b1fa7d29395bc --- Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationCalculationOutputEntityReadExtensionsTest.cs (.../DuneLocationCalculationOutputEntityReadExtensionsTest.cs) (revision 879d46016d425a19663a7dc1aea55613f6a4525f) +++ Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationCalculationOutputEntityReadExtensionsTest.cs (.../DuneLocationCalculationOutputEntityReadExtensionsTest.cs) (revision 94a162cd5c8d44f206a2a0f5e30b1fa7d29395bc) @@ -66,7 +66,7 @@ TargetReliability = targetReliability, CalculatedProbability = calculatedProbability, CalculatedReliability = calculatedReliability, - CalculationConvergence = (byte) convergence + CalculationConvergence = Convert.ToByte(convergence) }; // Call @@ -97,7 +97,7 @@ TargetReliability = null, CalculatedProbability = null, CalculatedReliability = null, - CalculationConvergence = (byte) convergence + CalculationConvergence = Convert.ToByte(convergence) }; // Call