Index: Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneLocationCalculationService.cs
===================================================================
diff -u -r8fa62efd9d2a32aef893660a60e8f7ac12fc78bf -r96adc990966e755e4cf8c140e2b1350a4da2ef63
--- Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneLocationCalculationService.cs (.../DuneLocationCalculationService.cs) (revision 8fa62efd9d2a32aef893660a60e8f7ac12fc78bf)
+++ Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneLocationCalculationService.cs (.../DuneLocationCalculationService.cs) (revision 96adc990966e755e4cf8c140e2b1350a4da2ef63)
@@ -53,7 +53,7 @@
/// The to perform.
/// The norm to use during the calculation.
/// The containing all data
- /// to perform a hydraulic boundary calculation.
+ /// to perform a hydraulic boundary calculation.
/// The object which is used to build log messages.
/// Preprocessing is disabled when the preprocessor directory equals .
/// Thrown when ,
Index: Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/GuiServices/DuneLocationCalculationGuiServiceTest.cs
===================================================================
diff -u -rd97f06dcf08df485826a196e31c05e811ab6dc67 -r96adc990966e755e4cf8c140e2b1350a4da2ef63
--- Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/GuiServices/DuneLocationCalculationGuiServiceTest.cs (.../DuneLocationCalculationGuiServiceTest.cs) (revision d97f06dcf08df485826a196e31c05e811ab6dc67)
+++ Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/GuiServices/DuneLocationCalculationGuiServiceTest.cs (.../DuneLocationCalculationGuiServiceTest.cs) (revision 96adc990966e755e4cf8c140e2b1350a4da2ef63)
@@ -227,9 +227,10 @@
calculatorFactory.Expect(cf => cf.CreateDunesBoundaryConditionsCalculator(Arg.Is.NotNull))
.WhenCalled(invocation =>
{
- var settings = (HydraRingCalculationSettings)invocation.Arguments[0];
- Assert.AreEqual(validFilePath, settings.HlcdFilePath);
- Assert.AreEqual(validPreprocessorDirectory, settings.PreprocessorDirectory);
+ var hydraRingCalculationSettings = (HydraRingCalculationSettings)invocation.Arguments[0];
+ HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings(
+ HydraulicBoundaryCalculationSettingsFactory.CreateSettings(hydraulicBoundaryDatabase),
+ hydraRingCalculationSettings);
})
.Return(new TestDunesBoundaryConditionsCalculator());
var assessmentSection = mockRepository.Stub();
Index: Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneLocationCalculationsViewTest.cs
===================================================================
diff -u -rd97f06dcf08df485826a196e31c05e811ab6dc67 -r96adc990966e755e4cf8c140e2b1350a4da2ef63
--- Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneLocationCalculationsViewTest.cs (.../DuneLocationCalculationsViewTest.cs) (revision d97f06dcf08df485826a196e31c05e811ab6dc67)
+++ Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneLocationCalculationsViewTest.cs (.../DuneLocationCalculationsViewTest.cs) (revision 96adc990966e755e4cf8c140e2b1350a4da2ef63)
@@ -458,11 +458,11 @@
calculatorFactory.Expect(cf => cf.CreateDunesBoundaryConditionsCalculator(Arg.Is.NotNull))
.WhenCalled(invocation =>
{
- var settings = (HydraRingCalculationSettings)invocation.Arguments[0];
+ var settings = (HydraRingCalculationSettings) invocation.Arguments[0];
Assert.AreEqual(hydraulicBoundaryDatabaseFilePath, settings.HlcdFilePath);
Assert.IsEmpty(settings.PreprocessorDirectory);
})
- .Return(new TestDunesBoundaryConditionsCalculator());
+ .Return(new TestDunesBoundaryConditionsCalculator());
mocks.ReplayAll();
IObservableEnumerable calculations = GenerateDuneLocationCalculations();
@@ -518,14 +518,9 @@
var calculationsObserver = mocks.StrictMock();
var calculatorFactory = mocks.StrictMock();
- calculatorFactory.Expect(cf => cf.CreateDunesBoundaryConditionsCalculator(Arg.Is.NotNull))
- .WhenCalled(invocation =>
- {
- var settings = (HydraRingCalculationSettings)invocation.Arguments[0];
- Assert.AreEqual(hydraulicBoundaryDatabaseFilePath, settings.HlcdFilePath);
- Assert.IsEmpty(settings.PreprocessorDirectory);
- })
- .Return(new TestDunesBoundaryConditionsCalculator());
+ calculatorFactory.Expect(cf => cf.CreateDunesBoundaryConditionsCalculator(null))
+ .IgnoreArguments()
+ .Return(new TestDunesBoundaryConditionsCalculator());
mocks.ReplayAll();
IObservableEnumerable calculations = GenerateDuneLocationCalculations();
@@ -630,14 +625,15 @@
{
// Setup
const double norm = 0.1;
+ var hydraulicBoundaryDatabase = new HydraulicBoundaryDatabase
+ {
+ FilePath = hydraulicBoundaryDatabaseFilePath
+ };
var assessmentSection = mocks.Stub();
assessmentSection.Stub(a => a.Id).Return("1");
assessmentSection.Stub(a => a.FailureMechanismContribution).Return(FailureMechanismContributionTestFactory.CreateFailureMechanismContribution());
- assessmentSection.Stub(a => a.HydraulicBoundaryDatabase).Return(new HydraulicBoundaryDatabase
- {
- FilePath = hydraulicBoundaryDatabaseFilePath
- });
+ assessmentSection.Stub(a => a.HydraulicBoundaryDatabase).Return(hydraulicBoundaryDatabase);
assessmentSection.Stub(a => a.Attach(null)).IgnoreArguments();
assessmentSection.Stub(a => a.Detach(null)).IgnoreArguments();
@@ -646,11 +642,12 @@
calculatorFactory.Expect(cf => cf.CreateDunesBoundaryConditionsCalculator(Arg.Is.NotNull))
.WhenCalled(invocation =>
{
- var settings = (HydraRingCalculationSettings)invocation.Arguments[0];
- Assert.AreEqual(hydraulicBoundaryDatabaseFilePath, settings.HlcdFilePath);
- Assert.IsEmpty(settings.PreprocessorDirectory);
+ var hydraRingCalculationSettings = (HydraRingCalculationSettings) invocation.Arguments[0];
+ HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings(
+ HydraulicBoundaryCalculationSettingsFactory.CreateSettings(hydraulicBoundaryDatabase),
+ hydraRingCalculationSettings);
})
- .Return(dunesBoundaryConditionsCalculator);
+ .Return(dunesBoundaryConditionsCalculator);
mocks.ReplayAll();
var failureMechanism = new DuneErosionFailureMechanism();
@@ -692,17 +689,18 @@
{
// Setup
const double norm = 0.1;
-
- var assessmentSection = mocks.Stub();
- assessmentSection.Stub(a => a.Id).Return("1");
- assessmentSection.Stub(a => a.FailureMechanismContribution).Return(FailureMechanismContributionTestFactory.CreateFailureMechanismContribution());
- assessmentSection.Stub(a => a.HydraulicBoundaryDatabase).Return(new HydraulicBoundaryDatabase
+ var hydraulicBoundaryDatabase = new HydraulicBoundaryDatabase
{
FilePath = hydraulicBoundaryDatabaseFilePath,
CanUsePreprocessor = true,
UsePreprocessor = true,
PreprocessorDirectory = validPreprocessorDirectory
- });
+ };
+
+ var assessmentSection = mocks.Stub();
+ assessmentSection.Stub(a => a.Id).Return("1");
+ assessmentSection.Stub(a => a.FailureMechanismContribution).Return(FailureMechanismContributionTestFactory.CreateFailureMechanismContribution());
+ assessmentSection.Stub(a => a.HydraulicBoundaryDatabase).Return(hydraulicBoundaryDatabase);
assessmentSection.Stub(a => a.Attach(null)).IgnoreArguments();
assessmentSection.Stub(a => a.Detach(null)).IgnoreArguments();
@@ -711,11 +709,12 @@
calculatorFactory.Expect(cf => cf.CreateDunesBoundaryConditionsCalculator(Arg.Is.NotNull))
.WhenCalled(invocation =>
{
- var settings = (HydraRingCalculationSettings)invocation.Arguments[0];
- Assert.AreEqual(hydraulicBoundaryDatabaseFilePath, settings.HlcdFilePath);
- Assert.AreEqual(validPreprocessorDirectory, settings.PreprocessorDirectory);
+ var hydraRingCalculationSettings = (HydraRingCalculationSettings) invocation.Arguments[0];
+ HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings(
+ HydraulicBoundaryCalculationSettingsFactory.CreateSettings(hydraulicBoundaryDatabase),
+ hydraRingCalculationSettings);
})
- .Return(dunesBoundaryConditionsCalculator);
+ .Return(dunesBoundaryConditionsCalculator);
mocks.ReplayAll();
var failureMechanism = new DuneErosionFailureMechanism();
@@ -757,19 +756,19 @@
{
// Setup
const double norm = 0.1;
-
- var assessmentSection = mocks.Stub();
- assessmentSection.Stub(a => a.Id).Return("1");
- assessmentSection.Stub(a => a.FailureMechanismContribution)
- .Return(FailureMechanismContributionTestFactory.CreateFailureMechanismContribution());
-
- assessmentSection.Stub(a => a.HydraulicBoundaryDatabase).Return(new HydraulicBoundaryDatabase
+ var hydraulicBoundaryDatabase = new HydraulicBoundaryDatabase
{
FilePath = hydraulicBoundaryDatabaseFilePath,
CanUsePreprocessor = true,
UsePreprocessor = false,
PreprocessorDirectory = "InvalidPreprocessorDirectory"
- });
+ };
+
+ var assessmentSection = mocks.Stub();
+ assessmentSection.Stub(a => a.Id).Return("1");
+ assessmentSection.Stub(a => a.FailureMechanismContribution)
+ .Return(FailureMechanismContributionTestFactory.CreateFailureMechanismContribution());
+ assessmentSection.Stub(a => a.HydraulicBoundaryDatabase).Return(hydraulicBoundaryDatabase);
assessmentSection.Stub(a => a.Attach(null)).IgnoreArguments();
assessmentSection.Stub(a => a.Detach(null)).IgnoreArguments();
@@ -778,11 +777,12 @@
calculatorFactory.Expect(cf => cf.CreateDunesBoundaryConditionsCalculator(Arg.Is.NotNull))
.WhenCalled(invocation =>
{
- var settings = (HydraRingCalculationSettings)invocation.Arguments[0];
- Assert.AreEqual(hydraulicBoundaryDatabaseFilePath, settings.HlcdFilePath);
- Assert.IsEmpty(settings.PreprocessorDirectory);
+ var hydraRingCalculationSettings = (HydraRingCalculationSettings) invocation.Arguments[0];
+ HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings(
+ HydraulicBoundaryCalculationSettingsFactory.CreateSettings(hydraulicBoundaryDatabase),
+ hydraRingCalculationSettings);
})
- .Return(dunesBoundaryConditionsCalculator);
+ .Return(dunesBoundaryConditionsCalculator);
mocks.ReplayAll();
var failureMechanism = new DuneErosionFailureMechanism();
Index: Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/TreeNodeInfos/DuneErosionFailureMechanismContextTreeNodeInfoTest.cs
===================================================================
diff -u -rd97f06dcf08df485826a196e31c05e811ab6dc67 -r96adc990966e755e4cf8c140e2b1350a4da2ef63
--- Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/TreeNodeInfos/DuneErosionFailureMechanismContextTreeNodeInfoTest.cs (.../DuneErosionFailureMechanismContextTreeNodeInfoTest.cs) (revision d97f06dcf08df485826a196e31c05e811ab6dc67)
+++ Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/TreeNodeInfos/DuneErosionFailureMechanismContextTreeNodeInfoTest.cs (.../DuneErosionFailureMechanismContextTreeNodeInfoTest.cs) (revision 96adc990966e755e4cf8c140e2b1350a4da2ef63)
@@ -38,9 +38,11 @@
using Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Calculators.Categories;
using Ringtoets.Common.Data;
using Ringtoets.Common.Data.AssessmentSection;
+using Ringtoets.Common.Data.Hydraulics;
using Ringtoets.Common.Data.TestUtil;
using Ringtoets.Common.Forms.PresentationObjects;
using Ringtoets.Common.Plugin.TestUtil;
+using Ringtoets.Common.Service.TestUtil;
using Ringtoets.DuneErosion.Data;
using Ringtoets.DuneErosion.Data.TestUtil;
using Ringtoets.DuneErosion.Forms.PresentationObjects;
@@ -531,12 +533,12 @@
calculatorFactory.Expect(cf => cf.CreateDunesBoundaryConditionsCalculator(Arg.Is.NotNull))
.WhenCalled(invocation =>
{
- var settings = (HydraRingCalculationSettings)invocation.Arguments[0];
- Assert.AreEqual(assessmentSection.HydraulicBoundaryDatabase.FilePath,
- settings.HlcdFilePath);
- Assert.IsEmpty(settings.PreprocessorDirectory);
+ var hydraRingCalculationSettings = (HydraRingCalculationSettings) invocation.Arguments[0];
+ HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings(
+ HydraulicBoundaryCalculationSettingsFactory.CreateSettings(assessmentSection.HydraulicBoundaryDatabase),
+ hydraRingCalculationSettings);
})
- .Return(dunesBoundaryConditionsCalculator).Repeat.Times(5);
+ .Return(dunesBoundaryConditionsCalculator).Repeat.Times(5);
mocksRepository.ReplayAll();
plugin.Gui = gui;
Index: Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/TreeNodeInfos/DuneLocationCalculationsContextTreeNodeInfoTest.cs
===================================================================
diff -u -rd97f06dcf08df485826a196e31c05e811ab6dc67 -r96adc990966e755e4cf8c140e2b1350a4da2ef63
--- Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/TreeNodeInfos/DuneLocationCalculationsContextTreeNodeInfoTest.cs (.../DuneLocationCalculationsContextTreeNodeInfoTest.cs) (revision d97f06dcf08df485826a196e31c05e811ab6dc67)
+++ Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/TreeNodeInfos/DuneLocationCalculationsContextTreeNodeInfoTest.cs (.../DuneLocationCalculationsContextTreeNodeInfoTest.cs) (revision 96adc990966e755e4cf8c140e2b1350a4da2ef63)
@@ -400,13 +400,8 @@
int nrOfCalculators = duneLocationCalculations.Count;
var calculatorFactory = mocks.Stub();
- calculatorFactory.Expect(cf => cf.CreateDunesBoundaryConditionsCalculator(Arg.Is.NotNull))
- .WhenCalled(invocation =>
- {
- var settings = (HydraRingCalculationSettings) invocation.Arguments[0];
- Assert.AreEqual(validFilePath, settings.HlcdFilePath);
- Assert.IsEmpty(settings.PreprocessorDirectory);
- })
+ calculatorFactory.Expect(cf => cf.CreateDunesBoundaryConditionsCalculator(null))
+ .IgnoreArguments()
.Return(new TestDunesBoundaryConditionsCalculator())
.Repeat
.Times(nrOfCalculators);
@@ -455,9 +450,6 @@
{
// Setup
const double norm = 0.01;
-
- string validFilePath = Path.Combine(testDataPath, "complete.sqlite");
-
var duneLocationCalculations = new ObservableList
{
new DuneLocationCalculation(new DuneLocation(1300001, "A", new Point2D(0, 0), new DuneLocation.ConstructionProperties
@@ -476,10 +468,11 @@
var assessmentSection = mocks.Stub();
- assessmentSection.Stub(a => a.HydraulicBoundaryDatabase).Return(new HydraulicBoundaryDatabase
+ var hydraulicBoundaryDatabase = new HydraulicBoundaryDatabase
{
- FilePath = validFilePath
- });
+ FilePath = Path.Combine(testDataPath, "complete.sqlite")
+ };
+ assessmentSection.Stub(a => a.HydraulicBoundaryDatabase).Return(hydraulicBoundaryDatabase);
assessmentSection.Stub(a => a.Id).Return("13-1");
assessmentSection.Stub(a => a.GetFailureMechanisms()).Return(new[]
{
@@ -505,12 +498,12 @@
calculatorFactory.Expect(cf => cf.CreateDunesBoundaryConditionsCalculator(Arg.Is.NotNull))
.WhenCalled(invocation =>
{
- var settings = (HydraRingCalculationSettings) invocation.Arguments[0];
- Assert.AreEqual(validFilePath, settings.HlcdFilePath);
- Assert.IsEmpty(settings.PreprocessorDirectory);
+ var hydraRingCalculationSettings = (HydraRingCalculationSettings) invocation.Arguments[0];
+ HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings(
+ HydraulicBoundaryCalculationSettingsFactory.CreateSettings(hydraulicBoundaryDatabase),
+ hydraRingCalculationSettings);
})
.Return(dunesBoundaryConditionsCalculator);
-
mocks.ReplayAll();
plugin.Gui = gui;
@@ -536,7 +529,6 @@
{
// Setup
const double norm = 0.01;
- string validFilePath = Path.Combine(testDataPath, "complete.sqlite");
string preprocessorDirectory = TestHelper.GetScratchPadPath();
var duneLocationCalculations = new ObservableList
@@ -557,13 +549,14 @@
var assessmentSection = mocks.Stub();
- assessmentSection.Stub(a => a.HydraulicBoundaryDatabase).Return(new HydraulicBoundaryDatabase
+ var hydraulicBoundaryDatabase = new HydraulicBoundaryDatabase
{
- FilePath = validFilePath,
+ FilePath = Path.Combine(testDataPath, "complete.sqlite"),
CanUsePreprocessor = true,
UsePreprocessor = true,
PreprocessorDirectory = preprocessorDirectory
- });
+ };
+ assessmentSection.Stub(a => a.HydraulicBoundaryDatabase).Return(hydraulicBoundaryDatabase);
assessmentSection.Stub(a => a.Id).Return("13-1");
assessmentSection.Stub(a => a.GetFailureMechanisms()).Return(new[]
{
@@ -589,9 +582,10 @@
calculatorFactory.Expect(cf => cf.CreateDunesBoundaryConditionsCalculator(Arg.Is.NotNull))
.WhenCalled(invocation =>
{
- var settings = (HydraRingCalculationSettings) invocation.Arguments[0];
- Assert.AreEqual(validFilePath, settings.HlcdFilePath);
- Assert.AreEqual(preprocessorDirectory, settings.PreprocessorDirectory);
+ var hydraRingCalculationSettings = (HydraRingCalculationSettings) invocation.Arguments[0];
+ HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings(
+ HydraulicBoundaryCalculationSettingsFactory.CreateSettings(hydraulicBoundaryDatabase),
+ hydraRingCalculationSettings);
})
.Return(dunesBoundaryConditionsCalculator);
@@ -640,13 +634,14 @@
var assessmentSection = mocks.Stub();
- assessmentSection.Stub(a => a.HydraulicBoundaryDatabase).Return(new HydraulicBoundaryDatabase
+ var hydraulicBoundaryDatabase = new HydraulicBoundaryDatabase
{
FilePath = validFilePath,
CanUsePreprocessor = true,
UsePreprocessor = false,
PreprocessorDirectory = "InvalidPreprocessorDirectory"
- });
+ };
+ assessmentSection.Stub(a => a.HydraulicBoundaryDatabase).Return(hydraulicBoundaryDatabase);
assessmentSection.Stub(a => a.Id).Return("13-1");
assessmentSection.Stub(a => a.GetFailureMechanisms()).Return(new[]
{
@@ -672,9 +667,10 @@
calculatorFactory.Expect(cf => cf.CreateDunesBoundaryConditionsCalculator(Arg.Is.NotNull))
.WhenCalled(invocation =>
{
- var settings = (HydraRingCalculationSettings) invocation.Arguments[0];
- Assert.AreEqual(validFilePath, settings.HlcdFilePath);
- Assert.IsEmpty(settings.PreprocessorDirectory);
+ var hydraRingCalculationSettings = (HydraRingCalculationSettings) invocation.Arguments[0];
+ HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings(
+ HydraulicBoundaryCalculationSettingsFactory.CreateSettings(hydraulicBoundaryDatabase),
+ hydraRingCalculationSettings);
})
.Return(dunesBoundaryConditionsCalculator);
Index: Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/TreeNodeInfos/DuneLocationCalculationsGroupContextTreeNodeInfoTest.cs
===================================================================
diff -u -rd97f06dcf08df485826a196e31c05e811ab6dc67 -r96adc990966e755e4cf8c140e2b1350a4da2ef63
--- Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/TreeNodeInfos/DuneLocationCalculationsGroupContextTreeNodeInfoTest.cs (.../DuneLocationCalculationsGroupContextTreeNodeInfoTest.cs) (revision d97f06dcf08df485826a196e31c05e811ab6dc67)
+++ Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/TreeNodeInfos/DuneLocationCalculationsGroupContextTreeNodeInfoTest.cs (.../DuneLocationCalculationsGroupContextTreeNodeInfoTest.cs) (revision 96adc990966e755e4cf8c140e2b1350a4da2ef63)
@@ -35,8 +35,10 @@
using NUnit.Framework;
using Rhino.Mocks;
using Ringtoets.Common.Data.AssessmentSection;
+using Ringtoets.Common.Data.Hydraulics;
using Ringtoets.Common.Data.TestUtil;
using Ringtoets.Common.Plugin.TestUtil;
+using Ringtoets.Common.Service.TestUtil;
using Ringtoets.DuneErosion.Data;
using Ringtoets.DuneErosion.Data.TestUtil;
using Ringtoets.DuneErosion.Forms.PresentationObjects;
@@ -445,11 +447,12 @@
calculatorFactory.Expect(cf => cf.CreateDunesBoundaryConditionsCalculator(Arg.Is.NotNull))
.WhenCalled(invocation =>
{
- var settings = (HydraRingCalculationSettings)invocation.Arguments[0];
- Assert.AreEqual(validFilePath, settings.HlcdFilePath);
- Assert.IsEmpty(settings.PreprocessorDirectory);
+ var hydraRingCalculationSettings = (HydraRingCalculationSettings) invocation.Arguments[0];
+ HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings(
+ HydraulicBoundaryCalculationSettingsFactory.CreateSettings(assessmentSection.HydraulicBoundaryDatabase),
+ hydraRingCalculationSettings);
})
- .Return(dunesBoundaryConditionsCalculator).Repeat.Times(5);
+ .Return(dunesBoundaryConditionsCalculator).Repeat.Times(5);
mocks.ReplayAll();
using (var plugin = new DuneErosionPlugin())