Index: Riskeer/GrassCoverErosionInwards/src/Riskeer.GrassCoverErosionInwards.Forms/PropertyClasses/GrassCoverErosionInwardsCalculationsProperties.cs =================================================================== diff -u -r79378656df68fb71e15e1511f3c5071ace38f857 -ra0a47e24c45537d82a6d1c7c3b402b1554b90b76 --- Riskeer/GrassCoverErosionInwards/src/Riskeer.GrassCoverErosionInwards.Forms/PropertyClasses/GrassCoverErosionInwardsCalculationsProperties.cs (.../GrassCoverErosionInwardsCalculationsProperties.cs) (revision 79378656df68fb71e15e1511f3c5071ace38f857) +++ Riskeer/GrassCoverErosionInwards/src/Riskeer.GrassCoverErosionInwards.Forms/PropertyClasses/GrassCoverErosionInwardsCalculationsProperties.cs (.../GrassCoverErosionInwardsCalculationsProperties.cs) (revision a0a47e24c45537d82a6d1c7c3b402b1554b90b76) @@ -53,7 +53,7 @@ /// /// The instance to show the properties of. /// Handler responsible for handling effects of a property change. - /// Thrown when any input parameter is null. + /// Thrown when any parameter is null. public GrassCoverErosionInwardsCalculationsProperties( GrassCoverErosionInwardsFailureMechanism data, IFailureMechanismPropertyChangeHandler handler) : base(data, new ConstructionProperties Index: Riskeer/GrassCoverErosionInwards/test/Riskeer.GrassCoverErosionInwards.Forms.Test/PropertyClasses/GrassCoverErosionInwardsCalculationsPropertiesTest.cs =================================================================== diff -u -rf4a45a11e173eabd485d2bb1727c28a3d07a18d1 -ra0a47e24c45537d82a6d1c7c3b402b1554b90b76 --- Riskeer/GrassCoverErosionInwards/test/Riskeer.GrassCoverErosionInwards.Forms.Test/PropertyClasses/GrassCoverErosionInwardsCalculationsPropertiesTest.cs (.../GrassCoverErosionInwardsCalculationsPropertiesTest.cs) (revision f4a45a11e173eabd485d2bb1727c28a3d07a18d1) +++ Riskeer/GrassCoverErosionInwards/test/Riskeer.GrassCoverErosionInwards.Forms.Test/PropertyClasses/GrassCoverErosionInwardsCalculationsPropertiesTest.cs (.../GrassCoverErosionInwardsCalculationsPropertiesTest.cs) (revision a0a47e24c45537d82a6d1c7c3b402b1554b90b76) @@ -56,33 +56,6 @@ } [Test] - public void Constructor_DataIsNull_ThrowArgumentNullException() - { - // Setup - var handler = mocks.Stub>(); - mocks.ReplayAll(); - - // Call - void Call() => new GrassCoverErosionInwardsCalculationsProperties(null, handler); - - // Assert - string paramName = Assert.Throws(Call).ParamName; - Assert.AreEqual("data", paramName); - mocks.VerifyAll(); - } - - [Test] - public void Constructor_ChangeHandlerIsNull_ThrowArgumentNullException() - { - // Call - void Call() => new GrassCoverErosionInwardsCalculationsProperties(new GrassCoverErosionInwardsFailureMechanism(), null); - - // Assert - string paramName = Assert.Throws(Call).ParamName; - Assert.AreEqual("handler", paramName); - } - - [Test] public void Constructor_ExpectedValues() { // Setup @@ -102,8 +75,9 @@ Assert.AreEqual(failureMechanism.Group, properties.Group); Assert.AreEqual(failureMechanism.Contribution, properties.Contribution); - var generalInput = new GeneralGrassCoverErosionInwardsInput(); + GeneralGrassCoverErosionInwardsInput generalInput = failureMechanism.GeneralInput; + Assert.AreEqual(2, properties.N.NumberOfDecimalPlaces); Assert.AreEqual(generalInput.N, properties.N, properties.N.GetAccuracy()); Assert.AreEqual(generalInput.FbFactor.Mean, properties.FbFactor.Mean); @@ -224,6 +198,7 @@ mocks.ReplayAll(); var failureMechanism = new GrassCoverErosionInwardsFailureMechanism(); + var changeHandler = new FailureMechanismSetPropertyValueAfterConfirmationParameterTester( failureMechanism, newN, @@ -249,7 +224,9 @@ [Test] [TestCase(1.0)] + [TestCase(1.0000001)] [TestCase(10.0)] + [TestCase(19.9999999)] [TestCase(20.0)] public void N_SetValidValue_UpdateDataAndNotifyObservers(double newN) { @@ -259,6 +236,7 @@ mocks.ReplayAll(); var failureMechanism = new GrassCoverErosionInwardsFailureMechanism(); + var changeHandler = new FailureMechanismSetPropertyValueAfterConfirmationParameterTester( failureMechanism, newN, Index: Riskeer/GrassCoverErosionInwards/test/Riskeer.GrassCoverErosionInwards.Forms.Test/PropertyClasses/GrassCoverErosionInwardsFailureMechanismPropertiesTest.cs =================================================================== diff -u -rf4a45a11e173eabd485d2bb1727c28a3d07a18d1 -ra0a47e24c45537d82a6d1c7c3b402b1554b90b76 --- Riskeer/GrassCoverErosionInwards/test/Riskeer.GrassCoverErosionInwards.Forms.Test/PropertyClasses/GrassCoverErosionInwardsFailureMechanismPropertiesTest.cs (.../GrassCoverErosionInwardsFailureMechanismPropertiesTest.cs) (revision f4a45a11e173eabd485d2bb1727c28a3d07a18d1) +++ Riskeer/GrassCoverErosionInwards/test/Riskeer.GrassCoverErosionInwards.Forms.Test/PropertyClasses/GrassCoverErosionInwardsFailureMechanismPropertiesTest.cs (.../GrassCoverErosionInwardsFailureMechanismPropertiesTest.cs) (revision a0a47e24c45537d82a6d1c7c3b402b1554b90b76) @@ -85,7 +85,7 @@ } [Test] - public void Constructor_HandlerNull_ThrowsArgumentNullException() + public void Constructor_ChangeHandlerNull_ThrowsArgumentNullException() { // Call void Call() => new GrassCoverErosionInwardsFailureMechanismProperties(new GrassCoverErosionInwardsFailureMechanism(), new GrassCoverErosionInwardsFailureMechanismProperties.ConstructionProperties(), null); @@ -222,7 +222,9 @@ [Test] [TestCase(1.0)] + [TestCase(1.0000001)] [TestCase(10.0)] + [TestCase(19.9999999)] [TestCase(20.0)] public void N_SetValidValue_UpdateDataAndNotifyObservers(double newN) { Index: Riskeer/GrassCoverErosionInwards/test/Riskeer.GrassCoverErosionInwards.Forms.Test/PropertyClasses/GrassCoverErosionInwardsFailurePathPropertiesTest.cs =================================================================== diff -u -re2cba843b032cb2c87af83354f7ebd41e3b03027 -ra0a47e24c45537d82a6d1c7c3b402b1554b90b76 --- Riskeer/GrassCoverErosionInwards/test/Riskeer.GrassCoverErosionInwards.Forms.Test/PropertyClasses/GrassCoverErosionInwardsFailurePathPropertiesTest.cs (.../GrassCoverErosionInwardsFailurePathPropertiesTest.cs) (revision e2cba843b032cb2c87af83354f7ebd41e3b03027) +++ Riskeer/GrassCoverErosionInwards/test/Riskeer.GrassCoverErosionInwards.Forms.Test/PropertyClasses/GrassCoverErosionInwardsFailurePathPropertiesTest.cs (.../GrassCoverErosionInwardsFailurePathPropertiesTest.cs) (revision a0a47e24c45537d82a6d1c7c3b402b1554b90b76) @@ -64,14 +64,14 @@ public void Constructor_ExpectedValues(bool isRelevant) { // Setup + var handler = mocks.Stub>(); + mocks.ReplayAll(); + var failureMechanism = new GrassCoverErosionInwardsFailureMechanism { IsRelevant = isRelevant }; - var handler = mocks.Stub>(); - mocks.ReplayAll(); - // Call var properties = new GrassCoverErosionInwardsFailurePathProperties(failureMechanism, handler); @@ -236,9 +236,11 @@ } [Test] - [TestCase(1)] - [TestCase(10)] - [TestCase(20)] + [TestCase(1.0)] + [TestCase(1.0000001)] + [TestCase(10.0)] + [TestCase(19.9999999)] + [TestCase(20.0)] public void N_SetValidValue_UpdateDataAndNotifyObservers(double newN) { // Setup