Index: Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/Views/HeightStructuresFailureMechanismSectionResultRow.cs =================================================================== diff -u -r4613f112c78c8a1ea1c69d07a0e08e5a69b3689e -ra2405640a09a0b6df9457c317ab921a8dd7877fa --- Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/Views/HeightStructuresFailureMechanismSectionResultRow.cs (.../HeightStructuresFailureMechanismSectionResultRow.cs) (revision 4613f112c78c8a1ea1c69d07a0e08e5a69b3689e) +++ Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/Views/HeightStructuresFailureMechanismSectionResultRow.cs (.../HeightStructuresFailureMechanismSectionResultRow.cs) (revision a2405640a09a0b6df9457c317ab921a8dd7877fa) @@ -203,7 +203,7 @@ { get { - return FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(simpleAssemblyCategoryGroup); + return FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(simpleAssemblyCategoryGroup); } } @@ -214,7 +214,7 @@ { get { - return FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(detailedAssemblyCategoryGroup); + return FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(detailedAssemblyCategoryGroup); } } @@ -225,7 +225,7 @@ { get { - return FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(tailorMadeAssemblyCategoryGroup); + return FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(tailorMadeAssemblyCategoryGroup); } } @@ -236,7 +236,7 @@ { get { - return FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(combinedAssemblyCategoryGroup); + return FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(combinedAssemblyCategoryGroup); } } Index: Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.IO/Configurations/HeightStructuresCalculationConfigurationImporter.cs =================================================================== diff -u -rfd9e1dd4f143af493965eea4d564c087081fb7f7 -ra2405640a09a0b6df9457c317ab921a8dd7877fa --- Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.IO/Configurations/HeightStructuresCalculationConfigurationImporter.cs (.../HeightStructuresCalculationConfigurationImporter.cs) (revision fd9e1dd4f143af493965eea4d564c087081fb7f7) +++ Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.IO/Configurations/HeightStructuresCalculationConfigurationImporter.cs (.../HeightStructuresCalculationConfigurationImporter.cs) (revision a2405640a09a0b6df9457c317ab921a8dd7877fa) @@ -107,24 +107,24 @@ return new HeightStructuresCalculationConfigurationReader(xmlFilePath); } - protected override ICalculation ParseReadCalculation(HeightStructuresCalculationConfiguration readCalculation) + protected override ICalculation ParseReadCalculation(HeightStructuresCalculationConfiguration calculationConfiguration) { var calculation = new StructuresCalculation { - Name = readCalculation.Name + Name = calculationConfiguration.Name }; - if (TrySetStructure(readCalculation.StructureId, calculation) - && TrySetHydraulicBoundaryLocation(readCalculation.HydraulicBoundaryLocationName, calculation) - && TrySetForeshoreProfile(readCalculation.ForeshoreProfileId, calculation) - && TrySetStochasts(readCalculation, calculation) - && TrySetOrientation(readCalculation, calculation) - && TrySetFailureProbabilityStructureWithErosion(readCalculation, calculation) - && readCalculation.WaveReduction.ValidateWaveReduction(calculation.InputParameters.ForeshoreProfile, + if (TrySetStructure(calculationConfiguration.StructureId, calculation) + && TrySetHydraulicBoundaryLocation(calculationConfiguration.HydraulicBoundaryLocationName, calculation) + && TrySetForeshoreProfile(calculationConfiguration.ForeshoreProfileId, calculation) + && TrySetStochasts(calculationConfiguration, calculation) + && TrySetOrientation(calculationConfiguration, calculation) + && TrySetFailureProbabilityStructureWithErosion(calculationConfiguration, calculation) + && calculationConfiguration.WaveReduction.ValidateWaveReduction(calculation.InputParameters.ForeshoreProfile, calculation.Name, Log)) { - SetWaveReductionParameters(readCalculation.WaveReduction, calculation.InputParameters); - SetShouldIllustrationPointsBeCalculated(readCalculation, calculation); + SetWaveReductionParameters(calculationConfiguration.WaveReduction, calculation.InputParameters); + SetShouldIllustrationPointsBeCalculated(calculationConfiguration, calculation); return calculation; } Index: Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.IO/Configurations/HeightStructuresCalculationStochastAssigner.cs =================================================================== diff -u -r4bf59bb3506b840b284efe0c0f4431b7876e0e5b -ra2405640a09a0b6df9457c317ab921a8dd7877fa --- Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.IO/Configurations/HeightStructuresCalculationStochastAssigner.cs (.../HeightStructuresCalculationStochastAssigner.cs) (revision 4bf59bb3506b840b284efe0c0f4431b7876e0e5b) +++ Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.IO/Configurations/HeightStructuresCalculationStochastAssigner.cs (.../HeightStructuresCalculationStochastAssigner.cs) (revision a2405640a09a0b6df9457c317ab921a8dd7877fa) @@ -43,7 +43,7 @@ StructuresCalculation calculation) : base(configuration, calculation) {} - protected override IEnumerable GetStandardDeviationStochasts(bool onlyStructureDependent = false) + protected override IEnumerable GetStandardDeviationStochasts(bool structureDependent = false) { yield return new StandardDeviationDefinition( HeightStructuresConfigurationSchemaIdentifiers.LevelCrestStructureStochastName, @@ -69,7 +69,7 @@ i => i.WidthFlowApertures, (i, d) => i.WidthFlowApertures = (NormalDistribution) d); - if (!onlyStructureDependent) + if (!structureDependent) { yield return new StandardDeviationDefinition( ConfigurationSchemaIdentifiers.ModelFactorSuperCriticalFlowStochastName, @@ -79,7 +79,7 @@ } } - protected override IEnumerable GetVariationCoefficientStochasts(bool onlyStructureDependent = false) + protected override IEnumerable GetVariationCoefficientStochasts(bool structureDependent = false) { yield return new VariationCoefficientDefinition( ConfigurationSchemaIdentifiers.CriticalOvertoppingDischargeStochastName, @@ -93,7 +93,7 @@ i => i.StorageStructureArea, (i, d) => i.StorageStructureArea = (VariationCoefficientLogNormalDistribution) d); - if (!onlyStructureDependent) + if (!structureDependent) { yield return new VariationCoefficientDefinition( ConfigurationSchemaIdentifiers.StormDurationStochastName, Index: Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/Views/HeightStructuresFailureMechanismSectionResultRowTest.cs =================================================================== diff -u -r37d015e59a004f7deb5f1a9657016bd9c13c6539 -ra2405640a09a0b6df9457c317ab921a8dd7877fa --- Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/Views/HeightStructuresFailureMechanismSectionResultRowTest.cs (.../HeightStructuresFailureMechanismSectionResultRowTest.cs) (revision 37d015e59a004f7deb5f1a9657016bd9c13c6539) +++ Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/Views/HeightStructuresFailureMechanismSectionResultRowTest.cs (.../HeightStructuresFailureMechanismSectionResultRowTest.cs) (revision a2405640a09a0b6df9457c317ab921a8dd7877fa) @@ -322,13 +322,13 @@ ConstructionProperties); // Precondition - Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(calculator.SimpleAssessmentAssemblyOutput.Group), + Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(calculator.SimpleAssessmentAssemblyOutput.Group), row.SimpleAssemblyCategoryGroup); - Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(calculator.DetailedAssessmentAssemblyOutput.Group), + Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(calculator.DetailedAssessmentAssemblyOutput.Group), row.DetailedAssemblyCategoryGroup); - Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(calculator.TailorMadeAssessmentAssemblyOutput.Group), + Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(calculator.TailorMadeAssessmentAssemblyOutput.Group), row.TailorMadeAssemblyCategoryGroup); - Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(calculator.CombinedAssemblyOutput.Group), + Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(calculator.CombinedAssemblyOutput.Group), row.CombinedAssemblyCategoryGroup); Assert.AreEqual(calculator.CombinedAssemblyOutput.Probability, row.CombinedAssemblyProbability); @@ -337,13 +337,13 @@ row.SimpleAssessmentResult = SimpleAssessmentResultType.AssessFurther; // Then - Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(FailureMechanismSectionAssemblyCategoryGroup.None), + Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(FailureMechanismSectionAssemblyCategoryGroup.None), row.SimpleAssemblyCategoryGroup); - Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(FailureMechanismSectionAssemblyCategoryGroup.None), + Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(FailureMechanismSectionAssemblyCategoryGroup.None), row.DetailedAssemblyCategoryGroup); - Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(FailureMechanismSectionAssemblyCategoryGroup.None), + Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(FailureMechanismSectionAssemblyCategoryGroup.None), row.TailorMadeAssemblyCategoryGroup); - Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(FailureMechanismSectionAssemblyCategoryGroup.None), + Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(FailureMechanismSectionAssemblyCategoryGroup.None), row.CombinedAssemblyCategoryGroup); Assert.IsNaN(row.CombinedAssemblyProbability); Index: Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Forms/Views/StabilityPointStructuresFailureMechanismSectionResultRow.cs =================================================================== diff -u -r4613f112c78c8a1ea1c69d07a0e08e5a69b3689e -ra2405640a09a0b6df9457c317ab921a8dd7877fa --- Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Forms/Views/StabilityPointStructuresFailureMechanismSectionResultRow.cs (.../StabilityPointStructuresFailureMechanismSectionResultRow.cs) (revision 4613f112c78c8a1ea1c69d07a0e08e5a69b3689e) +++ Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Forms/Views/StabilityPointStructuresFailureMechanismSectionResultRow.cs (.../StabilityPointStructuresFailureMechanismSectionResultRow.cs) (revision a2405640a09a0b6df9457c317ab921a8dd7877fa) @@ -206,7 +206,7 @@ { get { - return FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(simpleAssemblyCategoryGroup); + return FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(simpleAssemblyCategoryGroup); } } @@ -217,7 +217,7 @@ { get { - return FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(detailedAssemblyCategoryGroup); + return FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(detailedAssemblyCategoryGroup); } } @@ -228,7 +228,7 @@ { get { - return FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(tailorMadeAssemblyCategoryGroup); + return FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(tailorMadeAssemblyCategoryGroup); } } @@ -239,7 +239,7 @@ { get { - return FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(combinedAssemblyCategoryGroup); + return FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(combinedAssemblyCategoryGroup); } } Index: Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.IO/Configurations/StabilityPointStructuresCalculationConfigurationImporter.cs =================================================================== diff -u -r951c6fb790f3ea3e0a89771b62ad323967746455 -ra2405640a09a0b6df9457c317ab921a8dd7877fa --- Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.IO/Configurations/StabilityPointStructuresCalculationConfigurationImporter.cs (.../StabilityPointStructuresCalculationConfigurationImporter.cs) (revision 951c6fb790f3ea3e0a89771b62ad323967746455) +++ Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.IO/Configurations/StabilityPointStructuresCalculationConfigurationImporter.cs (.../StabilityPointStructuresCalculationConfigurationImporter.cs) (revision a2405640a09a0b6df9457c317ab921a8dd7877fa) @@ -112,32 +112,32 @@ return new StabilityPointStructuresCalculationConfigurationReader(xmlFilePath); } - protected override ICalculation ParseReadCalculation(StabilityPointStructuresCalculationConfiguration readCalculation) + protected override ICalculation ParseReadCalculation(StabilityPointStructuresCalculationConfiguration calculationConfiguration) { var calculation = new StructuresCalculation { - Name = readCalculation.Name + Name = calculationConfiguration.Name }; - if (TrySetStructure(readCalculation.StructureId, calculation) - && TrySetHydraulicBoundaryLocation(readCalculation.HydraulicBoundaryLocationName, calculation) - && TrySetForeshoreProfile(readCalculation.ForeshoreProfileId, calculation) - && TrySetEvaluationLevel(readCalculation, calculation) - && TrySetFailureProbabilityRepairClosure(readCalculation, calculation) - && TrySetFailureProbabilityStructureWithErosion(readCalculation, calculation) - && TrySetInflowModelType(readCalculation, calculation) - && TrySetLevellingCount(readCalculation, calculation) - && TrySetLoadSchematizationType(readCalculation, calculation) - && TrySetProbabilityCollisionSecondaryStructure(readCalculation, calculation) - && TrySetStochasts(readCalculation, calculation) - && TrySetStructureNormalOrientation(readCalculation, calculation) - && TrySetVerticalDistance(readCalculation, calculation) - && readCalculation.WaveReduction.ValidateWaveReduction(calculation.InputParameters.ForeshoreProfile, calculation.Name, Log)) + if (TrySetStructure(calculationConfiguration.StructureId, calculation) + && TrySetHydraulicBoundaryLocation(calculationConfiguration.HydraulicBoundaryLocationName, calculation) + && TrySetForeshoreProfile(calculationConfiguration.ForeshoreProfileId, calculation) + && TrySetEvaluationLevel(calculationConfiguration, calculation) + && TrySetFailureProbabilityRepairClosure(calculationConfiguration, calculation) + && TrySetFailureProbabilityStructureWithErosion(calculationConfiguration, calculation) + && TrySetInflowModelType(calculationConfiguration, calculation) + && TrySetLevellingCount(calculationConfiguration, calculation) + && TrySetLoadSchematizationType(calculationConfiguration, calculation) + && TrySetProbabilityCollisionSecondaryStructure(calculationConfiguration, calculation) + && TrySetStochasts(calculationConfiguration, calculation) + && TrySetStructureNormalOrientation(calculationConfiguration, calculation) + && TrySetVerticalDistance(calculationConfiguration, calculation) + && calculationConfiguration.WaveReduction.ValidateWaveReduction(calculation.InputParameters.ForeshoreProfile, calculation.Name, Log)) { - SetFactorStormDurationOpenStructure(readCalculation, calculation); - SetVolumicWeightWater(readCalculation, calculation); - SetWaveReductionParameters(readCalculation.WaveReduction, calculation.InputParameters); - SetShouldIllustrationPointsBeCalculated(readCalculation, calculation); + SetFactorStormDurationOpenStructure(calculationConfiguration, calculation); + SetVolumicWeightWater(calculationConfiguration, calculation); + SetWaveReductionParameters(calculationConfiguration.WaveReduction, calculation.InputParameters); + SetShouldIllustrationPointsBeCalculated(calculationConfiguration, calculation); return calculation; } Index: Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Forms.Test/Views/StabilityPointStructuresFailureMechanismSectionResultRowTest.cs =================================================================== diff -u -r37d015e59a004f7deb5f1a9657016bd9c13c6539 -ra2405640a09a0b6df9457c317ab921a8dd7877fa --- Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Forms.Test/Views/StabilityPointStructuresFailureMechanismSectionResultRowTest.cs (.../StabilityPointStructuresFailureMechanismSectionResultRowTest.cs) (revision 37d015e59a004f7deb5f1a9657016bd9c13c6539) +++ Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Forms.Test/Views/StabilityPointStructuresFailureMechanismSectionResultRowTest.cs (.../StabilityPointStructuresFailureMechanismSectionResultRowTest.cs) (revision a2405640a09a0b6df9457c317ab921a8dd7877fa) @@ -222,13 +222,13 @@ ConstructionProperties); // Assert - Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(calculator.SimpleAssessmentAssemblyOutput.Group), + Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(calculator.SimpleAssessmentAssemblyOutput.Group), row.SimpleAssemblyCategoryGroup); - Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(calculator.DetailedAssessmentAssemblyOutput.Group), + Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(calculator.DetailedAssessmentAssemblyOutput.Group), row.DetailedAssemblyCategoryGroup); - Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(calculator.TailorMadeAssessmentAssemblyOutput.Group), + Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(calculator.TailorMadeAssessmentAssemblyOutput.Group), row.TailorMadeAssemblyCategoryGroup); - Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(calculator.CombinedAssemblyOutput.Group), + Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(calculator.CombinedAssemblyOutput.Group), row.CombinedAssemblyCategoryGroup); Assert.AreEqual(calculator.CombinedAssemblyOutput.Probability, row.CombinedAssemblyProbability); mocks.VerifyAll(); @@ -269,13 +269,13 @@ ConstructionProperties); // Precondition - Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(calculator.SimpleAssessmentAssemblyOutput.Group), + Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(calculator.SimpleAssessmentAssemblyOutput.Group), row.SimpleAssemblyCategoryGroup); - Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(calculator.DetailedAssessmentAssemblyOutput.Group), + Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(calculator.DetailedAssessmentAssemblyOutput.Group), row.DetailedAssemblyCategoryGroup); - Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(calculator.TailorMadeAssessmentAssemblyOutput.Group), + Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(calculator.TailorMadeAssessmentAssemblyOutput.Group), row.TailorMadeAssemblyCategoryGroup); - Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(calculator.CombinedAssemblyOutput.Group), + Assert.AreEqual(FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(calculator.CombinedAssemblyOutput.Group), row.CombinedAssemblyCategoryGroup); Assert.AreEqual(calculator.CombinedAssemblyOutput.Probability, row.CombinedAssemblyProbability); @@ -284,7 +284,7 @@ row.SimpleAssessmentResult = SimpleAssessmentValidityOnlyResultType.Applicable; // Then - string expectedAssemblyDisplayName = FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayname(FailureMechanismSectionAssemblyCategoryGroup.None); + string expectedAssemblyDisplayName = FailureMechanismSectionAssemblyCategoryGroupHelper.GetCategoryGroupDisplayName(FailureMechanismSectionAssemblyCategoryGroup.None); Assert.AreEqual(expectedAssemblyDisplayName, row.SimpleAssemblyCategoryGroup); Assert.AreEqual(expectedAssemblyDisplayName, row.DetailedAssemblyCategoryGroup); Assert.AreEqual(expectedAssemblyDisplayName, row.TailorMadeAssemblyCategoryGroup);