Index: Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/FailureMechanismContributionNormChangeHandlerTest.cs =================================================================== diff -u -r1bd68d22bc0484d9d18afb2a776b8f5943712803 -raa09279c23d20a532712b4e0a8abe942a879149f --- Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/FailureMechanismContributionNormChangeHandlerTest.cs (.../FailureMechanismContributionNormChangeHandlerTest.cs) (revision 1bd68d22bc0484d9d18afb2a776b8f5943712803) +++ Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/FailureMechanismContributionNormChangeHandlerTest.cs (.../FailureMechanismContributionNormChangeHandlerTest.cs) (revision aa09279c23d20a532712b4e0a8abe942a879149f) @@ -309,7 +309,7 @@ AssertHydraulicBoundaryLocationOutput(assessmentSection, true); - Assert.IsNotNull(assessmentSection.DuneErosion.DuneLocations[0].Calculation.Output); + Assert.IsNotNull(assessmentSection.DuneErosion.DuneLocations[1].Calculation.Output); CollectionAssert.IsEmpty(affectedObjects); } Index: Ringtoets/Integration/test/Ringtoets.Integration.TestUtil.Test/TestDataGeneratorTest.cs =================================================================== diff -u -r5333704809da36195e26ea4c4e0fe5ed0169348f -raa09279c23d20a532712b4e0a8abe942a879149f --- Ringtoets/Integration/test/Ringtoets.Integration.TestUtil.Test/TestDataGeneratorTest.cs (.../TestDataGeneratorTest.cs) (revision 5333704809da36195e26ea4c4e0fe5ed0169348f) +++ Ringtoets/Integration/test/Ringtoets.Integration.TestUtil.Test/TestDataGeneratorTest.cs (.../TestDataGeneratorTest.cs) (revision aa09279c23d20a532712b4e0a8abe942a879149f) @@ -60,8 +60,8 @@ DuneErosionFailureMechanism duneErosionFailureMechanism = assessmentSection.GetFailureMechanisms() .OfType() .Single(); - AssertDuneErosionFailureMechanismContainsCalculationConfigurationsWithOutputs(duneErosionFailureMechanism); - AssertDuneErosionFailureMechanismContainsCalculationConfigurationsWithoutOutputs(duneErosionFailureMechanism); + AssertDuneErosionFailureMechanismCalculationConfigurationsWithoutOutputs(duneErosionFailureMechanism); + AssertDuneErosionFailureMechanismCalculationConfigurationsWithOutputs(duneErosionFailureMechanism); } [Test] @@ -82,8 +82,8 @@ DuneErosionFailureMechanism duneErosionFailureMechanism = assessmentSection.GetFailureMechanisms() .OfType() .Single(); - AssertDuneErosionFailureMechanismContainsCalculationConfigurationsWithOutputs(duneErosionFailureMechanism); - AssertDuneErosionFailureMechanismContainsCalculationConfigurationsWithoutOutputs(duneErosionFailureMechanism); + AssertDuneErosionFailureMechanismCalculationConfigurationsWithoutOutputs(duneErosionFailureMechanism); + AssertDuneErosionFailureMechanismCalculationConfigurationsWithOutputs(duneErosionFailureMechanism); } [Test] @@ -96,11 +96,7 @@ Assert.AreEqual(AssessmentSectionComposition.Dike, assessmentSection.Composition); AssertFailureMechanismsHaveAllPossibleCalculationConfigurations(assessmentSection); AssertHydraulicBoundaryOutput(assessmentSection, false); - - DuneErosionFailureMechanism duneErosionFailureMechanism = assessmentSection.GetFailureMechanisms() - .OfType() - .Single(); - AssertDuneErosionFailureAssertDuneErosionFailureMechanismCalculationConfigurations(duneErosionFailureMechanism, false); + Assert.True(assessmentSection.DuneErosion.DuneLocations.All(dl => dl.Calculation.Output == null)); } [Test] @@ -117,11 +113,7 @@ Assert.AreEqual(composition, assessmentSection.Composition); AssertFailureMechanismsHaveAllPossibleCalculationConfigurations(assessmentSection); AssertHydraulicBoundaryOutput(assessmentSection, false); - - DuneErosionFailureMechanism duneErosionFailureMechanism = assessmentSection.GetFailureMechanisms() - .OfType() - .Single(); - AssertDuneErosionFailureAssertDuneErosionFailureMechanismCalculationConfigurations(duneErosionFailureMechanism, false); + Assert.True(assessmentSection.DuneErosion.DuneLocations.All(dl => dl.Calculation.Output == null)); } [Test] @@ -139,8 +131,8 @@ DuneErosionFailureMechanism duneErosionFailureMechanism = assessmentSection.GetFailureMechanisms() .OfType() .Single(); - AssertDuneErosionFailureMechanismContainsCalculationConfigurationsWithOutputs(duneErosionFailureMechanism); - AssertDuneErosionFailureMechanismContainsCalculationConfigurationsWithoutOutputs(duneErosionFailureMechanism); + AssertDuneErosionFailureMechanismCalculationConfigurationsWithoutOutputs(duneErosionFailureMechanism); + AssertDuneErosionFailureMechanismCalculationConfigurationsWithOutputs(duneErosionFailureMechanism); } [Test] @@ -162,9 +154,8 @@ DuneErosionFailureMechanism duneErosionFailureMechanism = assessmentSection.GetFailureMechanisms() .OfType() .Single(); - AssertNumberOfDuneErosionFailureMechanismCalculations(duneErosionFailureMechanism); - AssertDuneErosionFailureMechanismContainsCalculationConfigurationsWithoutOutputs(duneErosionFailureMechanism); - AssertDuneErosionFailureMechanismContainsCalculationConfigurationsWithOutputs(duneErosionFailureMechanism); + AssertDuneErosionFailureMechanismCalculationConfigurationsWithoutOutputs(duneErosionFailureMechanism); + AssertDuneErosionFailureMechanismCalculationConfigurationsWithOutputs(duneErosionFailureMechanism); } private static void AssertHydraulicBoundaryOutput(AssessmentSection assessmentSection, bool hasOutput) @@ -392,7 +383,6 @@ if (duneErosionFailureMechanism != null) { - AssertNumberOfDuneErosionFailureMechanismCalculations(duneErosionFailureMechanism); containsDuneErosionFailureMechanism = true; } @@ -684,60 +674,14 @@ #region Dune Erosion - private static void AssertNumberOfDuneErosionFailureMechanismCalculations(DuneErosionFailureMechanism failureMechanism) + private static void AssertDuneErosionFailureMechanismCalculationConfigurationsWithOutputs(DuneErosionFailureMechanism failureMechanism) { - int expectedCalculationsCount = failureMechanism.DuneLocations.Count; - Assert.AreEqual(expectedCalculationsCount, failureMechanism.CalculationsForMechanismSpecificFactorizedSignalingNorm.Count()); - Assert.AreEqual(expectedCalculationsCount, failureMechanism.CalculationsForMechanismSpecificSignalingNorm.Count()); - Assert.AreEqual(expectedCalculationsCount, failureMechanism.CalculationsForMechanismSpecificLowerLimitNorm.Count()); - Assert.AreEqual(expectedCalculationsCount, failureMechanism.CalculationsForLowerLimitNorm.Count()); - Assert.AreEqual(expectedCalculationsCount, failureMechanism.CalculationsForFactorizedLowerLimitNorm.Count()); - } - - private static void AssertDuneErosionFailureAssertDuneErosionFailureMechanismCalculationConfigurations(DuneErosionFailureMechanism failureMechanism, bool hasOutput) - { - if (hasOutput) - { - Assert.True(failureMechanism.DuneLocations.All(dl => dl.Calculation.Output != null)); - - Assert.True(failureMechanism.CalculationsForMechanismSpecificFactorizedSignalingNorm.All(calc => calc.Output != null)); - Assert.True(failureMechanism.CalculationsForMechanismSpecificSignalingNorm.All(calc => calc.Output != null)); - Assert.True(failureMechanism.CalculationsForMechanismSpecificLowerLimitNorm.All(calc => calc.Output != null)); - Assert.True(failureMechanism.CalculationsForLowerLimitNorm.All(calc => calc.Output != null)); - Assert.True(failureMechanism.CalculationsForFactorizedLowerLimitNorm.All(calc => calc.Output != null)); - } - else - { - Assert.True(failureMechanism.DuneLocations.All(dl => dl.Calculation.Output == null)); - - Assert.True(failureMechanism.CalculationsForMechanismSpecificFactorizedSignalingNorm.All(calc => calc.Output == null)); - Assert.True(failureMechanism.CalculationsForMechanismSpecificSignalingNorm.All(calc => calc.Output == null)); - Assert.True(failureMechanism.CalculationsForMechanismSpecificLowerLimitNorm.All(calc => calc.Output == null)); - Assert.True(failureMechanism.CalculationsForLowerLimitNorm.All(calc => calc.Output == null)); - Assert.True(failureMechanism.CalculationsForFactorizedLowerLimitNorm.All(calc => calc.Output == null)); - } - } - - private static void AssertDuneErosionFailureMechanismContainsCalculationConfigurationsWithOutputs(DuneErosionFailureMechanism failureMechanism) - { Assert.True(failureMechanism.DuneLocations.Any(dl => dl.Calculation.Output != null)); - - Assert.True(failureMechanism.CalculationsForMechanismSpecificFactorizedSignalingNorm.Any(calc => calc.Output != null)); - Assert.True(failureMechanism.CalculationsForMechanismSpecificSignalingNorm.Any(calc => calc.Output != null)); - Assert.True(failureMechanism.CalculationsForMechanismSpecificLowerLimitNorm.Any(calc => calc.Output != null)); - Assert.True(failureMechanism.CalculationsForLowerLimitNorm.Any(calc => calc.Output != null)); - Assert.True(failureMechanism.CalculationsForFactorizedLowerLimitNorm.Any(calc => calc.Output != null)); } - private static void AssertDuneErosionFailureMechanismContainsCalculationConfigurationsWithoutOutputs(DuneErosionFailureMechanism failureMechanism) + private static void AssertDuneErosionFailureMechanismCalculationConfigurationsWithoutOutputs(DuneErosionFailureMechanism failureMechanism) { Assert.True(failureMechanism.DuneLocations.Any(dl => dl.Calculation.Output == null)); - - Assert.True(failureMechanism.CalculationsForMechanismSpecificFactorizedSignalingNorm.Any(calc => calc.Output == null)); - Assert.True(failureMechanism.CalculationsForMechanismSpecificSignalingNorm.Any(calc => calc.Output == null)); - Assert.True(failureMechanism.CalculationsForMechanismSpecificLowerLimitNorm.Any(calc => calc.Output == null)); - Assert.True(failureMechanism.CalculationsForLowerLimitNorm.Any(calc => calc.Output == null)); - Assert.True(failureMechanism.CalculationsForFactorizedLowerLimitNorm.Any(calc => calc.Output == null)); } #endregion Index: Ringtoets/Integration/test/Ringtoets.Integration.TestUtil/TestDataGenerator.cs =================================================================== diff -u -r35cdb63312e00d641feb421d02e99b08b087938f -raa09279c23d20a532712b4e0a8abe942a879149f --- Ringtoets/Integration/test/Ringtoets.Integration.TestUtil/TestDataGenerator.cs (.../TestDataGenerator.cs) (revision 35cdb63312e00d641feb421d02e99b08b087938f) +++ Ringtoets/Integration/test/Ringtoets.Integration.TestUtil/TestDataGenerator.cs (.../TestDataGenerator.cs) (revision aa09279c23d20a532712b4e0a8abe942a879149f) @@ -33,7 +33,6 @@ using Ringtoets.Common.Data.TestUtil; using Ringtoets.DuneErosion.Data; using Ringtoets.DuneErosion.Data.TestUtil; -using Ringtoets.DuneErosion.Service; using Ringtoets.GrassCoverErosionInwards.Data; using Ringtoets.GrassCoverErosionInwards.Data.TestUtil; using Ringtoets.GrassCoverErosionOutwards.Data; @@ -125,11 +124,6 @@ { AssessmentSection assessmentSection = GetAssessmentSectionWithAllCalculationConfigurations(composition); RingtoetsDataSynchronizationService.ClearHydraulicBoundaryLocationOutput(assessmentSection.HydraulicBoundaryDatabase, assessmentSection); - DuneErosionDataSynchronizationService.ClearDuneCalculationsOutput(assessmentSection.DuneErosion.CalculationsForMechanismSpecificFactorizedSignalingNorm); - DuneErosionDataSynchronizationService.ClearDuneCalculationsOutput(assessmentSection.DuneErosion.CalculationsForMechanismSpecificSignalingNorm); - DuneErosionDataSynchronizationService.ClearDuneCalculationsOutput(assessmentSection.DuneErosion.CalculationsForMechanismSpecificLowerLimitNorm); - DuneErosionDataSynchronizationService.ClearDuneCalculationsOutput(assessmentSection.DuneErosion.CalculationsForLowerLimitNorm); - DuneErosionDataSynchronizationService.ClearDuneCalculationsOutput(assessmentSection.DuneErosion.CalculationsForFactorizedLowerLimitNorm); return assessmentSection; } @@ -1005,27 +999,15 @@ private static void SetFullyConfiguredFailureMechanism(DuneErosionFailureMechanism failureMechanism) { - var duneLocations = new[] + failureMechanism.DuneLocations.Add(new TestDuneLocation()); + failureMechanism.DuneLocations.Add(new TestDuneLocation { - new TestDuneLocation + Calculation = { - Calculation = - { - Output = new TestDuneLocationOutput() - } - }, - new TestDuneLocation() - }; + Output = new TestDuneLocationOutput() + } + }); - failureMechanism.DuneLocations.AddRange(duneLocations); - failureMechanism.SetDuneLocationCalculations(duneLocations); - - failureMechanism.CalculationsForMechanismSpecificFactorizedSignalingNorm.First().Output = new TestDuneLocationOutput(); - failureMechanism.CalculationsForMechanismSpecificSignalingNorm.First().Output = new TestDuneLocationOutput(); - failureMechanism.CalculationsForMechanismSpecificLowerLimitNorm.First().Output = new TestDuneLocationOutput(); - failureMechanism.CalculationsForLowerLimitNorm.First().Output = new TestDuneLocationOutput(); - failureMechanism.CalculationsForFactorizedLowerLimitNorm.First().Output = new TestDuneLocationOutput(); - AddFailureMechanismSections(failureMechanism); }