Index: Riskeer/GrassCoverErosionOutwards/src/Riskeer.GrassCoverErosionOutwards.Plugin/GrassCoverErosionOutwardsPlugin.cs =================================================================== diff -u -rd45fcaaa3ed0debc693959db83a519288644fb5f -raacd6850ae589059dc1909ceaa2a1bc27308d65d --- Riskeer/GrassCoverErosionOutwards/src/Riskeer.GrassCoverErosionOutwards.Plugin/GrassCoverErosionOutwardsPlugin.cs (.../GrassCoverErosionOutwardsPlugin.cs) (revision d45fcaaa3ed0debc693959db83a519288644fb5f) +++ Riskeer/GrassCoverErosionOutwards/src/Riskeer.GrassCoverErosionOutwards.Plugin/GrassCoverErosionOutwardsPlugin.cs (.../GrassCoverErosionOutwardsPlugin.cs) (revision aacd6850ae589059dc1909ceaa2a1bc27308d65d) @@ -43,6 +43,7 @@ using Riskeer.Common.Forms.PresentationObjects; using Riskeer.Common.Forms.TreeNodeInfos; using Riskeer.Common.Forms.UpdateInfos; +using Riskeer.Common.Forms.Views; using Riskeer.Common.Plugin; using Riskeer.Common.Service; using Riskeer.Common.Util.Helpers; @@ -126,16 +127,16 @@ }; yield return new RiskeerViewInfo< - FailureMechanismSectionResultContext, - IObservableEnumerable, - GrassCoverErosionOutwardsFailureMechanismResultViewOld>(() => Gui) + GrassCoverErosionOutwardsFailureMechanismSectionResultContext, + IObservableEnumerable, + NonAdoptableWithProfileProbabilityFailureMechanismResultView>(() => Gui) { GetViewName = (view, context) => RiskeerCommonFormsResources.FailureMechanism_AssessmentResult_DisplayName, CloseForData = CloseFailureMechanismResultViewForData, GetViewData = context => context.WrappedData, - CreateInstance = context => new GrassCoverErosionOutwardsFailureMechanismResultViewOld( - context.WrappedData, - (GrassCoverErosionOutwardsFailureMechanism) context.FailureMechanism) + CreateInstance = context => new NonAdoptableWithProfileProbabilityFailureMechanismResultView( + context.WrappedData, (GrassCoverErosionOutwardsFailureMechanism) context.FailureMechanism, context.AssessmentSection, + fm => fm.GeneralInput.N, fm => fm.GeneralInput.ApplyLengthEffectInSection) }; yield return new RiskeerViewInfo view, + object dataToCloseFor) { var failureMechanism = dataToCloseFor as GrassCoverErosionOutwardsFailureMechanism; @@ -297,7 +298,7 @@ failureMechanism = failurePathContext.WrappedData; } - return failureMechanism != null && ReferenceEquals(view.FailureMechanism.SectionResultsOld, failureMechanism.SectionResultsOld); + return failureMechanism != null && ReferenceEquals(view.FailureMechanism.SectionResults, failureMechanism.SectionResults); } #endregion @@ -456,17 +457,14 @@ foreach (ICalculationBase item in nodeData.WrappedData.Children) { - var calculation = item as GrassCoverErosionOutwardsWaveConditionsCalculation; - var group = item as CalculationGroup; - - if (calculation != null) + if (item is GrassCoverErosionOutwardsWaveConditionsCalculation calculation) { childNodeObjects.Add(new GrassCoverErosionOutwardsWaveConditionsCalculationContext(calculation, nodeData.WrappedData, nodeData.FailureMechanism, nodeData.AssessmentSection)); } - else if (group != null) + else if (item is CalculationGroup group) { childNodeObjects.Add(new GrassCoverErosionOutwardsWaveConditionsCalculationGroupContext(group, nodeData.WrappedData, Index: Riskeer/GrassCoverErosionOutwards/test/Riskeer.GrassCoverErosionOutwards.Plugin.Test/GrassCoverErosionOutwardsPluginTest.cs =================================================================== diff -u -rd45fcaaa3ed0debc693959db83a519288644fb5f -raacd6850ae589059dc1909ceaa2a1bc27308d65d --- Riskeer/GrassCoverErosionOutwards/test/Riskeer.GrassCoverErosionOutwards.Plugin.Test/GrassCoverErosionOutwardsPluginTest.cs (.../GrassCoverErosionOutwardsPluginTest.cs) (revision d45fcaaa3ed0debc693959db83a519288644fb5f) +++ Riskeer/GrassCoverErosionOutwards/test/Riskeer.GrassCoverErosionOutwards.Plugin.Test/GrassCoverErosionOutwardsPluginTest.cs (.../GrassCoverErosionOutwardsPluginTest.cs) (revision aacd6850ae589059dc1909ceaa2a1bc27308d65d) @@ -31,7 +31,8 @@ using NUnit.Framework; using Rhino.Mocks; using Riskeer.Common.Data.Calculation; -using Riskeer.Common.Forms.PresentationObjects; +using Riskeer.Common.Data.FailureMechanism; +using Riskeer.Common.Forms.Views; using Riskeer.GrassCoverErosionOutwards.Data; using Riskeer.GrassCoverErosionOutwards.Forms.PresentationObjects; using Riskeer.GrassCoverErosionOutwards.Forms.PropertyClasses; @@ -89,9 +90,9 @@ PluginTestHelper.AssertViewInfoDefined( viewInfos, - typeof(FailureMechanismSectionResultContext), - typeof(IObservableEnumerable), - typeof(GrassCoverErosionOutwardsFailureMechanismResultViewOld)); + typeof(GrassCoverErosionOutwardsFailureMechanismSectionResultContext), + typeof(IObservableEnumerable), + typeof(NonAdoptableWithProfileProbabilityFailureMechanismResultView)); PluginTestHelper.AssertViewInfoDefined( viewInfos, Index: Riskeer/GrassCoverErosionOutwards/test/Riskeer.GrassCoverErosionOutwards.Plugin.Test/ViewInfos/GrassCoverErosionOutwardsFailureMechanismResultViewInfoTest.cs =================================================================== diff -u -r72082701dd10333c0dd79313fca6191306d134a7 -raacd6850ae589059dc1909ceaa2a1bc27308d65d --- Riskeer/GrassCoverErosionOutwards/test/Riskeer.GrassCoverErosionOutwards.Plugin.Test/ViewInfos/GrassCoverErosionOutwardsFailureMechanismResultViewInfoTest.cs (.../GrassCoverErosionOutwardsFailureMechanismResultViewInfoTest.cs) (revision 72082701dd10333c0dd79313fca6191306d134a7) +++ Riskeer/GrassCoverErosionOutwards/test/Riskeer.GrassCoverErosionOutwards.Plugin.Test/ViewInfos/GrassCoverErosionOutwardsFailureMechanismResultViewInfoTest.cs (.../GrassCoverErosionOutwardsFailureMechanismResultViewInfoTest.cs) (revision aacd6850ae589059dc1909ceaa2a1bc27308d65d) @@ -27,10 +27,9 @@ using Rhino.Mocks; using Riskeer.Common.Data.AssessmentSection; using Riskeer.Common.Data.FailureMechanism; -using Riskeer.Common.Forms.PresentationObjects; +using Riskeer.Common.Forms.Views; using Riskeer.GrassCoverErosionOutwards.Data; using Riskeer.GrassCoverErosionOutwards.Forms.PresentationObjects; -using Riskeer.GrassCoverErosionOutwards.Forms.Views; namespace Riskeer.GrassCoverErosionOutwards.Plugin.Test.ViewInfos { @@ -46,7 +45,7 @@ { mocks = new MockRepository(); plugin = new GrassCoverErosionOutwardsPlugin(); - info = plugin.GetViewInfos().First(tni => tni.ViewType == typeof(GrassCoverErosionOutwardsFailureMechanismResultViewOld)); + info = plugin.GetViewInfos().First(tni => tni.ViewType == typeof(NonAdoptableWithProfileProbabilityFailureMechanismResultView)); } [TearDown] @@ -59,24 +58,27 @@ public void Initialized_Always_ExpectedPropertiesSet() { // Assert - Assert.AreEqual(typeof(FailureMechanismSectionResultContext), info.DataType); - Assert.AreEqual(typeof(IObservableEnumerable), info.ViewDataType); + Assert.AreEqual(typeof(GrassCoverErosionOutwardsFailureMechanismSectionResultContext), info.DataType); + Assert.AreEqual(typeof(IObservableEnumerable), info.ViewDataType); } [Test] public void GetViewData_WithContext_ReturnsWrappedFailureMechanismResult() { // Setup + var assessmentSection = mocks.Stub(); + mocks.ReplayAll(); + var failureMechanism = new GrassCoverErosionOutwardsFailureMechanism(); - var context = new FailureMechanismSectionResultContext( - failureMechanism.SectionResultsOld, - failureMechanism); + var context = new GrassCoverErosionOutwardsFailureMechanismSectionResultContext( + failureMechanism.SectionResults, failureMechanism, assessmentSection); // Call object viewData = info.GetViewData(context); // Assert - Assert.AreSame(failureMechanism.SectionResultsOld, viewData); + Assert.AreSame(failureMechanism.SectionResults, viewData); + mocks.VerifyAll(); } [Test] @@ -99,7 +101,8 @@ var failureMechanism = new GrassCoverErosionOutwardsFailureMechanism(); - using (var view = new GrassCoverErosionOutwardsFailureMechanismResultViewOld(failureMechanism.SectionResultsOld, failureMechanism)) + using (var view = new NonAdoptableWithProfileProbabilityFailureMechanismResultView( + failureMechanism.SectionResults, failureMechanism, assessmentSection, fm => fm.GeneralInput.N, fm => fm.GeneralInput.ApplyLengthEffectInSection)) { // Call bool closeForData = info.CloseForData(view, assessmentSection); @@ -126,7 +129,8 @@ mocks.ReplayAll(); - using (var view = new GrassCoverErosionOutwardsFailureMechanismResultViewOld(failureMechanism.SectionResultsOld, failureMechanism)) + using (var view = new NonAdoptableWithProfileProbabilityFailureMechanismResultView( + failureMechanism.SectionResults, failureMechanism, assessmentSection, fm => fm.GeneralInput.N, fm => fm.GeneralInput.ApplyLengthEffectInSection)) { // Call bool closeForData = info.CloseForData(view, assessmentSection); @@ -152,7 +156,8 @@ mocks.ReplayAll(); - using (var view = new GrassCoverErosionOutwardsFailureMechanismResultViewOld(failureMechanism.SectionResultsOld, failureMechanism)) + using (var view = new NonAdoptableWithProfileProbabilityFailureMechanismResultView( + failureMechanism.SectionResults, failureMechanism, assessmentSection, fm => fm.GeneralInput.N, fm => fm.GeneralInput.ApplyLengthEffectInSection)) { // Call bool closeForData = info.CloseForData(view, assessmentSection); @@ -168,34 +173,46 @@ public void CloseForData_ViewCorrespondingToRemovedFailureMechanism_ReturnsTrue() { // Setup + var assessmentSection = mocks.Stub(); + mocks.ReplayAll(); + var failureMechanism = new GrassCoverErosionOutwardsFailureMechanism(); - using (var view = new GrassCoverErosionOutwardsFailureMechanismResultViewOld(failureMechanism.SectionResultsOld, failureMechanism)) + using (var view = new NonAdoptableWithProfileProbabilityFailureMechanismResultView( + failureMechanism.SectionResults, failureMechanism, assessmentSection, fm => fm.GeneralInput.N, fm => fm.GeneralInput.ApplyLengthEffectInSection)) { // Call bool closeForData = info.CloseForData(view, failureMechanism); // Assert Assert.IsTrue(closeForData); } + + mocks.VerifyAll(); } [Test] public void CloseForData_ViewNotCorrespondingToRemovedFailureMechanism_ReturnsFalse() { // Setup + var assessmentSection = mocks.Stub(); + mocks.ReplayAll(); + var failureMechanism = new GrassCoverErosionOutwardsFailureMechanism(); - using (var view = new GrassCoverErosionOutwardsFailureMechanismResultViewOld(failureMechanism.SectionResultsOld, failureMechanism)) + using (var view = new NonAdoptableWithProfileProbabilityFailureMechanismResultView( + failureMechanism.SectionResults, failureMechanism, assessmentSection, fm => fm.GeneralInput.N, fm => fm.GeneralInput.ApplyLengthEffectInSection)) { // Call bool closeForData = info.CloseForData(view, new GrassCoverErosionOutwardsFailureMechanism()); // Assert Assert.IsFalse(closeForData); } - } - + + mocks.VerifyAll(); + } + [Test] public void CloseForData_ViewCorrespondingToRemovedFailurePathContext_ReturnsTrue() { @@ -206,7 +223,8 @@ var failureMechanism = new GrassCoverErosionOutwardsFailureMechanism(); var context = new GrassCoverErosionOutwardsFailurePathContext(failureMechanism, assessmentSection); - using (var view = new GrassCoverErosionOutwardsFailureMechanismResultViewOld(failureMechanism.SectionResultsOld, failureMechanism)) + using (var view = new NonAdoptableWithProfileProbabilityFailureMechanismResultView( + failureMechanism.SectionResults, failureMechanism, assessmentSection, fm => fm.GeneralInput.N, fm => fm.GeneralInput.ApplyLengthEffectInSection)) { // Call bool closeForData = info.CloseForData(view, context); @@ -230,7 +248,8 @@ var failureMechanism = new GrassCoverErosionOutwardsFailureMechanism(); - using (var view = new GrassCoverErosionOutwardsFailureMechanismResultViewOld(failureMechanism.SectionResultsOld, failureMechanism)) + using (var view = new NonAdoptableWithProfileProbabilityFailureMechanismResultView( + failureMechanism.SectionResults, failureMechanism, assessmentSection, fm => fm.GeneralInput.N, fm => fm.GeneralInput.ApplyLengthEffectInSection)) { // Call bool closeForData = info.CloseForData(view, context); @@ -246,16 +265,19 @@ public void CreateInstance_WithContext_ReturnsView() { // Setup + var assessmentSection = mocks.Stub(); + mocks.ReplayAll(); + var failureMechanism = new GrassCoverErosionOutwardsFailureMechanism(); - var context = new FailureMechanismSectionResultContext( - failureMechanism.SectionResultsOld, - failureMechanism); + var context = new GrassCoverErosionOutwardsFailureMechanismSectionResultContext( + failureMechanism.SectionResults, failureMechanism, assessmentSection); // Call IView view = info.CreateInstance(context); // Assert - Assert.IsInstanceOf(view); + Assert.IsInstanceOf>(view); + mocks.VerifyAll(); } } } \ No newline at end of file