Index: Riskeer/HeightStructures/src/Riskeer.HeightStructures.Data/HeightStructuresFailureMechanismAssemblyFactory.cs
===================================================================
diff -u -r35349144a21f4e3627505605840f286b21b2d004 -raae260b47427807667f590bd3db59c3d7890129d
--- Riskeer/HeightStructures/src/Riskeer.HeightStructures.Data/HeightStructuresFailureMechanismAssemblyFactory.cs (.../HeightStructuresFailureMechanismAssemblyFactory.cs) (revision 35349144a21f4e3627505605840f286b21b2d004)
+++ Riskeer/HeightStructures/src/Riskeer.HeightStructures.Data/HeightStructuresFailureMechanismAssemblyFactory.cs (.../HeightStructuresFailureMechanismAssemblyFactory.cs) (revision aae260b47427807667f590bd3db59c3d7890129d)
@@ -118,7 +118,7 @@
{
return calculator.AssembleDetailedAssessment(
failureMechanismSectionResult.DetailedAssessmentResult,
- failureMechanismSectionResult.GetDetailedAssessmentProbability(calculationScenarios, failureMechanism, assessmentSection),
+ failureMechanismSectionResult.GetDetailedAssessmentProbability(calculationScenarios),
CreateAssemblyCategoriesInput(failureMechanism, assessmentSection));
}
catch (FailureMechanismSectionAssemblyCalculatorException e)
Index: Riskeer/HeightStructures/src/Riskeer.HeightStructures.Data/HeightStructuresFailureMechanismSectionResultDetailedAssessmentExtensions.cs
===================================================================
diff -u -r6e98190f16ad4ff9228abc51131fccfa3816d5d0 -raae260b47427807667f590bd3db59c3d7890129d
--- Riskeer/HeightStructures/src/Riskeer.HeightStructures.Data/HeightStructuresFailureMechanismSectionResultDetailedAssessmentExtensions.cs (.../HeightStructuresFailureMechanismSectionResultDetailedAssessmentExtensions.cs) (revision 6e98190f16ad4ff9228abc51131fccfa3816d5d0)
+++ Riskeer/HeightStructures/src/Riskeer.HeightStructures.Data/HeightStructuresFailureMechanismSectionResultDetailedAssessmentExtensions.cs (.../HeightStructuresFailureMechanismSectionResultDetailedAssessmentExtensions.cs) (revision aae260b47427807667f590bd3db59c3d7890129d)
@@ -24,7 +24,6 @@
using System.Linq;
using Core.Common.Base.Data;
using Core.Common.Base.Geometry;
-using Riskeer.Common.Data.AssessmentSection;
using Riskeer.Common.Data.Calculation;
using Riskeer.Common.Data.Probability;
using Riskeer.Common.Data.Structures;
@@ -42,16 +41,12 @@
///
/// The section result to get the detailed assessment probability for.
/// All calculation scenarios in the failure mechanism.
- /// The failure mechanism the section result belongs to.
- /// The assessment section the section result belongs to.
/// The calculated detailed assessment probability; or when there
/// are no relevant calculations, when not all relevant calculations are performed or when the
/// contribution of the relevant calculations don't add up to 1.
/// Thrown when any parameter is null.
public static double GetDetailedAssessmentProbability(this HeightStructuresFailureMechanismSectionResult sectionResult,
- IEnumerable> calculationScenarios,
- HeightStructuresFailureMechanism failureMechanism,
- IAssessmentSection assessmentSection)
+ IEnumerable> calculationScenarios)
{
if (sectionResult == null)
{
@@ -63,16 +58,6 @@
throw new ArgumentNullException(nameof(calculationScenarios));
}
- if (failureMechanism == null)
- {
- throw new ArgumentNullException(nameof(failureMechanism));
- }
-
- if (assessmentSection == null)
- {
- throw new ArgumentNullException(nameof(assessmentSection));
- }
-
StructuresCalculationScenario[] relevantScenarios = sectionResult.GetCalculationScenarios(calculationScenarios).ToArray();
if (relevantScenarios.Length == 0 || !relevantScenarios.All(s => s.HasOutput) || Math.Abs(sectionResult.GetTotalContribution(relevantScenarios) - 1.0) > 1e-6)
@@ -84,7 +69,7 @@
foreach (StructuresCalculationScenario scenario in relevantScenarios)
{
ProbabilityAssessmentOutput derivedOutput = ProbabilityAssessmentOutputFactory.Create(scenario.Output.Reliability);
-
+
totalDetailedAssessmentProbability += derivedOutput.Probability * (double) scenario.Contribution;
}
Index: Riskeer/HeightStructures/src/Riskeer.HeightStructures.Forms/Views/HeightStructuresFailureMechanismSectionResultRow.cs
===================================================================
diff -u -r35349144a21f4e3627505605840f286b21b2d004 -raae260b47427807667f590bd3db59c3d7890129d
--- Riskeer/HeightStructures/src/Riskeer.HeightStructures.Forms/Views/HeightStructuresFailureMechanismSectionResultRow.cs (.../HeightStructuresFailureMechanismSectionResultRow.cs) (revision 35349144a21f4e3627505605840f286b21b2d004)
+++ Riskeer/HeightStructures/src/Riskeer.HeightStructures.Forms/Views/HeightStructuresFailureMechanismSectionResultRow.cs (.../HeightStructuresFailureMechanismSectionResultRow.cs) (revision aae260b47427807667f590bd3db59c3d7890129d)
@@ -155,7 +155,7 @@
/// Gets the value representing the result of the detailed assessment.
///
[TypeConverter(typeof(NoProbabilityValueDoubleConverter))]
- public double DetailedAssessmentProbability => SectionResult.GetDetailedAssessmentProbability(calculationScenarios, failureMechanism, assessmentSection);
+ public double DetailedAssessmentProbability => SectionResult.GetDetailedAssessmentProbability(calculationScenarios);
///
/// Gets or sets the value representing the tailor made assessment result.
@@ -270,7 +270,7 @@
ColumnStateDefinitions[detailedAssessmentProbabilityIndex].ErrorText = FailureMechanismSectionResultRowHelper.GetDetailedAssessmentProbabilityError(
SectionResult.GetCalculationScenarios(calculationScenarios).ToArray(),
scenarios => SectionResult.GetTotalContribution(scenarios),
- scenarios => SectionResult.GetDetailedAssessmentProbability(scenarios, failureMechanism, assessmentSection));
+ scenarios => SectionResult.GetDetailedAssessmentProbability(scenarios));
}
}
Index: Riskeer/HeightStructures/test/Riskeer.HeightStructures.Data.Test/HeightStructuresFailureMechanismAssemblyFactoryTest.cs
===================================================================
diff -u -r35349144a21f4e3627505605840f286b21b2d004 -raae260b47427807667f590bd3db59c3d7890129d
--- Riskeer/HeightStructures/test/Riskeer.HeightStructures.Data.Test/HeightStructuresFailureMechanismAssemblyFactoryTest.cs (.../HeightStructuresFailureMechanismAssemblyFactoryTest.cs) (revision 35349144a21f4e3627505605840f286b21b2d004)
+++ Riskeer/HeightStructures/test/Riskeer.HeightStructures.Data.Test/HeightStructuresFailureMechanismAssemblyFactoryTest.cs (.../HeightStructuresFailureMechanismAssemblyFactoryTest.cs) (revision aae260b47427807667f590bd3db59c3d7890129d)
@@ -237,8 +237,7 @@
// Assert
Assert.AreEqual(sectionResult.GetDetailedAssessmentProbability(
- Enumerable.Empty>(),
- failureMechanism, assessmentSection),
+ Enumerable.Empty>()),
calculator.DetailedAssessmentProbabilityInput);
Assert.AreEqual(sectionResult.DetailedAssessmentResult, calculator.DetailedAssessmentProbabilityOnlyResultInput);
AssertAssemblyCategoriesInput(assessmentSection, failureMechanism, calculator.DetailedAssessmentAssemblyCategoriesInput);
Index: Riskeer/HeightStructures/test/Riskeer.HeightStructures.Data.Test/HeightStructuresFailureMechanismSectionResultDetailedAssessmentExtensionsTest.cs
===================================================================
diff -u -r35349144a21f4e3627505605840f286b21b2d004 -raae260b47427807667f590bd3db59c3d7890129d
--- Riskeer/HeightStructures/test/Riskeer.HeightStructures.Data.Test/HeightStructuresFailureMechanismSectionResultDetailedAssessmentExtensionsTest.cs (.../HeightStructuresFailureMechanismSectionResultDetailedAssessmentExtensionsTest.cs) (revision 35349144a21f4e3627505605840f286b21b2d004)
+++ Riskeer/HeightStructures/test/Riskeer.HeightStructures.Data.Test/HeightStructuresFailureMechanismSectionResultDetailedAssessmentExtensionsTest.cs (.../HeightStructuresFailureMechanismSectionResultDetailedAssessmentExtensionsTest.cs) (revision aae260b47427807667f590bd3db59c3d7890129d)
@@ -25,8 +25,6 @@
using Core.Common.Base.Data;
using Core.Common.Base.Geometry;
using NUnit.Framework;
-using Rhino.Mocks;
-using Riskeer.Common.Data.AssessmentSection;
using Riskeer.Common.Data.FailureMechanism;
using Riskeer.Common.Data.Structures;
using Riskeer.Common.Data.TestUtil;
@@ -40,91 +38,35 @@
[Test]
public void GetDetailedAssessmentProbability_SectionResultNull_ThrowsArgumentNullException()
{
- // Setup
- var mocks = new MockRepository();
- var assessmentSection = mocks.Stub();
- mocks.ReplayAll();
-
// Call
void Call() => HeightStructuresFailureMechanismSectionResultDetailedAssessmentExtensions.GetDetailedAssessmentProbability(
- null, Enumerable.Empty>(),
- new HeightStructuresFailureMechanism(), assessmentSection);
+ null, Enumerable.Empty>());
// Assert
var exception = Assert.Throws(Call);
Assert.AreEqual("sectionResult", exception.ParamName);
- mocks.VerifyAll();
}
[Test]
public void GetDetailedAssessmentProbability_CalculationScenariosNull_ThrowsArgumentNullException()
{
// Setup
- var mocks = new MockRepository();
- var assessmentSection = mocks.Stub();
- mocks.ReplayAll();
-
FailureMechanismSection section = FailureMechanismSectionTestFactory.CreateFailureMechanismSection();
var failureMechanismSectionResult = new HeightStructuresFailureMechanismSectionResult(section);
// Call
void Call() => failureMechanismSectionResult.GetDetailedAssessmentProbability(
- null, new HeightStructuresFailureMechanism(), assessmentSection);
+ null);
// Assert
var exception = Assert.Throws(Call);
Assert.AreEqual("calculationScenarios", exception.ParamName);
- mocks.VerifyAll();
}
[Test]
- public void GetDetailedAssessmentProbability_FailureMechanismNull_ThrowsArgumentNullException()
- {
- // Setup
- var mocks = new MockRepository();
- var assessmentSection = mocks.Stub();
- mocks.ReplayAll();
-
- FailureMechanismSection section = FailureMechanismSectionTestFactory.CreateFailureMechanismSection();
- var failureMechanismSectionResult = new HeightStructuresFailureMechanismSectionResult(section);
-
- // Call
- void Call() => failureMechanismSectionResult.GetDetailedAssessmentProbability(
- Enumerable.Empty>(), null, assessmentSection);
-
- // Assert
- var exception = Assert.Throws(Call);
- Assert.AreEqual("failureMechanism", exception.ParamName);
- mocks.VerifyAll();
- }
-
- [Test]
- public void GetDetailedAssessmentProbability_AssessmentSectionNull_ThrowsArgumentNullException()
- {
- // Setup
- FailureMechanismSection section = FailureMechanismSectionTestFactory.CreateFailureMechanismSection();
- var failureMechanismSectionResult = new HeightStructuresFailureMechanismSectionResult(section);
-
- // Call
- void Call() => failureMechanismSectionResult.GetDetailedAssessmentProbability(
- Enumerable.Empty>(),
- new HeightStructuresFailureMechanism(), null);
-
- // Assert
- var exception = Assert.Throws(Call);
- Assert.AreEqual("assessmentSection", exception.ParamName);
- }
-
- [Test]
public void GetDetailedAssessmentProbability_MultipleScenarios_ReturnsValueBasedOnRelevantScenarios()
{
// Setup
- var failureMechanism = new HeightStructuresFailureMechanism();
-
- var mocks = new MockRepository();
- IAssessmentSection assessmentSection = AssessmentSectionTestHelper.CreateAssessmentSectionStub(failureMechanism, mocks);
- mocks.ReplayAll();
-
FailureMechanismSection section = FailureMechanismSectionTestFactory.CreateFailureMechanismSection();
var failureMechanismSectionResult = new HeightStructuresFailureMechanismSectionResult(section);
@@ -150,47 +92,31 @@
};
// Call
- double detailedAssessmentProbability = failureMechanismSectionResult.GetDetailedAssessmentProbability(calculations, failureMechanism, assessmentSection);
+ double detailedAssessmentProbability = failureMechanismSectionResult.GetDetailedAssessmentProbability(calculations);
// Assert
Assert.AreEqual(0.3973850177700996, detailedAssessmentProbability);
- mocks.VerifyAll();
}
[Test]
public void GetDetailedAssessmentProbability_NoScenarios_ReturnsNaN()
{
// Setup
- var mocks = new MockRepository();
- var assessmentSection = mocks.Stub();
- mocks.ReplayAll();
-
- var failureMechanism = new HeightStructuresFailureMechanism();
-
FailureMechanismSection section = FailureMechanismSectionTestFactory.CreateFailureMechanismSection();
var failureMechanismSectionResult = new HeightStructuresFailureMechanismSectionResult(section);
// Call
double detailedAssessmentProbability = failureMechanismSectionResult.GetDetailedAssessmentProbability(
- Enumerable.Empty>(),
- failureMechanism,
- assessmentSection);
+ Enumerable.Empty>());
// Assert
Assert.IsNaN(detailedAssessmentProbability);
- mocks.VerifyAll();
}
[Test]
public void GetDetailedAssessmentProbability_NoRelevantScenarios_ReturnsNaN()
{
// Setup
- var mocks = new MockRepository();
- var assessmentSection = mocks.Stub();
- mocks.ReplayAll();
-
- var failureMechanism = new HeightStructuresFailureMechanism();
-
FailureMechanismSection section = FailureMechanismSectionTestFactory.CreateFailureMechanismSection();
var failureMechanismSectionResult = new HeightStructuresFailureMechanismSectionResult(section);
@@ -202,25 +128,16 @@
new[]
{
calculationScenario
- },
- failureMechanism,
- assessmentSection);
+ });
// Assert
Assert.IsNaN(detailedAssessmentProbability);
- mocks.VerifyAll();
}
[Test]
public void GetDetailedAssessmentProbability_ScenarioNotCalculated_ReturnsNaN()
{
// Setup
- var mocks = new MockRepository();
- var assessmentSection = mocks.Stub();
- mocks.ReplayAll();
-
- var failureMechanism = new HeightStructuresFailureMechanism();
-
FailureMechanismSection section = FailureMechanismSectionTestFactory.CreateFailureMechanismSection();
var failureMechanismSectionResult = new HeightStructuresFailureMechanismSectionResult(section);
@@ -230,23 +147,16 @@
double detailedAssessmentProbability = failureMechanismSectionResult.GetDetailedAssessmentProbability(new[]
{
calculationScenario
- }, failureMechanism, assessmentSection);
+ });
// Assert
Assert.IsNaN(detailedAssessmentProbability);
- mocks.VerifyAll();
}
[Test]
public void GetDetailedAssessmentProbability_ScenarioWithNaNResults_ReturnsNaN()
{
// Setup
- var failureMechanism = new HeightStructuresFailureMechanism();
-
- var mocks = new MockRepository();
- IAssessmentSection assessmentSection = AssessmentSectionTestHelper.CreateAssessmentSectionStub(failureMechanism, mocks);
- mocks.ReplayAll();
-
FailureMechanismSection section = FailureMechanismSectionTestFactory.CreateFailureMechanismSection();
var failureMechanismSectionResult = new HeightStructuresFailureMechanismSectionResult(section);
@@ -270,11 +180,10 @@
};
// Call
- double detailedAssessmentProbability = failureMechanismSectionResult.GetDetailedAssessmentProbability(calculations, failureMechanism, assessmentSection);
+ double detailedAssessmentProbability = failureMechanismSectionResult.GetDetailedAssessmentProbability(calculations);
// Assert
Assert.IsNaN(detailedAssessmentProbability);
- mocks.VerifyAll();
}
[Test]
@@ -284,11 +193,6 @@
public void GetDetailedAssessmentProbability_RelevantScenarioContributionsDoNotAddUpTo1_ReturnNaN(double contributionA, double contributionB)
{
// Setup
- var mocks = new MockRepository();
- var assessmentSection = mocks.Stub();
- mocks.ReplayAll();
-
- var failureMechanism = new HeightStructuresFailureMechanism();
FailureMechanismSection section = FailureMechanismSectionTestFactory.CreateFailureMechanismSection();
StructuresCalculationScenario scenarioA = HeightStructuresCalculationScenarioTestFactory.CreateNotCalculatedHeightStructuresCalculationScenario(section);
StructuresCalculationScenario scenarioB = HeightStructuresCalculationScenarioTestFactory.CreateNotCalculatedHeightStructuresCalculationScenario(section);
@@ -302,11 +206,10 @@
{
scenarioA,
scenarioB
- }, failureMechanism, assessmentSection);
+ });
// Assert
Assert.IsNaN(detailedAssessmentProbability);
- mocks.VerifyAll();
}
[Test]
Index: Riskeer/HeightStructures/test/Riskeer.HeightStructures.Forms.Test/Views/HeightStructuresFailureMechanismSectionResultRowTest.cs
===================================================================
diff -u -r35349144a21f4e3627505605840f286b21b2d004 -raae260b47427807667f590bd3db59c3d7890129d
--- Riskeer/HeightStructures/test/Riskeer.HeightStructures.Forms.Test/Views/HeightStructuresFailureMechanismSectionResultRowTest.cs (.../HeightStructuresFailureMechanismSectionResultRowTest.cs) (revision 35349144a21f4e3627505605840f286b21b2d004)
+++ Riskeer/HeightStructures/test/Riskeer.HeightStructures.Forms.Test/Views/HeightStructuresFailureMechanismSectionResultRowTest.cs (.../HeightStructuresFailureMechanismSectionResultRowTest.cs) (revision aae260b47427807667f590bd3db59c3d7890129d)
@@ -903,7 +903,7 @@
sectionResult, calculationScenarios, failureMechanism, assessmentSection, ConstructionProperties);
// Assert
- Assert.AreEqual(sectionResult.GetDetailedAssessmentProbability(calculationScenarios, failureMechanism, assessmentSection), resultRow.DetailedAssessmentProbability);
+ Assert.AreEqual(sectionResult.GetDetailedAssessmentProbability(calculationScenarios), resultRow.DetailedAssessmentProbability);
Assert.IsEmpty(resultRow.ColumnStateDefinitions[ConstructionProperties.DetailedAssessmentProbabilityIndex].ErrorText);
mocks.VerifyAll();
}
@@ -1006,7 +1006,7 @@
// Assert
Assert.AreEqual(sectionResult.GetDetailedAssessmentProbability(
- calculationScenarios, failureMechanism, assessmentSection),
+ calculationScenarios),
resultRow.DetailedAssessmentProbability);
Assert.IsEmpty(resultRow.ColumnStateDefinitions[ConstructionProperties.DetailedAssessmentProbabilityIndex].ErrorText);
mocks.VerifyAll();
@@ -1274,7 +1274,7 @@
double detailedAssessmentProbability = resultRow.DetailedAssessmentProbability;
// Assert
- Assert.AreEqual(sectionResult.GetDetailedAssessmentProbability(calculationScenarios, failureMechanism, assessmentSection), detailedAssessmentProbability);
+ Assert.AreEqual(sectionResult.GetDetailedAssessmentProbability(calculationScenarios), detailedAssessmentProbability);
mocks.VerifyAll();
}
}