Index: Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Service/GrassCoverErosionInwardsCalculationService.cs =================================================================== diff -u -r664870ad3a5105ce8865a49d5ba07661b50320fd -raca65a56029a6646ce2e997d7c14e547356b5b65 --- Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Service/GrassCoverErosionInwardsCalculationService.cs (.../GrassCoverErosionInwardsCalculationService.cs) (revision 664870ad3a5105ce8865a49d5ba07661b50320fd) +++ Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Service/GrassCoverErosionInwardsCalculationService.cs (.../GrassCoverErosionInwardsCalculationService.cs) (revision aca65a56029a6646ce2e997d7c14e547356b5b65) @@ -248,6 +248,7 @@ string preprocessorDirectory) { var numberOfCalculators = 1; + var settings = new HydraRingCalculationSettings(hlcdDirectory, preprocessorDirectory); overtoppingCalculator = HydraRingCalculatorFactory.Instance.CreateOvertoppingCalculator(hlcdDirectory, preprocessorDirectory); @@ -259,7 +260,8 @@ if (calculation.InputParameters.DikeHeightCalculationType != DikeHeightCalculationType.NoCalculation && dikeHeightNormValid) { - dikeHeightCalculator = HydraRingCalculatorFactory.Instance.CreateDikeHeightCalculator(hlcdDirectory, preprocessorDirectory); + + dikeHeightCalculator = HydraRingCalculatorFactory.Instance.CreateDikeHeightCalculator(settings); numberOfCalculators++; } @@ -271,7 +273,7 @@ if (calculation.InputParameters.OvertoppingRateCalculationType != OvertoppingRateCalculationType.NoCalculation && overtoppingRateNormValid) { - var settings = new HydraRingCalculationSettings(hlcdDirectory, preprocessorDirectory); + overtoppingRateCalculator = HydraRingCalculatorFactory.Instance.CreateOvertoppingRateCalculator(settings); numberOfCalculators++; } Index: Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Integration.Test/GrassCoverErosionInwardsCalculationActivityIntegrationTest.cs =================================================================== diff -u -r664870ad3a5105ce8865a49d5ba07661b50320fd -raca65a56029a6646ce2e997d7c14e547356b5b65 --- Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Integration.Test/GrassCoverErosionInwardsCalculationActivityIntegrationTest.cs (.../GrassCoverErosionInwardsCalculationActivityIntegrationTest.cs) (revision 664870ad3a5105ce8865a49d5ba07661b50320fd) +++ Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Integration.Test/GrassCoverErosionInwardsCalculationActivityIntegrationTest.cs (.../GrassCoverErosionInwardsCalculationActivityIntegrationTest.cs) (revision aca65a56029a6646ce2e997d7c14e547356b5b65) @@ -125,7 +125,14 @@ Assert.IsEmpty(settings.PreprocessorDirectory); }) .Return(new TestHydraulicLoadsCalculator()); - calculatorFactory.Stub(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(new TestHydraulicLoadsCalculator()); + calculatorFactory.Stub(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(new TestHydraulicLoadsCalculator()); mockRepository.ReplayAll(); var assessmentSection = new AssessmentSection(AssessmentSectionComposition.Dike); @@ -514,7 +521,14 @@ var mockRepository = new MockRepository(); var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(new TestOvertoppingCalculator()); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); mockRepository.ReplayAll(); var assessmentSection = new AssessmentSection(AssessmentSectionComposition.Dike); @@ -606,7 +620,14 @@ var calculatorFactory = mockRepository.StrictMock(); var overtoppingCalculator = new TestOvertoppingCalculator(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); mockRepository.ReplayAll(); var assessmentSection = new AssessmentSection(AssessmentSectionComposition.Dike); @@ -665,7 +686,14 @@ var mockRepository = new MockRepository(); var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); mockRepository.ReplayAll(); var assessmentSection = new AssessmentSection(AssessmentSectionComposition.Dike); @@ -725,7 +753,14 @@ var mockRepository = new MockRepository(); var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); mockRepository.ReplayAll(); var assessmentSection = new AssessmentSection(AssessmentSectionComposition.Dike); @@ -785,7 +820,14 @@ var mockRepository = new MockRepository(); var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); mockRepository.ReplayAll(); var assessmentSection = new AssessmentSection(AssessmentSectionComposition.Dike); @@ -846,7 +888,14 @@ }; var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(new TestOvertoppingCalculator()); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); mockRepository.ReplayAll(); var assessmentSection = new AssessmentSection(AssessmentSectionComposition.Dike); @@ -893,7 +942,14 @@ var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(new TestOvertoppingCalculator()); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(new TestHydraulicLoadsCalculator()); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(new TestHydraulicLoadsCalculator()); mockRepository.ReplayAll(); var assessmentSection = new AssessmentSection(AssessmentSectionComposition.Dike); Index: Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Service.Test/GrassCoverErosionInwardsCalculationServiceTest.cs =================================================================== diff -u -r664870ad3a5105ce8865a49d5ba07661b50320fd -raca65a56029a6646ce2e997d7c14e547356b5b65 --- Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Service.Test/GrassCoverErosionInwardsCalculationServiceTest.cs (.../GrassCoverErosionInwardsCalculationServiceTest.cs) (revision 664870ad3a5105ce8865a49d5ba07661b50320fd) +++ Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Service.Test/GrassCoverErosionInwardsCalculationServiceTest.cs (.../GrassCoverErosionInwardsCalculationServiceTest.cs) (revision aca65a56029a6646ce2e997d7c14e547356b5b65) @@ -780,7 +780,13 @@ { IllustrationPointsResult = new TestGeneralResult() }); - calculatorFactory.Stub(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(new TestHydraulicLoadsCalculator + calculatorFactory.Stub(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }).Return(new TestHydraulicLoadsCalculator { IllustrationPointsResult = new TestGeneralResult() }); @@ -896,7 +902,14 @@ var overtoppingCalculator = new TestOvertoppingCalculator(); var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); mockRepository.ReplayAll(); DikeProfile dikeProfile = GetDikeProfile(); @@ -1092,7 +1105,14 @@ var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); var dikeHeightCalculator = new TestHydraulicLoadsCalculator(); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); mockRepository.ReplayAll(); var calculation = new GrassCoverErosionInwardsCalculation @@ -1152,7 +1172,14 @@ var overtoppingRateCalculator = new TestHydraulicLoadsCalculator(); var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(new TestHydraulicLoadsCalculator()); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(new TestHydraulicLoadsCalculator()); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { @@ -1440,7 +1467,14 @@ var overtoppingCalculator = new TestOvertoppingCalculator(); var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); mockRepository.ReplayAll(); DikeProfile dikeProfile = GetDikeProfile(); @@ -1511,7 +1545,14 @@ var overtoppingCalculator = new TestOvertoppingCalculator(); var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); mockRepository.ReplayAll(); DikeProfile dikeProfile = GetDikeProfile(); @@ -1583,7 +1624,14 @@ var calculatorFactory = mockRepository.StrictMock(); var overtoppingCalculator = new TestOvertoppingCalculator(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); mockRepository.ReplayAll(); DikeProfile dikeProfile = GetDikeProfile(); @@ -1656,7 +1704,14 @@ var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(new TestHydraulicLoadsCalculator()); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(new TestHydraulicLoadsCalculator()); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { @@ -1734,7 +1789,14 @@ var overtoppingCalculator = new TestOvertoppingCalculator(); var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(new TestHydraulicLoadsCalculator()); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(new TestHydraulicLoadsCalculator()); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { @@ -1898,7 +1960,14 @@ }; var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { @@ -1987,7 +2056,14 @@ }; var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { @@ -2076,7 +2152,14 @@ }; var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { @@ -2165,7 +2248,14 @@ }; var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { @@ -2254,7 +2344,14 @@ }; var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { @@ -2343,7 +2440,14 @@ }; var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { @@ -2431,7 +2535,14 @@ }; var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { @@ -2521,7 +2632,14 @@ }; var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { @@ -2613,7 +2731,14 @@ }; var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { @@ -2703,7 +2828,14 @@ }; var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { @@ -2795,7 +2927,14 @@ }; var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { @@ -2885,7 +3024,14 @@ }; var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { @@ -2968,7 +3114,14 @@ var overtoppingRateCalculator = new TestHydraulicLoadsCalculator(); var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { @@ -3020,7 +3173,14 @@ var overtoppingRateCalculator = new TestHydraulicLoadsCalculator(); var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, validPreprocessorDirectory)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, validPreprocessorDirectory)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.AreEqual(validPreprocessorDirectory, settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { @@ -3077,7 +3237,14 @@ var overtoppingRateCalculator = new TestHydraulicLoadsCalculator(); var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath, string.Empty)).Return(overtoppingCalculator); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath, string.Empty)).Return(dikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(Arg.Is.NotNull)) + .WhenCalled(invocation => + { + var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + Assert.AreEqual(testDataPath, settings.HlcdFilePath); + Assert.IsEmpty(settings.PreprocessorDirectory); + }) + .Return(dikeHeightCalculator); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { Index: Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/Factory/HydraRingCalculatorFactory.cs =================================================================== diff -u -r664870ad3a5105ce8865a49d5ba07661b50320fd -raca65a56029a6646ce2e997d7c14e547356b5b65 --- Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/Factory/HydraRingCalculatorFactory.cs (.../HydraRingCalculatorFactory.cs) (revision 664870ad3a5105ce8865a49d5ba07661b50320fd) +++ Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/Factory/HydraRingCalculatorFactory.cs (.../HydraRingCalculatorFactory.cs) (revision aca65a56029a6646ce2e997d7c14e547356b5b65) @@ -58,10 +58,9 @@ return new OvertoppingCalculator(settings); } - public IHydraulicLoadsCalculator CreateDikeHeightCalculator(string hlcdDirectory, string preprocessorDirectory) + public IHydraulicLoadsCalculator CreateDikeHeightCalculator(HydraRingCalculationSettings calculationSettings) { - var settings = new HydraRingCalculationSettings(hlcdDirectory, preprocessorDirectory); - return new HydraulicLoadsCalculator(settings); + return new HydraulicLoadsCalculator(calculationSettings); } public IHydraulicLoadsCalculator CreateOvertoppingRateCalculator(HydraRingCalculationSettings calculationSettings) Index: Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/Factory/IHydraRingCalculatorFactory.cs =================================================================== diff -u -r664870ad3a5105ce8865a49d5ba07661b50320fd -raca65a56029a6646ce2e997d7c14e547356b5b65 --- Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/Factory/IHydraRingCalculatorFactory.cs (.../IHydraRingCalculatorFactory.cs) (revision 664870ad3a5105ce8865a49d5ba07661b50320fd) +++ Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/Factory/IHydraRingCalculatorFactory.cs (.../IHydraRingCalculatorFactory.cs) (revision aca65a56029a6646ce2e997d7c14e547356b5b65) @@ -57,21 +57,21 @@ /// /// Creates a calculator for calculating a dike height. /// - /// The directory where the hydraulic database can be found. - /// The preprocessor directory. - /// Preprocessing is disabled when + /// The with the + /// general information for a Hydra-Ring calculation. + /// A new .> + /// Thrown when + /// is null. + /// Preprocessing is disabled when /// equals . - /// A new . - /// Thrown when - /// or is null. - IHydraulicLoadsCalculator CreateDikeHeightCalculator(string hlcdDirectory, string preprocessorDirectory); + IHydraulicLoadsCalculator CreateDikeHeightCalculator(HydraRingCalculationSettings calculationSettings); /// /// Creates a calculator for calculating an overtopping rate. /// /// The with the - /// general information for a Hydra-Ring calculation. - /// A new .> + /// general information for a Hydra-Ring calculation. + /// A new .> /// Thrown when /// is null. /// Preprocessing is disabled when