Index: Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Assembly/FailureMechanismSectionAssemblyCalculator.cs =================================================================== diff -u -re3d82403f9b3becf298210982ab410deacb3673d -rc64583d0bc73943162633d5517fa94e5e1557c8f --- Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Assembly/FailureMechanismSectionAssemblyCalculator.cs (.../FailureMechanismSectionAssemblyCalculator.cs) (revision e3d82403f9b3becf298210982ab410deacb3673d) +++ Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Assembly/FailureMechanismSectionAssemblyCalculator.cs (.../FailureMechanismSectionAssemblyCalculator.cs) (revision c64583d0bc73943162633d5517fa94e5e1557c8f) @@ -272,9 +272,9 @@ try { IFailureMechanismSectionAssemblyCalculatorKernel kernel = factory.CreateFailureMechanismSectionAssemblyKernel(); - Tuple input = + Tuple input = FailureMechanismSectionAssemblyCalculatorInputCreator.ConvertTailorMadeFailureMechanismSectionAssemblyCategoryGroup(tailorMadeAssessmentResult); - + FmSectionAssemblyDirectResult output = kernel.TranslateAssessmentResultWbi0T4(input.Item1, input.Item2); return FailureMechanismSectionAssemblyCreator.ConvertFailureMechanismSectionCategory(output.Result); @@ -296,12 +296,12 @@ try { IFailureMechanismSectionAssemblyCalculatorKernel kernel = factory.CreateFailureMechanismSectionAssemblyKernel(); - CalculationOutput output = kernel.CombinedAssessmentFromFailureMechanismSectionResults( - FailureMechanismSectionAssemblyCalculatorInputCreator.CreateFailureMechanismSectionAssemblyCategoryResult(simpleAssembly), - FailureMechanismSectionAssemblyCalculatorInputCreator.CreateFailureMechanismSectionAssemblyCategoryResult(detailedAssembly), - FailureMechanismSectionAssemblyCalculatorInputCreator.CreateFailureMechanismSectionAssemblyCategoryResult(tailorMadeAssembly)); + var output = (FmSectionAssemblyDirectResult) kernel.TranslateAssessmentResultWbi0A1( + FailureMechanismSectionAssemblyCalculatorInputCreator.CreateFailureMechanismSectionAssemblyDirectResult(simpleAssembly), + FailureMechanismSectionAssemblyCalculatorInputCreator.CreateFailureMechanismSectionAssemblyDirectResult(detailedAssembly), + FailureMechanismSectionAssemblyCalculatorInputCreator.CreateFailureMechanismSectionAssemblyDirectResult(tailorMadeAssembly)); - return FailureMechanismSectionAssemblyCreator.Create(output.Result); + return FailureMechanismSectionAssemblyCreator.Create(output); } catch (Exception e) { @@ -316,10 +316,10 @@ try { IFailureMechanismSectionAssemblyCalculatorKernel kernel = factory.CreateFailureMechanismSectionAssemblyKernel(); - CalculationOutput output = kernel.CombinedAssessmentFromFailureMechanismSectionResults( - FailureMechanismSectionAssemblyCalculatorInputCreator.ConvertFailureMechanismSectionAssemblyCategoryGroup(simpleAssembly), - FailureMechanismSectionAssemblyCalculatorInputCreator.ConvertFailureMechanismSectionAssemblyCategoryGroup(detailedAssembly), - FailureMechanismSectionAssemblyCalculatorInputCreator.ConvertFailureMechanismSectionAssemblyCategoryGroup(tailorMadeAssembly)); + var output = (FmSectionAssemblyDirectResult) kernel.TranslateAssessmentResultWbi0A1( + FailureMechanismSectionAssemblyCalculatorInputCreator.CreateFailureMechanismSectionAssemblyDirectResult(simpleAssembly), + FailureMechanismSectionAssemblyCalculatorInputCreator.CreateFailureMechanismSectionAssemblyDirectResult(detailedAssembly), + FailureMechanismSectionAssemblyCalculatorInputCreator.CreateFailureMechanismSectionAssemblyDirectResult(tailorMadeAssembly)); return FailureMechanismSectionAssemblyCreator.ConvertFailureMechanismSectionCategory(output.Result); } Index: Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Creators/FailureMechanismSectionAssemblyCalculatorInputCreator.cs =================================================================== diff -u -re3d82403f9b3becf298210982ab410deacb3673d -rc64583d0bc73943162633d5517fa94e5e1557c8f --- Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Creators/FailureMechanismSectionAssemblyCalculatorInputCreator.cs (.../FailureMechanismSectionAssemblyCalculatorInputCreator.cs) (revision e3d82403f9b3becf298210982ab410deacb3673d) +++ Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Creators/FailureMechanismSectionAssemblyCalculatorInputCreator.cs (.../FailureMechanismSectionAssemblyCalculatorInputCreator.cs) (revision c64583d0bc73943162633d5517fa94e5e1557c8f) @@ -113,7 +113,7 @@ /// a valid but unsupported . /// Thrown when any input parameter has an /// invalid value. - public static FmSectionAssemblyDirectResult CreateFailureMechanismSectionAssemblyCategoryResult(FailureMechanismSectionAssembly assembly) + public static FmSectionAssemblyDirectResult CreateFailureMechanismSectionAssemblyDirectResult(FailureMechanismSectionAssembly assembly) { if (assembly == null) { @@ -126,6 +126,22 @@ } /// + /// Creates based on the given parameters. + /// + /// The category group to convert. + /// The created . + /// Thrown when is + /// an invalid . + /// Thrown when is + /// a valid but unsupported . + /// Thrown when any input parameter has an + /// invalid value. + public static FmSectionAssemblyDirectResult CreateFailureMechanismSectionAssemblyDirectResult(FailureMechanismSectionAssemblyCategoryGroup categoryGroup) + { + return new FmSectionAssemblyDirectResult(ConvertFailureMechanismSectionAssemblyCategoryGroup(categoryGroup)); + } + + /// /// Creates a based on the given parameters. /// /// The detailed assessment result @@ -327,15 +343,15 @@ } /// - /// Converts a into a . + /// Converts a into a . /// /// The to convert. - /// A based on . + /// A based on . /// Thrown when /// is an invalid value. /// Thrown when /// is a valid value, but unsupported. - public static EFmSectionCategory ConvertFailureMechanismSectionAssemblyCategoryGroup( + public static Tuple ConvertTailorMadeFailureMechanismSectionAssemblyCategoryGroup( FailureMechanismSectionAssemblyCategoryGroup category) { if (!Enum.IsDefined(typeof(FailureMechanismSectionAssemblyCategoryGroup), category)) @@ -348,38 +364,38 @@ switch (category) { case FailureMechanismSectionAssemblyCategoryGroup.Iv: - return EFmSectionCategory.Iv; + return new Tuple(EAssessmentResultTypeT3.ResultSpecified, EFmSectionCategory.Iv); case FailureMechanismSectionAssemblyCategoryGroup.IIv: - return EFmSectionCategory.IIv; + return new Tuple(EAssessmentResultTypeT3.ResultSpecified, EFmSectionCategory.IIv); case FailureMechanismSectionAssemblyCategoryGroup.IIIv: - return EFmSectionCategory.IIIv; + return new Tuple(EAssessmentResultTypeT3.ResultSpecified, EFmSectionCategory.IIIv); case FailureMechanismSectionAssemblyCategoryGroup.IVv: - return EFmSectionCategory.IVv; + return new Tuple(EAssessmentResultTypeT3.ResultSpecified, EFmSectionCategory.IVv); case FailureMechanismSectionAssemblyCategoryGroup.Vv: - return EFmSectionCategory.Vv; + return new Tuple(EAssessmentResultTypeT3.ResultSpecified, EFmSectionCategory.Vv); case FailureMechanismSectionAssemblyCategoryGroup.VIv: - return EFmSectionCategory.VIv; + return new Tuple(EAssessmentResultTypeT3.ResultSpecified, EFmSectionCategory.VIv); case FailureMechanismSectionAssemblyCategoryGroup.VIIv: - return EFmSectionCategory.VIIv; + return new Tuple(EAssessmentResultTypeT3.ResultSpecified, EFmSectionCategory.VIIv); case FailureMechanismSectionAssemblyCategoryGroup.NotApplicable: - return EFmSectionCategory.NotApplicable; + return new Tuple(EAssessmentResultTypeT3.ResultSpecified, EFmSectionCategory.NotApplicable); case FailureMechanismSectionAssemblyCategoryGroup.None: - return EFmSectionCategory.Gr; + return new Tuple(EAssessmentResultTypeT3.Gr, null); default: throw new NotSupportedException(); } } /// - /// Converts a into a . + /// Converts a into a . /// /// The to convert. - /// A based on . + /// A based on . /// Thrown when /// is an invalid value. /// Thrown when /// is a valid value, but unsupported. - public static Tuple ConvertTailorMadeFailureMechanismSectionAssemblyCategoryGroup( + private static EFmSectionCategory ConvertFailureMechanismSectionAssemblyCategoryGroup( FailureMechanismSectionAssemblyCategoryGroup category) { if (!Enum.IsDefined(typeof(FailureMechanismSectionAssemblyCategoryGroup), category)) @@ -392,23 +408,23 @@ switch (category) { case FailureMechanismSectionAssemblyCategoryGroup.Iv: - return new Tuple(EAssessmentResultTypeT3.ResultSpecified, EFmSectionCategory.Iv); + return EFmSectionCategory.Iv; case FailureMechanismSectionAssemblyCategoryGroup.IIv: - return new Tuple(EAssessmentResultTypeT3.ResultSpecified, EFmSectionCategory.IIv); + return EFmSectionCategory.IIv; case FailureMechanismSectionAssemblyCategoryGroup.IIIv: - return new Tuple(EAssessmentResultTypeT3.ResultSpecified, EFmSectionCategory.IIIv); + return EFmSectionCategory.IIIv; case FailureMechanismSectionAssemblyCategoryGroup.IVv: - return new Tuple(EAssessmentResultTypeT3.ResultSpecified, EFmSectionCategory.IVv); + return EFmSectionCategory.IVv; case FailureMechanismSectionAssemblyCategoryGroup.Vv: - return new Tuple(EAssessmentResultTypeT3.ResultSpecified, EFmSectionCategory.Vv); + return EFmSectionCategory.Vv; case FailureMechanismSectionAssemblyCategoryGroup.VIv: - return new Tuple(EAssessmentResultTypeT3.ResultSpecified, EFmSectionCategory.VIv); + return EFmSectionCategory.VIv; case FailureMechanismSectionAssemblyCategoryGroup.VIIv: - return new Tuple(EAssessmentResultTypeT3.ResultSpecified, EFmSectionCategory.VIIv); + return EFmSectionCategory.VIIv; case FailureMechanismSectionAssemblyCategoryGroup.NotApplicable: - return new Tuple(EAssessmentResultTypeT3.ResultSpecified, EFmSectionCategory.NotApplicable); + return EFmSectionCategory.NotApplicable; case FailureMechanismSectionAssemblyCategoryGroup.None: - return new Tuple(EAssessmentResultTypeT3.Gr, null); + return EFmSectionCategory.Gr; default: throw new NotSupportedException(); } Index: Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Assembly/FailureMechanismSectionAssemblyCalculatorTest.cs =================================================================== diff -u -re3d82403f9b3becf298210982ab410deacb3673d -rc64583d0bc73943162633d5517fa94e5e1557c8f --- Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Assembly/FailureMechanismSectionAssemblyCalculatorTest.cs (.../FailureMechanismSectionAssemblyCalculatorTest.cs) (revision e3d82403f9b3becf298210982ab410deacb3673d) +++ Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Assembly/FailureMechanismSectionAssemblyCalculatorTest.cs (.../FailureMechanismSectionAssemblyCalculatorTest.cs) (revision c64583d0bc73943162633d5517fa94e5e1557c8f) @@ -126,60 +126,59 @@ public void AssembleSimpleAssessment_WithValidInput_InputCorrectlySetToKernel() { // Setup - const SimpleAssessmentResultType assessmentResult = SimpleAssessmentResultType.AssessFurther; + var random = new Random(39); + var assessmentResult = random.NextEnumValue(); using (new AssemblyToolKernelFactoryConfig()) { var factory = (TestAssemblyToolKernelFactory) AssemblyToolKernelFactory.Instance; FailureMechanismSectionAssemblyKernelStub kernel = factory.LastCreatedFailureMechanismSectionAssemblyKernel; - kernel.FailureMechanismSectionAssemblyCategoryResult = new CalculationOutput( - new FailureMechanismSectionAssemblyCategoryResult(FailureMechanismSectionCategoryGroup.Iv, Probability.NaN)); var calculator = new FailureMechanismSectionAssemblyCalculator(factory); // Call calculator.AssembleSimpleAssessment(assessmentResult); // Assert - Assert.AreEqual(SimpleCalculationResult.VB, kernel.SimpleAssessmentFailureMechanismsInput); + Assert.AreEqual(GetAssessmentResultTypeE1(assessmentResult), kernel.AssessmentResultTypeE1Input); } } [Test] public void AssembleSimpleAssessment_KernelWithCompleteOutput_OutputCorrectlyReturnedByCalculator() { // Setup + var random = new Random(39); using (new AssemblyToolKernelFactoryConfig()) { var factory = (TestAssemblyToolKernelFactory) AssemblyToolKernelFactory.Instance; FailureMechanismSectionAssemblyKernelStub kernel = factory.LastCreatedFailureMechanismSectionAssemblyKernel; - kernel.FailureMechanismSectionAssemblyCategoryResult = new CalculationOutput( - new FailureMechanismSectionAssemblyCategoryResult(FailureMechanismSectionCategoryGroup.Iv, Probability.NaN)); + kernel.FailureMechanismSectionDirectResult = new FmSectionAssemblyDirectResult(random.NextEnumValue()); var calculator = new FailureMechanismSectionAssemblyCalculator(factory); // Call - FailureMechanismSectionAssembly assembly = calculator.AssembleSimpleAssessment(SimpleAssessmentResultType.AssessFurther); + FailureMechanismSectionAssembly assembly = calculator.AssembleSimpleAssessment(random.NextEnumValue()); // Assert - AssertCalculatorOutput(kernel.FailureMechanismSectionAssemblyCategoryResult, assembly); + AssertCalculatorOutput(kernel.FailureMechanismSectionDirectResult, assembly); } } [Test] public void AssembleSimpleAssessment_KernelWithInvalidOutput_ThrowFailureMechanismSectionAssemblyCalculatorException() { // Setup + var random = new Random(39); using (new AssemblyToolKernelFactoryConfig()) { var factory = (TestAssemblyToolKernelFactory) AssemblyToolKernelFactory.Instance; FailureMechanismSectionAssemblyKernelStub kernel = factory.LastCreatedFailureMechanismSectionAssemblyKernel; - kernel.FailureMechanismSectionAssemblyCategoryResult = new CalculationOutput( - new FailureMechanismSectionAssemblyCategoryResult((FailureMechanismSectionCategoryGroup) 99, Probability.NaN)); + kernel.FailureMechanismSectionDirectResult = new FmSectionAssemblyDirectResult((EFmSectionCategory) 99); var calculator = new FailureMechanismSectionAssemblyCalculator(factory); // Call - TestDelegate test = () => calculator.AssembleSimpleAssessment(SimpleAssessmentResultType.AssessFurther); + TestDelegate test = () => calculator.AssembleSimpleAssessment(random.NextEnumValue()); // Assert var exception = Assert.Throws(test); @@ -193,6 +192,7 @@ public void AssembleSimpleAssessment_KernelThrowsException_ThrowFailureMechanismSectionAssemblyCalculatorException() { // Setup + var random = new Random(39); using (new AssemblyToolKernelFactoryConfig()) { var factory = (TestAssemblyToolKernelFactory) AssemblyToolKernelFactory.Instance; @@ -202,7 +202,7 @@ var calculator = new FailureMechanismSectionAssemblyCalculator(factory); // Call - TestDelegate test = () => calculator.AssembleSimpleAssessment(SimpleAssessmentResultType.AssessFurther); + TestDelegate test = () => calculator.AssembleSimpleAssessment(random.NextEnumValue()); // Assert var exception = Assert.Throws(test); @@ -219,7 +219,6 @@ using (new AssemblyToolKernelFactoryConfig()) { var factory = (TestAssemblyToolKernelFactory) AssemblyToolKernelFactory.Instance; - var calculator = new FailureMechanismSectionAssemblyCalculator(factory); // Call @@ -237,60 +236,59 @@ public void AssembleSimpleAssessmentValidityOnly_WithValidInput_InputCorrectlySetToKernel() { // Setup - const SimpleAssessmentValidityOnlyResultType assessmentResult = SimpleAssessmentValidityOnlyResultType.Applicable; + var random = new Random(39); + var assessmentResult = random.NextEnumValue(); using (new AssemblyToolKernelFactoryConfig()) { var factory = (TestAssemblyToolKernelFactory) AssemblyToolKernelFactory.Instance; FailureMechanismSectionAssemblyKernelStub kernel = factory.LastCreatedFailureMechanismSectionAssemblyKernel; - kernel.FailureMechanismSectionAssemblyCategoryResult = new CalculationOutput( - new FailureMechanismSectionAssemblyCategoryResult(FailureMechanismSectionCategoryGroup.Iv, Probability.NaN)); var calculator = new FailureMechanismSectionAssemblyCalculator(factory); // Call calculator.AssembleSimpleAssessment(assessmentResult); // Assert - Assert.AreEqual(SimpleCalculationResultValidityOnly.WVT, kernel.SimpleAssessmentFailureMechanismsValidityOnlyInput); + Assert.AreEqual(GetAssessmentResultTypeE2(assessmentResult), kernel.AssessmentResultTypeE2Input); } } [Test] public void AssembleSimpleAssessmentValidityOnly_KernelWithCompleteOutput_OutputCorrectlyReturnedByCalculator() { // Setup + var random = new Random(39); using (new AssemblyToolKernelFactoryConfig()) { var factory = (TestAssemblyToolKernelFactory) AssemblyToolKernelFactory.Instance; FailureMechanismSectionAssemblyKernelStub kernel = factory.LastCreatedFailureMechanismSectionAssemblyKernel; - kernel.FailureMechanismSectionAssemblyCategoryResult = new CalculationOutput( - new FailureMechanismSectionAssemblyCategoryResult(FailureMechanismSectionCategoryGroup.Iv, Probability.NaN)); + kernel.FailureMechanismSectionDirectResult = new FmSectionAssemblyDirectResult(random.NextEnumValue()); var calculator = new FailureMechanismSectionAssemblyCalculator(factory); // Call - FailureMechanismSectionAssembly assembly = calculator.AssembleSimpleAssessment(SimpleAssessmentValidityOnlyResultType.NotApplicable); + FailureMechanismSectionAssembly assembly = calculator.AssembleSimpleAssessment(random.NextEnumValue()); // Assert - AssertCalculatorOutput(kernel.FailureMechanismSectionAssemblyCategoryResult, assembly); + AssertCalculatorOutput(kernel.FailureMechanismSectionDirectResult, assembly); } } [Test] public void AssembleSimpleAssessmentValidityOnly_KernelWithInvalidOutput_ThrowFailureMechanismSectionAssemblyCalculatorException() { // Setup + var random = new Random(39); using (new AssemblyToolKernelFactoryConfig()) { var factory = (TestAssemblyToolKernelFactory) AssemblyToolKernelFactory.Instance; FailureMechanismSectionAssemblyKernelStub kernel = factory.LastCreatedFailureMechanismSectionAssemblyKernel; - kernel.FailureMechanismSectionAssemblyCategoryResult = new CalculationOutput( - new FailureMechanismSectionAssemblyCategoryResult((FailureMechanismSectionCategoryGroup) 99, Probability.NaN)); + kernel.FailureMechanismSectionDirectResult = new FmSectionAssemblyDirectResult((EFmSectionCategory) 99); var calculator = new FailureMechanismSectionAssemblyCalculator(factory); // Call - TestDelegate test = () => calculator.AssembleSimpleAssessment(SimpleAssessmentValidityOnlyResultType.Applicable); + TestDelegate test = () => calculator.AssembleSimpleAssessment(random.NextEnumValue()); // Assert var exception = Assert.Throws(test); @@ -304,6 +302,7 @@ public void AssembleSimpleAssessmentValidityOnly_KernelThrowsException_ThrowFailureMechanismSectionAssemblyCalculatorException() { // Setup + var random = new Random(39); using (new AssemblyToolKernelFactoryConfig()) { var factory = (TestAssemblyToolKernelFactory) AssemblyToolKernelFactory.Instance; @@ -313,7 +312,7 @@ var calculator = new FailureMechanismSectionAssemblyCalculator(factory); // Call - TestDelegate test = () => calculator.AssembleSimpleAssessment(SimpleAssessmentValidityOnlyResultType.Applicable); + TestDelegate test = () => calculator.AssembleSimpleAssessment(random.NextEnumValue()); // Assert var exception = Assert.Throws(test); @@ -322,6 +321,38 @@ } } + private static EAssessmentResultTypeE1 GetAssessmentResultTypeE1(SimpleAssessmentResultType detailedAssessmentResult) + { + switch (detailedAssessmentResult) + { + case SimpleAssessmentResultType.None: + return EAssessmentResultTypeE1.Gr; + case SimpleAssessmentResultType.NotApplicable: + return EAssessmentResultTypeE1.Nvt; + case SimpleAssessmentResultType.ProbabilityNegligible: + return EAssessmentResultTypeE1.Fv; + case SimpleAssessmentResultType.AssessFurther: + return EAssessmentResultTypeE1.Vb; + default: + throw new NotSupportedException(); + } + } + + private static EAssessmentResultTypeE2 GetAssessmentResultTypeE2(SimpleAssessmentValidityOnlyResultType detailedAssessmentResult) + { + switch (detailedAssessmentResult) + { + case SimpleAssessmentValidityOnlyResultType.None: + return EAssessmentResultTypeE2.Gr; + case SimpleAssessmentValidityOnlyResultType.NotApplicable: + return EAssessmentResultTypeE2.Nvt; + case SimpleAssessmentValidityOnlyResultType.Applicable: + return EAssessmentResultTypeE2.Wvt; + default: + throw new NotSupportedException(); + } + } + #endregion #region Detailed Assessment @@ -1463,7 +1494,7 @@ // Setup var random = new Random(39); var categoryGroupResult = random.NextEnumValue(); - + using (new AssemblyToolKernelFactoryConfig()) { var factory = (TestAssemblyToolKernelFactory) AssemblyToolKernelFactory.Instance; @@ -1475,7 +1506,7 @@ calculator.AssembleTailorMadeAssessment(categoryGroupResult); // Assert - Tuple expectedInput = + Tuple expectedInput = FailureMechanismSectionAssemblyCalculatorInputCreator.ConvertTailorMadeFailureMechanismSectionAssemblyCategoryGroup(categoryGroupResult); Assert.AreEqual(expectedInput.Item1, kernel.AssessmentResultTypeT3Input); @@ -1653,18 +1684,16 @@ { var factory = (TestAssemblyToolKernelFactory) AssemblyToolKernelFactory.Instance; FailureMechanismSectionAssemblyKernelStub kernel = factory.LastCreatedFailureMechanismSectionAssemblyKernel; - kernel.FailureMechanismSectionAssemblyCategoryResult = new CalculationOutput( - new FailureMechanismSectionAssemblyCategoryResult(FailureMechanismSectionCategoryGroup.Iv, Probability.NaN)); var calculator = new FailureMechanismSectionAssemblyCalculator(factory); // Call calculator.AssembleCombined(simpleAssembly, detailedAssembly, tailorMadeAssembly); // Assert - AssertAssembly(simpleAssembly, kernel.CombinedSimpleAssessmentInput); - AssertAssembly(detailedAssembly, kernel.CombinedDetailedAssessmentInput); - AssertAssembly(tailorMadeAssembly, kernel.CombinedTailorMadeAssessmentInput); + AssertAssembly(simpleAssembly, kernel.SimpleAssessmentResultInput); + AssertAssembly(detailedAssembly, kernel.DetailedAssessmentResultInput); + AssertAssembly(tailorMadeAssembly, kernel.TailorMadeAssessmentResultInput); } } @@ -1678,8 +1707,7 @@ { var factory = (TestAssemblyToolKernelFactory) AssemblyToolKernelFactory.Instance; FailureMechanismSectionAssemblyKernelStub kernel = factory.LastCreatedFailureMechanismSectionAssemblyKernel; - kernel.FailureMechanismSectionAssemblyCategoryResult = new CalculationOutput( - new FailureMechanismSectionAssemblyCategoryResult(FailureMechanismSectionCategoryGroup.Iv, Probability.NaN)); + kernel.FailureMechanismSectionDirectResult = new FmSectionAssemblyDirectResult(random.NextEnumValue()); var calculator = new FailureMechanismSectionAssemblyCalculator(factory); @@ -1690,7 +1718,7 @@ new FailureMechanismSectionAssembly(random.NextDouble(), random.NextEnumValue())); // Assert - AssertCalculatorOutput(kernel.FailureMechanismSectionAssemblyCategoryResult, assembly); + AssertCalculatorOutput(kernel.FailureMechanismSectionDirectResult, assembly); } } @@ -1704,8 +1732,7 @@ { var factory = (TestAssemblyToolKernelFactory) AssemblyToolKernelFactory.Instance; FailureMechanismSectionAssemblyKernelStub kernel = factory.LastCreatedFailureMechanismSectionAssemblyKernel; - kernel.FailureMechanismSectionAssemblyCategoryResult = new CalculationOutput( - new FailureMechanismSectionAssemblyCategoryResult((FailureMechanismSectionCategoryGroup) 99, Probability.NaN)); + kernel.FailureMechanismSectionDirectResult = new FmSectionAssemblyDirectResult((EFmSectionCategory) 99); var calculator = new FailureMechanismSectionAssemblyCalculator(factory); @@ -1760,10 +1787,6 @@ using (new AssemblyToolKernelFactoryConfig()) { var factory = (TestAssemblyToolKernelFactory) AssemblyToolKernelFactory.Instance; - FailureMechanismSectionAssemblyKernelStub kernel = factory.LastCreatedFailureMechanismSectionAssemblyKernel; - kernel.FailureMechanismSectionAssemblyCategoryGroup = new CalculationOutput( - FailureMechanismSectionCategoryGroup.VIv); - var calculator = new FailureMechanismSectionAssemblyCalculator(factory); // Call @@ -1792,18 +1815,16 @@ { var factory = (TestAssemblyToolKernelFactory) AssemblyToolKernelFactory.Instance; FailureMechanismSectionAssemblyKernelStub kernel = factory.LastCreatedFailureMechanismSectionAssemblyKernel; - kernel.FailureMechanismSectionAssemblyCategoryGroup = new CalculationOutput( - FailureMechanismSectionCategoryGroup.VIv); var calculator = new FailureMechanismSectionAssemblyCalculator(factory); // Call calculator.AssembleCombined(simpleAssembly, detailedAssembly, tailorMadeAssembly); // Assert - Assert.AreEqual(simpleAssembly, GetGroup(kernel.CombinedSimpleAssessmentGroupInput.Value)); - Assert.AreEqual(detailedAssembly, GetGroup(kernel.CombinedDetailedAssessmentGroupInput.Value)); - Assert.AreEqual(tailorMadeAssembly, GetGroup(kernel.CombinedTailorMadeAssessmentGroupInput.Value)); + Assert.AreEqual(simpleAssembly, GetGroup(kernel.SimpleAssessmentResultInput.Result)); + Assert.AreEqual(detailedAssembly, GetGroup(kernel.DetailedAssessmentResultInput.Result)); + Assert.AreEqual(tailorMadeAssembly, GetGroup(kernel.TailorMadeAssessmentResultInput.Result)); } } @@ -1817,8 +1838,7 @@ { var factory = (TestAssemblyToolKernelFactory) AssemblyToolKernelFactory.Instance; FailureMechanismSectionAssemblyKernelStub kernel = factory.LastCreatedFailureMechanismSectionAssemblyKernel; - kernel.FailureMechanismSectionAssemblyCategoryGroup = new CalculationOutput( - FailureMechanismSectionCategoryGroup.VIv); + kernel.FailureMechanismSectionDirectResult = new FmSectionAssemblyDirectResult(random.NextEnumValue()); var calculator = new FailureMechanismSectionAssemblyCalculator(factory); @@ -1829,7 +1849,7 @@ random.NextEnumValue()); // Assert - Assert.AreEqual(GetGroup(kernel.FailureMechanismSectionAssemblyCategoryGroup.Result), group); + Assert.AreEqual(GetGroup(kernel.FailureMechanismSectionDirectResult.Result), group); } } @@ -1843,8 +1863,7 @@ { var factory = (TestAssemblyToolKernelFactory) AssemblyToolKernelFactory.Instance; FailureMechanismSectionAssemblyKernelStub kernel = factory.LastCreatedFailureMechanismSectionAssemblyKernel; - kernel.FailureMechanismSectionAssemblyCategoryGroup = new CalculationOutput( - (FailureMechanismSectionCategoryGroup) 99); + kernel.FailureMechanismSectionDirectResult = new FmSectionAssemblyDirectResult((EFmSectionCategory) 99); var calculator = new FailureMechanismSectionAssemblyCalculator(factory); @@ -1890,10 +1909,10 @@ } } - private static void AssertAssembly(FailureMechanismSectionAssembly simpleAssembly, FailureMechanismSectionAssemblyCategoryResult kernelInput) + private static void AssertAssembly(FailureMechanismSectionAssembly simpleAssembly, FmSectionAssemblyDirectResult kernelInput) { - Assert.AreEqual(simpleAssembly.Probability, kernelInput.EstimatedProbabilityOfFailure); - Assert.AreEqual(simpleAssembly.Group, GetGroup(kernelInput.CategoryGroup)); + Assert.AreEqual(simpleAssembly.Probability, kernelInput.FailureProbability); + Assert.AreEqual(simpleAssembly.Group, GetGroup(kernelInput.Result)); } #endregion Index: Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Creators/FailureMechanismSectionAssemblyCalculatorInputCreatorTest.cs =================================================================== diff -u -re3d82403f9b3becf298210982ab410deacb3673d -rc64583d0bc73943162633d5517fa94e5e1557c8f --- Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Creators/FailureMechanismSectionAssemblyCalculatorInputCreatorTest.cs (.../FailureMechanismSectionAssemblyCalculatorInputCreatorTest.cs) (revision e3d82403f9b3becf298210982ab410deacb3673d) +++ Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Creators/FailureMechanismSectionAssemblyCalculatorInputCreatorTest.cs (.../FailureMechanismSectionAssemblyCalculatorInputCreatorTest.cs) (revision c64583d0bc73943162633d5517fa94e5e1557c8f) @@ -263,10 +263,10 @@ #region Failure Mechanism Section Assembly [Test] - public void CreateFailureMechanismSectionAssemblyCategoryResult_AssemblyNull_ThrowsArgumentNullException() + public void CreateFailureMechanismSectionAssemblyDirectResult_AssemblyNull_ThrowsArgumentNullException() { // Call - TestDelegate call = () => FailureMechanismSectionAssemblyCalculatorInputCreator.CreateFailureMechanismSectionAssemblyCategoryResult(null); + TestDelegate call = () => FailureMechanismSectionAssemblyCalculatorInputCreator.CreateFailureMechanismSectionAssemblyDirectResult(null); // Assert var exception = Assert.Throws(call); @@ -283,7 +283,7 @@ [TestCase(FailureMechanismSectionAssemblyCategoryGroup.Vv, EFmSectionCategory.Vv)] [TestCase(FailureMechanismSectionAssemblyCategoryGroup.VIv, EFmSectionCategory.VIv)] [TestCase(FailureMechanismSectionAssemblyCategoryGroup.VIIv, EFmSectionCategory.VIIv)] - public void CreateFailureMechanismSectionAssemblyCategoryResult_WithAssembly_ReturnFailureMechanismSectionAssemblyCategoryResult( + public void CreateFailureMechanismSectionAssemblyDirectResult_WithAssembly_ReturnFailureMechanismSectionAssemblyCategoryResult( FailureMechanismSectionAssemblyCategoryGroup originalGroup, EFmSectionCategory expectedGroup) { @@ -292,7 +292,7 @@ var assembly = new FailureMechanismSectionAssembly(random.NextDouble(), originalGroup); // Call - FmSectionAssemblyDirectResult input = FailureMechanismSectionAssemblyCalculatorInputCreator.CreateFailureMechanismSectionAssemblyCategoryResult( + FmSectionAssemblyDirectResult input = FailureMechanismSectionAssemblyCalculatorInputCreator.CreateFailureMechanismSectionAssemblyDirectResult( assembly); // Assert @@ -301,10 +301,10 @@ } [Test] - public void CreateFailureMechanismSectionAssemblyCategoryResult_WithInvalidEnumInput_ThrowInvalidEnumArgumentException() + public void CreateFailureMechanismSectionAssemblyDirectResult_WithInvalidEnumInput_ThrowInvalidEnumArgumentException() { // Call - TestDelegate test = () => FailureMechanismSectionAssemblyCalculatorInputCreator.CreateFailureMechanismSectionAssemblyCategoryResult( + TestDelegate test = () => FailureMechanismSectionAssemblyCalculatorInputCreator.CreateFailureMechanismSectionAssemblyDirectResult( new FailureMechanismSectionAssembly(0, (FailureMechanismSectionAssemblyCategoryGroup) 99)); // Assert @@ -322,23 +322,23 @@ [TestCase(FailureMechanismSectionAssemblyCategoryGroup.Vv, EFmSectionCategory.Vv)] [TestCase(FailureMechanismSectionAssemblyCategoryGroup.VIv, EFmSectionCategory.VIv)] [TestCase(FailureMechanismSectionAssemblyCategoryGroup.VIIv, EFmSectionCategory.VIIv)] - public void ConvertFailureMechanismSectionAssemblyCategoryGroup_ValidGroup_ReturnEFmSectionCategory( + public void CreateFailureMechanismSectionAssemblyDirectResult_WithValidGroup_ReturnEFmSectionCategory( FailureMechanismSectionAssemblyCategoryGroup originalGroup, EFmSectionCategory expectedGroup) { // Call - EFmSectionCategory actualGroup = FailureMechanismSectionAssemblyCalculatorInputCreator.ConvertFailureMechanismSectionAssemblyCategoryGroup( + FmSectionAssemblyDirectResult actualGroup = FailureMechanismSectionAssemblyCalculatorInputCreator.CreateFailureMechanismSectionAssemblyDirectResult( originalGroup); // Assert Assert.AreEqual(expectedGroup, actualGroup); } [Test] - public void ConvertFailureMechanismSectionAssemblyCategoryGroup_InvalidGroup_ThrowInvalidEnumArgumentException() + public void CreateFailureMechanismSectionAssemblyDirectResult_WithInvalidGroup_ThrowInvalidEnumArgumentException() { // Call - TestDelegate test = () => FailureMechanismSectionAssemblyCalculatorInputCreator.ConvertFailureMechanismSectionAssemblyCategoryGroup( + TestDelegate test = () => FailureMechanismSectionAssemblyCalculatorInputCreator.CreateFailureMechanismSectionAssemblyDirectResult( (FailureMechanismSectionAssemblyCategoryGroup) 99); // Assert