Index: Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReader.cs =================================================================== diff -u -rdc381b4bef2de717bfa3ad01b38f5fed7ae98891 -re9961fad25fe961bf28281b004686b8d1bef593f --- Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReader.cs (.../HydraulicBoundaryDatabaseReader.cs) (revision dc381b4bef2de717bfa3ad01b38f5fed7ae98891) +++ Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReader.cs (.../HydraulicBoundaryDatabaseReader.cs) (revision e9961fad25fe961bf28281b004686b8d1bef593f) @@ -33,8 +33,8 @@ namespace Ringtoets.HydraRing.IO.HydraulicBoundaryDatabase { /// - /// This class reads a SqLite database file and constructs a - /// instance from this database. + /// This class reads a hydraulic boundary database file and constructs a + /// instance from this database. /// public class HydraulicBoundaryDatabaseReader : SqLiteDatabaseReaderBase { @@ -56,19 +56,18 @@ /// /// A read hydraulic boundary database. /// Thrown when the database contains incorrect values for required properties. - /// Thrown when a query could not be executed on the database schema. + /// Thrown when the data cannot be read. public ReadHydraulicBoundaryDatabase Read() { return new ReadHydraulicBoundaryDatabase(ReadTrackId(), ReadVersion(), ReadLocations().ToArray()); } /// - /// Reads the track id from the hydraulic boundary database. + /// Reads the track Id from the hydraulic boundary database. /// - /// The track id found in the database. + /// The track Id found in the database. /// Thrown when the database contains incorrect values for required properties. - /// Thrown when a query could not be executed on the database schema - /// or the track id cannot be found. + /// Thrown when the track Id cannot be read. private long ReadTrackId() { try @@ -104,7 +103,7 @@ /// Gets the version of the hydraulic boundary database. /// /// The version found in the database, or if the version cannot be found. - /// Thrown when a query could not be executed on the database schema. + /// Thrown when the version cannot be read.. public string ReadVersion() { try @@ -134,7 +133,7 @@ } /// - /// + /// Reads the locations from the database. /// /// Thrown when the database contains incorrect values for required properties. private IEnumerable ReadLocations() @@ -149,10 +148,9 @@ } /// - /// Reads the next location from the database. + /// Reads a location from the database. /// - /// A new instance of based on the data read from - /// the database or null if no data is available. + /// A based on the data read from the database. /// Thrown when the database contains incorrect values for required properties. private ReadHydraulicBoundaryLocation ReadLocation(IDataReader reader) { Index: Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicBoundaryDatabase/ReadHydraulicBoundaryDatabase.cs =================================================================== diff -u -r9f8630eed6ba63a3cac3fe42b6600605d289fac8 -re9961fad25fe961bf28281b004686b8d1bef593f --- Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicBoundaryDatabase/ReadHydraulicBoundaryDatabase.cs (.../ReadHydraulicBoundaryDatabase.cs) (revision 9f8630eed6ba63a3cac3fe42b6600605d289fac8) +++ Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicBoundaryDatabase/ReadHydraulicBoundaryDatabase.cs (.../ReadHydraulicBoundaryDatabase.cs) (revision e9961fad25fe961bf28281b004686b8d1bef593f) @@ -31,7 +31,7 @@ /// /// Creates a new instance of . /// - /// The track ID of the read hydraulic boundary database. + /// The track Id of the read hydraulic boundary database. /// The version of the read hydraulic boundary database. /// The read hydraulic boundary locations. internal ReadHydraulicBoundaryDatabase(long trackId, string version, IEnumerable locations) Index: Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReaderTest.cs =================================================================== diff -u -rdc381b4bef2de717bfa3ad01b38f5fed7ae98891 -re9961fad25fe961bf28281b004686b8d1bef593f --- Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReaderTest.cs (.../HydraulicBoundaryDatabaseReaderTest.cs) (revision dc381b4bef2de717bfa3ad01b38f5fed7ae98891) +++ Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReaderTest.cs (.../HydraulicBoundaryDatabaseReaderTest.cs) (revision e9961fad25fe961bf28281b004686b8d1bef593f) @@ -73,16 +73,16 @@ [Test] [TestCase(null)] [TestCase("")] - public void Constructor_FileNullOrEmpty_ThrowsCriticalFileReadException(string hydraulicBoundaryDatabaseFile) + public void Constructor_FilePathNullOrEmpty_ThrowsCriticalFileReadException(string hydraulicBoundaryDatabaseFilePath) { // Call TestDelegate test = () => { - using (new HydraulicBoundaryDatabaseReader(hydraulicBoundaryDatabaseFile)) {} + using (new HydraulicBoundaryDatabaseReader(hydraulicBoundaryDatabaseFilePath)) {} }; // Assert - string expectedMessage = $"Fout bij het lezen van bestand '{hydraulicBoundaryDatabaseFile}': bestandspad mag niet leeg of ongedefinieerd zijn."; + string expectedMessage = $"Fout bij het lezen van bestand '{hydraulicBoundaryDatabaseFilePath}': bestandspad mag niet leeg of ongedefinieerd zijn."; var exception = Assert.Throws(test); Assert.AreEqual(expectedMessage, exception.Message); } @@ -175,7 +175,7 @@ // Assert Assert.AreEqual("Dutch coast South19-11-2015 12:0013", readDatabase.Version); - Assert.AreEqual((long) 13, readDatabase.TrackId); + Assert.AreEqual(13, readDatabase.TrackId); Assert.AreEqual(18, readDatabase.Locations.Count()); ReadHydraulicBoundaryLocation location = readDatabase.Locations.First(); Assert.AreEqual(1, location.Id);