Index: Ringtoets/Common/test/Ringtoets.Common.Forms.Test/GuiServices/HydraulicBoundaryLocationCalculationGuiServiceTest.cs =================================================================== diff -u -r171d7076759cc5d094c73342e3f5c24d642f4380 -ref6277218199e4e5168132ac6f9ffd7fab2e8008 --- Ringtoets/Common/test/Ringtoets.Common.Forms.Test/GuiServices/HydraulicBoundaryLocationCalculationGuiServiceTest.cs (.../HydraulicBoundaryLocationCalculationGuiServiceTest.cs) (revision 171d7076759cc5d094c73342e3f5c24d642f4380) +++ Ringtoets/Common/test/Ringtoets.Common.Forms.Test/GuiServices/HydraulicBoundaryLocationCalculationGuiServiceTest.cs (.../HydraulicBoundaryLocationCalculationGuiServiceTest.cs) (revision ef6277218199e4e5168132ac6f9ffd7fab2e8008) @@ -40,7 +40,6 @@ [TestFixture] public class HydraulicBoundaryLocationCalculationGuiServiceTest : NUnitFormTest { - private MockRepository mockRepository; private static readonly string testDataPath = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.Integration.Service, "HydraRingCalculation"); private static readonly string validFilePath = Path.Combine(testDataPath, "HRD dutch coast south.sqlite"); private static readonly string validPreprocessorDirectory = TestHelper.GetScratchPadPath(); @@ -75,12 +74,11 @@ public void CalculateDesignWaterLevels_CalculationsNull_ThrowsArgumentNullException() { // Setup - var calculatorFactory = mockRepository.StrictMock(); + var mockRepository = new MockRepository(); var calculationMessageProvider = mockRepository.StrictMock(); mockRepository.ReplayAll(); using (var viewParent = new Form()) - using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { var guiService = new HydraulicBoundaryLocationCalculationGuiService(viewParent); @@ -104,11 +102,7 @@ public void CalculateDesignWaterLevels_CalculationServiceMessageProviderNull_ThrowsArgumentNullException() { // Setup - var calculatorFactory = mockRepository.StrictMock(); - mockRepository.ReplayAll(); - using (var viewParent = new Form()) - using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { var guiService = new HydraulicBoundaryLocationCalculationGuiService(viewParent); @@ -124,20 +118,17 @@ const string expectedParamName = "messageProvider"; Assert.AreEqual(expectedParamName, paramName); } - - mockRepository.VerifyAll(); } [Test] public void CalculateDesignWaterLevels_HydraulicDatabaseDoesNotExist_LogsError() { // Setup - var calculatorFactory = mockRepository.StrictMock(); + var mockRepository = new MockRepository(); var calculationMessageProvider = mockRepository.StrictMock(); mockRepository.ReplayAll(); using (var viewParent = new Form()) - using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { var guiService = new HydraulicBoundaryLocationCalculationGuiService(viewParent); @@ -164,12 +155,11 @@ public void CalculateDesignWaterLevels_InvalidNorm_LogsError() { // Setup - var calculatorFactory = mockRepository.StrictMock(); + var mockRepository = new MockRepository(); var calculationMessageProvider = mockRepository.StrictMock(); mockRepository.ReplayAll(); using (var viewParent = new Form()) - using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { var guiService = new HydraulicBoundaryLocationCalculationGuiService(viewParent); @@ -181,12 +171,7 @@ calculationMessageProvider); // Assert - TestHelper.AssertLogMessages(call, messages => - { - string[] msgs = messages.ToArray(); - Assert.AreEqual(1, msgs.Length); - Assert.AreEqual("Berekeningen konden niet worden gestart. Doelkans is te groot om een berekening uit te kunnen voeren.", msgs.First()); - }); + TestHelper.AssertLogMessages(call, messages => { Assert.AreEqual("Berekeningen konden niet worden gestart. Doelkans is te groot om een berekening uit te kunnen voeren.", messages.Single()); }); } mockRepository.VerifyAll(); @@ -196,7 +181,7 @@ public void CalculateDesignWaterLevels_ValidPathEmptyList_NoLog() { // Setup - var calculatorFactory = mockRepository.StrictMock(); + var mockRepository = new MockRepository(); var calculationMessageProvider = mockRepository.StrictMock(); mockRepository.ReplayAll(); @@ -206,7 +191,6 @@ }; using (var viewParent = new Form()) - using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { var guiService = new HydraulicBoundaryLocationCalculationGuiService(viewParent); @@ -232,6 +216,7 @@ const string calculationName = "calculationName"; const string calculatedNotConvergedMessage = "calculatedNotConvergedMessage"; + var mockRepository = new MockRepository(); var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateDesignWaterLevelCalculator(testDataPath, validPreprocessorDirectory)).Return(new TestDesignWaterLevelCalculator()); var calculationMessageProvider = mockRepository.StrictMock(); @@ -282,12 +267,11 @@ public void CalculateWaveHeights_CalculationsNull_ThrowsArgumentNullException() { // Setup - var calculatorFactory = mockRepository.StrictMock(); + var mockRepository = new MockRepository(); var calculationMessageProvider = mockRepository.StrictMock(); mockRepository.ReplayAll(); using (var viewParent = new Form()) - using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { var guiService = new HydraulicBoundaryLocationCalculationGuiService(viewParent); @@ -311,11 +295,7 @@ public void CalculateWaveHeights_CalculationServiceMessageProviderNull_ThrowsArgumentNullException() { // Setup - var calculatorFactory = mockRepository.StrictMock(); - mockRepository.ReplayAll(); - using (var viewParent = new Form()) - using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { var guiService = new HydraulicBoundaryLocationCalculationGuiService(viewParent); @@ -331,20 +311,17 @@ const string expectedParamName = "messageProvider"; Assert.AreEqual(expectedParamName, paramName); } - - mockRepository.VerifyAll(); } [Test] public void CalculateWaveHeights_HydraulicDatabaseDoesNotExist_LogsError() { // Setup - var calculatorFactory = mockRepository.StrictMock(); + var mockRepository = new MockRepository(); var calculationMessageProvider = mockRepository.StrictMock(); mockRepository.ReplayAll(); using (var viewParent = new Form()) - using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { var guiService = new HydraulicBoundaryLocationCalculationGuiService(viewParent); @@ -371,12 +348,11 @@ public void CalculateWaveHeights_InvalidNorm_LogsError() { // Setup - var calculatorFactory = mockRepository.StrictMock(); + var mockRepository = new MockRepository(); var calculationMessageProvider = mockRepository.StrictMock(); mockRepository.ReplayAll(); using (var viewParent = new Form()) - using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { var guiService = new HydraulicBoundaryLocationCalculationGuiService(viewParent); @@ -388,12 +364,7 @@ calculationMessageProvider); // Assert - TestHelper.AssertLogMessages(call, messages => - { - string[] msgs = messages.ToArray(); - Assert.AreEqual(1, msgs.Length); - Assert.AreEqual("Berekeningen konden niet worden gestart. Doelkans is te groot om een berekening uit te kunnen voeren.", msgs.First()); - }); + TestHelper.AssertLogMessages(call, messages => { Assert.AreEqual("Berekeningen konden niet worden gestart. Doelkans is te groot om een berekening uit te kunnen voeren.", messages.Single()); }); } mockRepository.VerifyAll(); @@ -403,7 +374,7 @@ public void CalculateWaveHeights_ValidPathEmptyList_NoLog() { // Setup - var calculatorFactory = mockRepository.StrictMock(); + var mockRepository = new MockRepository(); var calculationMessageProvider = mockRepository.StrictMock(); mockRepository.ReplayAll(); @@ -413,7 +384,6 @@ }; using (var viewParent = new Form()) - using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { var guiService = new HydraulicBoundaryLocationCalculationGuiService(viewParent); @@ -439,6 +409,7 @@ const string calculationName = "calculationName"; const string calculatedNotConvergedMessage = "calculatedNotConvergedMessage"; + var mockRepository = new MockRepository(); var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(testDataPath, validPreprocessorDirectory)).Return(new TestWaveHeightCalculator()); var calculationMessageProvider = mockRepository.StrictMock(); @@ -484,10 +455,5 @@ mockRepository.VerifyAll(); } - - public override void Setup() - { - mockRepository = new MockRepository(); - } } } \ No newline at end of file Index: Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/GuiServices/DuneLocationCalculationGuiServiceTest.cs =================================================================== diff -u -rbf0bb686ee2b533188f8eabdc09732e52d775888 -ref6277218199e4e5168132ac6f9ffd7fab2e8008 --- Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/GuiServices/DuneLocationCalculationGuiServiceTest.cs (.../DuneLocationCalculationGuiServiceTest.cs) (revision bf0bb686ee2b533188f8eabdc09732e52d775888) +++ Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/GuiServices/DuneLocationCalculationGuiServiceTest.cs (.../DuneLocationCalculationGuiServiceTest.cs) (revision ef6277218199e4e5168132ac6f9ffd7fab2e8008) @@ -40,17 +40,10 @@ [TestFixture] public class DuneLocationCalculationGuiServiceTest { - private MockRepository mockRepository; private static readonly string testDataPath = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.Common.IO, "HydraulicBoundaryDatabaseImporter"); private static readonly string validFilePath = Path.Combine(testDataPath, "complete.sqlite"); private static readonly string validPreprocessorDirectory = TestHelper.GetScratchPadPath(); - [SetUp] - public void Setup() - { - mockRepository = new MockRepository(); - } - [Test] public void Constructor_ViewParentNull_ThrowArgumentNullException() { @@ -105,6 +98,8 @@ }; int nrOfCalculators = duneLocationCalculations.Length; + + var mockRepository = new MockRepository(); var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateDunesBoundaryConditionsCalculator(testDataPath, validPreprocessorDirectory)) .Return(new TestDunesBoundaryConditionsCalculator()) @@ -157,12 +152,9 @@ public void Calculate_HydraulicDatabaseDoesNotExist_LogsError() { // Setup - var calculatorFactory = mockRepository.StrictMock(); - mockRepository.ReplayAll(); - const string databasePath = "Does not exist"; + using (var viewParent = new Form()) - using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { var guiService = new DuneLocationCalculationGuiService(viewParent); @@ -180,19 +172,13 @@ StringAssert.StartsWith("Berekeningen konden niet worden gestart. ", msgs.First()); }); } - - mockRepository.VerifyAll(); } [Test] public void Calculate_InvalidNorm_LogsError() { // Setup - var calculatorFactory = mockRepository.StrictMock(); - mockRepository.ReplayAll(); - using (var viewParent = new Form()) - using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { var guiService = new DuneLocationCalculationGuiService(viewParent); @@ -203,26 +189,18 @@ 1.0); // Assert - TestHelper.AssertLogMessages(call, messages => - { - string[] msgs = messages.ToArray(); - Assert.AreEqual(1, msgs.Length); - Assert.AreEqual("Berekeningen konden niet worden gestart. Doelkans is te groot om een berekening uit te kunnen voeren.", msgs.First()); - }); + TestHelper.AssertLogMessages(call, messages => { Assert.AreEqual("Berekeningen konden niet worden gestart. Doelkans is te groot om een berekening uit te kunnen voeren.", messages.Single()); }); } - - mockRepository.VerifyAll(); } - [Test] public void Calculate_ValidPathOneCalculationInTheList_LogsMessages() { // Setup const string duneLocationName = "name"; + var mockRepository = new MockRepository(); var viewParent = mockRepository.Stub(); - var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateDunesBoundaryConditionsCalculator(testDataPath, validPreprocessorDirectory)).Return(new TestDunesBoundaryConditionsCalculator()); mockRepository.ReplayAll();