Index: Ringtoets/Storage/src/Ringtoets.Storage.Core/SqLiteEntityConnectionStringBuilder.cs =================================================================== diff -u -re177433c5d29e78e41416e66c6579181d43f345b -rf68e2bd2f8c001d237e656c8ab55bebca18b02a3 --- Ringtoets/Storage/src/Ringtoets.Storage.Core/SqLiteEntityConnectionStringBuilder.cs (.../SqLiteEntityConnectionStringBuilder.cs) (revision e177433c5d29e78e41416e66c6579181d43f345b) +++ Ringtoets/Storage/src/Ringtoets.Storage.Core/SqLiteEntityConnectionStringBuilder.cs (.../SqLiteEntityConnectionStringBuilder.cs) (revision f68e2bd2f8c001d237e656c8ab55bebca18b02a3) @@ -36,7 +36,7 @@ /// Location of the storage file. /// A new connection string. /// Thrown when is null or empty (only whitespaces). - public static string BuildSqLiteEntityConnectionString(string filePath, bool readOnly) + public static string BuildSqLiteEntityConnectionString(string filePath) { if (string.IsNullOrWhiteSpace(filePath)) { @@ -47,7 +47,7 @@ { Metadata = string.Format(@"res://*/{0}.csdl|res://*/{0}.ssdl|res://*/{0}.msl", "DbContext.RingtoetsEntities"), Provider = @"System.Data.SQLite.EF6", - ProviderConnectionString = SqLiteConnectionStringBuilder.BuildSqLiteConnectionString(GetDataSourceLocation(filePath), readOnly) + ProviderConnectionString = SqLiteConnectionStringBuilder.BuildSqLiteConnectionString(GetDataSourceLocation(filePath), false) }.ConnectionString; } Index: Ringtoets/Storage/src/Ringtoets.Storage.Core/StorageSqLite.cs =================================================================== diff -u -re177433c5d29e78e41416e66c6579181d43f345b -rf68e2bd2f8c001d237e656c8ab55bebca18b02a3 --- Ringtoets/Storage/src/Ringtoets.Storage.Core/StorageSqLite.cs (.../StorageSqLite.cs) (revision e177433c5d29e78e41416e66c6579181d43f345b) +++ Ringtoets/Storage/src/Ringtoets.Storage.Core/StorageSqLite.cs (.../StorageSqLite.cs) (revision f68e2bd2f8c001d237e656c8ab55bebca18b02a3) @@ -260,7 +260,7 @@ private static string GetConnectionToExistingFile(string databaseFilePath) { IOUtils.ValidateFilePath(databaseFilePath); - return GetConnectionToFile(databaseFilePath, true); + return GetConnectionToFile(databaseFilePath); } /// @@ -280,33 +280,33 @@ { IOUtils.ValidateFilePath(databaseFilePath); StorageSqliteCreator.CreateDatabaseStructure(databaseFilePath); - return GetConnectionToFile(databaseFilePath, false); + return GetConnectionToFile(databaseFilePath); } /// /// Establishes a connection to an existing . /// /// The path of the database file to connect to. /// No file exists at . - private static string GetConnectionToFile(string databaseFilePath, bool readOnly) + private static string GetConnectionToFile(string databaseFilePath) { if (!File.Exists(databaseFilePath)) { string message = new FileReaderErrorMessageBuilder(databaseFilePath).Build(UtilResources.Error_File_does_not_exist); throw new CouldNotConnectException(message); } - return GetConnectionToStorage(databaseFilePath, readOnly); + return GetConnectionToStorage(databaseFilePath); } /// /// Sets the connection to the Ringtoets database. /// /// The path of the file, which is used for creating exceptions. /// Thrown when the database does not contain the table version. - private static string GetConnectionToStorage(string databaseFilePath, bool readOnly) + private static string GetConnectionToStorage(string databaseFilePath) { - string connectionString = SqLiteEntityConnectionStringBuilder.BuildSqLiteEntityConnectionString(databaseFilePath, readOnly); + string connectionString = SqLiteEntityConnectionStringBuilder.BuildSqLiteEntityConnectionString(databaseFilePath); using (var dbContext = new RingtoetsEntities(connectionString)) { Index: Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/SqLiteEntityConnectionStringBuilderTest.cs =================================================================== diff -u -re177433c5d29e78e41416e66c6579181d43f345b -rf68e2bd2f8c001d237e656c8ab55bebca18b02a3 --- Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/SqLiteEntityConnectionStringBuilderTest.cs (.../SqLiteEntityConnectionStringBuilderTest.cs) (revision e177433c5d29e78e41416e66c6579181d43f345b) +++ Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/SqLiteEntityConnectionStringBuilderTest.cs (.../SqLiteEntityConnectionStringBuilderTest.cs) (revision f68e2bd2f8c001d237e656c8ab55bebca18b02a3) @@ -37,7 +37,7 @@ { // Call TestDelegate test = () => SqLiteEntityConnectionStringBuilder.BuildSqLiteEntityConnectionString( - invalidPathToSqLiteFile, true); + invalidPathToSqLiteFile); // Assert Assert.Throws(test); @@ -48,7 +48,7 @@ { // Call string connectionString = SqLiteEntityConnectionStringBuilder.BuildSqLiteEntityConnectionString( - pathToSqLiteFile, true); + pathToSqLiteFile); // Assert Assert.That(!string.IsNullOrEmpty(connectionString)); @@ -57,7 +57,7 @@ StringAssert.Contains("provider=System.Data.SQLite.EF6", connectionString); StringAssert.Contains("failifmissing=True", connectionString); StringAssert.Contains($"data source={pathToSqLiteFile}", connectionString); - StringAssert.Contains("read only=True", connectionString); + StringAssert.Contains("read only=False", connectionString); StringAssert.Contains("foreign keys=True", connectionString); StringAssert.Contains("version=3", connectionString); StringAssert.Contains("pooling=False", connectionString); @@ -71,7 +71,7 @@ // Call string connectionString = SqLiteEntityConnectionStringBuilder.BuildSqLiteEntityConnectionString( - uncPathToSqlFile, true); + uncPathToSqlFile); // Assert Assert.That(!string.IsNullOrEmpty(connectionString)); @@ -80,7 +80,7 @@ StringAssert.Contains("provider=System.Data.SQLite.EF6", connectionString); StringAssert.Contains("failifmissing=True", connectionString); StringAssert.Contains($@"data source=\\{uncPathToSqlFile}", connectionString); - StringAssert.Contains("read only=True", connectionString); + StringAssert.Contains("read only=False", connectionString); StringAssert.Contains("foreign keys=True", connectionString); StringAssert.Contains("version=3", connectionString); StringAssert.Contains("pooling=False", connectionString);