Index: src/Common/DelftTools.Utils/Binding/EnumBindingHelper.cs =================================================================== diff -u -r5fc71a385897af92ccb092f2f969b5709afab85a -rfbe5d1ac043ae74461b82b0ab71c5388bfbbc58b --- src/Common/DelftTools.Utils/Binding/EnumBindingHelper.cs (.../EnumBindingHelper.cs) (revision 5fc71a385897af92ccb092f2f969b5709afab85a) +++ src/Common/DelftTools.Utils/Binding/EnumBindingHelper.cs (.../EnumBindingHelper.cs) (revision fbe5d1ac043ae74461b82b0ab71c5388bfbbc58b) @@ -11,12 +11,12 @@ /// Copied from: /// http://geekswithblogs.net/sdorman/archive/2007/08/02/Data-Binding-an-Enum-with-Descriptions.aspx /// - /// + /// /// ComboBox combo = new ComboBox(); - /// combo.DataSource = EnumBindingHelper.ToList(); + /// combo.DataSource = EnumBindingHelper.ToList<SimpleEnum>(); /// combo.DisplayMember = "Value"; /// combo.ValueMember = "Key"; - /// + /// public class EnumBindingHelper { /// Index: src/Common/DelftTools.Utils/Collections/EnumerableExtensions.cs =================================================================== diff -u -r5fc71a385897af92ccb092f2f969b5709afab85a -rfbe5d1ac043ae74461b82b0ab71c5388bfbbc58b --- src/Common/DelftTools.Utils/Collections/EnumerableExtensions.cs (.../EnumerableExtensions.cs) (revision 5fc71a385897af92ccb092f2f969b5709afab85a) +++ src/Common/DelftTools.Utils/Collections/EnumerableExtensions.cs (.../EnumerableExtensions.cs) (revision fbe5d1ac043ae74461b82b0ab71c5388bfbbc58b) @@ -29,7 +29,7 @@ /// Type of item /// Collection to add the elements to /// Items to add - /// with + /// with public static IEnumerable Plus(this IEnumerable collection, params T[] items) { return collection.Concat(items); Index: src/Common/DelftTools.Utils/Collections/Generic/EnumerableList.cs =================================================================== diff -u -r5fc71a385897af92ccb092f2f969b5709afab85a -rfbe5d1ac043ae74461b82b0ab71c5388bfbbc58b --- src/Common/DelftTools.Utils/Collections/Generic/EnumerableList.cs (.../EnumerableList.cs) (revision 5fc71a385897af92ccb092f2f969b5709afab85a) +++ src/Common/DelftTools.Utils/Collections/Generic/EnumerableList.cs (.../EnumerableList.cs) (revision fbe5d1ac043ae74461b82b0ab71c5388bfbbc58b) @@ -7,8 +7,8 @@ namespace DelftTools.Utils.Collections.Generic { /// - /// Implement the IEnumerableList list and allows caching of the Count to speeds up performance. - /// If _collectionChangeSource is not set Count will always be processed by Enumerable. + /// Implement the IEnumerableList<T> list and allows caching of the Count to speeds up performance. + /// If _collectionChangeSource is not set, Count will always be processed by Enumerable. /// /// public class EnumerableList : IEnumerableList, IEnumerableListCache, INotifyPropertyChange Index: src/Common/DelftTools.Utils/Collections/Generic/EventedList.cs =================================================================== diff -u -r5fc71a385897af92ccb092f2f969b5709afab85a -rfbe5d1ac043ae74461b82b0ab71c5388bfbbc58b --- src/Common/DelftTools.Utils/Collections/Generic/EventedList.cs (.../EventedList.cs) (revision 5fc71a385897af92ccb092f2f969b5709afab85a) +++ src/Common/DelftTools.Utils/Collections/Generic/EventedList.cs (.../EventedList.cs) (revision fbe5d1ac043ae74461b82b0ab71c5388bfbbc58b) @@ -87,7 +87,6 @@ /// Construct me /// /// The initialization data - /// Specifies whether property/collection changed events on the items themselves are bubbled public EventedList(IEnumerable initialData) { list = initialData == null ? new List() : new List(initialData); Index: src/Common/DelftTools.Utils/Editing/IEditableObject.cs =================================================================== diff -u -r8f6ae890fed8e8eae3a32f9c0498a10f82e0ddf9 -rfbe5d1ac043ae74461b82b0ab71c5388bfbbc58b --- src/Common/DelftTools.Utils/Editing/IEditableObject.cs (.../IEditableObject.cs) (revision 8f6ae890fed8e8eae3a32f9c0498a10f82e0ddf9) +++ src/Common/DelftTools.Utils/Editing/IEditableObject.cs (.../IEditableObject.cs) (revision fbe5d1ac043ae74461b82b0ab71c5388bfbbc58b) @@ -21,7 +21,7 @@ /// /// Start editing object with the named action. - /// Note: Object must assign to before is changed. + /// Note: Object must assign to before is changed. /// /// void BeginEdit(IEditAction action); Index: src/Common/DelftTools.Utils/NamingHelper.cs =================================================================== diff -u -r5fc71a385897af92ccb092f2f969b5709afab85a -rfbe5d1ac043ae74461b82b0ab71c5388bfbbc58b --- src/Common/DelftTools.Utils/NamingHelper.cs (.../NamingHelper.cs) (revision 5fc71a385897af92ccb092f2f969b5709afab85a) +++ src/Common/DelftTools.Utils/NamingHelper.cs (.../NamingHelper.cs) (revision fbe5d1ac043ae74461b82b0ab71c5388bfbbc58b) @@ -71,7 +71,7 @@ } /// - /// Makes all have a unique name + /// Makes all have a unique name /// /// List of INameble objects to make unique public static void MakeNamesUnique(IEnumerable nameables) Index: src/Common/DelftTools.Utils/Reflection/TypeUtils.cs =================================================================== diff -u -r5fc71a385897af92ccb092f2f969b5709afab85a -rfbe5d1ac043ae74461b82b0ab71c5388bfbbc58b --- src/Common/DelftTools.Utils/Reflection/TypeUtils.cs (.../TypeUtils.cs) (revision 5fc71a385897af92ccb092f2f969b5709afab85a) +++ src/Common/DelftTools.Utils/Reflection/TypeUtils.cs (.../TypeUtils.cs) (revision fbe5d1ac043ae74461b82b0ab71c5388bfbbc58b) @@ -41,7 +41,7 @@ } /// - /// Usage: CreateGeneric(typeof(List<>), typeof(string)); + /// Usage: CreateGeneric(typeof(List<>), typeof(string)); /// /// /// @@ -194,7 +194,7 @@ } /// - /// Returns typeof(int) for List etc. + /// Returns typeof(int) for List<int> etc. /// /// public static Type GetFirstGenericTypeParameter(Type t) @@ -543,7 +543,7 @@ /// /// Returns generic instance method of given name. Cannot use GetMethod() because this does not - /// work if 2 members have the same name (eg. SetValues and SetValues) + /// work if 2 members have the same name (eg. SetValues and SetValues<T>) /// /// /// Index: src/Common/DelftTools.Utils/Selector.cs =================================================================== diff -u -r5fc71a385897af92ccb092f2f969b5709afab85a -rfbe5d1ac043ae74461b82b0ab71c5388bfbbc58b --- src/Common/DelftTools.Utils/Selector.cs (.../Selector.cs) (revision 5fc71a385897af92ccb092f2f969b5709afab85a) +++ src/Common/DelftTools.Utils/Selector.cs (.../Selector.cs) (revision fbe5d1ac043ae74461b82b0ab71c5388bfbbc58b) @@ -5,7 +5,7 @@ namespace DelftTools.Utils { /// - /// Inherit this class to have an enumerable with [] and Count functionality. (but no other IList functionality) + /// Inherit this class to have an enumerable with [] and Count functionality. (but no other IList<T> functionality) /// /// public abstract class Selector : IList Index: src/Common/DelftTools.Utils/StringExtensions.cs =================================================================== diff -u -r5fc71a385897af92ccb092f2f969b5709afab85a -rfbe5d1ac043ae74461b82b0ab71c5388bfbbc58b --- src/Common/DelftTools.Utils/StringExtensions.cs (.../StringExtensions.cs) (revision 5fc71a385897af92ccb092f2f969b5709afab85a) +++ src/Common/DelftTools.Utils/StringExtensions.cs (.../StringExtensions.cs) (revision fbe5d1ac043ae74461b82b0ab71c5388bfbbc58b) @@ -35,9 +35,9 @@ /// The resultant or the default of . /// /// - /// "1234".Parse<int>() == 1234; - /// "a".Parse<int>() == 0; - /// "a".Parse<int?>() == null; + /// "1234".Parse<int>() == 1234; + /// "a".Parse<int>() == 0; + /// "a".Parse<int?>() == null; /// "2010-01-01".Parse<DateTime?>() == new DateTime(2010, 1, 1) /// "2010-01-01a".Parse<DateTime?>() == null /// "127.0.0.1".Parse<System.Net.IPAddress>().Equals(new System.Net.IPAddress(new byte[] { 127, 0, 0, 1 })) @@ -58,8 +58,8 @@ /// The resultant or . /// /// - /// "1234".Parse<int>(-1) == 1234; - /// "a".Parse<int>(-1) == -1; + /// "1234".Parse <int>(-1) == 1234; + /// "a".Parse<int>(-1) == -1; /// "2010-01-01".Parse<DateTime?>(new DateTime(1900, 1, 1)) == new DateTime(2010, 1, 1) /// "2010-01-01a".Parse<DateTime?>(new DateTime(1900, 1, 1)) == new DateTime(1900, 1, 1) /// "127.0.0.1".Parse<System.Net.IPAddress>(new System.Net.IPAddress(new byte[] { 0, 0, 0, 0 })).Equals(new System.Net.IPAddress(new byte[] { 127, 0, 0, 1 })) Index: src/Common/DelftTools.Utils/Threading/NotifyingThreadQueue.cs =================================================================== diff -u -r5fc71a385897af92ccb092f2f969b5709afab85a -rfbe5d1ac043ae74461b82b0ab71c5388bfbbc58b --- src/Common/DelftTools.Utils/Threading/NotifyingThreadQueue.cs (.../NotifyingThreadQueue.cs) (revision 5fc71a385897af92ccb092f2f969b5709afab85a) +++ src/Common/DelftTools.Utils/Threading/NotifyingThreadQueue.cs (.../NotifyingThreadQueue.cs) (revision fbe5d1ac043ae74461b82b0ab71c5388bfbbc58b) @@ -148,10 +148,11 @@ { if (QueueState == QueueState.Idle) { - /// this is a judgment call if you pause this when you - /// don�t have any elements in it then you can go directly - /// to paused and this means that you basically want to - /// keep queuing until something happens + /* this is a judgment call if you pause this when you + * don�t have any elements in it then you can go directly + * to paused and this means that you basically want to + * keep queuing until something happens + */ QueueState = QueueState.Paused; QueueStateChangedInternal(QueueState); } @@ -160,15 +161,14 @@ QueueState = QueueState.Pausing; QueueStateChangedInternal(QueueState); - /// running means you had some active threads so you couldn�t - /// get to paused right away + // running means you had some active threads so you couldn�t get to paused right away } else if (QueueState == QueueState.Stopping || QueueState == QueueState.Aborting) { ThreadErrorInternal(default(T), new ThreadStateException("Once the queue is stopping its done processing")); } - /// if we are already paused or pausing we dont need to do anything + // if we are already paused or pausing we dont need to do anything } } @@ -183,24 +183,22 @@ { if ((QueueState == QueueState.Idle) || (QueueState == QueueState.Stopping) || (QueueState == QueueState.Aborting)) { - /// do nothing idle has nothing to stop and stopping - /// is already working on stopping + // Do nothing. Idle has nothing to stop and Stopping is already working on stopping return; } else if (QueueState == QueueState.Paused) { QueueState = QueueState.Stopping; QueueStateChangedInternal(QueueState); - /// if we are already paused then we have no threads running - /// so just drop all the extra items in the queue + // If we are already paused then we have no threads running so drop all the extra items in the queue while (queue.Count != 0) { ThreadErrorInternal(queue.Dequeue().Key, new ThreadStateException("the Queue is stopping . no processing done")); } - /// ensure proper event flow paused-> stopping -> idle + // ensure proper event flow paused-> stopping -> idle QueueState = QueueState.Idle; QueueStateChangedInternal(QueueState); } @@ -209,9 +207,9 @@ QueueState = QueueState.Stopping; QueueStateChangedInternal(QueueState); - /// why are we not dequeuing everything? that�s b/c if we have threads - /// left they have to finish in their own good time so they can go - /// through the process of getting rid of all the others. both ways work + // why are we not dequeuing everything? + // that�s b/c if we have threads left they have to finish in their own good time so they can go + // through the process of getting rid of all the others. both ways work if (currentthreads == 0) { QueueState = QueueState.Idle; @@ -230,17 +228,15 @@ { if ((QueueState == QueueState.Idle) || (QueueState == QueueState.Stopping) || (QueueState == QueueState.Aborting)) { - /// do nothing idle has nothing to stop and stopping - /// is already working on stopping + // Do nothing. Idle has nothing to stop and Stopping is already working on stopping return; } else if (QueueState == QueueState.Paused) { QueueState = QueueState.Aborting; QueueStateChangedInternal(QueueState); - // if we are already paused then we have no threads running - /// so just drop all the extra items in the queue + // if we are already paused then we have no threads running so drop all the extra items in the queue while (queue.Count != 0) { queue.Dequeue(); @@ -256,9 +252,9 @@ QueueState = QueueState.Aborting; QueueStateChangedInternal(QueueState); - /// why are we not dequeuing everything? that�s b/c if we have threads - /// left they have to finish in their own good time so they can go - /// through the process of getting rid of all the others. both ways work + // why are we not dequeuing everything? + // That�s b/c if we have threads left they have to finish in their own good time so they can go + // through the process of getting rid of all the others. both ways work //abort running threads KeyValuePair>[] kvpArr = @@ -323,15 +319,14 @@ } else if (QueueState == QueueState.Paused) { - /// if we are already paused then we have no threads running - /// remove item from the queue + // if we are already paused then we have no threads running, remove item from the queue RemoveQueueKvp(kvp); if (queue.Count == 0) { QueueState = QueueState.Stopping; QueueStateChangedInternal(QueueState); - /// ensure proper event flow paused-> stopping -> idle + // ensure proper event flow paused-> stopping -> idle QueueState = QueueState.Idle; QueueStateChangedInternal(QueueState); } @@ -412,14 +407,13 @@ } else if ((QueueState == QueueState.Idle) || (QueueState == QueueState.Running)) { - /// Continuing to process while the queue is idle is meaning - /// less just ignore the command + // Continuing to process while the queue is idle is meaningless. Ignoring the command return; } else if (QueueState == QueueState.Stopping) { ThreadErrorInternal(default(T), - new ThreadStateException("Once the queue is stopping its done processing")); + new ThreadStateException("Once the queue is stopping it's done processing")); } } } @@ -478,7 +472,7 @@ /// /// Adds the item to the queue to process asynchronously and - /// uses the different operation instead of the default. + /// uses the different operation instead of the default. /// /// the item to enqueue /// the new operation that overrides the default @@ -499,14 +493,13 @@ QueueState = QueueState.Running; QueueStateChangedInternal(QueueState); - /// the problem with generics is that sometimes the fully - /// descriptive name goes on for a while KeyValuePair> kvp = new KeyValuePair>(item, opp); - /// thread demands that its ParameterizedThreadStart take an object not a generic type - /// one might have resonably thought that there would be a generic constructor that - /// took a strongly typed value but there is not one + // TODO: rewrite comment below + // thread demands that its ParameterizedThreadStart take an object not a generic type + // one might have resonably thought that there would be a generic constructor that + // took a strongly typed value but there is not one currentthreads++; ParameterizedThreadStart threadStart = RunOpp; @@ -533,8 +526,7 @@ ThreadErrorInternal(kvp.Key, new Exception("This item is in the queue already")); return; } - /// in the case that we are pausing or currently paused we just add the value to the - /// queue we dont try to run the process + // in the case that we are pausing or currently paused we just add the value to the queue and dont try to run the process queue.Enqueue(kvp); #endregion @@ -551,9 +543,9 @@ return; } - /// you have to enqueue the item then try to execute the first item in the process - /// always enqueue first as this ensures that you get the oldest item first since - /// that is what you wanted to do you did not want a stack + // You have to enqueue the item and then try to execute the first item in the process. + // Always enqueue first as this ensures that you get the oldest item first, + // since that is what you wanted to do you did not want a stack queue.Enqueue(kvp); TryNewThread(); @@ -563,14 +555,9 @@ { #region stopping - /// when you are stopping the queue i assume that you wanted to stop it not pause it this - /// means that if you try to enqueue something it will throw an exception since you - /// shouldnt be enqueueing anything since when the queue gets done all its current - /// threads it clears the rest out so why bother enqueueing it. at this point we have - /// a choice we can make the notifyer die or we can use the error event we already - /// have built in to tell the sender. i chose the later. also try to pick an appropriate - /// exception not just the base - ThreadErrorInternal(item, new ThreadStateException("the Queue is stopping . no processing done")); + // when you are stopping the queue it is assumed that you wanted to Stop it not Pause it. + // Since it can not go back to a running state, if you try to enqueue something it will throw an exception + ThreadErrorInternal(item, new ThreadStateException("the Queue is stopping. No processing done")); #endregion } @@ -665,19 +652,17 @@ { #region stopping - /// normally when we stop a queue we can just clear out the remaining - /// values and let the threads peter out. however, we made the decision - /// to throw an exception by way of our exception handler. it is therefore - /// important to keep with that and get rid of all the queue items in - /// that same way + // Normally when we stop a queue we can just clear out the remaining + // values and let the threads figger out. however, we made the decision + // to throw an exception by way of our exception handler. It is therefore + // important to keep with that and get rid of all the queue items in that same way while (queue.Count != 0) { ThreadErrorInternal(queue.Dequeue().Key, - new ThreadStateException("the Queue is stopping . no processing done")); + new ThreadStateException("the Queue is stopping. No processing done")); } - /// all threads come through here so its up to us to single the change - /// from stopping to idle + // All threads come through here so its up to us to single the change from stopping to idle if (currentthreads == 0) { QueueState = QueueState.Idle; @@ -702,8 +687,7 @@ { #region Idle / Paused - /// there should be no way to got in here while your idle or paused - /// this is just an error check + // There should be no way to got in here while you're idle or paused. This is just an error check ThreadErrorInternal(default(T), new Exception("internal state bad")); #endregion Index: src/Common/DelftTools.Utils/VersionExtensions.cs =================================================================== diff -u -r5fc71a385897af92ccb092f2f969b5709afab85a -rfbe5d1ac043ae74461b82b0ab71c5388bfbbc58b --- src/Common/DelftTools.Utils/VersionExtensions.cs (.../VersionExtensions.cs) (revision 5fc71a385897af92ccb092f2f969b5709afab85a) +++ src/Common/DelftTools.Utils/VersionExtensions.cs (.../VersionExtensions.cs) (revision fbe5d1ac043ae74461b82b0ab71c5388bfbbc58b) @@ -7,7 +7,7 @@ /// /// Replaces -1 in version by 0. Allowing 1.3 == 1.3.0.0 /// - /// + /// /// public static Version GetFullVersion(this Version version) { Index: src/Common/DelftTools.Utils/WeakEventHandler.cs =================================================================== diff -u -r5fc71a385897af92ccb092f2f969b5709afab85a -rfbe5d1ac043ae74461b82b0ab71c5388bfbbc58b --- src/Common/DelftTools.Utils/WeakEventHandler.cs (.../WeakEventHandler.cs) (revision 5fc71a385897af92ccb092f2f969b5709afab85a) +++ src/Common/DelftTools.Utils/WeakEventHandler.cs (.../WeakEventHandler.cs) (revision fbe5d1ac043ae74461b82b0ab71c5388bfbbc58b) @@ -1,14 +1,13 @@ -/// Basic weak event management. -/// -/// Weak allow objects to be garbage collected without having to unsubscribe -/// -/// Taken with some minor variations from: -/// http://diditwith.net/2007/03/23/SolvingTheProblemWithEventsWeakEventHandlers.aspx -/// -/// use as class.theEvent +=new EventHandler(instance_handler).MakeWeak((e) => class.theEvent -= e); -/// MakeWeak extension methods take an delegate to unsubscribe the handler from the event -/// -/// +/* Basic weak event management. + * + * Weak allow objects to be garbage collected without having to unsubscribe + * + * Taken with some minor variations from: + * http://diditwith.net/2007/03/23/SolvingTheProblemWithEventsWeakEventHandlers.aspx + * + * use as class.theEvent +=new EventHandler(instance_handler).MakeWeak((e) => class.theEvent -= e); + * MakeWeak extension methods take an delegate to unsubscribe the handler from the event +*/ using System; using System.ComponentModel; @@ -54,7 +53,7 @@ public H Handler { get; private set; } /// - /// Performs an implicit conversion from to . + /// Performs an implicit conversion from to . /// /// The weh. /// The result of the conversion. @@ -139,7 +138,6 @@ /// /// An interface for a weak event handler /// - /// public interface IWeakPropertyChangedEventHandler { PropertyChangedEventHandler Handler { get; } @@ -150,7 +148,6 @@ /// handler must be a instance method /// /// - /// public class WeakPropertyChangeHandler : WeakEventHandlerGeneric, IWeakPropertyChangedEventHandler where T : class { @@ -168,7 +165,6 @@ /// /// Makes a property change handler weak /// - /// /// The event handler. /// The unregister. /// Index: src/Common/DelftTools.Utils/Xml/Serialization/ObjectXmlSerializer.cs =================================================================== diff -u -r5fc71a385897af92ccb092f2f969b5709afab85a -rfbe5d1ac043ae74461b82b0ab71c5388bfbbc58b --- src/Common/DelftTools.Utils/Xml/Serialization/ObjectXmlSerializer.cs (.../ObjectXmlSerializer.cs) (revision 5fc71a385897af92ccb092f2f969b5709afab85a) +++ src/Common/DelftTools.Utils/Xml/Serialization/ObjectXmlSerializer.cs (.../ObjectXmlSerializer.cs) (revision fbe5d1ac043ae74461b82b0ab71c5388bfbbc58b) @@ -28,8 +28,6 @@ /// /// Facade to XML serialization and deserialization of strongly typed objects to/from an XML file. - /// References: XML Serialization. - /// /// public static class ObjectXmlSerializer where T : class // Specify that T must be a class. { Index: src/DeltaShell/DeltaShell.Plugins.SharpMapGis.Gui/DeltaShell.Plugins.SharpMapGis.Gui.csproj =================================================================== diff -u -rb9fb2479ca915755aa087e7898b9a78eb1e4f0c0 -rfbe5d1ac043ae74461b82b0ab71c5388bfbbc58b --- src/DeltaShell/DeltaShell.Plugins.SharpMapGis.Gui/DeltaShell.Plugins.SharpMapGis.Gui.csproj (.../DeltaShell.Plugins.SharpMapGis.Gui.csproj) (revision b9fb2479ca915755aa087e7898b9a78eb1e4f0c0) +++ src/DeltaShell/DeltaShell.Plugins.SharpMapGis.Gui/DeltaShell.Plugins.SharpMapGis.Gui.csproj (.../DeltaShell.Plugins.SharpMapGis.Gui.csproj) (revision fbe5d1ac043ae74461b82b0ab71c5388bfbbc58b) @@ -26,6 +26,7 @@ false prompt MinimumRecommendedRules.ruleset + 0 bin\Release\ @@ -35,6 +36,7 @@ x86 prompt MinimumRecommendedRules.ruleset + 0 Index: test/Common/DelftTools.TestUtils/TestHelper.cs =================================================================== diff -u -rdbf346f0cc265bf639c1b94ac0eedc1c7bd9d0e4 -rfbe5d1ac043ae74461b82b0ab71c5388bfbbc58b --- test/Common/DelftTools.TestUtils/TestHelper.cs (.../TestHelper.cs) (revision dbf346f0cc265bf639c1b94ac0eedc1c7bd9d0e4) +++ test/Common/DelftTools.TestUtils/TestHelper.cs (.../TestHelper.cs) (revision fbe5d1ac043ae74461b82b0ab71c5388bfbbc58b) @@ -23,8 +23,6 @@ private static string lastTestName; private static Color[] colors; - private static bool suppressionInitialized; - public static string SolutionRoot { get Index: test/Common/DelftTools.Utils.Tests/Collections/Generic/EventedListTest.cs =================================================================== diff -u -r893ead4c5aa34d9e3c27688d0851f4064f9b38b6 -rfbe5d1ac043ae74461b82b0ab71c5388bfbbc58b --- test/Common/DelftTools.Utils.Tests/Collections/Generic/EventedListTest.cs (.../EventedListTest.cs) (revision 893ead4c5aa34d9e3c27688d0851f4064f9b38b6) +++ test/Common/DelftTools.Utils.Tests/Collections/Generic/EventedListTest.cs (.../EventedListTest.cs) (revision fbe5d1ac043ae74461b82b0ab71c5388bfbbc58b) @@ -220,13 +220,16 @@ private class MockWithPropertyAndCollectionChange : INotifyPropertyChange, INotifyCollectionChange { + // Required by interface, but not used (yet) +#pragma warning disable 67 public event PropertyChangingEventHandler PropertyChanging; public event PropertyChangedEventHandler PropertyChanged; public event NotifyCollectionChangedEventHandler CollectionChanged; public event NotifyCollectionChangingEventHandler CollectionChanging; +#pragma warning restore 67 bool INotifyCollectionChange.HasParentIsCheckedInItems { get; set; } Index: test/Common/DelftTools.Utils.Tests/PropertyBag/DynamicPropertyBagTest.cs =================================================================== diff -u -r893ead4c5aa34d9e3c27688d0851f4064f9b38b6 -rfbe5d1ac043ae74461b82b0ab71c5388bfbbc58b --- test/Common/DelftTools.Utils.Tests/PropertyBag/DynamicPropertyBagTest.cs (.../DynamicPropertyBagTest.cs) (revision 893ead4c5aa34d9e3c27688d0851f4064f9b38b6) +++ test/Common/DelftTools.Utils.Tests/PropertyBag/DynamicPropertyBagTest.cs (.../DynamicPropertyBagTest.cs) (revision fbe5d1ac043ae74461b82b0ab71c5388bfbbc58b) @@ -282,8 +282,10 @@ private class TestProperties : INotifyPropertyChange { public event PropertyChangedEventHandler PropertyChanged; +// Required by interface, but not used (yet) +#pragma warning disable 67 public event PropertyChangingEventHandler PropertyChanging; - +#pragma warning restore 67 private bool isNameReadOnly; public TestProperties() Index: test/DeltaShell/DeltaShell.Plugins.CommonTools.Tests/TestViewList.cs =================================================================== diff -u -reac97eab4acc4d2698cdc33a310e4fe843d54607 -rfbe5d1ac043ae74461b82b0ab71c5388bfbbc58b --- test/DeltaShell/DeltaShell.Plugins.CommonTools.Tests/TestViewList.cs (.../TestViewList.cs) (revision eac97eab4acc4d2698cdc33a310e4fe843d54607) +++ test/DeltaShell/DeltaShell.Plugins.CommonTools.Tests/TestViewList.cs (.../TestViewList.cs) (revision fbe5d1ac043ae74461b82b0ab71c5388bfbbc58b) @@ -10,14 +10,17 @@ { public class TestViewList : IViewList { +// Required by interface, but not used (yet) +#pragma warning disable 67 public event NotifyCollectionChangingEventHandler CollectionChanging; public event NotifyCollectionChangedEventHandler CollectionChanged; public event EventHandler ActiveViewChanging; + public event NotifyCollectionChangedEventHandler ChildViewChanged; +#pragma warning restore 67 public event EventHandler ActiveViewChanged; - public event NotifyCollectionChangedEventHandler ChildViewChanged; private readonly IList views = new List(); private IView activeView; Index: test/DeltaShell/DeltaShell.Tests/TestObjects/TestApplication.cs =================================================================== diff -u -reac97eab4acc4d2698cdc33a310e4fe843d54607 -rfbe5d1ac043ae74461b82b0ab71c5388bfbbc58b --- test/DeltaShell/DeltaShell.Tests/TestObjects/TestApplication.cs (.../TestApplication.cs) (revision eac97eab4acc4d2698cdc33a310e4fe843d54607) +++ test/DeltaShell/DeltaShell.Tests/TestObjects/TestApplication.cs (.../TestApplication.cs) (revision fbe5d1ac043ae74461b82b0ab71c5388bfbbc58b) @@ -12,14 +12,18 @@ { internal class TestApplication : IApplication { + // Required by interface, but not used (yet) +#pragma warning disable 67 public event Action ProjectOpening; + public event Action ProjectOpened; public event Action ProjectClosing; public event Action ProjectSaving; public event Action ProjectSaveFailed; public event Action ProjectSaved; public event Action AfterRun; +#pragma warning restore 67 public int DisposeCallCount { get; private set; } Index: test/DeltaShell/DeltaShell.Tests/TestObjects/TestDockingManager.cs =================================================================== diff -u -reac97eab4acc4d2698cdc33a310e4fe843d54607 -rfbe5d1ac043ae74461b82b0ab71c5388bfbbc58b --- test/DeltaShell/DeltaShell.Tests/TestObjects/TestDockingManager.cs (.../TestDockingManager.cs) (revision eac97eab4acc4d2698cdc33a310e4fe843d54607) +++ test/DeltaShell/DeltaShell.Tests/TestObjects/TestDockingManager.cs (.../TestDockingManager.cs) (revision fbe5d1ac043ae74461b82b0ab71c5388bfbbc58b) @@ -12,10 +12,13 @@ /// public class TestDockingManager : IDockingManager { +// Required by interface, but not used (yet) +#pragma warning disable 67 public event EventHandler ViewBarClosing; public event EventHandler ViewActivated; public event Action ViewSelectionMouseDown; +#pragma warning restore 67 public TestDockingManager() { Index: test/DeltaShell/DeltaShell.Tests/TestObjects/TestProjectService.cs =================================================================== diff -u -reac97eab4acc4d2698cdc33a310e4fe843d54607 -rfbe5d1ac043ae74461b82b0ab71c5388bfbbc58b --- test/DeltaShell/DeltaShell.Tests/TestObjects/TestProjectService.cs (.../TestProjectService.cs) (revision eac97eab4acc4d2698cdc33a310e4fe843d54607) +++ test/DeltaShell/DeltaShell.Tests/TestObjects/TestProjectService.cs (.../TestProjectService.cs) (revision fbe5d1ac043ae74461b82b0ab71c5388bfbbc58b) @@ -11,12 +11,14 @@ /// internal class TestProjectService : IProjectService { + // Required by interface, but not used (yet) +#pragma warning disable 67 public event EventHandler ProjectSaved; public event EventHandler ProjectOpening; public event EventHandler ProjectOpened; - +#pragma warning restore 67 public int CloseCallCount { get; private set; } public IProjectRepositoryFactory ProjectRepositoryFactory { get; set; } @@ -76,8 +78,11 @@ #region IProjectService Members +// Required by interface, but not used (yet) +#pragma warning disable 67 public event EventHandler ProjectSaving; public event EventHandler ProjectSaveFailed; +#pragma warning restore 67 public Project CreateNewProjectInTemporaryFolder() {