Edwin Spee

About
  • First commit 18 August 2016
  • Latest commit 20 April 2026
Last Week All Time
Commits: 9 23
Files changed: 0 4
Change in LOC: 0 4

Reviews

1 active review

Counts may include data that you cannot access.

Line History

Line Count Graph
Line Count Graph
 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Edwin Spee is mapped to 3 committers over 2 repositories
Username spee is mapped to:
Monday 20 Apr
2:53 pm

Edwin Spee

Merge branch 'master' into feature/15-add-parameter-c-to-storage

Options
2:37 pm

Edwin Spee

changes after 2nd review

Options
    • -79
    • +0
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Forms.Test/PresentationObjects/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismContextTest.cs
    • -9
    • +82
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Forms.Test/PropertyClasses/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismPropertiesTest.cs
Friday 17 Apr
1:49 pm

Edwin Spee

add extra tests in PresentationObjects

Options
    • -1
    • +80
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Forms.Test/PresentationObjects/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismContextTest.cs
11:58 am

Edwin Spee

update expected string

Options
    • -1
    • +1
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Data.Test/GeneralWaveImpactAsphaltCoverWaveConditionsInputTest.cs
11:55 am

Edwin Spee

reformatting

Options
    • -5
    • +6
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/GeneralWaveImpactAsphaltCoverWaveConditionsInput.cs
    • -1
    • +0
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Forms/PropertyClasses/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismProperties.cs
    • -2
    • +1
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Data.Test/GeneralWaveImpactAsphaltCoverWaveConditionsInputTest.cs
11:51 am

Edwin Spee

more review comments

Options
    • -1
    • +22
    /Riskeer/Piping/src/Riskeer.Piping.Data/Properties/Resources.Designer.cs
    • -11
    • +12
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/GeneralWaveImpactAsphaltCoverWaveConditionsInput.cs
    • -12
    • +33
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/Properties/Resources.Designer.cs
    • -4
    • +4
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Data.Test/GeneralWaveImpactAsphaltCoverWaveConditionsInputTest.cs
Wednesday 15 Apr
2:29 pm

Edwin Spee

remove obsolete tables SetUpHeights and WaveReductions from HydraRingCalculationInput

Options
    • -4
    • +2
    /Riskeer/HydraRing/src/Riskeer.HydraRing.Calculation/Services/HydraRingConfigurationService.cs
    • -73
    • +1
    /Riskeer/HydraRing/test/Riskeer.HydraRing.Calculation.Test/Integration/HydraRingConfigurationServiceIntegrationTest.cs
    • -9
    • +1
    /Riskeer/HydraRing/test/Riskeer.HydraRing.Calculation.Test/Services/HydraRingConfigurationServiceTest.cs
Tuesday 14 Apr
3:20 pm

Edwin Spee

add test for invalid values of param C

Options
    • -1
    • +1
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/Properties/Resources.Designer.cs
    • -1
    • +1
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/Properties/Resources.resx
    • -0
    • +20
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Data.Test/GeneralWaveImpactAsphaltCoverWaveConditionsInputTest.cs
2:48 pm

Edwin Spee

move validation for param C to data

improve error message for param volume of water in piping

Options
    • -26
    • +4
    /Riskeer/Piping/src/Riskeer.Piping.Data/Properties/Resources.Designer.cs
    • -28
    • +28
    /Riskeer/Piping/src/Riskeer.Piping.Data/Properties/Resources.resx
    • -2
    • +2
    /Riskeer/Piping/test/Riskeer.Piping.Data.Test/GeneralPipingInputTest.cs
    • -4
    • +4
    /Riskeer/Piping/test/Riskeer.Piping.Forms.Test/PropertyClasses/CalculationsState/PipingFailureMechanismPropertiesTest.cs
    • -4
    • +31
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/GeneralWaveImpactAsphaltCoverWaveConditionsInput.cs
    • -23
    • +10
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/Properties/Resources.Designer.cs
    • -27
    • +30
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/Properties/Resources.resx
    • -15
    • +1
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Forms/PropertyClasses/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismProperties.cs
Friday 10 Apr
5:08 pm

Edwin Spee

add propertyChangeHandler to WaveImpactAsphaltCoverFailureMechanismProperties

Options
    • -4
    • +32
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Forms/PropertyClasses/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismProperties.cs
    • -2
    • +2
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Plugin/WaveImpactAsphaltCoverPlugin.cs
    • -3
    • +4
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Forms.Test/PropertyClasses/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismPropertiesTest.cs
2:07 pm

Edwin Spee

add unit tests

Options
    • -0
    • +56
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Data.Test/GeneralWaveImpactAsphaltCoverWaveConditionsInputTest.cs
    • -1
    • +18
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Forms.Test/PropertyClasses/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismPropertiesTest.cs
1:19 pm

Edwin Spee

fix failing test

Options
    • -1
    • +1
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Forms.Test/PropertyClasses/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismPropertiesTest.cs
1:14 pm

Edwin Spee

simply constructor

Options
    • -11
    • +8
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/GeneralWaveImpactAsphaltCoverWaveConditionsInput.cs
    • -1
    • +1
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/WaveImpactAsphaltCoverFailureMechanism.cs
11:55 am

Edwin Spee

only update C if in valid range

Options
    • -1
    • +15
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Forms/PropertyClasses/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismProperties.cs
9:23 am

Edwin Spee

setter in param C only for asphalt

Options
    • -1
    • +1
    /Riskeer/Revetment/src/Riskeer.Revetment.Data/GeneralWaveConditionsInput.cs
    • -0
    • +59
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/GeneralWaveImpactAsphaltCoverWaveConditionsInput.cs
    • -4
    • +3
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/WaveImpactAsphaltCoverFailureMechanism.cs
    • -6
    • +6
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Service/WaveImpactAsphaltCoverWaveConditionsCalculationService.cs
    • -2
    • +2
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Forms.Test/PropertyClasses/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismPropertiesTest.cs
    • -2
    • +2
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Integration.Test/WaveImpactAsphaltCoverWaveConditionsCalculationActivityIntegrationTest.cs
    • -2
    • +2
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Service.Test/WaveImpactAsphaltCoverWaveConditionsCalculationServiceTest.cs
8:53 am

Edwin Spee

add setters for param C

Options
    • -2
    • +2
    /Riskeer/Revetment/src/Riskeer.Revetment.Data/GeneralWaveConditionsInput.cs
    • -1
    • +5
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Forms/PropertyClasses/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismProperties.cs
Monday 05 Sep 2016
3:20 pm

Edwin Spee

found missing doxygen comment during review

Related to Issue [DSB-760]

Options
    • -1
    • +1
    /src/Deltares.DSoilModel.Forms/DSoilModelContext.cs
Wednesday 31 Aug 2016
2:29 pm

Edwin Spee

remove debug code found during review

Related to Issue [DSB-715]

Options
    • -1
    • +0
    /src/Deltares.DSoilModel.Forms/DSoilModelContext.cs
Monday 29 Aug 2016
2:24 pm

Edwin Spee

found typo during review and missing return description

Related to Issue [DSB-494]

Options
    • -1
    • +2
    /src/Deltares.DSoilModel.Data/DSoilModelProject.cs
Friday 26 Aug 2016
3:11 pm

Edwin Spee

found typo during review

Related to Issue [DSB-598]

Options
    • -1
    • +1
    /src/Deltares.DSoilModel.Data/DSoilModelProject.cs
Thursday 18 Aug 2016
1:48 pm

Edwin Spee

add verification form TD

Related to Issue [DSB-544]

Options
    • binary
    /doc/DSoilModel - TD - Registratieformulier Verificatie WTI 2016_Edwin.pdf
    • binary
    /doc/DSoilModel - TD - Registratieformulier Verificatie WTI 2016_Edwin.docx
1:17 pm

Edwin Spee

TD: remove 2 empty pages

Related to Issue [DSB-544]

Options
    • binary
    /doc/DSoilModel - Technical design.docx
1:11 pm

Edwin Spee

TD:

- keep figures and description together

- update broken reference

Related to Issue [DSB-544]

Options
    • binary
    /doc/DSoilModel - Technical design.docx