Deltares.Dam.Data

Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Incorporated comments review:

- Made the PolderLevel property of the ScenarioRecord optional, as this can be defined in either the locations.csv or the scenarios.csv which makes the property optional.

- Added error message in case the PolderLevel was undefined in both files --> in this case the scenario is not imported and a log message is generated

Related to Issue [MWDAM-1584]

    • -1
    • +1
    ./CsvImporters/CsvImporterScenarios.cs
Incorporated comments review:

- Remove unused code

Related to Issue [MWDAM-1584]

Reordered HeadPl2: column should appear before HeadPl3 and HeadPl4 respectively as a default configuration

Related to Issue [MWDAM-1584]

Removed PolderLevel from the Location.cs

Related to Issue [MWDAM-1584]

  1. … 1 more file in changeset.
Removed HeadPL2 from the Location.cs

Related to Issue [MWDAM-1584]

  1. … 2 more files in changeset.
Rewired the HeadPl2 and the PolderLevel properties of Scenario to the new XML entities:

- Changed nullable PolderLevel to a regular double as this is a mandatory required parameter (maintained consistency with the rest of the application)

Related to Issue [MWDAM-1584]

    • -3
    • +2
    ./DamEngineIo/FillDamUiFromXmlInput.cs
    • -3
    • +3
    ./DamEngineIo/FillXmlInputFromDamUi.cs
  1. … 2 more files in changeset.
Removed obsolete GUI components from the property panel:

- Cleaned up unused translations

Related to Issue [MWDAM-1575]

  1. … 2 more files in changeset.
Updated label and description of polder level to "Polderpeil"

Related to Issue [MWDAM-1577]

Cleanup Location and references to HeadPL2: done as a preparation before removing HeadPL2 from the Location class

Related to Issue [MWDAM-1584]

  1. … 3 more files in changeset.
Adjusted DamContext to make HeadPL2 visible:

- Removed obsolete test file

- Changed translation entry due to a rename of the HeadPL2 property in Scenarios to be consistent with the other HeadPl<X> properties

Related to Issue [MWDAM-1584]

  1. … 4 more files in changeset.
Adjusted IO to be able to import HeadPl2 property from scenario files.

Related to Issue [MWDAM-1584]

    • -0
    • +9
    ./CsvImporters/CsvImporterScenarios.cs
  1. … 2 more files in changeset.
Added HeadPl2 to the Scenario as a preparation for removing it from the Location

Related to Issue [MWDAM-1584]

  1. … 1 more file in changeset.
Removed PolderLevel from the SensorLocation:

- Consistent with old migrations of location to scenario properties

Related to Issue [MWDAM-1584]

  1. … 1 more file in changeset.
Reordered columns in the Location Scenarios tab

Related to Issue [MWDAM-1584]

Cleanup: Preparations to remove the PolderLevel from the location object:

- Rewired SensorLocation to use the first scenario data (consistent with other implementations)

- Changed tests: objects should always start with a clean state and not be initialized once for a whole test fixture

Related to Issue [MWDAM-1584]

  1. … 1 more file in changeset.
Cleanup: Preparations to remove the PolderLevel from the location object

Related to Issue [MWDAM-1584]

  1. … 6 more files in changeset.
Added test to verify functionality of Scenario.

Related to Issue [MWDAM-1584]

  1. … 2 more files in changeset.
Added data to be imported to the IO and importer datamodels:

- Added PolderLevel column to be read from the Scenarios.csv files when applicable

Related to Issue [MWDAM-1584]

    • -0
    • +10
    ./CsvImporters/CsvImporterScenarios.cs
  1. … 2 more files in changeset.
Adjusted data model to cope with new functionality:

- Context to make the new column visible for the scenarios

- Added property to scenarios to fill it with the required information

Related to Issue [MWDAM-1584]

  1. … 1 more file in changeset.
Fix unit tests

Related to Issue [MWDAM-1535]

Fixed some SonarQube bug alerts

Related to Issue [MWDAM-1535]

getValue for scenario data in SensorLocation now works. Also added check that there is only 1 scenario in SensorLocation

Related to Issue [MWDAM-1535]

  1. … 1 more file in changeset.
Update XSD for Calculation parameters

Related to Issue [MWDAM-1295]

    • -24
    • +0
    ./Xsd/CalculationParametersDefinition.xsd
Remove obsolete MStab parameters

Related to Issue [MWDAM-1295]

    • -35
    • +11
    ./Assemblers/CalculationParametersAssembler.cs
  1. … 2 more files in changeset.
Remove obsolete calculation modules

Related to Issue [MWDAM-1295]

    • -28
    • +22
    ./Assemblers/CalculationParametersAssembler.cs
  1. … 4 more files in changeset.
Fixed ThrowIfArgumentNull to give proper message.

Fixed use of message CsvHeaderNullOrEmpty (it was not found because name was different).

Improved tests to see if expected message was given for header and splitter.

Related to Issue [MWDAM-1556]

    • -12
    • +12
    ./DamEngineIo/FillXmlInputFromDamUi.cs
  1. … 2 more files in changeset.
Fix bug reported by SonarQube

Related to Issue [MWDAM-1514]

    • -3
    • +5
    ./Sensors/SensorImportFromExcelSheet.cs
Reverted revision(s) 2602 from DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data/Translations.xml: change of names accidentally lead to RequiredRequired in translation ids, I changed that back.

Related to Issue [MWDAM-1521]

Refactored; improved layout

Related to Issue [MWDAM-1295]

    • -16
    • +51
    ./Assemblers/CalculationParametersAssembler.cs
Cleanup code due to SonarCube analysis

- Use ArgumentNullException i.s.o. NullReferenceException (implement ThrowHelper)

- Move strings to resources

Related to Issue [MWDAM-1556]

    • -74
    • +38
    ./DamEngineIo/FillXmlInputFromDamUi.cs
    • -22
    • +154
    ./Properties/Resources.Designer.cs
  1. … 1 more file in changeset.