DAM / DamClients / DamUI / trunk / src

DamClientsLibrary

Checkout Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 8
Last Commit: 08 Apr
Commits this week: 0
Total Lines of Code (LoC): 45,840
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 26 Jul 2019
3:57 pm

Esther van Zantvoort

Fixed ThrowIfArgumentNull to give proper message.

Fixed use of message CsvHeaderNullOrEmpty (it was not found because name was different).

Improved tests to see if expected message was given for header and splitter.

Related to Issue [MWDAM-1556]

Options
    • -5
    • +5
    ./Deltares.Dam.Data/ThrowHelper.cs
    • -3
    • +3
    ./Deltares.Dam.Data/CsvParser.cs
    • -12
    • +12
    ./Deltares.Dam.Data/DamEngineIo/FillXmlInputFromDamUi.cs
  4. … 2 more files in changeset.
8:57 am

Tom The

Fix bug reported by SonarQube

Related to Issue [MWDAM-1514]

Options
    • -3
    • +5
    ./Deltares.Dam.Data/Sensors/SensorImportFromExcelSheet.cs
Thursday 25 Jul 2019
6:08 pm

Esther van Zantvoort

Reverted revision(s) 2602 from DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data/Translations.xml: change of names accidentally lead to RequiredRequired in translation ids, I changed that back.

Related to Issue [MWDAM-1521]

Options
    • -7
    • +7
    ./Deltares.Dam.Data/Translations.xml
Wednesday 24 Jul 2019
11:51 am

Tom The

Refactored; improved layout

Related to Issue [MWDAM-1295]

Options
    • -16
    • +51
    ./Deltares.Dam.Data/Assemblers/CalculationParametersAssembler.cs
10:23 am

Tom The

Cleanup code due to SonarCube analysis

- Use ArgumentNullException i.s.o. NullReferenceException (implement ThrowHelper)

- Move strings to resources

Related to Issue [MWDAM-1556]

Options
    • -3
    • +54
    ./Deltares.Dam.Data/Properties/Resources.resx
    • -74
    • +38
    ./Deltares.Dam.Data/DamEngineIo/FillXmlInputFromDamUi.cs
    • -1
    • +15
    ./Deltares.Dam.Data/ThrowHelper.cs
    • -22
    • +154
    ./Deltares.Dam.Data/Properties/Resources.Designer.cs
  5. … 1 more file in changeset.
Tuesday 23 Jul 2019
4:37 pm

John Bokma

Improved handling of import errors for TimeDataSeries. Program no longer crashes, the error message now shows the relevant information.

Made sure that inner exception message is shown when program crashes.

Related to Issue [MWDAM-1457]

Options
    • -9
    • +36
    ./Deltares.Dam.Data/TimeSerieCollection.cs
  2. … 2 more files in changeset.
Monday 22 Jul 2019
1:10 pm

Esther van Zantvoort

Throw exception when River Level Low is not specified in case the calculation model is Stability Outside.

Related to Issue [MWDAM-1556]

Options
    • -0
    • +15
    ./Deltares.Dam.Data/DamEngineIo/FillXmlInputFromDamUi.cs
  2. … 1 more file in changeset.
11:52 am

Esther van Zantvoort

Do not set value of RiverLevel to RiverLevelLow in import from scenarios.csv when RiverLevelLow is not specified.

Related to Issue [MWDAM-1556]

Options
    • -4
    • +0
    ./Deltares.Dam.Data/CsvImporters/CsvImporterScenarios.cs
10:46 am

Esther van Zantvoort

Added tests for import of parameters that can be imported from scenarios.csv but also from locations.csv and shapefiles.

Related to Issue [MWDAM-1541]

Options
    • -6
    • +6
    ./Deltares.Dam.Data/Importers/LocationShapeFileAttributeMap.cs
  2. … 44 more files in changeset.
Friday 19 Jul 2019
2:37 pm

Esther van Zantvoort

Add import of uplift criteria and safety factors from locations.csv of shapefile to scenario.

Related to Issue [MWDAM-1521]

Options
    • -6
    • +6
    ./Deltares.Dam.Data/CsvImporters/CsvImporterScenarios.cs
    • -28
    • +13
    ./Deltares.Dam.Data/IO/CombineImportedData.cs
    • -7
    • +7
    ./Deltares.Dam.Data/Translations.xml
  4. … 1 more file in changeset.
Thursday 18 Jul 2019
6:03 pm

Tom The

Prepare to implement DamLicense object for DamLive

Related to Issue [MWDAM-890]

Options
    • -3
    • +5
    ./Deltares.Dam.Data/License/DamLicense.cs
  2. … 2 more files in changeset.
Wednesday 17 Jul 2019
1:32 am

Esther van Zantvoort

2nd part of commit (oops not saved)

Modified UI for: Made RequiredSafetyFactorStabilityInnerSlope, RequiredSafetyFactorStabilityOuterSlope, RequiredSafetyFactorPiping, UpliftCriterionStability and UpliftCriterionPiping required in xsd/DamLocation.xsd

Set defaults when not specified in import.

Related to Issue [MWDAM-1537]

Options
    • -34
    • +5
    ./Deltares.Dam.Data/CsvImporters/CsvImporterScenarios.cs
    • -8
    • +27
    ./Deltares.Dam.Data/IO/CombineImportedData.cs
1:30 am

Esther van Zantvoort

Modified UI for: Made RequiredSafetyFactorStabilityInnerSlope, RequiredSafetyFactorStabilityOuterSlope, RequiredSafetyFactorPiping, UpliftCriterionStability and UpliftCriterionPiping required in xsd/DamLocation.xsd

Set defaults when not specified in import.

Related to Issue [MWDAM-1537]

Options
    • -5
    • +5
    ./Deltares.Dam.Data/DamEngineIo/FillDamUiFromXmlInput.cs
    • -10
    • +5
    ./Deltares.Dam.Data/DamEngineIo/FillXmlInputFromDamUi.cs
    • -33
    • +15
    ./Deltares.Dam.Data/Scenario.cs
    • -18
    • +21
    ./Deltares.Dam.Data/ModelFactors.cs
12:47 am

Esther van Zantvoort

Reverted revision(s) 2573 from DamClients/DamUI/trunk/src that caused a stack overflow:

Refactored: removed ModelFactors as class.

Related to Issue [MWDAM-1537]

Options
    • -0
    • +1
    ./Deltares.Dam.Data/Deltares.Dam.Data.csproj
    • -0
    • +50
    ./Deltares.Dam.Data/ModelFactors.cs
    • -5
    • +8
    ./Deltares.Dam.Data/IO/CombineImportedData.cs
    • -37
    • +377
    ./Deltares.Dam.Data/Scenario.cs
Tuesday 16 Jul 2019
9:50 pm

Esther van Zantvoort

Refactored: removed ModelFactors as class.

Related to Issue [MWDAM-1537]

Options
    • -50
    • +0
    ./Deltares.Dam.Data/ModelFactors.cs
    • -8
    • +5
    ./Deltares.Dam.Data/IO/CombineImportedData.cs
    • -1
    • +0
    ./Deltares.Dam.Data/Deltares.Dam.Data.csproj
    • -377
    • +37
    ./Deltares.Dam.Data/Scenario.cs
9:20 pm

Esther van Zantvoort

Refactored: use type double instead of double? for PlLineOffsetBelowDikeToeAtPolder, PlLineOffsetBelowDikeTopAtPolder, PlLineOffsetBelowDikeTopAtRiver and PlLineOffsetBelowShoulderBaseInside in UI.

Related to Issue [MWDAM-1537]

Options
    • -4
    • +4
    ./Deltares.Dam.Data/DamEngineIo/FillXmlInputFromDamUi.cs
    • -38
    • +32
    ./Deltares.Dam.Data/Scenario.cs
7:24 pm

Esther van Zantvoort

Set proper defaults for PlLineOffsetBelowDikeToeAtPolder, PlLineOffsetBelowDikeTopAtPolder, PlLineOffsetBelowDikeTopAtRiver and PlLineOffsetBelowShoulderBaseInside in UI.

Related to Issue [MWDAM-1537]

Options
    • -4
    • +4
    ./Deltares.Dam.Data/Scenario.cs
    • -5
    • +6
    ./Deltares.Dam.Data/IO/CombineImportedData.cs
7:10 pm

Esther van Zantvoort

Modified UI for: Made PlLineOffsetBelowDikeToeAtPolder, PlLineOffsetBelowDikeTopAtPolder, PlLineOffsetBelowDikeTopAtRiver and PlLineOffsetBelowShoulderBaseInside required in xsd/DamLocation.xsd

Set default 0.0 when not specified in import (proper defaults in next commit)

Related to Issue [MWDAM-1537]

Options
    • -8
    • +4
    ./Deltares.Dam.Data/DamEngineIo/FillXmlInputFromDamUi.cs
    • -4
    • +4
    ./Deltares.Dam.Data/DamEngineIo/FillDamUiFromXmlInput.cs
    • -26
    • +21
    ./Deltares.Dam.Data/IO/CombineImportedData.cs
3:59 pm

Esther van Zantvoort

Removed PL1PlLineOffsetBelowDikeTopAtRiver, PL1PlLineOffsetBelowDikeTopAtPolder, PL1PlLineOffsetBelowShoulderBaseInside, PL1PlLineOffsetBelowDikeToeAtPolder from Translations.xml

Related to Issue [MWDAM-1537]

Options
    • -4
    • +0
    ./Deltares.Dam.Data/Translations.xml
3:17 pm

John Bokma

Corrected setting DampingFactorPl3 and DampingFactorPl4.

Removed obsolete ModelParameters.

Related to Issue [MWDAM-1533]

Options
    • -1
    • +0
    ./Deltares.Dam.Data/Deltares.Dam.Data.csproj
    • -2
    • +2
    ./Deltares.Dam.Data/DamEngineIo/FillDamUiFromXmlInput.cs
    • -2
    • +2
    ./Deltares.Dam.Data/DamEngineIo/FillXmlInputFromDamUi.cs
    • -69
    • +0
    ./Deltares.Dam.Data/ModelParameters.cs
1:51 pm

Esther van Zantvoort

DegreeOfConsolidation default to null. Write DegreeOfConsolidationSpecified=false in xml to Engine when DegreeOfConsolidation is null.

Related to Issue [MWDAM-1539]

Options
    • -3
    • +6
    ./Deltares.Dam.Data/Location.cs
    • -1
    • +1
    ./Deltares.Dam.Data/IO/CombineImportedData.cs
    • -2
    • +2
    ./Deltares.Dam.Data/DamEngineIo/FillXmlInputFromDamUi.cs
  4. … 1 more file in changeset.
Monday 15 Jul 2019
11:38 pm

Esther van Zantvoort

small refactoring in ImportDataForDikeRings

Related to Issue [MWDAM-1537]

Options
    • -4
    • +1
    ./Deltares.Dam.Data/DataPlugins/DataPluginImporter.cs
5:35 pm

John Bokma

Oops, now with the correct seepage length (was not saved yet).

Related to Issue [MWDAM-1361]

Options
    • -1
    • +1
    ./Deltares.Dam.Data/CsvExportData.cs
5:32 pm

John Bokma

Corrected piping output for entry point and correct seepage length. Made DistanceToEntryPoint visible in the locations table.

Removed obsolete arePlLineCreationExpertKnowledgeParametersNeeded. Added test on RequiredSafetyFactorStabilityInnerSlope to prevent unwanted error.Removed obsolete RequiredSafetyPipingForAssessment.

Related to Issue [MWDAM-1361]

Options
    • -2
    • +2
    ./Deltares.Dam.Data/Location.cs
    • -0
    • +2
    ./Deltares.Dam.Data/CsvExportData.cs
    • -1
    • +0
    ./Deltares.Dam.Data/DamGlobalConstants.cs
3:50 pm

Esther van Zantvoort

When expected head pl3 and pl4 headers are not found in the scenarios.csv, check if the old format headers are available.

Related to Issue [MWDAM-1530]

Options
    • -0
    • +18
    ./Deltares.Dam.Data/CsvImporters/CsvImporterScenarios.cs
    • -0
    • +10
    ./Deltares.Dam.Data/Importers/CsvColumnNames.cs
  3. … 1 more file in changeset.
3:17 pm

Esther van Zantvoort

Added comment at test that can fail on local computer after changing regional settings

Related to Issue [MWDAM-1537]

Options
    • -0
    • +1
    ./Deltares.Maps/Test/Domain/FeatureTest.cs
1:50 pm

John Bokma

Adapted due to review comments.

Related to Issue [MWDAM-1527]

Options
    • -9
    • +0
    ./Deltares.Dam.Data/Translations.xml
    • -4
    • +0
    ./Deltares.Dam.Data/FailureMechanismeParamatersMStab.cs
  3. … 2 more files in changeset.
10:26 am

Esther van Zantvoort

Removed parameters from Location that are in Scenario as well.

Related to Issue [MWDAM-1537]

Options
    • -138
    • +0
    ./Deltares.Dam.Data/Importers/LocationShapeFileImporterDotSpatial.cs
    • -8
    • +8
    ./Deltares.Dam.Data/Importers/CsvColumnNames.cs
    • -1
    • +2
    ./Deltares.Dam.Data/Importers/LocationAttributeMapping.cs
    • -1
    • +0
    ./Deltares.Dam.Data/Deltares.Dam.Data.csproj
    • -4
    • +4
    ./Deltares.Dam.Data/Translations.xml
    • -10
    • +10
    ./Deltares.Dam.Data/Importers/LineAttributeImporter.cs
    • -15
    • +16
    ./Deltares.Dam.Data/Importers/LocationShapeFileAttributeMap.cs
    • -5
    • +5
    ./Deltares.Dam.Data/Scenario.cs
    • -84
    • +0
    ./Deltares.Dam.Data/EntityFactory.cs
    • -55
    • +0
    ./Deltares.Dam.Data/Sensors/SensorLocation.cs
    • -58
    • +0
    ./Deltares.Dam.Data/DamProject.cs
    • -134
    • +58
    ./Deltares.Dam.Data/DataPlugins/DataPluginImporter.cs
    • -75
    • +35
    ./Deltares.Dam.Data/IO/CombineImportedData.cs
    • -23
    • +30
    ./Deltares.Dam.Data/Importers/LocationShapeFileImporter.cs
    • -0
    • +2471
    ./Deltares.Dam.Data/Location.cs
  16. … 22 more files in changeset.
Saturday 13 Jul 2019
12:02 am

Esther van Zantvoort

Removed ModelFactors from Location in xsd.

Related to Issue [MWDAM-1519]

Options
    • -16
    • +0
    ./Deltares.Dam.Data/DamEngineIo/FillXmlInputFromDamUi.cs
    • -12
    • +0
    ./Deltares.Dam.Data/DamEngineIo/FillDamUiFromXmlInput.cs
Friday 12 Jul 2019
6:59 pm

Esther van Zantvoort

Removed HeadPl3, HeadPl4, Pl1BelowCrestRiverside, Pl1BelowCrestPolderside, Pl1BelowShoulderCrestPolderside, Pl1BelowToeDikePolderside, Pl1BelowCrestMiddle, Pl1FactorBelowShoulderCrest from WaternetOptions.

Related to Issue [MWDAM-1519]

Options
    • -12
    • +0
    ./Deltares.Dam.Data/DamEngineIo/FillXmlInputFromDamUi.cs
    • -9
    • +0
    ./Deltares.Dam.Data/DamEngineIo/FillDamUiFromXmlInput.cs