Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Added comment at test that can fail on local computer after changing regional settings

Related to Issue [MWDAM-1537]

Adapted due to review comments.

Related to Issue [MWDAM-1527]

Removed DamCalculationBenchmarkTest.cs from Deltares.Dam.Tests.csproj, because it is also in Deltares.Dam.BenchmarkTests.csproj

Related to Issue [MWDAM-1519]

Removed parameters from Location that are in Scenario as well.

Related to Issue [MWDAM-1537]

    • -24
    • +23
    ./Dam/Tests/IO/CombineImportedDataTest.cs
    • -3
    • +10
    ./Dam/Tests/DataPluginImporterTests.cs
    • -70
    • +5
    ./Dam/Tests/LoadCompatiblityTest.cs
    • -1
    • +0
    ./Dam/Tests/DataPluginImporterCsvTests.cs
    • -13
    • +13
    ./Dam/Tests/CsvImporterTestsNew.cs
    • too large
    ./Dam/Tests/TestData/DamLive/Grebbedijk/input.damx
  1. … 22 more files in changeset.
Fixed IO tests, due to Removed ModelFactors.

Related to Issue [MWDAM-1519]

Removed ModelFactors from Location in xsd.

Related to Issue [MWDAM-1519]

Fixed IO tests, due to Removed HeadPl3, HeadPl4, Pl1BelowCrestRiverside, Pl1BelowCrestPolderside, Pl1BelowShoulderCrestPolderside, Pl1BelowToeDikePolderside, Pl1BelowCrestMiddle, Pl1FactorBelowShoulderCrest from WaternetOptions.

Related to Issue [MWDAM-1519]

Removed HeadPl3, HeadPl4, Pl1BelowCrestRiverside, Pl1BelowCrestPolderside, Pl1BelowShoulderCrestPolderside, Pl1BelowToeDikePolderside, Pl1BelowCrestMiddle, Pl1FactorBelowShoulderCrest from WaternetOptions.

Related to Issue [MWDAM-1519]

Fixed tests due to: Renamed WaterHeight back to RiverLevel, except in csv files.

Related to Issue [MWDAM-1521]

Fixed failing tests:

- WaterHeight was renamed back to RiverLevel which caused the newly introduced visibility tests to fail.

Related to Issue [MWDAM-1518]

Removed obsolete parameters ProbabilisticType and SoilType.

Related to Issue [MWDAM-1527]

    • -19
    • +5
    ./DamClientsLibrary/Deltares.Dam.Data/DamFailureMechanismeCalculationSpecification.cs
Renamed WaterHeight back to RiverLevel, except in csv files.

Related to Issue [MWDAM-1521]

    • -2
    • +2
    ./Dam/Tests/IO/CombineImportedDataTest.cs
    • -2
    • +2
    ./Dam/Tests/Sensors/SensorLocationTests.cs
    • -35
    • +35
    ./Dam/Tests/DataPluginImporterTests.cs
    • -12
    • +12
    ./Dam/Tests/CsvImporterTestsNew.cs
Removed obsolete parameter IsUseOriginalCalculationOptions, cleaned up text references for previous obsolete parameters and removed obsolete Overtopping calculator.

Related to Issue [MWDAM-1527]

    • -4
    • +0
    ./Dam/Tests/WaterBoardImporterTests.cs
    • -95
    • +0
    ./Dam/Tests/OvertoppingErosionCalculatorTest.cs
Raise exception when river level is not defined in ValidateDamProjectData

Related to Issue [MWDAM-1521]

Removed obsolete parameters GrassQuality, Direction, LevelReductionInside, LevelReductionOutside, LayerHeightDeviation, LayerHeightDistribution and IsUseOriginalPLLineAssignments.

Related to Issue [MWDAM-1527]

    • -8
    • +0
    ./Dam/Tests/IO/CombineImportedDataTest.cs
    • -3
    • +0
    ./Dam/Tests/WaterBoardImporterTests.cs
    • -6
    • +0
    ./Dam/Tests/TestHelper/ProjectLoader.cs
    • -59
    • +15
    ./Dam/Forms/DamProjectCalculationSpecificationPropertyControl.Designer.cs
    • -11
    • +0
    ./Dam/Tests/LoadCompatiblityTest.cs
  1. … 12 more files in changeset.
Added comments at tests

Related to Issue [MWDAM-1516]

    • -0
    • +20
    ./Dam/Tests/DataPluginImporterTests.cs
Restored removed controls as these should still be visible when the project is not in design mode.

Merged revision(s) 2445 from DamClients/DamUI/trunk:

Removed obsolete properties from the LocationPropertyControl:

- Removed HeadPL3 and HeadPL4 items

Related to Issue [MWDAM-1518]

    • -0
    • +72
    ./Dam/Forms/LocationPropertyControl.Designer.cs
    • -0
    • +2
    ./Dam/Forms/LocationPropertyControl.cs
Reordered properties that are related to the scenarios tab:

- Visibility should however be maintained when the program is not in DesignMode

-- Added tests to verify behaviour of the parameters that are also displayed in the scenariostab

-- Optimized the switch-case logic by using fall-through

Related to Issue [MWDAM-1518]

Restored removed properties as the context should determine the visibility and not the object itself

---

Merged revision(s) 2447 from DamClients/DamUI/trunk:

Removed obsolete properties from the Location:

- Removed the UpliftCriteria for Piping and Stability as these are already presented by the scenario

Related to Issue [MWDAM-1518]

Updated comments about required properties in scenarios.csv

Related to Issue [MWDAM-1531]

    • -3
    • +5
    ./Dam/Tests/DataPluginImporterTests.cs
Adapted test values to the removal of code deleting locations. Due to this, more locations and less errors are to be expected.

Related to Issue [MWDAM-1524]

    • -2
    • +2
    ./Dam/Tests/IO/CombineImportedDataTest.cs
Corrected test by setting the illegal value to a field that is read instead of now skipped.

Related to Issue [MWDAM-1527]

Removed all probabilistic parameters except for type. Also removed obsolete SchematizationFactorData and control.

Related to Issue [MWDAM-1527]

    • -214
    • +0
    ./Dam/Forms/SchematizationFactorPropertyControl.Designer.cs
    • -70
    • +0
    ./Dam/Forms/SchematizationFactorPropertyControl.cs
    • -120
    • +0
    ./Dam/Forms/SchematizationFactorPropertyControl.resx
  1. … 15 more files in changeset.
DikeTableHeight is no longer required in scenarios.csv

Related to Issue [MWDAM-1531]

    • -15
    • +15
    ./Dam/Tests/DataPluginImporterTests.cs
Removed deleting locations when WaterHeight is not specified in import.

Related to Issue [MWDAM-1524]

    • -112
    • +11
    ./Dam/Tests/DataPluginImporterTests.cs
Removed the water_height_decimeringshoogte and max_water_height options.

Related to Issue [MWDAM-1527]

    • -2
    • +0
    ./Dam/Tests/IO/CombineImportedDataTest.cs
Fixed another test for changed csv column names.

Related to Issue [MWDAM-1530]

Removed the Dupuit options and related test data.

Related to Issue [MWDAM-1527]

    • -21
    • +0
    ./Dam/Tests/Deltares.Dam.IntegrationTests.csproj
  1. … 16 more files in changeset.
Fixed tests for changed csv column names.

Related to Issue [MWDAM-1530]

Moved field names for import of scenarios.csv to CsvColumnNames.

Related to Issue [MWDAM-1530]