Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Removed StabilityKernelType:

- Removed from the FillXmlInputFromDamUi

Related to Issue [MWDAM-1630]

Disabled model selection when StabilityOutside or StabilityInside failure mechanism is active:

- Set UpLiftVan as default value when a new project is made

- Added tests to verify behaviour

Related to Issue [MWDAM-1630]

    • -0
    • +55
    ./Dam/Tests/MStabParametersTest.cs
    • -0
    • +110
    ./Dam/Tests/DamFailureMechanismeCalculationSpecificationTest.cs
    • -10
    • +14
    ./DamClientsLibrary/Deltares.Dam.Data/DamFailureMechanismeCalculationSpecification.cs
Incorporated comments reviewer:

- Reverted SoilGeometry2DName to simply the profile name (without extension)

Related to Issue [MWDAM-1380]

Incorporated comments reviewer:

- Moved the naming of the read SoilProfile2D to the Importer as all the information is available there

-- The reader is only responsible for reading the soil profile, not for setting additional postprocessing of the read data

Related to Issue [MWDAM-1374]

Incorporated comments reviewer:

- Removed argument "propertyName" and made dedicated messages for when the soil or geometry version numbers are unsupported

Related to Issue [MWDAM-1374]

Incorporated comments reviewer:

- Added check on whether the profile name has the .sti extension. If not --> add the extension to read from the reader.

- Corrected behaviour on the StiFileReader to set the profile name equivalent to the filename without extension.

Related to Issue [MWDAM-1374]

Cleanup:

- Renamed parameternames and cleaned up function call

Related to Issue [MWDAM-1380]

Added behaviour to serialise only one soilprofile in case there are duplicates present.

Related to Issue [MWDAM-1380]

Improved unit test by pulling all the relevant files to its own test data folder

Related to Issue [MWDAM-1380]

Fixed unit test, as SoilProfile2D profiles in a segment are being read from sti file:

- Reverted changes for the localChanges, as this ensures that ONLY the segments in the waterboard is serialized (prevents duplicated serialization)

- Cleaned up implementation

Related to Issue [MWDAM-1380]

  1. ./Dam/Tests/TestData/FillXMLInputFromDamUI
Cleanup XMLDoc.

Related to Issue [MWDAM-1374]

Added logic to wire the imported (and converted) soil profiles to the XMLInput object:

- Added unit tests to verify behaviour

Related to Issue [MWDAM-1380]

Cleanup unnecessary references.

Related to Issue [MWDAM-1374]

Fixed failing tests build server.

Related to Issue [MWDAM-1374]

Adjusted reader to set the full name on the soil profile instead of only the file name without extension --> the segments refer to the full name in the XML export.

Related to Issue [MWDAM-1374]

Renamed converter to fix sonarqube issues.

Related to Issue [MWDAM-1380]

Updated converter to set the correct values for the WaterpressureInterpolationModel:

- Set to value 1 as this corresponds with the DAM engine implementation of hydrostatic model

Related to Issue [MWDAM-1374]

Adapted XMLDoc

Related to Issue [MWDAM-1374]

Modified the reader such that an exception is thrown whenever an error occurs with a soil profile to read.

Related to Issue [MWDAM-1374]

Added conversion exception whenever a soil profile contains more than 1 inner loop in a soil profile layer

Related to Issue [MWDAM-1380]

Added functionality to set the name to the soil profile (this is not set automatically):

- Adjusted tests to verify behaviour.

- Added missing license headers

Related to Issue [MWDAM-1374]

Added converter to convert the imported SoilProfile2D to the XML format

Related to Issue [MWDAM-1380]

    • -0
    • +223
    ./Dam/Tests/DamEngineIo/XMLSoilProfile2DConverterTest.cs
Added assert for the inner loops

Related to Issue [MWDAM-1374]

Fixed failing test:

- The surfaces differ in order on different machines, so only assert whether all the surfaces are present.

Related to Issue [MWDAM-1374]

Moved message to resources:

- Applied for the validator

Related to Issue [MWDAM-1374]

Cleanup: renamed alias

Related to Issue [MWDAM-1374]

Moved message to resources:

- Applied for the reader

Related to Issue [MWDAM-1374]

Moved message to resources:

- Applied for the importer

Related to Issue [MWDAM-1374]

Added importer to retrieve collections of SoilProfile2D based on a segment and the soil (materials) that are available.

Related to Issue [MWDAM-1374]

    • -0
    • +219
    ./Dam/Tests/StiImporter/SoilProfile2DImporterTest.cs
Cleanup:

- Improved XMLDocs and removed TODO item

Related to Issue [MWDAM-1374]