Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Waternet is created based on SoilProfile1D when available

Related to Issue [MWDAM-2369]

    • too large
    ./PlLinesToWaternetConverterTests.cs
  1. … 4 more files in changeset.
Tolerance used in Waternet line creator corrected.

Related to Issue [MWDAM-2380]

    • too large
    ./PlLinesToWaternetConverterTests.cs
  1. … 2 more files in changeset.
Fifth commit of the combining code for SurfaceLine and SoilProfile2D. Still work to be done and to be tested.

Related to Issue [MWDAM-2258]

    • too large
    ./PlLinesToWaternetConverterTests.cs
Adapted to review: Unit test for 1D soil profile splits into 2 cases

Related to Issue [MWDAM-2252]

    • too large
    ./PlLinesToWaternetConverterTests.cs
Adapted to review: Unit test split into 2 cases

Related to Issue [MWDAM-2252]

    • -140
    • +174
    ./PlLinesToWaternetConverterTests.cs
Code improved

Related to Issue [MWDAM-2271]

Unit tests added to highlights the problems

Related to Issue [MWDAM-2271]

    • -0
    • +183
    ./PlLinesToWaternetConverterTests.cs
  1. … 3 more files in changeset.
Sonar cloud issues solved

Related to Issue [MWDAM-2251]

Case where phreatic line passes through all layers of 2D profile is better handled.

Also added that the waternet line for PL1 can't be situated in the bottom aquifer.

Related to Issue [MWDAM-2252]

    • -62
    • +39
    ./PlLinesToWaternetConverterTests.cs
  1. … 2 more files in changeset.
Waternet line for in-between aquifer changed into 2 lines instead of a close boundary to be correctly displayed in STIX file.

Related to Issue [MWDAM-2242]

    • -54
    • +67
    ./PlLinesToWaternetConverterTests.cs
  1. … 1 more file in changeset.
Adapted to review: exception is raised when no bottom aquifer present

Related to Issue [MWDAM-2225]

    • -32
    • +22
    ./PlLinesToWaternetConverterTests.cs
  1. … 1 more file in changeset.
Obsolete code removed and unit tests updated

Related to Issue [MWDAM-2246]

    • -1
    • +13
    ./PlLinesToWaternetConverterTests.cs
  1. … 2 more files in changeset.
Assert.Multiple called when possible

Related to Issue [MWDAM-2225]

    • -35
    • +53
    ./PlLinesToWaternetConverterTests.cs
Unused PL lines are not added to the headline list of the waternet

Related to Issue [MWDAM-2225]

    • -115
    • +114
    ./PlLinesToWaternetConverterTests.cs
  1. … 1 more file in changeset.
Adapted to review:

- Unit tests testing the position of the bottom aquifer and in-between aquifer are done calling DetermineLayerBoundaryPoints instead of CreateWaternetBasedOnPlLines

- Unit test for CreateWaternetBasedOnPlLines with 2D profile improved using more complex 2D profile

Related to Issue [MWDAM-2209]

    • -393
    • +292
    ./PlLinesToWaternetConverterTests.cs
  1. … 1 more file in changeset.
Adapted to review

Related to Issue [MWDAM-2201]

    • -4
    • +13
    ./PlLinesToWaternetConverterTests.cs
  1. … 4 more files in changeset.
Waternet line for PL2 is created only if penetration length > 0

Related to Issue [MWDAM-2215]

  1. … 1 more file in changeset.
Semi time dependent waternet type implemented.

Related to Issue [MWDAM-2215]

    • -85
    • +101
    ./PlLinesToWaternetConverterTests.cs
  1. … 1 more file in changeset.
"Full hydrostatic" waternet type implemented for 1D profile

Related to Issue [MWDAM-2211]

    • -47
    • +55
    ./PlLinesToWaternetConverterTests.cs
  1. … 1 more file in changeset.
"Full hydrostatic" waternet type implemented

Related to Issue [MWDAM-2211]

    • -24
    • +29
    ./PlLinesToWaternetConverterTests.cs
  1. … 1 more file in changeset.
Waternet type "Hydrostatic" implemented including unit tests

Related to Issue [MWDAM-2209]

  1. … 4 more files in changeset.
Waternet type "Linear" implemented including unit tests

Related to Issue [MWDAM-2201]

    • -38
    • +47
    ./PlLinesToWaternetConverterTests.cs
  1. … 4 more files in changeset.
Issues in sonar cloud solved

Related to Issue [MWDAM-2154]

  1. … 3 more files in changeset.
Issues in sonar cloud solved

Related to Issue [MWDAM-2154]

  1. … 2 more files in changeset.
Waternet improved by:

- assigning PL4 to all in-betweens aquifer clusters and to the complete cluster

- assigning PL1 to a waternet line which is the bottom of the soil layers “in which the phreatic plane lies”

- removing unnecessary points from the waternet lines

Related to Issue [MWDAM-2154]

    • -93
    • +236
    ./PlLinesToWaternetConverterTests.cs
  1. … 3 more files in changeset.
Cleanup and reformat

Related to Issue [MWDAM-2132]

    • -20
    • +20
    ./PlLinesToWaternetConverterTests.cs
  1. … 19 more files in changeset.
Adapted to review: class name improved

Related to Issue [MWDAM-2190]

    • -34
    • +34
    ./PlLinesToWaternetConverterTests.cs
  1. … 3 more files in changeset.
Case of aquifer layer with a vertical part is now correctly handled.

Unit tests updated with the new point of the waternet line.

Related to Issue [MWDAM-2190]

    • -2
    • +12
    ./PlLinesToWaternetConverterTests.cs
  1. … 1 more file in changeset.
Refactoring:

- duplicated code moved to new generic methods (CreateAllPlLines and CreateRectangularSoilLayer2D)

- picture of the soil profiles added as comment to illustrate the test

Related to Issue [MWDAM-2190]

    • -761
    • +578
    ./PlLinesToWaternetConverterTests.cs
Update to NUnit 4

Related to Issue [MWDAM-2017]

  1. … 34 more files in changeset.