Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tenth commit of the combining code for SurfaceLine and SoilProfile2D. Removed WiP status for several tests, corrected expected result for one test from 7 to 3 as 3 is the highest level of the given surface line so end result can never have a highest Z of 7, it must be 3.

Related to Issue [MWDAM-2258]

Fifth commit of the combining code for SurfaceLine and SoilProfile2D. Still work to be done and to be tested.

Related to Issue [MWDAM-2258]

    • too large
    ./PlLinesToWaternetConverterTests.cs
Adapted to review: Unit test for 1D soil profile splits into 2 cases

Related to Issue [MWDAM-2252]

    • too large
    ./PlLinesToWaternetConverterTests.cs
Adapted to review: Unit test split into 2 cases

Related to Issue [MWDAM-2252]

    • -140
    • +174
    ./PlLinesToWaternetConverterTests.cs
Code improved

Related to Issue [MWDAM-2271]

Unit tests added to highlights the problems

Related to Issue [MWDAM-2271]

    • -0
    • +183
    ./PlLinesToWaternetConverterTests.cs
    • -0
    • +511
    ./TestFiles/InputTutorialStabilitySoilProfileDWP1.xml
  1. … 2 more files in changeset.
Added Zone to Tests for TransferSlipPlaneConstraints

Related to Issue [MWDAM-2255]

Implemented TransferSlipPlaneConstraints and fixed test

Related to Issue [MWDAM-2255]

  1. … 6 more files in changeset.
Reverted TransferSlipPlaneConstraints (work in progress) due to failing tests

Related to Issue [MWDAM-2255]

  1. … 1 more file in changeset.
Implemented TransferSlipPlaneConstraints (work in progress)

Related to Issue [MWDAM-2255]

  1. … 1 more file in changeset.
Sonar cloud issues solved

Related to Issue [MWDAM-2251]

Case where phreatic line passes through all layers of 2D profile is better handled.

Also added that the waternet line for PL1 can't be situated in the bottom aquifer.

Related to Issue [MWDAM-2252]

    • -62
    • +39
    ./PlLinesToWaternetConverterTests.cs
  1. … 2 more files in changeset.
Waternet line for in-between aquifer changed into 2 lines instead of a close boundary to be correctly displayed in STIX file.

Related to Issue [MWDAM-2242]

    • -54
    • +67
    ./PlLinesToWaternetConverterTests.cs
  1. … 1 more file in changeset.
Added check on surfaceline being strict ascending

Related to Issue [MWDAM-2132]

    • -0
    • +10
    ./MacroStabilityCommonHelperTests.cs
  1. … 4 more files in changeset.
Adapted to review: exception is raised when no bottom aquifer present

Related to Issue [MWDAM-2225]

    • -32
    • +22
    ./PlLinesToWaternetConverterTests.cs
  1. … 1 more file in changeset.
Obsolete code removed and unit tests updated

Related to Issue [MWDAM-2246]

    • -1
    • +13
    ./PlLinesToWaternetConverterTests.cs
  1. … 2 more files in changeset.
Added test if surfaceline is fully above bottom of soilprofile2D before combining them

Related to Issue [MWDAM-2132]

    • -0
    • +11
    ./MacroStabilityCommonHelperTests.cs
  1. … 4 more files in changeset.
Fix some SonarCloud issues

Related to Issue [MWDAM-2132]

  1. … 2 more files in changeset.
Added (failing and ignored) test for combining a soilProfile2D with a surfaceline cutting the top boundary of the soilProfile2D

Related to Issue [MWDAM-2132]

    • -0
    • +23
    ./MacroStabilityCommonHelperTests.cs
  1. … 1 more file in changeset.
Added (failing and ignored) test for combining a soilProfile2D with a surfaceline fully below the top boundary of the soilProfile2D

Related to Issue [MWDAM-2132]

    • -2
    • +25
    ./MacroStabilityCommonHelperTests.cs
  1. … 1 more file in changeset.
Added (failing and ignored) test for combining a soilProfile2D with a surfaceline fully above the top boundary of the soilProfile2D

Related to Issue [MWDAM-2132]

    • -0
    • +23
    ./MacroStabilityCommonHelperTests.cs
  1. … 1 more file in changeset.
Implement cut right of geometry in CombineSoilProfile2DWithSurfaceLine()

Test ignored, because Work in Progress

Related to Issue [MWDAM-2132]

    • -1
    • +31
    ./MacroStabilityCommonHelperTests.cs
  1. … 1 more file in changeset.
Implement extend right of geometry in CombineSoilProfile2DWithSurfaceLine()

Related to Issue [MWDAM-2132]

    • -0
    • +26
    ./MacroStabilityCommonHelperTests.cs
  1. … 1 more file in changeset.
Implement extend left of geometry in CombineSoilProfile2DWithSurfaceLine()

Related to Issue [MWDAM-2132]

    • -0
    • +26
    ./MacroStabilityCommonHelperTests.cs
  1. … 1 more file in changeset.
Implement cut left of geometry in CombineSoilProfile2DWithSurfaceLine()

Related to Issue [MWDAM-2132]

    • -0
    • +30
    ./MacroStabilityCommonHelperTests.cs
  1. … 1 more file in changeset.
Added test for combining SoilProfile2D with matching surfaceline

Related to Issue [MWDAM-2132]

    • -0
    • +34
    ./MacroStabilityCommonHelperTests.cs
Use dedicated surfaceline for MacroStabilityCommon/MacroStabilityCommonHelperTests

Related to Issue [MWDAM-2132]

  1. … 1 more file in changeset.
Assert.Multiple called when possible

Related to Issue [MWDAM-2225]

    • -35
    • +53
    ./PlLinesToWaternetConverterTests.cs
Unused PL lines are not added to the headline list of the waternet

Related to Issue [MWDAM-2225]

    • -115
    • +114
    ./PlLinesToWaternetConverterTests.cs
  1. … 1 more file in changeset.
Adapted to review:

- Unit tests testing the position of the bottom aquifer and in-between aquifer are done calling DetermineLayerBoundaryPoints instead of CreateWaternetBasedOnPlLines

- Unit test for CreateWaternetBasedOnPlLines with 2D profile improved using more complex 2D profile

Related to Issue [MWDAM-2209]

    • -393
    • +292
    ./PlLinesToWaternetConverterTests.cs
  1. … 1 more file in changeset.