Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sonarcloud issues solved

Related to Issue [MWDAM-2767]

  1. … 6 more files in changeset.
Removed GeometryPoint from GeometryPointString/GeometryLoop classes and everywhere it was used. Improved geometry generation and Clone() methods for SoilProfile2D.

Related to Issue [MWDAM-2760]

  1. … 54 more files in changeset.
unit tests added on lower level + code improved

Related to Issue [MWDAM-2691]

  1. … 6 more files in changeset.
Code improved according to sonarcloud issue

Related to Issue [MWDAM-2691]

Unit test added using the data provided by RPS in issue MWDAM_2631.

Code corrected for searching the intersection point with PL1.

Unused property XSoilGeometry2DOrigin removed from PlLinesCreator.

Related to Issue [MWDAM-2631]

  1. … 22 more files in changeset.
Code improved according to sonarcloud issue

Related to Issue [MWDAM-2691]

Test is corrected and WIP is removed

Related to Issue [MWDAM-2462]

  1. … 1 more file in changeset.
Reduction of PL3/PL4 implemented when the aquifer intersects the surface line (i.e. the ditch)

Related to Issue [MWDAM-2691]

  1. … 4 more files in changeset.
Cognitive complexity is reduced

Related to Issue [MWDAM-2716]

Remove code for reading sti files.

Related to Issue [MWDAM-2160]

  1. … 26 more files in changeset.
Case without in between aquifers improved

Related to Issue [MWDAM-2716]

Sonarcloud issues fixed

Related to Issue [MWDAM-2716]

Waternet lines for in-between aquifer cluster with vertical part is improved by connecting the points to create a unique line

Related to Issue [MWDAM-2716]

  1. … 1 more file in changeset.
Determination of the top and bottom aquifers improved in case of cluster.

Unit tests added.

Related to Issue [MWDAM-2716]

  1. … 1 more file in changeset.
Determination of the boundaries of the in-between aquifers improved to deal with in-between aquifers cutting the not vertical geometry limit.

Unit test added.

Related to Issue [MWDAM-2716]

  1. … 5 more files in changeset.
Adapted to review: comment added to explain why the inner loops are removed

Related to Issue [MWDAM-2704]

Code improved and header in public method added

Related to Issue [MWDAM-2704]

  1. … 1 more file in changeset.
For the validation of the soil profile, an aquifer with aquitard inner loop is valid

Related to Issue [MWDAM-2704]

  1. … 2 more files in changeset.
Removed properties from Location that are duplicated in DesignScenario

Related to Issue [MWDAM-2649]

  1. … 11 more files in changeset.
Case where no uplift results available is improved by returning NaN

Related to Issue [MWDAM-2608]

Case where no uplift results available is handled to avoid exception

Related to Issue [MWDAM-2608]

The determination of the position of the Uplift Van grid with specified size is improved by using the point with the lowest uplift factor as grid boundary

Related to Issue [MWDAM-2608]

  1. … 11 more files in changeset.
Improve adapt geometry

- Use always shoulder embankment material

- Always use the original SoilProile2D to combine with the new adapted surfaceline

Related to Issue [MWDAM-2472]

Related to Issue [MWDAM-2469]

  1. … 4 more files in changeset.
Implement shoulder embankment material for adapt first shoulder adaption then shoulder adaption

Related to Issue [MWDAM-2472]

  1. … 6 more files in changeset.
Code refactored to solve issue detected by sonarcloud

Related to Issue [MWDAM-2581]

Code refactored to solve issues detected by sonarcloud

Related to Issue [MWDAM-2581]

  1. … 1 more file in changeset.
Add a validation on the presence of isolated in-between aquifers

Related to Issue [MWDAM-2581]

  1. … 7 more files in changeset.
Validations of the soil profile performed in class PlLinesCreator.cs and PlLinesToWaternetConverter.cs are moved to a new class SoilProfileValidator and called only by the PlLinesCreator.

Related to Issue [MWDAM-2164]

  1. … 12 more files in changeset.
The determination of 2D aquifer layers in PlLinesToWaternetConverter is extracted to a new class SoilProfile2DHelper in order to be used by the waternet creator validator

Related to Issue [MWDAM-2525]

    • -0
    • +232
    ./SoilProfile2DHelper.cs
  1. … 3 more files in changeset.
Refactoring: comments improved + unused method DetermineStabilityUplift removed

Related to Issue [MWDAM-2226]

  1. … 4 more files in changeset.