DAM / DamEngine / trunk / src / Deltares.DamEngine.Calculators / KernelWrappers

MacroStabilityCommon

Checkout Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 16:48
Commits this week: 0
Total Lines of Code (LoC): 5,026
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 03 Apr 2020
5:22 pm

John Bokma

Re-instated using UpliftVanCalculationGrid.

Related to Issue [MWDAM-1627]

Options
    • -2
    • +2
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -0
    • +29
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
  3. … 2 more files in changeset.
10:27 am

John Bokma

Adapted to new version of C#wrapper, fixed some WIP-test for the wrapper.

Related to Issue [MWDAM-1627]

Options
    • -14
    • +12
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -7
    • +6
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -2
    • +2
    ./MacroStabilityIo/ConversionHelper.cs
  4. … 5 more files in changeset.
Thursday 02 Apr 2020
9:10 am

tang_ds

Incorporated comments review:

- Adjusted function names

- Removed unused variable

Related to Issue [MWDAM-1398]

Options
    • -5
    • +5
    ./PlLinesToWaternetConverter.cs
  2. … 2 more files in changeset.
Wednesday 01 Apr 2020
11:46 am

John Bokma

Adapted the calculation grid. Cleaned code a bit.

Related to Issue [MWDAM-1627]

Options
    • -4
    • +0
    ./MacroStabilityIo/FillMacroStabilityWrapperOutputFromEngine.cs
    • -2
    • +26
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -25
    • +32
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -8
    • +4
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperOutput.cs
  5. … 4 more files in changeset.
Tuesday 31 Mar 2020
4:13 pm

John Bokma

Removed double using.

Related to Issue [MWDAM-1632]

Options
    • -16
    • +15
    ./MacroStabilityIo/ConversionHelper.cs
Friday 21 Feb 2020
10:31 am

tang_ds

Cleanup the 1D profile implementation:

- No need for separate CreateHeadLine method, as the generic method will already create one.

Related to Issue [MWDAM-1398]

Options
    • -52
    • +26
    ./PlLinesToWaternetConverter.cs
  2. … 1 more file in changeset.
10:20 am

tang_ds

Added NULL checks to the converter routine:

- Generalised log message

Related to Issue [MWDAM-1398]

Options
    • -7
    • +10
    ./PlLinesToWaternetConverter.cs
  2. … 4 more files in changeset.
Thursday 20 Feb 2020
4:50 pm

tang_ds

Added testcase which represents the edgecase when multiple aquifer layers for the inebtween aquifer layer does not envelope the whole X coordinate range

Related to Issue [MWDAM-1398]

Options
    • -10
    • +27
    ./PlLinesToWaternetConverter.cs
  2. … 1 more file in changeset.
3:03 pm

tang_ds

Added first implementation of PLLine conversion to waternet input for 2D profiles

Related to Issue [MWDAM-1398]

Options
    • -1
    • +146
    ./PlLinesToWaternetConverter.cs
  2. … 1 more file in changeset.
2:56 pm

John Bokma

Implemented the required (minimum) output with tests and conversion helper. Removed some obsolete code and tests.

Related to Issue [MWDAM-1627]

Options
    • -1
    • +35
    ./MacroStabilityIo/FillMacroStabilityWrapperOutputFromEngine.cs
    • -4
    • +38
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperOutput.cs
    • -6
    • +11
    ./MacroStabilityIo/ConversionHelper.cs
  4. … 4 more files in changeset.
11:49 am

John Bokma

Finished the issue now soil parameters are all decoded upon and implemented.

Related to Issue [MWDAM-1632]

Options
    • -10
    • +8
    ./MacroStabilityIo/ConversionHelper.cs
  2. … 1 more file in changeset.
10:50 am

John Bokma

Re-implemented r=the tangent lines now these are part of the wrapper again.

Related to Issue [MWDAM-1627]

Options
    • -6
    • +5
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -5
    • +4
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
  3. … 1 more file in changeset.
Wednesday 19 Feb 2020
6:50 pm

John Bokma

Adapted failing tests due to new C#wrapper, Started with correct implementation of MacroStabilityInwardsKernelWrapper based on the C#wrapper, added conversion methods with tests for that to support some result items.

Related to Issue [MWDAM-1627]

Options
    • -2
    • +38
    ./MacroStabilityIo/ConversionHelper.cs
  2. … 7 more files in changeset.
3:54 pm

tang_ds

Added testcase for the PLLines to Waternet converter when PLLines lie below the profile

Related to Issue [MWDAM-1398]

Options
    • -9
    • +25
    ./PlLinesToWaternetConverter.cs
  2. … 1 more file in changeset.
2:35 pm

tang_ds

Updated definitions for PL3 and PL4:

- Waternetline for PL3 is associated with the toplevel of the bottom most aquifer layer

- Waternetline for PL4 is associated with the toplevel of the in between aquifer layer

Related to Issue [MWDAM-1398]

Options
    • -4
    • +4
    ./PlLinesToWaternetConverter.cs
  2. … 1 more file in changeset.
12:56 pm

John Bokma

Quick fix for compilation errors due to new release of C#wrapper.

Related to Issue [MWDAM-1627]

Options
    • -9
    • +11
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -3
    • +3
    ./MacroStabilityIo/ConversionHelper.cs
    • -9
    • +11
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -0
    • +7
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperOutput.cs
  5. … 3 more files in changeset.
Tuesday 18 Feb 2020
1:50 pm

tang_ds

Implemented conversions for the waternet from the DamEngine to the calculation kernel.

Related to Issue [MWDAM-1398]

Options
    • -54
    • +54
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -52
    • +52
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
  3. … 1 more file in changeset.
11:45 am

John Bokma

Adapted to review comments bar the renaming of the Fill.. classes themselves. Solved some SonarQube code smells. Complaints by SonarQube about uncovered lines are BUILLSHIT!!!!!!!!!!!!!! All the added lines are covered by the IO tests which is easily verifiable by setting some breakpoints and debugging the IO tests. You see the code is covered.

Related to Issue [MWDAM-1623]

Options
    • -9
    • +17
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -7
    • +5
    ./MacroStabilityIo/ConversionHelper.cs
    • -12
    • +12
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
9:55 am

tang_ds

Implemented conversions for the UpliftVanCalculationGrid from the DamEngine to the calculation kernel.

Related to Issue [MWDAM-1399]

Options
    • -18
    • +23
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -18
    • +45
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
  3. … 1 more file in changeset.
Monday 17 Feb 2020
5:24 pm

John Bokma

Added conversion of surfaceline including test.

Related to Issue [MWDAM-1637]

Options
    • -16
    • +16
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -15
    • +12
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
  3. … 1 more file in changeset.
3:39 pm

John Bokma

Added conversion for SoilProfile2D and PreconcolidationStress (as these are part of the SoilProfile2D in DamEngine) with test. Improved the Factory to rpovide the correct data needed for a FULL test of the SoilProfile2D, so with Points next to CalcPoints.

Related to Issue [MWDAM-1397]

Options
    • -94
    • +76
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -91
    • +88
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
  3. … 2 more files in changeset.
2:10 pm

John Bokma

Adapted to review comments.

Related to Issue [MWDAM-1633]

Options
    • -1
    • +1
    ./MacroStabilityIo/ConversionHelper.cs
  2. … 1 more file in changeset.
11:21 am

John Bokma

Corrected MoveGrid parameter for kernel. It really is NOT in the DamEngine data model but is must be set to true as we want the brute force approach.

Related to Issue [MWDAM-1633]

Options
    • -7
    • +1
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -1
    • +1
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
Friday 14 Feb 2020
5:04 pm

John Bokma

Added code and test for this. But is depends on some parameters thta are still to be added in MWDAM-1625.

Related to Issue [MWDAM-1632]

Options
    • -28
    • +11
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -4
    • +3
    ./MacroStabilityIo/ConversionHelper.cs
    • -7
    • +11
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
  4. … 2 more files in changeset.
3:46 pm

John Bokma

Checked the correctness of the GridSizeDetermination parameter. This is indeed the correct one as this parameter gets filled with GridDetermination parameter when serializing the engine data from the given xml.

Related to Issue [MWDAM-1633]

Options
    • -1
    • +1
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
3:40 pm

John Bokma

Added the properties for Stability model with test. Also prepared IO tests a little better for the other items still to be transferred.

Related to Issue [MWDAM-1633]

Options
    • -9
    • +15
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -8
    • +43
    ./MacroStabilityIo/ConversionHelper.cs
    • -7
    • +4
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
  4. … 2 more files in changeset.
Thursday 13 Feb 2020
6:55 pm

John Bokma

Implemented review comments.

Related to Issue [MWDAM-1623]

Options
    • -12
    • +2
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -77
    • +81
    ./MacroStabilityIo/ConversionHelper.cs
    • -28
    • +14
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
  4. … 11 more files in changeset.
Wednesday 12 Feb 2020
6:35 pm

John Bokma

Fixed failing conversion tests. Made sure Only CSharpWrapper types are used.

Related to Issue [MWDAM-1623]

Options
    • -78
    • +77
    ./MacroStabilityIo/ConversionHelper.cs
  2. … 1 more file in changeset.
5:01 pm

John Bokma

Added the missing file.

Related to Issue [MWDAM-1623]

Options
    • -0
    • +37
    ./MacroStabilityIo/FillMacroStabilityWrapperOutputFromEngine.cs
4:36 pm

John Bokma

Added skeletons for FillEngineFromMacroStabilityWrapperInput, FillEngineFromMacroStabilityWrapperOutput, FillMacroStabilityWrapperInputFromEngine, FillMacroStabilityWrapperOutputFromEngine to replace wti serialization which is now removed. Started with adaptation of the kernelwrapper to no longer use wti-kernel but the full macro stability kernel via the C# wrapper (Issue [MWDAM-1627]). This latest issue can only be finished when all depending issues to actually fill in the data in the provided skeletons (and their belonging tests) are handled.

Made some tests WiP to reflect their proper status.

Removed remaining DAMMacroStability(xxx) files as these are now really no longer required.

Related to Issue [MWDAM-1623]

Options
    • -0
    • +322
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -1162
    • +0
    ./MacroStabilityIo/WTIDeserializer.cs
    • -60
    • +0
    ./DamMacroStabilityOutput.cs
    • -66
    • +0
    ./DamMacroStabilityInput.cs
    • -13
    • +5
    ./MacroStabilityIo/ConversionHelper.cs
    • -0
    • +327
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -341
    • +0
    ./MacroStabilityIo/FillWtiKernelData.cs
    • -0
    • +39
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperOutput.cs
    • -88
    • +0
    ./DamMacroStabilityOutputItem.cs
    • -326
    • +0
    ./MacroStabilityIo/FillDamEngineFromWti.cs
    • -1079
    • +0
    ./MacroStabilityIo/WTISerializer.cs
  12. … 8 more files in changeset.