Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Clean-up in MStabParameters.cs : obsolete parameters removed

Related to Issue [MWDAM-2565]

    • -6
    • +0
    ./MacroStabilityIo/ConversionHelper.cs
  1. … 6 more files in changeset.
Adapted to review: obsolete parameter IsTangentLinesAutomatic for Bishop removed

Related to Issue [MWDAM-2665]

    • -2
    • +4
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
  1. … 2 more files in changeset.
The shift of the geometry compared to the surface line is implemented and tested.

Related to Issue [MWDAM-2677]

  1. … 7 more files in changeset.
New choice (Automatic) added for Tangent line definition of UpliftVan, connected to the automatic method of Mac kernel

Related to Issue [MWDAM-2659]

    • -2
    • +4
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -1
    • +1
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
  1. … 6 more files in changeset.
Search area input is improved for Bishop (to fit the input of the MAC kernel) by using a new input parameter "BishopSearchAreaDetermination" (Automatic or Specified) which replaces the search method for grid and the search method for tangent lines.

Unit tests updated.

Related to Issue [MWDAM-2665]

    • -1
    • +1
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -1
    • +1
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
  1. … 12 more files in changeset.
Exception removed because object is always created

Related to Issue [MWDAM-2639]

    • -10
    • +0
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
Determination of the tangent lines levels for Specified is transfered to Mac kernel

Related to Issue [MWDAM-2639]

    • -0
    • +10
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
Determination of the tangent lines (automatic or on boundary lines) is corrected (was reversed).

Unit tests added.

Related to Issue [MWDAM-2639]

    • -92
    • +45
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -3
    • +3
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
  1. … 8 more files in changeset.
2 refinement steps are used for the grid and the tangent lines.

Unit tests updated with new calculated values.

Related to Issue [MWDAM-2609]

    • -0
    • +2
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
  1. … 2 more files in changeset.
Fix unit test

Related to Issue [MWDAM-2627]

Use original soilProfile1D for PL1 and soilProfile1D at DikeToeAtPolder for other PL lines.

........

Related to Issue [MWDAM-2623]

Adapted to review: synchronisation of the points called as last method

Related to Issue [MWDAM-2517]

Adapted to review comments

Related to Issue [MWDAM-2258]

  1. … 6 more files in changeset.
Convert soilProfile1D to soilProfile2D for Standard and SemiTimeDependent in CreateWaternetLineForPhreaticLine.

Related to Issue [MWDAM-2623]

  1. … 1 more file in changeset.
PL1 corrected if contains upwards vertical part

Related to Issue [MWDAM-2517]

Code refactored according to sonarcloud issues

Related to Issue [MWDAM-2573]

    • -1
    • +1
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
Code refactored according to sonarcloud issues

Related to Issue [MWDAM-2573]

    • -9
    • +5
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -1
    • +1
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
Fixed return value for design result when failing.

Added 2 tests for unsuccessful adapt geometry calculation

Related to Issue [MWDAM-2472]

Related to Issue [MWDAM-2469]

  1. … 1 more file in changeset.
TrafficLoadDegreeOfConsolidation is connected to the Mac kernel

Related to Issue [MWDAM-2573]

    • -0
    • +19
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -4
    • +25
    ./MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
  1. … 4 more files in changeset.
Adapted to review by using a tolerance when comparing doubles

Related to Issue [MWDAM-2517]

Improved validation.

Related to Issue [MWDAM-2400]

Code refactored to solve issue detected by sonarcloud

Related to Issue [MWDAM-2581]

UpliftVan with BeeSwarm is calculated using the Thorough setting of DStability

Related to Issue [MWDAM-2390]

    • -3
    • +3
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
Adapted to review: all points are handled in the method

Related to Issue [MWDAM-2517]

Validations of the soil profile performed in class PlLinesCreator.cs and PlLinesToWaternetConverter.cs are moved to a new class SoilProfileValidator and called only by the PlLinesCreator.

Related to Issue [MWDAM-2164]

  1. … 14 more files in changeset.
If statement removed because always true

Related to Issue [MWDAM-2517]

Reference line of the waternet containing upwards vertical part is corrected (by shifting the highest point by 1cm) in order to be correctly displayed in D-Stability

Related to Issue [MWDAM-2517]

  1. … 1 more file in changeset.
Added (rudimentary) tests for the geometry exporter.

Related to Issue [MWDAM-2446]

    • -0
    • +10
    ./MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
  1. … 7 more files in changeset.
The determination of 2D aquifer layers in PlLinesToWaternetConverter is extracted to a new class SoilProfile2DHelper in order to be used by the waternet creator validator

Related to Issue [MWDAM-2525]

  1. … 3 more files in changeset.
Sonar cloud issues solved

Related to Issue [MWDAM-2369]