Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Added conversion for SoilProfile2D and PreconcolidationStress (as these are part of the SoilProfile2D in DamEngine) with test. Improved the Factory to rpovide the correct data needed for a FULL test of the SoilProfile2D, so with Points next to CalcPoints.

Related to Issue [MWDAM-1397]

    • -94
    • +76
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -91
    • +88
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
  1. … 2 more files in changeset.
Adapted to review comments.

Related to Issue [MWDAM-1633]

  1. … 1 more file in changeset.
Corrected MoveGrid parameter for kernel. It really is NOT in the DamEngine data model but is must be set to true as we want the brute force approach.

Related to Issue [MWDAM-1633]

    • -7
    • +1
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -1
    • +1
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
Added code and test for this. But is depends on some parameters thta are still to be added in MWDAM-1625.

Related to Issue [MWDAM-1632]

    • -28
    • +11
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -7
    • +11
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
  1. … 2 more files in changeset.
Checked the correctness of the GridSizeDetermination parameter. This is indeed the correct one as this parameter gets filled with GridDetermination parameter when serializing the engine data from the given xml.

Related to Issue [MWDAM-1633]

    • -1
    • +1
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
Added the properties for Stability model with test. Also prepared IO tests a little better for the other items still to be transferred.

Related to Issue [MWDAM-1633]

    • -9
    • +15
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -7
    • +4
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
  1. … 2 more files in changeset.
Implemented review comments.

Related to Issue [MWDAM-1623]

    • -9
    • +3
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -12
    • +2
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -28
    • +14
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
  1. … 10 more files in changeset.
Fixed failing conversion tests. Made sure Only CSharpWrapper types are used.

Related to Issue [MWDAM-1623]

  1. … 1 more file in changeset.
Added the missing file.

Related to Issue [MWDAM-1623]

    • -0
    • +37
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperOutputFromEngine.cs
Added skeletons for FillEngineFromMacroStabilityWrapperInput, FillEngineFromMacroStabilityWrapperOutput, FillMacroStabilityWrapperInputFromEngine, FillMacroStabilityWrapperOutputFromEngine to replace wti serialization which is now removed. Started with adaptation of the kernelwrapper to no longer use wti-kernel but the full macro stability kernel via the C# wrapper (Issue [MWDAM-1627]). This latest issue can only be finished when all depending issues to actually fill in the data in the provided skeletons (and their belonging tests) are handled.

Made some tests WiP to reflect their proper status.

Removed remaining DAMMacroStability(xxx) files as these are now really no longer required.

Related to Issue [MWDAM-1623]

    • -0
    • +322
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -60
    • +0
    ./MacroStabilityCommon/DamMacroStabilityOutput.cs
    • -66
    • +0
    ./MacroStabilityCommon/DamMacroStabilityInput.cs
    • -0
    • +50
    ./MacroStabilityInwards/MacroStabilityKernelDataInput.cs
    • -0
    • +327
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -0
    • +39
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperOutput.cs
    • -100
    • +88
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -88
    • +0
    ./MacroStabilityCommon/DamMacroStabilityOutputItem.cs
    • -39
    • +0
    ./MacroStabilityInwards/MacroStabilityInput.cs
  1. … 5 more files in changeset.
Renamed assembler:

- Should operate independently of whatever kernel is involved

Related to Issue [MWDAM-1629]

    • -0
    • +202
    ./Assemblers/Geometry2DSectionAssembler.cs
    • -202
    • +0
    ./Assemblers/DAMMStabGeometry2DSectionAssembler.cs
  1. … 2 more files in changeset.
Fixed typo

Related to Issue [MWDAM-1629]

    • -6
    • +6
    ./Assemblers/FileIdentificationAssembler.cs
    • -3
    • +3
    ./Assemblers/DtoPropertyAttributeMapping.cs
    • -30
    • +30
    ./Assemblers/DtoPropertyAttributeMap.cs
Removed DamMStabAssembler:

- Decoupling the Geometry2DSectionAssembler from the DAMMacroStability kernel. Extracted used XML keywords to a separate file

Related to Issue [MWDAM-1629]

    • -679
    • +0
    ./Assemblers/DamMStabAssembler.cs
    • -23
    • +23
    ./Assemblers/DAMMStabGeometry2DSectionAssembler.cs
    • -0
    • +51
    ./Assemblers/XMLAttributes.cs
  1. … 1 more file in changeset.
Removed DamMacroStabilityCommon.

Related to Issue [MWDAM-1629]

    • -1
    • +0
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -255
    • +0
    ./DamMacroStabilityCommon/MStabXmlDoc.cs
    • -35
    • +0
    ./DamMacroStabilityCommon/Xsd/FileIdentificationDefinition.xsd
    • -270
    • +0
    ./DamMacroStabilityCommon/Xsd/DamMStabInputDefinition.xsd
    • -65
    • +0
    ./DamMacroStabilityCommon/Xsd/DamMStabDocDefinition.xsd
    • -78
    • +0
    ./DamMacroStabilityCommon/CalculationHelper.cs
    • -137
    • +0
    ./DamMacroStabilityCommon/DamMacroStabilityUtils.cs
    • -145
    • +0
    ./DamMacroStabilityCommon/DGSMStabDAMInterface.cs
    • -132
    • +0
    ./DamMacroStabilityCommon/DGSStandardDLLInterface.cs
    • -58
    • +0
    ./DamMacroStabilityCommon/Xsd/ProfileDefinition.xsd
    • -38
    • +0
    ./DamMacroStabilityCommon/MStabXmlDocException.cs
  1. … 2 more files in changeset.
Moved Assemblers upward, as these are used by the Geometry2DTo1DConverter. These components are still used and should not be deleted.

Related to Issue [MWDAM-1629]

    • -0
    • +679
    ./Assemblers/DamMStabAssembler.cs
    • -39
    • +0
    ./DamMacroStabilityCommon/Assemblers/DtoPropertyMapException.cs
    • -679
    • +0
    ./DamMacroStabilityCommon/Assemblers/DamMStabAssembler.cs
    • -0
    • +39
    ./Assemblers/DtoAssemblerException.cs
    • -585
    • +0
    ./DamMacroStabilityCommon/Assemblers/DtoHelperServices.cs
    • -342
    • +0
    ./DamMacroStabilityCommon/Assemblers/DtoPropertyAttributeMap.cs
    • -0
    • +161
    ./Assemblers/SoilProfileAssembler.cs
    • -0
    • +188
    ./Assemblers/DtoDocumentAssembler.cs
    • -0
    • +39
    ./Assemblers/MissingRequiredFieldValueException.cs
    • -48
    • +0
    ./DamMacroStabilityCommon/Assemblers/EmbeddedResourceNotFoundException.cs
    • -0
    • +109
    ./Assemblers/AssemblyExtensions.cs
  1. … 27 more files in changeset.
Moved general components to MacroStabilityCommon:

- These components are still used and should not be deleted

Related to Issue [MWDAM-1629]

    • -0
    • +1
    ./DamMacroStabilityCommon/DamMacroStabilityUtils.cs
    • -0
    • +38
    ./MacroStabilityCommon/MacroStabilityException.cs
    • -0
    • +66
    ./MacroStabilityCommon/DamMacroStabilityInput.cs
    • -66
    • +0
    ./DamMacroStabilityCommon/DamMacroStabilityInput.cs
    • -88
    • +0
    ./DamMacroStabilityCommon/DamMacroStabilityOutputItem.cs
    • -0
    • +60
    ./MacroStabilityCommon/DamMacroStabilityOutput.cs
    • -38
    • +0
    ./DamMacroStabilityCommon/MacroStabilityException.cs
    • -0
    • +88
    ./MacroStabilityCommon/DamMacroStabilityOutputItem.cs
    • -60
    • +0
    ./DamMacroStabilityCommon/DamMacroStabilityOutput.cs
  1. … 2 more files in changeset.
Removed DamMacroStabilityHorizontalBalance:

- Adjusted the KernelWrapperHelper

Related to Issue [MWDAM-1629]

    • -318
    • +0
    ./DamMacroStabilityHorizontalBalance/DamMacroStabilityHorizontalBalanceKernelWrapper.cs
  1. … 4 more files in changeset.
Removed DamMacroStabilityInwards:

- Adjusted the KernelWrapperHelper

Related to Issue [MWDAM-1629]

    • -660
    • +0
    ./DamMacroStabilityInwards/DamMacroStabilityInwardsKernelWrapper.cs
  1. … 4 more files in changeset.
Removed DamMacroStabilityOutwards:

- Adjusted the KernelWrapperHelper

Related to Issue [MWDAM-1629]

    • -357
    • +0
    ./DamMacroStabilityOutwards/DamMacroStabilityOutwardsKernelWrapper.cs
  1. … 4 more files in changeset.
Adapted to comments some more.

Related to Issue [MWDAM-1383]

  1. … 1 more file in changeset.
Moved HeadPl2 within Location from WaternetOptions to DesignScenario. Also removed HeadPl3 and HeadPl4 from Location.

Started fixing failing tests.

Related to Issue [MWDAM-1618]

  1. … 18 more files in changeset.
Moved PolderLevel within Location from WaternetOptions to DesignScenario.

Related to Issue [MWDAM-1618]

    • -2
    • +2
    ./DamPipingBligh/DamPipingBlighKernelWrapper.cs
    • -3
    • +3
    ./DamPipingSellmeijerVnk/DamPipingSellmeijerVnkKernelWrapper.cs
    • -3
    • +3
    ./WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedKernelWrapper.cs
    • -2
    • +2
    ./DamPipingSellmeijer4Forces/DamPipingSellmeijer4ForcesKernelWrapper.cs
  1. … 25 more files in changeset.
Added code (with tests) to improve handling of "wrong" segments. To be able to test this properly, added PipingModelType.Wti2017 to supported models so we can actually define an improper test project. Adding this also helps for MWDAM-1393 and thus MWDAM-1145, Piping part.

Related to Issue [MWDAM-1445]

    • -8
    • +13
    ./WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedKernelWrapper.cs
  1. … 2 more files in changeset.
Fix bug reported by SonarQube

Related to Issue [MWDAM-1514]

    • -2
    • +1
    ./WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedKernelWrapper.cs
Fix bug reported by SonarQube

Related to Issue [MWDAM-1514]

    • -2
    • +1
    ./WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedKernelWrapper.cs
Made RequiredSafetyFactorStabilityInnerSlope, RequiredSafetyFactorStabilityOuterSlope, RequiredSafetyFactorPiping, UpliftCriterionStability and UpliftCriterionPiping required in xsd/DamLocation.xsd

Related to Issue [MWDAM-1537]

    • -4
    • +4
    ./DamPipingBligh/DamPipingBlighKernelWrapper.cs
    • -5
    • +1
    ./DamMacroStabilityOutwards/DamMacroStabilityOutwardsKernelWrapper.cs
    • -4
    • +4
    ./DamPipingSellmeijerVnk/DamPipingSellmeijerVnkKernelWrapper.cs
    • -4
    • +4
    ./DamPipingSellmeijer4Forces/DamPipingSellmeijer4ForcesKernelWrapper.cs
    • -4
    • +4
    ./WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedKernelWrapper.cs
    • -1
    • +1
    ./DamMacroStabilityCommon/MStabXmlDoc.cs
    • -1
    • +1
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -7
    • +3
    ./DamMacroStabilityInwards/DamMacroStabilityInwardsKernelWrapper.cs
  1. … 12 more files in changeset.
Removed all probabilistic parameters named under "Added on 9-7-2019" except for SlopeDampingPiezometricHeightPolderSide (used in PlLinesCreator) and SlopeDampingPiezometricHeightPolderSide (used by Delphi D-GeoStability) as these are used in the engine.

Related to Issue [MWDAM-1527]

    • -2
    • +0
    ./DamMacroStabilityCommon/Xsd/DamMStabInputDefinition.xsd
    • -1
    • +0
    ./DamMacroStabilityCommon/MStabXmlDoc.cs
  1. … 6 more files in changeset.
Removed obsolete parameters from the Engine. Increased version number from 19.1 to 19.2.

Related to Issue [MWDAM-1527]

    • -0
    • +3
    ./DamMacroStabilityCommon/CalculationHelper.cs
    • -2
    • +0
    ./DamMacroStabilityCommon/Xsd/DamMStabInputDefinition.xsd
    • -26
    • +0
    ./DamMacroStabilityCommon/Assemblers/DamMStabAssembler.cs
  1. … 4 more files in changeset.
Implemented DistanceToEntryPoint in design oprion too. Added test to show influence of DistanceToEntryPoint on calculations.

Related to Issue [MWDAM-1361]

    • -1
    • +1
    ./WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedKernelWrapper.cs
  1. … 1 more file in changeset.
Added DistanceToEntryPoint to Location (class and xsd), implemented it in the WtiPipingSellmeijerRevisedKernelWrapper. Added it to the Interface code (both FillDamFromXmlInput and FillXmlInputFromDam) with tests.

Related to Issue [MWDAM-1361]

    • -1
    • +1
    ./WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedKernelWrapper.cs
  1. … 7 more files in changeset.