Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
The waternet creator based on 2D geometry is used instead of the one based on 1D.

Related to Issue [MWDAM-2251]

    • -6
    • +1
    ./MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
    • -6
    • +1
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
Adapted to review: exception is raised when no bottom aquifer present

Related to Issue [MWDAM-2225]

    • -21
    • +33
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 1 more file in changeset.
Added test if surfaceline is fully above bottom of soilprofile2D before combining them

Related to Issue [MWDAM-2132]

    • -1
    • +5
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
  1. … 4 more files in changeset.
Fix SonarCloud issue

Related to Issue [MWDAM-2132]

    • -1
    • +1
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
  1. … 1 more file in changeset.
Fix some SonarCloud issues

Related to Issue [MWDAM-2132]

    • -1
    • +9
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
  1. … 2 more files in changeset.
Implement cut right of geometry in CombineSoilProfile2DWithSurfaceLine()

Test ignored, because Work in Progress

Related to Issue [MWDAM-2132]

    • -1
    • +6
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
  1. … 1 more file in changeset.
Implement extend right of geometry in CombineSoilProfile2DWithSurfaceLine()

Related to Issue [MWDAM-2132]

    • -0
    • +6
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
  1. … 1 more file in changeset.
Implement extend left of geometry in CombineSoilProfile2DWithSurfaceLine()

Related to Issue [MWDAM-2132]

    • -0
    • +5
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
  1. … 1 more file in changeset.
Implement cut left of geometry in CombineSoilProfile2DWithSurfaceLine()

Related to Issue [MWDAM-2132]

    • -0
    • +12
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
  1. … 1 more file in changeset.
Unused PL lines are not added to the headline list of the waternet

Related to Issue [MWDAM-2225]

    • -37
    • +25
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 1 more file in changeset.
Adapted to review:

- Unit tests testing the position of the bottom aquifer and in-between aquifer are done calling DetermineLayerBoundaryPoints instead of CreateWaternetBasedOnPlLines

- Unit test for CreateWaternetBasedOnPlLines with 2D profile improved using more complex 2D profile

Related to Issue [MWDAM-2209]

    • -18
    • +28
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 1 more file in changeset.
Adapted to review

Related to Issue [MWDAM-2201]

    • -0
    • +14
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 4 more files in changeset.
Unused argument removed

Related to Issue [MWDAM-2215]

    • -6
    • +4
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
Added test MacroStabilityCommonHelperTests.GivenSoilGeometryProbabilityWithSoilProfile1DAndSurfaceLineWhenCombiningThenSoilProfile2DIsCreated()

Made most MacroStabilityCommonHelper methods static

Related to Issue [MWDAM-2132]

    • -12
    • +12
    ./MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
    • -22
    • +22
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -21
    • +21
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
  1. … 3 more files in changeset.
Waternet line for PL2 is created only if penetration length > 0

Related to Issue [MWDAM-2215]

    • -2
    • +2
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 1 more file in changeset.
Semi time dependent waternet type implemented.

Related to Issue [MWDAM-2215]

    • -59
    • +80
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 1 more file in changeset.
Prepare for implementation of combining surfaceline with SoilProfile2D

Related to Issue [MWDAM-2132]

    • -2
    • +2
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -2
    • +2
    ./MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
    • -19
    • +62
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
"Full hydrostatic" waternet type implemented for 1D profile

Related to Issue [MWDAM-2211]

    • -23
    • +27
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 1 more file in changeset.
"Full hydrostatic" waternet type implemented

Related to Issue [MWDAM-2211]

    • -7
    • +27
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 1 more file in changeset.
Waternet type "Hydrostatic" implemented including unit tests

Related to Issue [MWDAM-2209]

    • -17
    • +73
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 4 more files in changeset.
Waternet type "Linear" implemented including unit tests

Related to Issue [MWDAM-2201]

    • -12
    • +30
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
    • -1
    • +3
    ./MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
    • -1
    • +3
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
  1. … 1 more file in changeset.
Issues in sonar cloud solved

Related to Issue [MWDAM-2154]

    • -9
    • +9
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 3 more files in changeset.
Issues in sonar cloud solved

Related to Issue [MWDAM-2154]

    • -21
    • +21
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 3 more files in changeset.
Issues in sonar cloud solved

Related to Issue [MWDAM-2154]

    • -45
    • +56
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 2 more files in changeset.
Expected results of the tests updated with the new calculated results due to improvement on waternet

Related to Issue [MWDAM-2154]

    • -7
    • +6
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
  1. … 6 more files in changeset.
Waternet improved by:

- assigning PL4 to all in-betweens aquifer clusters and to the complete cluster

- assigning PL1 to a waternet line which is the bottom of the soil layers “in which the phreatic plane lies”

- removing unnecessary points from the waternet lines

Related to Issue [MWDAM-2154]

    • -53
    • +337
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 3 more files in changeset.
Cleanup and reformat

Related to Issue [MWDAM-2132]

    • -2
    • +6
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -16
    • +16
    ./WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedInput.cs
    • -1
    • +1
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -1
    • +0
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
    • -14
    • +15
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 15 more files in changeset.
Adapted to review: class name improved

Related to Issue [MWDAM-2190]

    • -2
    • +2
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
    • -1
    • +1
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -1
    • +1
    ./MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
  1. … 1 more file in changeset.
Case of aquifer layer with a vertical part is now correctly handled.

Unit tests updated with the new point of the waternet line.

Related to Issue [MWDAM-2190]

    • -15
    • +45
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 1 more file in changeset.
Implement helper method ExtendGeometryLeft

Related to Issue [MWDAM-2132]

    • -0
    • +1
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
  1. … 8 more files in changeset.