Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Use original soilProfile1D for PL1 and soilProfile1D at DikeToeAtPolder for other PL lines.

........

Related to Issue [MWDAM-2623]

    • -5
    • +9
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
    • -3
    • +1
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
Adapted to review: synchronisation of the points called as last method

Related to Issue [MWDAM-2517]

    • -1
    • +1
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
Adapted to review comments

Related to Issue [MWDAM-2258]

    • -0
    • +1
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
  1. … 6 more files in changeset.
Convert soilProfile1D to soilProfile2D for Standard and SemiTimeDependent in CreateWaternetLineForPhreaticLine.

Related to Issue [MWDAM-2623]

    • -10
    • +13
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 1 more file in changeset.
PL1 corrected if contains upwards vertical part

Related to Issue [MWDAM-2517]

    • -0
    • +1
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
Corrected DetermineGridsFromSettings and added unit tests.

Related to Issue [MWDAM-2600]

    • -4
    • +4
    ./MacroStabilityInwards/UpliftVanGridCreator.cs
  1. … 1 more file in changeset.
Improve adapt geometry

- Use always shoulder embankment material

- Always use the original SoilProile2D to combine with the new adapted surfaceline

Related to Issue [MWDAM-2472]

Related to Issue [MWDAM-2469]

  1. … 4 more files in changeset.
Code refactored according to sonarcloud issues

Related to Issue [MWDAM-2573]

    • -1
    • +1
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
Code refactored according to sonarcloud issues

Related to Issue [MWDAM-2573]

    • -9
    • +5
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -1
    • +1
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
Fix unit tests

Related to Issue [MWDAM-2469]

    • -3
    • +3
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
  1. … 1 more file in changeset.
Fixed return value for design result when failing.

Added 2 tests for unsuccessful adapt geometry calculation

Related to Issue [MWDAM-2472]

Related to Issue [MWDAM-2469]

    • -24
    • +29
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
  1. … 1 more file in changeset.
TrafficLoadDegreeOfConsolidation is connected to the Mac kernel

Related to Issue [MWDAM-2573]

    • -0
    • +19
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -4
    • +25
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
  1. … 4 more files in changeset.
Implement shoulder embankment material for adapt first shoulder adaption then shoulder adaption

Related to Issue [MWDAM-2472]

    • -1
    • +1
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -1
    • +1
    ./MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
  1. … 4 more files in changeset.
Adapted to review by using a tolerance when comparing doubles

Related to Issue [MWDAM-2517]

    • -2
    • +2
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
Improved validation.

Related to Issue [MWDAM-2400]

    • -3
    • +3
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
Code refactored to solve issue detected by sonarcloud

Related to Issue [MWDAM-2581]

    • -1
    • +1
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
Code refactored to solve issue detected by sonarcloud

Related to Issue [MWDAM-2581]

UpliftVan with BeeSwarm is calculated using the Thorough setting of DStability

Related to Issue [MWDAM-2390]

    • -3
    • +3
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
Adapted to review: all points are handled in the method

Related to Issue [MWDAM-2517]

    • -10
    • +12
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
Code refactored to solve issues detected by sonarcloud

Related to Issue [MWDAM-2581]

  1. … 1 more file in changeset.
Add a validation on the presence of isolated in-between aquifers

Related to Issue [MWDAM-2581]

  1. … 7 more files in changeset.
Validations of the soil profile performed in class PlLinesCreator.cs and PlLinesToWaternetConverter.cs are moved to a new class SoilProfileValidator and called only by the PlLinesCreator.

Related to Issue [MWDAM-2164]

    • -41
    • +7
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 10 more files in changeset.
If statement removed because always true

Related to Issue [MWDAM-2517]

    • -9
    • +6
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
Reference line of the waternet containing upwards vertical part is corrected (by shifting the highest point by 1cm) in order to be correctly displayed in D-Stability

Related to Issue [MWDAM-2517]

    • -0
    • +26
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 1 more file in changeset.
Added (rudimentary) tests for the geometry exporter.

Related to Issue [MWDAM-2446]

    • -0
    • +10
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
  1. … 7 more files in changeset.
The determination of 2D aquifer layers in PlLinesToWaternetConverter is extracted to a new class SoilProfile2DHelper in order to be used by the waternet creator validator

Related to Issue [MWDAM-2525]

    • -207
    • +8
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
    • -0
    • +232
    ./Common/SoilProfile2DHelper.cs
  1. … 2 more files in changeset.
Refactoring: comments improved + unused method DetermineStabilityUplift removed

Related to Issue [MWDAM-2226]

    • -1
    • +0
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
  1. … 3 more files in changeset.
Removed liquefaction, implemented All for stability (inwards and outwards). Re-instated the stability test based on All.

Related to Issue [MWDAM-1979]

    • -1
    • +3
    ./MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
    • -1
    • +3
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
  1. … 4 more files in changeset.
Expected path of the fictive Uplift-Van results added

Related to Issue [MWDAM-2439]

    • -0
    • +1
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
Sonar cloud issues solved

Related to Issue [MWDAM-2369]

    • -9
    • +11
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs