Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Code improved according to sonarcloud issue

Related to Issue [MWDAM-2691]

Waternet line associated to an empty PL line (no points) is not created

Related to Issue [MWDAM-2733]

    • -26
    • +11
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 1 more file in changeset.
Test is corrected and WIP is removed

Related to Issue [MWDAM-2462]

  1. … 1 more file in changeset.
Reduction of PL3/PL4 implemented when the aquifer intersects the surface line (i.e. the ditch)

Related to Issue [MWDAM-2691]

  1. … 4 more files in changeset.
Fix SonarCloud issues

Related to Issue [MWDAM-2548]

    • -1
    • +1
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
  1. … 1 more file in changeset.
Cognitive complexity is reduced

Related to Issue [MWDAM-2716]

Removed Geometry2DSectionAssembler.cs

Related to Issue [MWDAM-2160]

    • -96
    • +0
    ./Assemblers/Geometry2DSectionAssembler.cs
  1. … 5 more files in changeset.
Remove code for reading sti files.

Related to Issue [MWDAM-2160]

    • -1
    • +0
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
  1. … 25 more files in changeset.
Case without in between aquifers improved

Related to Issue [MWDAM-2716]

In-between aquifers situated at the left side of DikeToeAtPolder are not taken into account.

Unit tets added.

Related to Issue [MWDAM-2720]

    • -4
    • +4
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
    • -9
    • +20
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 2 more files in changeset.
Sonarcloud issues fixed

Related to Issue [MWDAM-2716]

Waternet lines for in-between aquifer cluster with vertical part is improved by connecting the points to create a unique line

Related to Issue [MWDAM-2716]

  1. … 1 more file in changeset.
Fix unit test

Related to Issue [MWDAM-2474]

    • -1
    • +1
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
Reformat and Cleanup

Related to Issue [MWDAM-2474]

    • -51
    • +55
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
Fixed using the leading calculation (Uplift or Bishop) when designing

Related to Issue [MWDAM-2474]

    • -1
    • +3
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
    • -7
    • +22
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
  1. … 1 more file in changeset.
Determination of the top and bottom aquifers improved in case of cluster.

Unit tests added.

Related to Issue [MWDAM-2716]

  1. … 1 more file in changeset.
Adapted to review: refactored

Related to Issue [MWDAM-2474]

    • -32
    • +31
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
Determination of the boundaries of the in-between aquifers improved to deal with in-between aquifers cutting the not vertical geometry limit.

Unit test added.

Related to Issue [MWDAM-2716]

    • -20
    • +17
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
    • -83
    • +129
    ./Common/SoilProfile2DHelper.cs
  1. … 4 more files in changeset.
Reimplemented remove shift, removed from xml-comments.

Related to Issue [MWDAM-2677]

    • -2
    • +0
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
Adapted to review: comment added to explain why the inner loops are removed

Related to Issue [MWDAM-2704]

Reimplemented remove shift.

Related to Issue [MWDAM-2677]

    • -4
    • +4
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
    • -1
    • +1
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -1
    • +1
    ./MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
  1. … 5 more files in changeset.
Added Su Table to Dam Engine TD. Update mapping of Soil.

Related to Issue [MWDAM-2711]

  1. … 1 more file in changeset.
Reverted remove shift until UI is OK.

Related to Issue [MWDAM-2677]

    • -4
    • +4
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
    • -1
    • +1
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -1
    • +1
    ./MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
  1. … 7 more files in changeset.
Removed using shift as that should be a task in the UI, not in the engine.

Related to Issue [MWDAM-2677]

    • -1
    • +1
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -1
    • +1
    ./MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
    • -4
    • +4
    ./MacroStabilityCommon/MacroStabilityCommonHelper.cs
  1. … 6 more files in changeset.
Code improved and header in public method added

Related to Issue [MWDAM-2704]

  1. … 1 more file in changeset.
For the validation of the soil profile, an aquifer with aquitard inner loop is valid

Related to Issue [MWDAM-2704]

  1. … 2 more files in changeset.
Add design result message to output when design fails

Related to Issue [MWDAM-2474]

    • -0
    • +12
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
  1. … 1 more file in changeset.
Fix handling when design is unsuccessful

Related to Issue [MWDAM-2474]

    • -2
    • +11
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
  1. … 3 more files in changeset.
Connect DamEngine with Mac Kernel.

Related to Issue [MWDAM-2575]

  1. … 2 more files in changeset.
Fix Adapt geometry optimized slope and shoulder adjustment

Related to Issue [MWDAM-2474]

    • -0
    • +6
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -0
    • +5
    ./MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
  1. … 3 more files in changeset.