Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Add a validation on the presence of isolated in-between aquifers

Related to Issue [MWDAM-2581]

  1. … 7 more files in changeset.
Validation of the Dike embankment material is incorrect (material needed only for 1D profile, not 2D)

Related to Issue [MWDAM-2164]

  1. … 1 more file in changeset.
Check on the presence of aquifers/aquitards for 1D profile is done at cross section DikeTopAtPolder (instead of DikeToeAtPolder) to include the layers in the dike body.

Related to Issue [MWDAM-2164]

Validations of the soil profile performed in class PlLinesCreator.cs and PlLinesToWaternetConverter.cs are moved to a new class SoilProfileValidator and called only by the PlLinesCreator.

Related to Issue [MWDAM-2164]

    • -0
    • +186
    ./SoilProfileValidator.cs
  1. … 13 more files in changeset.
Refactoring: comments improved + unused method DetermineStabilityUplift removed

Related to Issue [MWDAM-2226]

  1. … 5 more files in changeset.
Redundant code removed

Related to Issue [MWDAM-2380]

The creation of the infiltration layer is removed because not needed anymore in Macrostability

Related to Issue [MWDAM-2378]

  1. … 2 more files in changeset.
Determination of the 1D profile at given X from a 2D profile is improved to handle the case where a vertical layer separation is present

Related to Issue [MWDAM-2380]

  1. … 5 more files in changeset.
PL line creator improved by using the soil profile at DikeToeAtPolder for the determination of the relevant aquifers.

Unit tests adapted to get the expected result.

Related to Issue [MWDAM-2363]

  1. … 2 more files in changeset.
Out-commented tests are fixed and run again.

One test is set to Ignore because problem will be solved in other issue.

Related to Issue [MWDAM-2327]

  1. … 4 more files in changeset.
Waternet type "Hydrostatic" implemented including unit tests

Related to Issue [MWDAM-2209]

  1. … 4 more files in changeset.
Reformat and cleanup (copyright to 2024)

Related to Issue [MWDAM-2007]

  1. … 318 more files in changeset.
Corrected some of the tests, now only two fail again,

Related to Issue [MWDAM-1948]

  1. … 2 more files in changeset.
Removed some static methods.

Related to Issue [MWDAM-1889]

  1. … 13 more files in changeset.
Reversed accidental full commit.

Related to Issue [MWDAM-1889]

  1. … 26 more files in changeset.
Made sure that file is copied as it is supposed to be.

Related to Issue [MWDAM-1889]

  1. … 26 more files in changeset.
Use string interpolation

Related to Issue [MWDAM-1878]

  1. … 28 more files in changeset.
Convert to file-scoped namespace

Related to Issue [MWDAM-1878]

    • -158
    • +157
    ./SensorPlLineCreatorBase.cs
    • -76
    • +75
    ./SensorPlLine3Or4CreatorBase.cs
    • -13
    • +12
    ./SensorPlLineCreatorException.cs
  1. … 310 more files in changeset.
Remove trailing comma's

Related to Issue [MWDAM-1877]

  1. … 10 more files in changeset.
Remove some code smells

Related to Issue [MWDAM-1877]

  1. … 3 more files in changeset.
Reformat and cleanup

Related to Issue [MWDAM-1874]

    • -34
    • +36
    ./SensorPlLine3Or4CreatorBase.cs
  1. … 388 more files in changeset.
Adapted to review comments.

Related to Issue [MWDAM-1852]

Run clean-up to update file headers

Related to Issue [MWDAM-1854]

  1. … 322 more files in changeset.
Use Any instead of Count >0

Related to Issue [MWDAM-1856]

  1. … 1 more file in changeset.
Remove this formatting call and simply use the input string

Related to Issue [MWDAM-1856]

  1. … 1 more file in changeset.
Remove useless assignment

Related to Issue [MWDAM-1856]

Use count property

Related to Issue [MWDAM-1856]

Remove unused private methods

Related to Issue [MWDAM-1856]

  1. … 1 more file in changeset.
Remove the unnecessary Boolean literal(s)

Related to Issue [MWDAM-1856]

  1. … 7 more files in changeset.
Solved the bugs in SonarQube. Note that 2 (of the 10) reported bugs were actually false negatives as assessed by me and reviewed by Tom who closed these two bugs.

Related to Issue [MWDAM-1852]

  1. … 4 more files in changeset.