DAM / DamEngine / trunk / src / Deltares.DamEngine.Calculators

PlLinesCreator

Checkout Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 1
Total Committers: 6
Last Commit: 05 Dec
Commits this week: 1
Total Lines of Code (LoC): 3,293
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 17 Jan
5:13 pm

Virginie Trompille

Add a validation on the presence of isolated in-between aquifers

Related to Issue [MWDAM-2581]

Options
    • -0
    • +20
    ./SoilProfileValidator.cs
  2. … 7 more files in changeset.
9:30 am

Virginie Trompille

Validation of the Dike embankment material is incorrect (material needed only for 1D profile, not 2D)

Related to Issue [MWDAM-2164]

Options
    • -3
    • +3
    ./SoilProfileValidator.cs
  2. … 1 more file in changeset.
Thursday 16 Jan
4:58 pm

Virginie Trompille

Check on the presence of aquifers/aquitards for 1D profile is done at cross section DikeTopAtPolder (instead of DikeToeAtPolder) to include the layers in the dike body.

Related to Issue [MWDAM-2164]

Options
    • -1
    • +1
    ./SoilProfileValidator.cs
11:52 am

Virginie Trompille

Validations of the soil profile performed in class PlLinesCreator.cs and PlLinesToWaternetConverter.cs are moved to a new class SoilProfileValidator and called only by the PlLinesCreator.

Related to Issue [MWDAM-2164]

Options
    • -48
    • +22
    ./PlLinesCreator.cs
    • -0
    • +186
    ./SoilProfileValidator.cs
  3. … 13 more files in changeset.
Friday 10 Jan
2:40 pm

Virginie Trompille

Refactoring: comments improved + unused method DetermineStabilityUplift removed

Related to Issue [MWDAM-2226]

Options
    • -1
    • +0
    ./PlLinesCreator.cs
  2. … 5 more files in changeset.
Wednesday 18 Dec 2024
3:29 pm

Virginie Trompille

Redundant code removed

Related to Issue [MWDAM-2380]

Options
    • -5
    • +0
    ./PlLinesCreator.cs
Friday 13 Dec 2024
9:01 pm

Virginie Trompille

The creation of the infiltration layer is removed because not needed anymore in Macrostability

Related to Issue [MWDAM-2378]

Options
    • -20
    • +0
    ./PlLinesCreator.cs
  2. … 2 more files in changeset.
9:19 am

Virginie Trompille

Determination of the 1D profile at given X from a 2D profile is improved to handle the case where a vertical layer separation is present

Related to Issue [MWDAM-2380]

Options
    • -12
    • +5
    ./PlLinesCreator.cs
  2. … 5 more files in changeset.
Wednesday 11 Dec 2024
5:07 pm

Virginie Trompille

PL line creator improved by using the soil profile at DikeToeAtPolder for the determination of the relevant aquifers.

Unit tests adapted to get the expected result.

Related to Issue [MWDAM-2363]

Options
    • -17
    • +30
    ./PlLinesCreator.cs
  2. … 2 more files in changeset.
Tuesday 10 Dec 2024
2:01 pm

Virginie Trompille

Out-commented tests are fixed and run again.

One test is set to Ignore because problem will be solved in other issue.

Related to Issue [MWDAM-2327]

Options
    • -5
    • +5
    ./PlLinesCreator.cs
  2. … 4 more files in changeset.
Thursday 31 Oct 2024
6:04 pm

Virginie Trompille

Waternet type "Hydrostatic" implemented including unit tests

Related to Issue [MWDAM-2209]

Options
    • -1
    • +1
    ./PlLinesCreator.cs
  2. … 4 more files in changeset.
Wednesday 31 Jul 2024
10:04 am

Tom The

Reformat and cleanup (copyright to 2024)

Related to Issue [MWDAM-2007]

Options
    • -1
    • +1
    ./PLLineConstructor.cs
    • -1
    • +1
    ./SensorPlLineCreatorException.cs
    • -1
    • +1
    ./SensorPlLine3Or4CreatorBase.cs
    • -1
    • +1
    ./SensorPlLine4Creator.cs
    • -1
    • +1
    ./PlLinesCreatorException.cs
    • -1
    • +1
    ./SensorPlLine3Creator.cs
    • -1
    • +1
    ./SensorPlLine2Creator.cs
    • -1
    • +1
    ./SensorPlLineCreator.cs
    • -3
    • +3
    ./SensorPlLine1Creator.cs
    • -1
    • +1
    ./IPlLineCreator.cs
    • -1
    • +1
    ./SensorPlLineCreatorBase.cs
    • -2
    • +2
    ./PlLinesCreator.cs
  13. … 318 more files in changeset.
Monday 20 Nov 2023
12:48 pm

John Bokma

Corrected some of the tests, now only two fail again,

Related to Issue [MWDAM-1948]

Options
    • -4
    • +4
    ./PlLinesCreator.cs
  2. … 2 more files in changeset.
Monday 11 Sep 2023
3:23 pm

John Bokma

Removed some static methods.

Related to Issue [MWDAM-1889]

Options
    • -5
    • +5
    ./PlLinesCreator.cs
  2. … 13 more files in changeset.
Wednesday 28 Jun 2023
5:31 pm

John Bokma

Reversed accidental full commit.

Related to Issue [MWDAM-1889]

Options
    • -5
    • +5
    ./PlLinesCreator.cs
  2. … 26 more files in changeset.
5:28 pm

John Bokma

Made sure that file is copied as it is supposed to be.

Related to Issue [MWDAM-1889]

Options
    • -5
    • +5
    ./PlLinesCreator.cs
  2. … 26 more files in changeset.
Thursday 13 Apr 2023
10:41 am

Walter Austmann

Use string interpolation

Related to Issue [MWDAM-1878]

Options
    • -2
    • +2
    ./SensorPlLine1Creator.cs
    • -11
    • +8
    ./PlLinesCreator.cs
  3. … 28 more files in changeset.
10:35 am

Walter Austmann

Convert to file-scoped namespace

Related to Issue [MWDAM-1878]

Options
    • -5
    • +4
    ./IPlLineCreator.cs
    • -101
    • +100
    ./SensorPlLineCreator.cs
    • -158
    • +157
    ./SensorPlLineCreatorBase.cs
    • -76
    • +75
    ./SensorPlLine3Or4CreatorBase.cs
    • -13
    • +12
    ./SensorPlLineCreatorException.cs
    • -33
    • +32
    ./SensorPlLine4Creator.cs
    • -277
    • +276
    ./SensorPlLine1Creator.cs
    • -44
    • +43
    ./PLLineConstructor.cs
    • -38
    • +37
    ./SensorPlLine3Creator.cs
    • -18
    • +17
    ./PlLinesCreatorException.cs
    • -8
    • +7
    ./SensorPlLine2Creator.cs
    • -1383
    • +1382
    ./PlLinesCreator.cs
  13. … 310 more files in changeset.
Wednesday 12 Apr 2023
10:03 am

Walter Austmann

Remove trailing comma's

Related to Issue [MWDAM-1877]

Options
    • -1
    • +1
    ./SensorPlLineCreator.cs
  2. … 10 more files in changeset.
Tuesday 11 Apr 2023
3:46 pm

Walter Austmann

Remove some code smells

Related to Issue [MWDAM-1877]

Options
    • -7
    • +5
    ./PlLinesCreator.cs
  2. … 3 more files in changeset.
Thursday 06 Apr 2023
2:47 pm

Tom The

Reformat and cleanup

Related to Issue [MWDAM-1874]

Options
    • -168
    • +208
    ./SensorPlLine1Creator.cs
    • -1
    • +1
    ./SensorPlLineCreatorException.cs
    • -34
    • +36
    ./SensorPlLine3Or4CreatorBase.cs
    • -4
    • +3
    ./PlLinesCreatorException.cs
    • -382
    • +443
    ./PlLinesCreator.cs
    • -33
    • +39
    ./SensorPlLineCreator.cs
    • -43
    • +53
    ./SensorPlLineCreatorBase.cs
    • -3
    • +11
    ./PLLineConstructor.cs
    • -5
    • +4
    ./SensorPlLine4Creator.cs
    • -3
    • +1
    ./SensorPlLine2Creator.cs
    • -4
    • +4
    ./SensorPlLine3Creator.cs
  12. … 388 more files in changeset.
Thursday 15 Dec 2022
1:46 pm

John Bokma

Adapted to review comments.

Related to Issue [MWDAM-1852]

Options
    • -11
    • +13
    ./PlLinesCreator.cs
Wednesday 14 Dec 2022
11:15 am

Walter Austmann

Run clean-up to update file headers

Related to Issue [MWDAM-1854]

Options
    • -5
    • +5
    ./SensorPlLineCreator.cs
    • -5
    • +5
    ./PLLineConstructor.cs
    • -5
    • +5
    ./SensorPlLine1Creator.cs
    • -5
    • +5
    ./PlLinesCreatorException.cs
    • -5
    • +5
    ./SensorPlLine2Creator.cs
    • -5
    • +5
    ./SensorPlLine4Creator.cs
    • -5
    • +5
    ./IPlLineCreator.cs
    • -5
    • +5
    ./SensorPlLineCreatorException.cs
    • -5
    • +5
    ./PlLinesCreator.cs
    • -5
    • +5
    ./SensorPlLineCreatorBase.cs
    • -5
    • +5
    ./SensorPlLine3Creator.cs
    • -5
    • +5
    ./SensorPlLine3Or4CreatorBase.cs
  13. … 322 more files in changeset.
Monday 12 Dec 2022
9:03 am

Walter Austmann

Use Any instead of Count >0

Related to Issue [MWDAM-1856]

Options
    • -1
    • +1
    ./PlLinesCreator.cs
  2. … 1 more file in changeset.
Friday 09 Dec 2022
11:28 am

Walter Austmann

Remove this formatting call and simply use the input string

Related to Issue [MWDAM-1856]

Options
    • -1
    • +1
    ./PlLinesCreator.cs
  2. … 1 more file in changeset.
10:25 am

Walter Austmann

Remove useless assignment

Related to Issue [MWDAM-1856]

Options
    • -2
    • +1
    ./PlLinesCreator.cs
9:11 am

Walter Austmann

Use count property

Related to Issue [MWDAM-1856]

Options
    • -2
    • +2
    ./SensorPlLineCreatorBase.cs
Thursday 08 Dec 2022
4:52 pm

Walter Austmann

Remove unused private methods

Related to Issue [MWDAM-1856]

Options
    • -19
    • +0
    ./SensorPlLine1Creator.cs
  2. … 1 more file in changeset.
4:45 pm

Walter Austmann

Remove the unnecessary Boolean literal(s)

Related to Issue [MWDAM-1856]

Options
    • -2
    • +2
    ./PlLinesCreator.cs
  2. … 7 more files in changeset.
2:45 pm

John Bokma

Solved the bugs in SonarQube. Note that 2 (of the 10) reported bugs were actually false negatives as assessed by me and reviewed by Tom who closed these two bugs.

Related to Issue [MWDAM-1852]

Options
    • -0
    • +1754
    ./PlLinesCreator.cs
  2. … 4 more files in changeset.