Deltares.DamEngine.Calculators

Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Added skeletons for FillEngineFromMacroStabilityWrapperInput, FillEngineFromMacroStabilityWrapperOutput, FillMacroStabilityWrapperInputFromEngine, FillMacroStabilityWrapperOutputFromEngine to replace wti serialization which is now removed. Started with adaptation of the kernelwrapper to no longer use wti-kernel but the full macro stability kernel via the C# wrapper (Issue [MWDAM-1627]). This latest issue can only be finished when all depending issues to actually fill in the data in the provided skeletons (and their belonging tests) are handled.

Made some tests WiP to reflect their proper status.

Removed remaining DAMMacroStability(xxx) files as these are now really no longer required.

Related to Issue [MWDAM-1623]

    • -30
    • +51
    ./Deltares.DamEngine.Calculators.csproj
  1. … 4 more files in changeset.
Renamed assembler:

- Should operate independently of whatever kernel is involved

Related to Issue [MWDAM-1629]

    • -0
    • +202
    ./KernelWrappers/Assemblers/Geometry2DSectionAssembler.cs
    • -202
    • +0
    ./KernelWrappers/Assemblers/DAMMStabGeometry2DSectionAssembler.cs
    • -1
    • +1
    ./Deltares.DamEngine.Calculators.csproj
Fixed typo

Related to Issue [MWDAM-1629]

    • -30
    • +30
    ./KernelWrappers/Assemblers/DtoPropertyAttributeMap.cs
Removed DamMStabAssembler:

- Decoupling the Geometry2DSectionAssembler from the DAMMacroStability kernel. Extracted used XML keywords to a separate file

Related to Issue [MWDAM-1629]

    • -23
    • +23
    ./KernelWrappers/Assemblers/DAMMStabGeometry2DSectionAssembler.cs
    • -1
    • +1
    ./Deltares.DamEngine.Calculators.csproj
    • -0
    • +51
    ./KernelWrappers/Assemblers/XMLAttributes.cs
Removed DamMacroStabilityCommon.

Related to Issue [MWDAM-1629]

    • -28
    • +1
    ./Deltares.DamEngine.Calculators.csproj
  1. … 1 more file in changeset.
Moved Assemblers upward, as these are used by the Geometry2DTo1DConverter. These components are still used and should not be deleted.

Related to Issue [MWDAM-1629]

    • -20
    • +22
    ./Deltares.DamEngine.Calculators.csproj
    • -0
    • +39
    ./KernelWrappers/Assemblers/MissingRequiredFieldValueException.cs
  1. … 27 more files in changeset.
Moved general components to MacroStabilityCommon:

- These components are still used and should not be deleted

Related to Issue [MWDAM-1629]

    • -4
    • +4
    ./Deltares.DamEngine.Calculators.csproj
  1. … 1 more file in changeset.
Removed DamMacroStabilityHorizontalBalance:

- Adjusted the KernelWrapperHelper

Related to Issue [MWDAM-1629]

    • -1
    • +0
    ./Deltares.DamEngine.Calculators.csproj
  1. … 3 more files in changeset.
Removed DamMacroStabilityInwards:

- Adjusted the KernelWrapperHelper

Related to Issue [MWDAM-1629]

    • -1
    • +0
    ./Deltares.DamEngine.Calculators.csproj
  1. … 3 more files in changeset.
Removed DamMacroStabilityOutwards:

- Adjusted the KernelWrapperHelper

Related to Issue [MWDAM-1629]

    • -1
    • +0
    ./Deltares.DamEngine.Calculators.csproj
    • -12
    • +0
    ./KernelWrappers/Common/KernelWrapperHelper.cs
  1. … 3 more files in changeset.
Adapted to comments some more.

Related to Issue [MWDAM-1383]

  1. … 1 more file in changeset.
Moved HeadPl2 within Location from WaternetOptions to DesignScenario. Also removed HeadPl3 and HeadPl4 from Location.

Started fixing failing tests.

Related to Issue [MWDAM-1618]

    • -6
    • +6
    ./KernelWrappers/Common/PlLinesHelper.cs
  1. … 17 more files in changeset.
Fixed failing unit test

Related to Issue [MWDAM-1617]

    • too large
    ./PlLinesCreator/PlLinesCreator.cs
  1. … 2 more files in changeset.
Moved PolderLevel within Location from WaternetOptions to DesignScenario.

Related to Issue [MWDAM-1618]

    • -2
    • +2
    ./KernelWrappers/Common/PlLinesHelper.cs
    • -1
    • +2
    ./DikesDesign/SurfaceLineShoulderAdapter.cs
    • -2
    • +2
    ./DikesDesign/DesignCalculatorCombinedSlopeAndShoulderAdaption.cs
    • -1
    • +2
    ./DikesDesign/SurfaceLineHeightAdapter.cs
    • -2
    • +2
    ./DikesDesign/DesignCalculatorFirstSlopeAdaptionThenShoulderAdaption.cs
    • -2
    • +3
    ./DikesDesign/SurfaceLineSlopeAdapter.cs
    • -1
    • +1
    ./DikesDesign/DesignCalculatorShoulderPerPoint.cs
  1. … 17 more files in changeset.
Fixed problem 1 as stated by PO in issue, just throw error when water level (high/low) at riverside is below dike toe. Added tests for this.

Related to Issue [MWDAM-1345]

    • too large
    ./PlLinesCreator/PlLinesCreator.cs
    • -2
    • +2
    ./PlLinesCreator/SensorPlLine1Creator.cs
  1. … 3 more files in changeset.
I improved some code (code was correct, but prevent SonarQube message and improved exception testing in the tests)

Related to Issue [MWDAM-1445]

    • -2
    • +0
    ./DikesOperational/OperationalCalculator.cs
  1. … 2 more files in changeset.
Added code (with tests) to improve handling of "wrong" segments. To be able to test this properly, added PipingModelType.Wti2017 to supported models so we can actually define an improper test project. Adding this also helps for MWDAM-1393 and thus MWDAM-1145, Piping part.

Related to Issue [MWDAM-1445]

    • -18
    • +53
    ./DikesOperational/OperationalCalculator.cs
  1. … 1 more file in changeset.
Fix bug reported by SonarQube

Related to Issue [MWDAM-1513]

    • -13
    • +1
    ./DikesOperational/OperationalCalculator.cs
Fix bug reported by SonarQube

Related to Issue [MWDAM-1514]

Fix bug reported by SonarQube

Related to Issue [MWDAM-1514]

Typos fixed and improved formatting

Related to Issue [MWDAM-1554]

    • -12
    • +11
    ./DikesDesign/DesignCalculator.cs
Re-instated deep copy and reset of surface line in PerformDesignCalculation to ensure that correct surface line is used for each individual design step in case of Piping as well as in Stability.

Related to Issue [MWDAM-1554]

    • -21
    • +34
    ./DikesDesign/DesignCalculator.cs
Fixed the issue by taking the adaption of the surface line forward to before kernel Prepare statement. Added tests for it.

Related to Issue [MWDAM-1554]

    • -78
    • +88
    ./DikesDesign/DesignCalculator.cs
  1. … 4 more files in changeset.
Improved naming of functions for PL3 and PL4

Related to Issue [MWDAM-1555]

    • too large
    ./PlLinesCreator/PlLinesCreator.cs
Whilst investigating this option, came across typo and 2 thing that could easily be fixed when looking at the sonarqube results. So did this whilst waiting for Irene to return her verdict about this issue.

Related to Issue [MWDAM-1554]

    • too large
    ./PlLinesCreator/PlLinesCreator.cs
  1. … 2 more files in changeset.
Made RequiredSafetyFactorStabilityInnerSlope, RequiredSafetyFactorStabilityOuterSlope, RequiredSafetyFactorPiping, UpliftCriterionStability and UpliftCriterionPiping required in xsd/DamLocation.xsd

Related to Issue [MWDAM-1537]

  1. … 8 more files in changeset.
Made PlLineOffsetBelowDikeToeAtPolder, PlLineOffsetBelowDikeTopAtPolder, PlLineOffsetBelowDikeTopAtRiver and PlLineOffsetBelowShoulderBaseInside required in xsd/DamLocation.xsd

Related to Issue [MWDAM-1537]

  1. … 6 more files in changeset.
Removed all probabilistic parameters named under "Added on 9-7-2019" except for SlopeDampingPiezometricHeightPolderSide (used in PlLinesCreator) and SlopeDampingPiezometricHeightPolderSide (used by Delphi D-GeoStability) as these are used in the engine.

Related to Issue [MWDAM-1527]

  1. … 6 more files in changeset.
Removed obsolete parameters from the Engine. Increased version number from 19.1 to 19.2.

Related to Issue [MWDAM-1527]

  1. … 4 more files in changeset.
Implemented DistanceToEntryPoint in design oprion too. Added test to show influence of DistanceToEntryPoint on calculations.

Related to Issue [MWDAM-1361]

  1. … 1 more file in changeset.