Deltares.DamEngine.Calculators

Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Solved the vulnerability and some code smwlls as reported by SonarQube.

Related to Issue [MWDAM-1852]

    • -64
    • +101
    ./DikesDesign/DesignCalculator.cs
  1. … 1 more file in changeset.
Use Any instead of Count >0

Related to Issue [MWDAM-1856]

Remove this formatting call and simply use the input string

Related to Issue [MWDAM-1856]

    • -1
    • +1
    ./Uplift/UpliftLocationDeterminator.cs
Remove useless assignment

Related to Issue [MWDAM-1856]

Use count property

Related to Issue [MWDAM-1856]

    • -2
    • +2
    ./PlLinesCreator/SensorPlLineCreatorBase.cs
Remove unnecessary cast

Related to Issue [MWDAM-1856]

    • -35
    • +29
    ./KernelWrappers/Assemblers/DtoPropertyAttributeMap.cs
Rename parameters to match base class or interface declaration

Related to Issue [MWDAM-1856]

Remove redundant jump

Related to Issue [MWDAM-1856]

Remove unused private method in release mode

Related to Issue [MWDAM-1856]

Remove unused private methods

Related to Issue [MWDAM-1856]

    • -19
    • +0
    ./PlLinesCreator/SensorPlLine1Creator.cs
  1. … 1 more file in changeset.
Remove the unnecessary Boolean literal(s)

Related to Issue [MWDAM-1856]

    • -1
    • +1
    ./Uplift/UpliftLocationDeterminator.cs
  1. … 6 more files in changeset.
Remove unused directives

Related to Issue [MWDAM-1856]

    • -1
    • +0
    ./DikesDesign/SurfaceLineHeightAdapter.cs
    • -1
    • +0
    ./Uplift/UpliftLocationDeterminator.cs
  1. … 19 more files in changeset.
Create UpliftSituation for output parameter

Related to Issue [MWDAM-1856]

    • -14
    • +21
    ./KernelWrappers/Common/PlLinesHelper.cs
Use getters and setters for properties

Related to Issue [MWDAM-1856]

    • -3
    • +3
    ./KernelWrappers/Common/DamKernelInput.cs
  1. … 5 more files in changeset.
Solved the bugs in SonarQube. Note that 2 (of the 10) reported bugs were actually false negatives as assessed by me and reviewed by Tom who closed these two bugs.

Related to Issue [MWDAM-1852]

    • -0
    • +1754
    ./PlLinesCreator/PlLinesCreator.cs
  1. … 4 more files in changeset.
Update the code for the new library of the Macrostability C#-wrapper.

Related to Issue [MWDAM-1848]

Adapted to review comments.

Related to Issue [MWDAM-1792]

Updated to the latest successful build of the C# wrapper. Adapted for missing WaterNetDefinition in construction stage.

Related to Issue [MWDAM-1792]

  1. … 16 more files in changeset.
Re-added handling of UpliftVan/BishopUpliftVan in Postprocessing Stability Inwards.

Related to Issue [MWDAM-1792]

(Re-)Added the stability outward calculation for Bishop, NoAdaption.

Related to Issue [MWDAM-1792]

    • -0
    • +353
    ./KernelWrappers/MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
    • -0
    • +13
    ./KernelWrappers/Common/KernelWrapperHelper.cs
    • -0
    • +2
    ./Deltares.DamEngine.Calculators.csproj
  1. … 5 more files in changeset.
Re-implemented Adapt Geometry option for OptimizedSlopeAndShoulderAdaption, model Bishop.

Related to Issue [MWDAM-1842]

    • -1
    • +1
    ./DikesDesign/DesignCalculatorShoulderPerPoint.cs
    • -9
    • +45
    ./DikesDesign/DesignCalculatorCombinedSlopeAndShoulderAdaption.cs
    • -7
    • +7
    ./DikesDesign/DesignCalculatorFirstSlopeAdaptionThenShoulderAdaption.cs
  1. … 3 more files in changeset.
Fix typo's

Related to Issue [MWDAM-1809]

    • too large
    ./PlLinesCreator/PlLinesCreator.cs
  1. … 1 more file in changeset.
Add test (and fixed bug) for the case that no uplift occurs

Related to Issue [MWDAM-1809]

    • -10
    • +6
    ./KernelWrappers/Common/UpliftHelper.cs
  1. … 1 more file in changeset.
Add reviewer suggestions

Related to Issue [MWDAM-1809]

Add Bishop UpliftVan in PostProcess

Related to Issue [MWDAM-1809]

  1. … 1 more file in changeset.
Remove comment

Related to Issue [MWDAM-1809]

Code clean-up

Related to Issue [MWDAM-1809]

Implement Bishop UpliftVan

Related to Issue [MWDAM-1809]

  1. … 1 more file in changeset.
Fix build

Related to Issue [MWDAM-1809]

Reduce input argument

Related to Issue [MWDAM-1809]

  1. … 1 more file in changeset.