Deltares.DamEngine.Calculators

Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Now all the multicore adaption tests should succeed.

Related to Issue [MWDAM-1948]

  1. … 2 more files in changeset.
Corrected some of the tests, now only two fail again,

Related to Issue [MWDAM-1948]

  1. … 2 more files in changeset.
Adapted to review comments.

Related to Issue [MWDAM-1934]

    • -1
    • +2
    ./DikesOperational/OperationalCalculator.cs
  1. … 1 more file in changeset.
Renamed the method and moved it to DesignScenario (where it actually belongs).

Related to Issue [MWDAM-1934]

    • -1
    • +1
    ./DikesOperational/OperationalCalculator.cs
  1. … 2 more files in changeset.
Added extra test for Adaption (non multicore) as SonarCloud says its not covered (it is, but only in multicore). Added two words to the dictionary to prevent annoying wrong hint/problems. Solve two smells.

Related to Issue [MWDAM-1948]

    • -17
    • +13
    ./DikesDesign/DesignCalculator.cs
  1. … 2 more files in changeset.
Unused Shear Strength Models are removed from xsd, code and documentation

Related to Issue [MWDAM-1954]

  1. … 10 more files in changeset.
Made sure that during one calculation (per location per subsoil per scenario) only the CurrentScenario is used. For Design, all scenarios but the Current are removed at the start of the calculation. For Operational, there only ever is one scenario (as this is a demand which is tested). Replaced use of Scenarios[0] with CurrentScenario, removed Scenarios from Dike. Also removed the reference to Location in DesignScenario, added LocationName to DesignScenario.

Adapted all tests for this. I expect two failing (new) tests at the moment.

Related to Issue [MWDAM-1948]

    • -8
    • +0
    ./KernelWrappers/Common/PlLinesHelper.cs
    • -23
    • +38
    ./DikesDesign/DesignCalculatorCombinedSlopeAndShoulderAdaption.cs
    • -2
    • +3
    ./DikesDesign/DesignCalculatorSingle.cs
    • -19
    • +14
    ./DikesDesign/DesignCalculator.cs
    • -5
    • +10
    ./DikesDesign/DesignCalculatorShoulderPerPoint.cs
    • -11
    • +16
    ./DikesDesign/DesignCalculatorFirstSlopeAdaptionThenShoulderAdaption.cs
    • -1
    • +1
    ./DikesOperational/OperationalCalculator.cs
  1. … 17 more files in changeset.
First repair some things in Adaption calculations themselves:

- give CircleSurfacePointRightXCoordinate a proper value

- remove unused CircleSurfacePointLeftXCoordinate

- make sure centerOfLeftGridXCoordinate is given a proper value when IsGridAutomatic = true.

Related to Issue [MWDAM-1948]

Extracted the method as requested.

Related to Issue [MWDAM-1934]

    • -37
    • +12
    ./DikesDesign/DesignCalculator.cs
  1. … 1 more file in changeset.
Bump package StixFileWriter to 23.2.1.5

Related to Issue [MAC-1383]

    • -1
    • +1
    ./Deltares.DamEngine.Calculators.csproj
  1. … 2 more files in changeset.
Removed obsolete piping code. Note that reading VNK and 4Forces from input xml is kept in order to be able to give a nice "not implemented error".

Related to Issue [MWDAM-1922]

    • -3
    • +4
    ./DikesOperational/OperationalCalculator.cs
  1. … 10 more files in changeset.
Re-added nuget package Geo.Common

Merged revision(s) 4354 from DamEngine/trunk/src/Deltares.DamEngine.Calculators/Deltares.DamEngine.Calculators.csproj:

Related to Issue [MWDAM-1943]

    • -0
    • +3
    ./Deltares.DamEngine.Calculators.csproj
Remove nuget package Geo.Common

Set to AnyCPU

Related to Issue [MWDAM-1943]

    • -3
    • +0
    ./Deltares.DamEngine.Calculators.csproj
  1. … 2 more files in changeset.
Bump StixFileWriter nuget package

Related to Issue [MWDAM-1943]

    • -1
    • +1
    ./Deltares.DamEngine.Calculators.csproj
  1. … 2 more files in changeset.
Added nuget package Geo.Common.Standard

Related to Issue [MWDAM-1943]

    • -0
    • +3
    ./Deltares.DamEngine.Calculators.csproj
Use StixFileWriter nuget package i.s.o. external libraries

Related to Issue [MWDAM-1943]

    • -3
    • +5
    ./Deltares.DamEngine.Calculators.csproj
  1. … 8 more files in changeset.
Try to fix TC build

Related to Issue [MWDAM-1943]

    • -8
    • +0
    ./Deltares.DamEngine.Calculators.csproj
Implemented the improvements for Multi Core as found solving MWDAM-1906 and MWDAM-1925.

Related to Issue [MWDAM-1934]

    • -6
    • +6
    ./KernelWrappers/Common/PlLinesHelper.cs
  1. … 4 more files in changeset.
Obsolete merged dll replaced with last WTI piping dll from artifact of DikesPiping trunk #13337.66.

Related to Issue [MWDAM-1927]

    • -2
    • +5
    ./Deltares.DamEngine.Calculators.csproj
  1. … 7 more files in changeset.
Removed the obsolete piping models from the DAM Engine.

Related to Issue [MWDAM-1916]

    • -3
    • +1
    ./DikesOperational/OperationalCalculator.cs
    • -13
    • +0
    ./Deltares.DamEngine.Calculators.csproj
  1. … 7 more files in changeset.
Removed some static methods.

Related to Issue [MWDAM-1889]

    • -3
    • +5
    ./DikesDesign/SurfaceLineHeightAdapter.cs
    • -2
    • +4
    ./DikesDesign/SurfaceLineShoulderAdapter.cs
  1. … 10 more files in changeset.
Update stix file writer in Dam Engine

Related to Issue [MWDAM-1910]

    • -1
    • +1
    ./Deltares.DamEngine.Calculators.csproj
  1. … 12 more files in changeset.
Prevented no uplift cases to be calculated (with unit tests).

Related to Issue [MWDAM-1907]

  1. … 5 more files in changeset.
Fixed the problem for CurrentScenario = null.

Related to Issue [MWDAM-1906]

    • -0
    • +8
    ./KernelWrappers/Common/PlLinesHelper.cs
Fixed the scenario Head problems for trunk version.

Related to Issue [MWDAM-1906]

    • -8
    • +8
    ./KernelWrappers/Common/PlLinesHelper.cs
Added getting back more error information for failed preparations (Stability).

Related to Issue [MWDAM-1889]

    • -0
    • +12
    ./DikesOperational/OperationalCalculator.cs
Fixed the scenario Head problems for trunk version.

Related to Issue [MWDAM-1906]

  1. … 1 more file in changeset.
Reversed accidental full commit.

Related to Issue [MWDAM-1889]

    • -4
    • +2
    ./DikesDesign/SurfaceLineShoulderAdapter.cs
    • -4
    • +0
    ./Deltares.DamEngine.Calculators.csproj
    • -5
    • +3
    ./DikesDesign/SurfaceLineHeightAdapter.cs
  1. … 23 more files in changeset.
Made sure that file is copied as it is supposed to be.

Related to Issue [MWDAM-1889]

    • -0
    • +4
    ./Deltares.DamEngine.Calculators.csproj
    • -3
    • +5
    ./DikesDesign/SurfaceLineHeightAdapter.cs
    • -2
    • +4
    ./DikesDesign/SurfaceLineShoulderAdapter.cs
  1. … 23 more files in changeset.
Improved tests to check more; extended the error messages with stack trace information.

Added check on null in Routines2D to prevent errors.

Related to Issue [MWDAM-1889]

    • -4
    • +10
    ./DikesOperational/OperationalCalculator.cs
  1. … 3 more files in changeset.