DAM / DamEngine / trunk / src

Deltares.DamEngine.Calculators

Checkout Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 10 Dec
Commits this week: 0
Total Lines of Code (LoC): 18,892
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 22 Jan
12:16 pm

Tom The

Improve adapt first shoulder adaption then shoulder adaption

Related to Issue [MWDAM-2472]

Options
    • -0
    • +5
    ./DikesDesign/DesignCalculatorFirstSlopeAdaptionThenShoulderAdaption.cs
  2. … 1 more file in changeset.
Tuesday 21 Jan
1:01 pm

Virginie Trompille

Adapted to review: isolated aquifer changed to discontinuous aquifer

Related to Issue [MWDAM-2164]

Options
    • -4
    • +4
    ./Properties/Resources.nl-NL.resx
    • -6
    • +6
    ./PlLinesCreator/SoilProfileValidator.cs
    • -7
    • +4
    ./Properties/Resources.Designer.cs
    • -3
    • +3
    ./Properties/Resources.resx
  5. … 1 more file in changeset.
Monday 20 Jan
5:29 pm

Virginie Trompille

Adapted to review: typo + renaming + pictures of soil profile added in tests

Related to Issue [MWDAM-2164]

Options
    • -6
    • +6
    ./PlLinesCreator/SoilProfileValidator.cs
    • -3
    • +3
    ./Properties/Resources.nl-NL.resx
    • -4
    • +4
    ./Properties/Resources.resx
  4. … 1 more file in changeset.
2:06 pm

Virginie Trompille

Adapted to review by using a tolerance when comparing doubles

Related to Issue [MWDAM-2517]

Options
    • -2
    • +2
    ./KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
12:03 pm

Virginie Trompille

Use last nuget package of the StixFileWriter, see pin 24.1.0 from TC project "MacrostabilityStixFileWriter build"

Related to Issue [MWDAM-2390]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Calculators.csproj
  2. … 2 more files in changeset.
11:29 am

John Bokma

Improved validation.

Related to Issue [MWDAM-2400]

Options
    • -3
    • +3
    ./KernelWrappers/MacroStabilityCommon/MacroStabilityCommonHelper.cs
10:10 am

Virginie Trompille

Code refactored to solve issue detected by sonarcloud

Related to Issue [MWDAM-2581]

Options
    • -1
    • +1
    ./KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
9:40 am

Virginie Trompille

Code refactored to solve issue detected by sonarcloud

Related to Issue [MWDAM-2581]

Options
    • -5
    • +2
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
9:36 am

Virginie Trompille

UpliftVan with BeeSwarm is calculated using the Thorough setting of DStability

Related to Issue [MWDAM-2390]

Options
    • -3
    • +3
    ./KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
9:31 am

Virginie Trompille

Adapted to review: all points are handled in the method

Related to Issue [MWDAM-2517]

Options
    • -10
    • +12
    ./KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
9:09 am

Virginie Trompille

Code refactored to solve issues detected by sonarcloud

Related to Issue [MWDAM-2581]

Options
    • -1
    • +1
    ./PlLinesCreator/SoilProfileValidator.cs
    • -30
    • +28
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
Friday 17 Jan
5:13 pm

Virginie Trompille

Add a validation on the presence of isolated in-between aquifers

Related to Issue [MWDAM-2581]

Options
    • -0
    • +6
    ./Properties/Resources.Designer.cs
    • -0
    • +3
    ./Properties/Resources.resx
    • -0
    • +20
    ./PlLinesCreator/SoilProfileValidator.cs
    • -0
    • +3
    ./Properties/Resources.nl-NL.resx
    • -19
    • +72
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
  6. … 3 more files in changeset.
9:30 am

Virginie Trompille

Validation of the Dike embankment material is incorrect (material needed only for 1D profile, not 2D)

Related to Issue [MWDAM-2164]

Options
    • -3
    • +3
    ./PlLinesCreator/SoilProfileValidator.cs
  2. … 1 more file in changeset.
Thursday 16 Jan
4:58 pm

Virginie Trompille

Check on the presence of aquifers/aquitards for 1D profile is done at cross section DikeTopAtPolder (instead of DikeToeAtPolder) to include the layers in the dike body.

Related to Issue [MWDAM-2164]

Options
    • -1
    • +1
    ./PlLinesCreator/SoilProfileValidator.cs
11:52 am

Virginie Trompille

Validations of the soil profile performed in class PlLinesCreator.cs and PlLinesToWaternetConverter.cs are moved to a new class SoilProfileValidator and called only by the PlLinesCreator.

Related to Issue [MWDAM-2164]

Options
    • -8
    • +3
    ./KernelWrappers/Common/DamPipingHelper.cs
    • -1
    • +1
    ./KernelWrappers/Interfaces/IKernelDataOutput.cs
    • -13
    • +25
    ./Properties/Resources.resx
    • -5
    • +23
    ./Properties/Resources.nl-NL.resx
    • -48
    • +22
    ./PlLinesCreator/PlLinesCreator.cs
    • -1
    • +1
    ./KernelWrappers/Common/PlLinesHelper.cs
    • -1
    • +1
    ./KernelWrappers/Common/UpliftHelper.cs
    • -0
    • +186
    ./PlLinesCreator/SoilProfileValidator.cs
    • -41
    • +7
    ./KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
    • -28
    • +46
    ./Properties/Resources.Designer.cs
  11. … 5 more files in changeset.
Tuesday 14 Jan
9:33 am

Virginie Trompille

If statement removed because always true

Related to Issue [MWDAM-2517]

Options
    • -9
    • +6
    ./KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
9:04 am

Virginie Trompille

Reference line of the waternet containing upwards vertical part is corrected (by shifting the highest point by 1cm) in order to be correctly displayed in D-Stability

Related to Issue [MWDAM-2517]

Options
    • -0
    • +26
    ./KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
  2. … 1 more file in changeset.
Monday 13 Jan
5:09 pm

John Bokma

Added (rudimentary) tests for the geometry exporter.

Related to Issue [MWDAM-2446]

Options
    • -0
    • +10
    ./KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
  2. … 7 more files in changeset.
10:05 am

Virginie Trompille

The determination of 2D aquifer layers in PlLinesToWaternetConverter is extracted to a new class SoilProfile2DHelper in order to be used by the waternet creator validator

Related to Issue [MWDAM-2525]

Options
    • -207
    • +8
    ./KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
    • -0
    • +232
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
  3. … 2 more files in changeset.
Friday 10 Jan
2:40 pm

Virginie Trompille

Refactoring: comments improved + unused method DetermineStabilityUplift removed

Related to Issue [MWDAM-2226]

Options
    • -1
    • +0
    ./PlLinesCreator/PlLinesCreator.cs
    • -5
    • +3
    ./KernelWrappers/Common/PlLinesHelper.cs
    • -14
    • +2
    ./KernelWrappers/Common/UpliftHelper.cs
    • -1
    • +0
    ./KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
  5. … 2 more files in changeset.
Wednesday 08 Jan
3:54 pm

John Bokma

Removed liquefaction, implemented All for stability (inwards and outwards). Re-instated the stability test based on All.

Related to Issue [MWDAM-1979]

Options
    • -1
    • +3
    ./KernelWrappers/MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
    • -1
    • +3
    ./KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
  3. … 4 more files in changeset.
Tuesday 07 Jan
4:13 pm

Virginie Trompille

Expected path of the fictive Uplift-Van results added

Related to Issue [MWDAM-2439]

Options
    • -0
    • +1
    ./KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
12:31 pm

Tom The

Remove redundant package Geo.Common

Related to Issue [MWDAM-2328]

Options
    • -3
    • +0
    ./Deltares.DamEngine.Calculators.csproj
  2. … 1 more file in changeset.
Friday 20 Dec 2024
11:00 am

Virginie Trompille

Sonar cloud issues solved

Related to Issue [MWDAM-2369]

Options
    • -9
    • +11
    ./KernelWrappers/MacroStabilityCommon/MacroStabilityCommonHelper.cs
9:20 am

Virginie Trompille

Comments improved

Related to Issue [MWDAM-2410]

Options
    • -6
    • +5
    ./KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
  2. … 1 more file in changeset.
Thursday 19 Dec 2024
5:08 pm

Virginie Trompille

Code improved after review

Related to Issue [MWDAM-2410]

Options
    • -6
    • +7
    ./KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
  2. … 2 more files in changeset.
4:46 pm

Virginie Trompille

Adapted to review: exception throws when soil profile 2D is null

Related to Issue [MWDAM-2369]

Options
    • -1
    • +1
    ./KernelWrappers/MacroStabilityCommon/MacroStabilityCommonHelper.cs
3:47 pm

Virginie Trompille

Nuget package StixFileWriter upgraded to tag 24.1.500.13

Related to Issue [MWDAM-2434]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Calculators.csproj
  2. … 2 more files in changeset.
3:40 pm

Virginie Trompille

Nuget package GeoCommon upgraded to last release 24.1.1.74

Related to Issue [MWDAM-2434]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Calculators.csproj
3:09 pm

Virginie Trompille

The stix files are written only if the calculation succeeded because the input file needs the results of the macrostability kernel for the position of the grid

Related to Issue [MWDAM-2421]

Options
    • -41
    • +36
    ./KernelWrappers/MacroStabilityCommon/MacroStabilityCommonHelper.cs