Deltares.DamEngine.Calculators

Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Removed obsolete code

Related to Issue [MWDAM-2160]

    • -38
    • +0
    ./KernelWrappers/Assemblers/MissingRequiredFieldValueException.cs
    • -47
    • +0
    ./KernelWrappers/Assemblers/EmbeddedResourceNotFoundException.cs
    • -80
    • +0
    ./KernelWrappers/Assemblers/Common.cs
    • -38
    • +0
    ./KernelWrappers/Assemblers/DtoAssemblerConversionException.cs
    • -363
    • +0
    ./KernelWrappers/Assemblers/DtoPropertyAttributeMap.cs
  1. … 4 more files in changeset.
Code improved according to sonarcloud issue

Related to Issue [MWDAM-2691]

    • -11
    • +3
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
Waternet line associated to an empty PL line (no points) is not created

Related to Issue [MWDAM-2733]

  1. … 1 more file in changeset.
Code for the PL3/PL4 reduction re-implemented and improved (1D soil profile is not converted to 2D soil profile to spare calculation time).

Integration tests for piping updated with the new results.

Related to Issue [MWDAM-2691]

    • -58
    • +76
    ./PlLinesCreator/PlLinesCreator.cs
  1. … 3 more files in changeset.
code temporary reverted due to execution timeout

Related to Issue [MWDAM-2691]

Reduction of PL3/PL4 temporary reverted to better investigate the piping failing tests (execution time out)

Related to Issue [MWDAM-2691]

  1. … 1 more file in changeset.
Test is corrected and WIP is removed

Related to Issue [MWDAM-2462]

  1. … 1 more file in changeset.
Adapted to review: method starting with Get renamed into Determine

Related to Issue [MWDAM-2724]

    • -2
    • +2
    ./DikesDesign/SurfaceLineShoulderAdapter.cs
    • -3
    • +3
    ./DikesDesign/SurfaceLineHeightAdapter.cs
  1. … 2 more files in changeset.
Reduction of PL3/PL4 implemented when the aquifer intersects the surface line (i.e. the ditch)

Related to Issue [MWDAM-2691]

    • -13
    • +103
    ./PlLinesCreator/PlLinesCreator.cs
    • -0
    • +41
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
  1. … 3 more files in changeset.
Fix SonarCloud issues

Related to Issue [MWDAM-2548]

  1. … 1 more file in changeset.
Cognitive complexity is reduced

Related to Issue [MWDAM-2716]

    • -15
    • +22
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
Removed Geometry2DSectionAssembler.cs

Related to Issue [MWDAM-2160]

    • -80
    • +0
    ./General/Geometry2DSectionParameters.cs
    • -96
    • +0
    ./KernelWrappers/Assemblers/Geometry2DSectionAssembler.cs
  1. … 4 more files in changeset.
Remove code for reading sti files.

Related to Issue [MWDAM-2160]

    • -3
    • +1
    ./Uplift/UpliftLocationDeterminator.cs
    • -1
    • +0
    ./KernelWrappers/Common/PlLinesHelper.cs
    • -5
    • +1
    ./PlLinesCreator/SoilProfileValidator.cs
    • -5
    • +5
    ./KernelWrappers/Common/UpliftHelper.cs
  1. … 22 more files in changeset.
Case without in between aquifers improved

Related to Issue [MWDAM-2716]

    • -8
    • +15
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
In-between aquifers situated at the left side of DikeToeAtPolder are not taken into account.

Unit tets added.

Related to Issue [MWDAM-2720]

  1. … 2 more files in changeset.
Sonarcloud issues fixed

Related to Issue [MWDAM-2716]

    • -30
    • +25
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
Waternet lines for in-between aquifer cluster with vertical part is improved by connecting the points to create a unique line

Related to Issue [MWDAM-2716]

    • -10
    • +41
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
  1. … 1 more file in changeset.
Validation performed in PlLinesCreator removed because duplication of the validation performed in ValidateSoilProfileForPlLinesCreation

Related to Issue [MWDAM-2724]

    • -5
    • +3
    ./DikesDesign/SurfaceLineHeightAdapter.cs
    • -87
    • +22
    ./PlLinesCreator/PlLinesCreator.cs
    • -4
    • +2
    ./DikesDesign/SurfaceLineShoulderAdapter.cs
  1. … 4 more files in changeset.
Fix unit test

Related to Issue [MWDAM-2474]

Reformat and Cleanup

Related to Issue [MWDAM-2474]

Fixed using the leading calculation (Uplift or Bishop) when designing

Related to Issue [MWDAM-2474]

  1. … 1 more file in changeset.
Determination of the top and bottom aquifers improved in case of cluster.

Unit tests added.

Related to Issue [MWDAM-2716]

    • -61
    • +80
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
  1. … 1 more file in changeset.
Adapted to review: refactored

Related to Issue [MWDAM-2474]

Determination of the boundaries of the in-between aquifers improved to deal with in-between aquifers cutting the not vertical geometry limit.

Unit test added.

Related to Issue [MWDAM-2716]

    • -83
    • +129
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
  1. … 4 more files in changeset.
Reimplemented remove shift, removed from xml-comments.

Related to Issue [MWDAM-2677]

Adapted to review: comment added to explain why the inner loops are removed

Related to Issue [MWDAM-2704]

Reimplemented remove shift.

Related to Issue [MWDAM-2677]

    • -1
    • +1
    ./DikesDesign/DesignCalculatorCombinedSlopeAndShoulderAdaption.cs
  1. … 4 more files in changeset.
Added Su Table to Dam Engine TD. Update mapping of Soil.

Related to Issue [MWDAM-2711]

  1. … 1 more file in changeset.
Reverted remove shift until UI is OK.

Related to Issue [MWDAM-2677]

    • -1
    • +1
    ./DikesDesign/DesignCalculatorCombinedSlopeAndShoulderAdaption.cs
  1. … 6 more files in changeset.
Update DamEngine with StixFileWriter rev.118

Related to Issue [MWDAM-2545]

    • -1
    • +1
    ./Deltares.DamEngine.Calculators.csproj
  1. … 2 more files in changeset.