Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Reverted on request of reviewer revision(s) 5223 from DamEngine/trunk/src/Deltares.DamEngine.Data/General/Dike.cs:

Fix SonarCloud issues

Related to Issue [MWDAM-2367]

........

Refactoring: comments improved + unused method DetermineStabilityUplift removed

Related to Issue [MWDAM-2226]

  1. … 5 more files in changeset.
Removed liquefaction, implemented All for stability (inwards and outwards). Re-instated the stability test based on All.

Related to Issue [MWDAM-1979]

  1. … 5 more files in changeset.
Fix SonarCloud issues

Related to Issue [MWDAM-2367]

Removed minimumCircleDepth from MStabCalculationOptions

Related to Issue [MWDAM-2255]

  1. … 4 more files in changeset.
Cleanup and reformat

Related to Issue [MWDAM-2132]

  1. … 19 more files in changeset.
Nuget for Stix file writer updated with version 24.1.0.66.

Code of DAM engine updated for new slice output.

Related to Issue [MAC-1467]

    • -21
    • +21
    ./Results/StabilityResultSlice.cs
  1. … 6 more files in changeset.
Reformat and cleanup (copyright to 2024)

Related to Issue [MWDAM-2007]

    • -1
    • +1
    ./Specifications/PredicateSpecification.cs
  1. … 315 more files in changeset.
Fixed 2 bugs indicated by sonarcloud

Related to Issue [MWDAM-1911]

  1. … 1 more file in changeset.
Corrected some of the tests, now only two fail again,

Related to Issue [MWDAM-1948]

  1. … 2 more files in changeset.
Renamed the method and moved it to DesignScenario (where it actually belongs).

Related to Issue [MWDAM-1934]

  1. … 3 more files in changeset.
Made sure that during one calculation (per location per subsoil per scenario) only the CurrentScenario is used. For Design, all scenarios but the Current are removed at the start of the calculation. For Operational, there only ever is one scenario (as this is a demand which is tested). Replaced use of Scenarios[0] with CurrentScenario, removed Scenarios from Dike. Also removed the reference to Location in DesignScenario, added LocationName to DesignScenario.

Adapted all tests for this. I expect two failing (new) tests at the moment.

Related to Issue [MWDAM-1948]

  1. … 22 more files in changeset.
Extracted the method as requested.

Related to Issue [MWDAM-1934]

  1. … 1 more file in changeset.
Adapted to review comment after consulting reviewer for required solution.

Related to Issue [MWDAM-1922]

  1. … 6 more files in changeset.
Removed obsolete piping code. Note that reading VNK and 4Forces from input xml is kept in order to be able to give a nice "not implemented error".

Related to Issue [MWDAM-1922]

    • -1
    • +1
    ./DamFailureMechanismeCalculationSpecification.cs
  1. … 12 more files in changeset.
Fixed the scenario Head problems for trunk version.

Related to Issue [MWDAM-1906]

  1. … 1 more file in changeset.
Adapted to review

Related to Issue [MWDAM-1874]

  1. … 3 more files in changeset.
Use string interpolation

Related to Issue [MWDAM-1878]

    • -2
    • +2
    ./DamFailureMechanismeCalculationSpecification.cs
  1. … 24 more files in changeset.
Convert to file-scoped namespace

Related to Issue [MWDAM-1878]

    • -27
    • +26
    ./Specifications/OrSpecification.cs
    • -40
    • +39
    ./Specifications/ISpecification.cs
    • -83
    • +82
    ./FailureMechanismParametersMStab.cs
  1. … 307 more files in changeset.
Remove code smell by using string builders

Related to Issue [MWDAM-1877]

Reformat and cleanup

Related to Issue [MWDAM-1874]

    • -1
    • +3
    ./Specifications/PredicateSpecification.cs
    • -322
    • +38
    ./Results/PipingDesignResults.cs
  1. … 384 more files in changeset.
Update Dam Engine to new SDK project format

Related to Issue [MWDAM-1874]

  1. … 27 more files in changeset.
Run clean-up to update file headers

Related to Issue [MWDAM-1854]

    • -5
    • +5
    ./Specifications/CompositeSpecification.cs
    • -5
    • +5
    ./DamFailureMechanismeCalculationSpecification.cs
    • -5
    • +5
    ./Specifications/PredicateSpecification.cs
  1. … 319 more files in changeset.
Remove unused directives

Related to Issue [MWDAM-1856]

    • -1
    • +0
    ./Sensors/SensorPlLineCreatorSettings.cs
  1. … 18 more files in changeset.
Use getters and setters for properties

Related to Issue [MWDAM-1856]

    • -1
    • +1
    ./Sensors/SensorPlLineCreatorSettings.cs
  1. … 6 more files in changeset.
Clean-up unused of DGeoStability executable

Related to Issue [MWDAM-1809]

    • -41
    • +21
    ./FailureMechanismParametersMStab.cs
Removed obsolete model Horizontal Balance and option UpliftVanWti from code.

Related to Issue [MWDAM-1818]

  1. … 8 more files in changeset.
Removed obsolete IsCombinedBishopUpliftVanCalculation.

Related to Issue [MWDAM-1807]

Removed some more obsolete ZoneArea related items.

Related to Issue [MWDAM-1639]

    • -88
    • +12
    ./Results/StabilityDesignResults.cs
  1. … 1 more file in changeset.
Removed the obsolete ZoneAreaRestSlopeCrestWidth (but not from xsd definition to prevent possible backward compatibility problems).

Related to Issue [MWDAM-1639]

  1. … 7 more files in changeset.