Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I improved some code (code was correct, but prevent SonarQube message and improved exception testing in the tests)

Related to Issue [MWDAM-1445]

  1. … 2 more files in changeset.
Added code (with tests) to improve handling of "wrong" segments. To be able to test this properly, added PipingModelType.Wti2017 to supported models so we can actually define an improper test project. Adding this also helps for MWDAM-1393 and thus MWDAM-1145, Piping part.

Related to Issue [MWDAM-1445]

  1. … 2 more files in changeset.
Ensured deleting of created test data folders at end of tests.

Related to Issue [MWDAM-1554]

Replaced two test files by one, rewrote tests to use common code.

Related to Issue [MWDAM-1554]

    • -103
    • +92
    ./MacroStabilityInwardsTests.cs
  1. … 4 more files in changeset.
Fixed the issue by taking the adaption of the surface line forward to before kernel Prepare statement. Added tests for it.

Related to Issue [MWDAM-1554]

  1. … 4 more files in changeset.
Set Run_UsingTestFiles_HasExpectedResultsInOutputFile in OperationalIntegrationTests to Categories.WorkInProgress due to:

Removed ModelFactors from Location in xsd.

Related to Issue [MWDAM-1519]

Set Run_UsingTestFiles_HasExpectedResultsInOutputFile in OperationalPulauTekongTests and Run_UsingTestFiles_HasExpectedResultsInOutputFile in OperationalGrebbedijkTests to Categories.WorkInProgress due to: Removed HeadPl3, HeadPl4, Pl1BelowCrestRiverside, Pl1BelowCrestPolderside, Pl1BelowShoulderCrestPolderside, Pl1BelowToeDikePolderside, Pl1BelowCrestMiddle, Pl1FactorBelowShoulderCrest from WaternetOptions.

Related to Issue [MWDAM-1519]

Tests must be solved in MWDAM-1535

Removed fixed detriment factor 1.05 for Uplift as this is no longer required.

Here I changed the external for DamMacroStability to use the trunk version 19.1.0 instead of the tagged 18.1 as only the new version holds the proper change. Then I adapted all test values for UpliftVan.

Related to Issue [MWDAM-1504]

  1. … 2 more files in changeset.
SoilProfile should also be included in the calculation if the SoilProfile is of type SegmentFailureMechanismType.All

Related to Issue [MWDAM-1294]

    • -2
    • +29
    ./WtiPipingSellmeijerRevisedTests.cs
  1. … 10 more files in changeset.
Improved unit test

Related to Issue [MWDAM-1294]

Improved unit test

Related to Issue [MWDAM-1294]

Fix failing compile

Related to Issue [MWDAM-1294]

  1. … 3 more files in changeset.
Fixed TestGiveFeedBackWhenNoProfilesAreAvailable

Related to Issue [MWDAM-1231]

Set message when no segments with the expected failure mechanism type were found

Related to Issue [MWDAM-1231]

    • -0
    • +53
    ./DesignCalculatorTests.cs
  1. … 7 more files in changeset.
Split test for Bligh MultiCore off so the tests for Sellmeijer4Forces and SellmeijerVNK are not ignored

Related to Issue [MWDAM-1020]

    • -2
    • +13
    ./MultiCorePipingCalculationTests.cs
added calculation message to PerformSingleCalculation (NoAdaption) when calculation fails, as for PerformDesignCalculation (AdaptGeometry)

Related to Issue [MWDAM-1396]

  1. … 1 more file in changeset.
Fixed test CanPerformWtiDesignNoAdaptionRechterDiezedijk

Related to Issue [MWDAM-1394]

Removed Assessment mode from the Engine (code and xsd). Note: the enumerations belonging to this mode will be removed in next commit as this is part of two issues.

Related to Issue [MWDAM-1410]

    • -39
    • +39
    ./WtiPipingSellmeijerRevisedTests.cs
    • -14
    • +14
    ./MacroStabilityOutwardsTests.cs
    • -408
    • +0
    ./RegionalAssessmentCalculatorTests.cs
    • -32
    • +32
    ./PipingSellmeijer4ForcesTests.cs
  1. … 70 more files in changeset.
When uplift, heave or Sellmeijer revised fails, the whole calculation fails. All output from these calculation parts will be set to 0 when they fail. If one of them fails, the next will not be done.

When calculation result is InvalidInputStructure, InvalidInputData, UnexpectedError the result will be set to RunFailed.

Related to Issue [MWDAM-1394]

  1. … 4 more files in changeset.
Modified comment in test (issue will not be fixed)

Related to Issue [MWDAM-1395]

Added a warning to calculation messages in design calculator when there are no soil profiles for a location

Related to Issue [MWDAM-1341]

  1. … 6 more files in changeset.
Added test for failed result with Piping Wti Sellmeijer Revised with several ToDo's for other issues

Related to Issue [MWDAM-1390]

    • -0
    • +31
    ./WtiPipingSellmeijerRevisedTests.cs
  1. … 2 more files in changeset.
Fixed failing test by correcting the expected result. As the calculation fails with an unexpected error, the result must be -1.

Related to Issue [MWDAM-1383]

    • -1
    • +1
    ./RegionalAssessmentCalculatorTests.cs
Added multicore test for piping wti sellmeijer revised

Related to Issue [MWDAM-1389]

    • -0
    • +45
    ./WtiPipingSellmeijerRevisedTests.cs
Modified comments in tests with respect to how to reproduce

Related to Issue [MWDAM-1388]

It turned out that PipingSellmeijerRevisedTests.cs already existed. It should have been named WtiPipingSellmeijerRevisedTests.

Related to Issue [MWDAM-1388]

    • -13
    • +59
    ./WtiPipingSellmeijerRevisedTests.cs
    • -160
    • +0
    ./PipingSellmeijerRevisedTests.cs
  1. … 6 more files in changeset.
Modified comments in tests with respect to expected values

Related to Issue [MWDAM-1388]

    • -36
    • +30
    ./WtiPipingSellmeijerRevisedTests.cs
Modified tests so the multicore result is compared to the single core result

Related to Issue [MWDAM-1145]

    • -24
    • +25
    ./OperationalPulauTekongTests.cs
    • -14
    • +22
    ./OperationalIntegrationTests.cs
Added a test for Wti Piping with Rechter Diezedijk project, to be used later for multicore calculation test

Related to Issue [MWDAM-1389]

    • -0
    • +21
    ./WtiPipingSellmeijerRevisedTests.cs
  1. … 3 more files in changeset.
Removed test category MultiCore from one of the multicore integration tests to increase test coverage on build server.

Related to Issue [MWDAM-1145]