DAM / DamEngine / trunk

src

Checkout Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 17 Dec
Commits this week: 0
Total Lines of Code (LoC): 147,819
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 20 Mar 2019
3:52 pm

Tom The

Introduce SegmentFailureMechanismType and also conversion method to convert FailureMechanismSystemType to SegmentFailureMechanismType

Related to Issue [MWDAM-1294]

Options
    • -0
    • +11
    ./Deltares.DamEngine.Data/General/Location.cs
    • -0
    • +1
    ./Deltares.DamEngine.Data.Tests/Deltares.DamEngine.Data.Tests.csproj
    • -0
    • +1
    ./Deltares.DamEngine.Data/Deltares.DamEngine.Data.csproj
    • -0
    • +43
    ./Deltares.DamEngine.Data/General/ConversionHelper.cs
    • -0
    • +41
    ./Deltares.DamEngine.Data.Tests/General/ConversionHelperTests.cs
11:49 am

Tom The

Adapted to review

Related to Issue [MWDAM-1340]

Options
    • -0
    • +1
    ./Deltares.DamEngine.Interface.Tests/FillDamFromXmlInputTests.cs
  2. … 1 more file in changeset.
Tuesday 19 Mar 2019
5:04 pm

John Bokma

Removed DamType as property from Location and xsd.

Related to Issue [MWDAM-1441]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityCommon/DamMStabAssemblerTest.cs
    • -28
    • +0
    ./Deltares.DamEngine.Data/General/Location.cs
    • too large
    ./Deltares.DamEngine.Io/DamInput.cs
    • -1
    • +0
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityOutwards/DamMacroStabilityOutwardsKernelWrapperTests.cs
    • -1
    • +1
    ./Deltares.DamEngine.Calculators.Tests/Uplift/UpliftLocationDeterminatorTest.cs
    • -1
    • +0
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityCommon/DamMacroStabilityTestHelper.cs
  7. … 1 more file in changeset.
4:11 pm

Esther van Zantvoort

Fixed TestGiveFeedBackWhenNoProfilesAreAvailable

Related to Issue [MWDAM-1231]

Options
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
1:42 pm

Esther van Zantvoort

Set message when no segments with the expected failure mechanism type were found

Related to Issue [MWDAM-1231]

Options
    • -0
    • +68
    ./Deltares.DamEngine.IntegrationTests/TestFiles/PipingVoorbeeld1_WtiSellmeijerRevisedNoPipingInputFile.xml
    • -0
    • +384
    ./Deltares.DamEngine.IntegrationTests/TestFiles/Rechter Diezedijk_NoStabilityInsideInputFile.xml
    • -0
    • +7
    ./Deltares.DamEngine.IntegrationTests/Deltares.DamEngine.IntegrationTests.csproj
    • -0
    • +9
    ./Deltares.DamEngine.Calculators/Properties/Resources.Designer.cs
    • -0
    • +3
    ./Deltares.DamEngine.Calculators/Properties/Resources.resx
    • -22
    • +42
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculator.cs
    • -0
    • +53
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/DesignCalculatorTests.cs
    • -0
    • +3
    ./Deltares.DamEngine.Calculators/Properties/Resources.nl-NL.resx
11:57 am

John Bokma

Removed Location.DikeTableHeight from the interface as suggested by the reviewer.

Related to Issue [MWDAM-1410]

Options
    • -1
    • +0
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
    • -2
    • +0
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForDamProjectData.cs
    • -1
    • +0
    ./Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
    • too large
    ./Deltares.DamEngine.Io/DamInput.cs
  5. … 1 more file in changeset.
Monday 18 Mar 2019
4:06 pm

Esther van Zantvoort

Fixed failing test CreatePL2andPL4For1DGeometryWithExpertKnowledgeRRDWithAllWithSandLayerInBetweenAndPenetrationLengthInThisAquiferLayer

There is no longer a distinction between a regional and a primary location.

Related to Issue [MWDAM-1434]

Options
    • too large
    ./Deltares.DamEngine.Calculators.Tests/PlLinesCreator/PlLinesCreatorTest.cs
1:46 pm

Esther van Zantvoort

Removed DamType from CreatePlLineByExpertKnowledge

Related to Issue [MWDAM-1434]

Options
    • too large
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
    • too large
    ./Deltares.DamEngine.Calculators.Tests/PlLinesCreator/PlLinesCreatorTest.cs
1:35 pm

Esther van Zantvoort

Removed DamType from GetHeadPl4

Related to Issue [MWDAM-1434]

Options
    • too large
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
1:29 pm

Esther van Zantvoort

Removed 'no hydraulic shortcut' from comment because it is no longer applicable. If no value for headPl4 then always use waterLevel.

Related to Issue [MWDAM-1434]

Options
    • too large
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
Friday 15 Mar 2019
7:53 pm

Esther van Zantvoort

Split test for Bligh MultiCore off so the tests for Sellmeijer4Forces and SellmeijerVNK are not ignored

Related to Issue [MWDAM-1020]

Options
    • -2
    • +13
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MultiCorePipingCalculationTests.cs
6:49 pm

Esther van Zantvoort

added calculation message to PerformSingleCalculation (NoAdaption) when calculation fails, as for PerformDesignCalculation (AdaptGeometry)

Related to Issue [MWDAM-1396]

Options
    • -0
    • +1
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculatorSingle.cs
    • -6
    • +5
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/WtiPipingSellmeijerRevisedTests.cs
12:31 pm

John Bokma

Removed obsolete PolderLevelLow and PolderLevelLowSpecified.

Related to Issue [MWDAM-1409]

Options
    • too large
    ./Deltares.DamEngine.Io/DamInput.cs
    • -2
    • +0
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
    • -19
    • +0
    ./Deltares.DamEngine.Data/General/Location.cs
    • -1
    • +0
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForDamProjectData.cs
    • -2
    • +0
    ./Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
  6. … 1 more file in changeset.
Thursday 14 Mar 2019
6:18 pm

Esther van Zantvoort

Moved exception classes to separate files.

Related to Issue [MWDAM-1394]

Options
    • -13
    • +0
    ./Deltares.DamEngine.Data/General/PolyLine.cs
    • -13
    • +0
    ./Deltares.DamEngine.Data/General/Dike.cs
    • -13
    • +0
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamMacroStabilityCommon/MStabXmlDoc.cs
    • -0
    • +3
    ./Deltares.DamEngine.Data/Deltares.DamEngine.Data.csproj
    • -0
    • +37
    ./Deltares.DamEngine.Data/Geometry/CoordinateSystemConverterException.cs
    • -0
    • +38
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamMacroStabilityCommon/MStabXmlDocException.cs
    • -0
    • +38
    ./Deltares.DamEngine.Data/General/DikeException.cs
    • -0
    • +38
    ./Deltares.DamEngine.Data/General/PolyLineException.cs
    • -0
    • +2
    ./Deltares.DamEngine.Calculators/Deltares.DamEngine.Calculators.csproj
    • -0
    • +37
    ./Deltares.DamEngine.Calculators/Uplift/SoilVolumicMassCalculatorException.cs
    • -12
    • +0
    ./Deltares.DamEngine.Data/Geometry/CoordinateSystemConverter.cs
    • -12
    • +0
    ./Deltares.DamEngine.Calculators/Uplift/SoilVolumicMassCalculator.cs
6:05 pm

Esther van Zantvoort

Removed ObjectExtensions from Calculators, instead use ObjectExtensions from Standard. Added the missing methods from Calculators to Standard.

Related to Issue [MWDAM-1394]

Options
    • -0
    • +1
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamMacroStabilityCommon/Assemblers/DtoHelperServices.cs
    • -618
    • +0
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamMacroStabilityCommon/Assemblers/ObjectExtensions.cs
    • -0
    • +7
    ./Deltares.DamEngine.Data/Standard/ConversionException.cs
    • -1
    • +0
    ./Deltares.DamEngine.Calculators/Deltares.DamEngine.Calculators.csproj
    • -1
    • +88
    ./Deltares.DamEngine.Data/Standard/ObjectExtensions.cs
2:53 pm

Esther van Zantvoort

refactored all Exception classes, removed methods that were not used, added comments

Related to Issue [MWDAM-1394]

Options
    • -18
    • +10
    ./Deltares.DamEngine.Calculators/PlLinesCreator/SensorPlLineCreatorException.cs
    • -1
    • +5
    ./Deltares.DamEngine.Calculators/Uplift/SoilVolumicMassCalculator.cs
    • -4
    • +1
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamMacroStabilityCommon/MStabXmlDoc.cs
    • -4
    • +1
    ./Deltares.DamEngine.Data/General/Dike.cs
    • -26
    • +9
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamMacroStabilityCommon/Assemblers/DtoAssemblerConversionException.cs
    • -7
    • +0
    ./Deltares.DamEngine.Data/General/PlLines/Pl1Line.cs
    • -3
    • +1
    ./Deltares.DamEngine.Calculators/DikesOperational/OperationalCalculatorException.cs
    • -26
    • +9
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamMacroStabilityCommon/Assemblers/DtoAssemblerException.cs
    • -30
    • +0
    ./Deltares.DamEngine.Data/Standard/ThrowHelper.cs
    • -1
    • +1
    ./Deltares.DamEngine.Interface/EngineInterfaceException.cs
    • -12
    • +10
    ./Deltares.DamEngine.Data/Standard/ConversionException.cs
    • -30
    • +2
    ./Deltares.DamEngine.Calculators/DikesDesign/SurfaceLineAdapterException.cs
    • -6
    • +4
    ./Deltares.DamEngine.Calculators/Stability/StabilityServiceAgentException.cs
    • -4
    • +9
    ./Deltares.DamEngine.Data/General/PolyLine.cs
    • -12
    • +15
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamMacroStabilityCommon/Assemblers/ObjectExtensions.cs
  16. … 7 more files in changeset.
2:48 pm

Esther van Zantvoort

refactored WtiPipingSellmeijerRevisedException, removed methods that were not used, added comments

Related to Issue [MWDAM-1394]

Options
    • -14
    • +10
    ./Deltares.DamEngine.Calculators/KernelWrappers/WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedException.cs
1:08 pm

Esther van Zantvoort

Fixed test CanPerformWtiDesignNoAdaptionRechterDiezedijk

Related to Issue [MWDAM-1394]

Options
    • -4
    • +7
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/WtiPipingSellmeijerRevisedTests.cs
Wednesday 13 Mar 2019
5:08 pm

John Bokma

After removing Assessment mode, cleaned code somewhat. Mainly getting rid of dead code.

Related to Issue [MWDAM-1410]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Data/General/Specifications/PredicateSpecification.cs
    • -1
    • +24
    ./Deltares.DamEngine.Data/General/MStabParameters.cs
    • -1
    • +1
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
    • -39
    • +0
    ./Deltares.DamEngine.Data/General/Specifications/LessThanOrEqualToSpecification.cs
    • -40
    • +0
    ./Deltares.DamEngine.Data/General/Results/PipingResults.cs
    • -12
    • +0
    ./Deltares.DamEngine.Data/Deltares.DamEngine.Data.csproj
    • -1
    • +1
    ./Deltares.DamEngine.Data/General/Specifications/AndSpecification.cs
    • -88
    • +0
    ./Deltares.DamEngine.Data/General/LocationJob.cs
    • -41
    • +0
    ./Deltares.DamEngine.Data/General/Specifications/MaximumAttribute.cs
    • -31
    • +1
    ./Deltares.DamEngine.Data/General/DamFailureMechanismeCalculationSpecification.cs
    • -494
    • +27
    ./Deltares.DamEngine.Data/Design/DesignScenario.cs
    • -93
    • +0
    ./Deltares.DamEngine.Data/General/Specifications/SpecificationBaseAttribute.cs
    • -56
    • +0
    ./Deltares.DamEngine.Data/General/Specifications/GreaterThanOrEqualToSpecification.cs
    • -10
    • +1
    ./Deltares.DamEngine.Data/General/Sensors/SensorLocation.cs
    • -11
    • +1
    ./Deltares.DamEngine.Calculators/DikesOperational/OperationalCalculator.cs
  16. … 12 more files in changeset.
2:49 pm

John Bokma

Removed all Assessment mode enumerations now too see Issue [MWDAM-1282].

Related to Issue [MWDAM-1410]

Options
    • -52
    • +2
    ./Deltares.DamEngine.Data/General/DAMEnumerations.cs
2:47 pm

John Bokma

Removed Assessment mode from the Engine (code and xsd). Note: the enumerations belonging to this mode will be removed in next commit as this is part of two issues.

Related to Issue [MWDAM-1410]

Options
    • -38
    • +3
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/Common/PlLinesHelperTests.cs
    • -25
    • +1
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
  3. ./Deltares.DamEngine.Data/RegionalAssessmentResults
    • -2
    • +0
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamMacroStabilityInwards/DamMacroStabilityInwardsKernelWrapper.cs
    • -5
    • +0
    ./Deltares.DamEngine.Calculators.Tests/Deltares.DamEngine.Calculators.Tests.csproj
    • -28
    • +28
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/PipingSellmeijerVnkTests.cs
    • -39
    • +39
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/WtiPipingSellmeijerRevisedTests.cs
    • -14
    • +14
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityOutwardsTests.cs
    • -42
    • +42
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/PipingBlighTests.cs
    • -1
    • +0
    ./Deltares.DamEngine.IntegrationTests/Deltares.DamEngine.IntegrationTests.csproj
    • -7
    • +0
    ./Deltares.DamEngine.Data/Deltares.DamEngine.Data.csproj
    • -118
    • +1
    ./Deltares.DamEngine.Interface.Tests/ConversionHelperTests.cs
    • -87
    • +0
    ./Deltares.DamEngine.Data/General/RegionalAssessmentScenarioJobSettings.cs
  14. ./Deltares.DamEngine.Calculators/RegionalAssessment
    • too large
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
  16. … 65 more files in changeset.
10:04 am

Tom The

Small fixes

Related to Issue [MWDAM-1340]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
    • -2
    • +2
    ./Deltares.DamEngine.Io/IdValidator.cs
Tuesday 12 Mar 2019
4:39 pm

Esther van Zantvoort

When uplift, heave or Sellmeijer revised fails, the whole calculation fails. All output from these calculation parts will be set to 0 when they fail. If one of them fails, the next will not be done.

When calculation result is InvalidInputStructure, InvalidInputData, UnexpectedError the result will be set to RunFailed.

Related to Issue [MWDAM-1394]

Options
    • -10
    • +69
    ./Deltares.DamEngine.Calculators/KernelWrappers/WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedKernelWrapper.cs
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/WtiPipingSellmeijerRevisedTests.cs
    • -0
    • +1
    ./Deltares.DamEngine.Calculators/Deltares.DamEngine.Calculators.csproj
    • -0
    • +94
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedKernelWrapperTests.cs
    • -0
    • +42
    ./Deltares.DamEngine.Calculators/KernelWrappers/WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedException.cs
2:48 pm

Tom The

Correct typo

Related to Issue [MWDAM-1340]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Io.Tests/IdValidatorTests.cs
2:42 pm

Tom The

Added validation of Id's before XML serialization

Related to Issue [MWDAM-1340]

Options
    • -0
    • +63
    ./Deltares.DamEngine.Interface/Properties/Resources.Designer.cs
    • -0
    • +21
    ./Deltares.DamEngine.Interface/Properties/Resources.resx
    • -0
    • +1
    ./Deltares.DamEngine.Io/Deltares.DamEngine.Io.csproj
    • -0
    • +36
    ./Deltares.DamEngine.Io/IdValidatorException.cs
    • -0
    • +46
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
    • -0
    • +21
    ./Deltares.DamEngine.Interface/Properties/Resources.nl-NL.resx
    • -3
    • +2
    ./Deltares.DamEngine.Interface.Tests/FillDamFromXmlInputTests.cs
    • -6
    • +6
    ./Deltares.DamEngine.Io.Tests/IdValidatorTests.cs
1:46 pm

Tom The

Add test for check on legal names

Add IdValidator

Some refactoring

Related to Issue [MWDAM-1340]

Options
    • -0
    • +47
    ./Deltares.DamEngine.Io/IdValidator.cs
    • -0
    • +1
    ./Deltares.DamEngine.Io/Deltares.DamEngine.Io.csproj
    • -0
    • +71
    ./Deltares.DamEngine.Io.Tests/IdValidatorTests.cs
    • -2
    • +42
    ./Deltares.DamEngine.Interface.Tests/FillDamFromXmlInputTests.cs
    • -0
    • +1
    ./Deltares.DamEngine.Io.Tests/Deltares.DamEngine.Io.Tests.csproj
12:08 pm

John Bokma

Cleaned DAMEnumerations.cs as far as possible for now. Moving RWScenario options not done as these have to be removed as stated in MWDAM-1410.

Related to Issue [MWDAM-1282]

Options
    • -60
    • +0
    ./Deltares.DamEngine.Data/General/Results/JobResultInterpreter.cs
    • -2
    • +32
    ./Deltares.DamEngine.Data/General/DamFailureMechanismeCalculationSpecification.cs
    • -0
    • +2
    ./Deltares.DamEngine.Interface.Tests/ConversionHelperTests.cs
    • -0
    • +59
    ./Deltares.DamEngine.Data/General/Location.cs
    • -0
    • +37
    ./Deltares.DamEngine.Data/General/Sensors/SensorEnumerations.cs
    • -0
    • +2
    ./Deltares.DamEngine.Interface/ConversionHelper.cs
    • -1
    • +2
    ./Deltares.DamEngine.Data/Deltares.DamEngine.Data.csproj
    • -205
    • +7
    ./Deltares.DamEngine.Data/General/DAMEnumerations.cs
    • -0
    • +35
    ./Deltares.DamEngine.Data/General/TimeSeries/TimeSerieEnumerations.cs
    • -0
    • +46
    ./Deltares.DamEngine.Data/General/MStabParameters.cs
    • -0
    • +15
    ./Deltares.DamEngine.Calculators/DikesOperational/OperationalCalculator.cs
    • -57
    • +0
    ./Deltares.DamEngine.Data/General/PlLines/PlLine.cs
Monday 11 Mar 2019
5:19 pm

Esther van Zantvoort

Modified comment in test (issue will not be fixed)

Related to Issue [MWDAM-1395]

Options
    • -2
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/WtiPipingSellmeijerRevisedTests.cs
12:53 pm

Tom The

Add test for check on illegal names

Related to Issue [MWDAM-1340]

Options
    • -0
    • +21
    ./Deltares.DamEngine.Interface.Tests/FillDamFromXmlInputTests.cs
10:48 am

Tom The

Refactored, removed unused usings

Related to Issue [MWDAM-1340]

Options
    • -15
    • +0
    ./Deltares.DamEngine.Interface.Tests/FillDamFromXmlInputTests.cs
    • -1
    • +0
    ./Deltares.DamEngine.Interface.Tests/FillXmlOutputFromDamTests.cs